From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EE4FA0C43; Wed, 11 Aug 2021 17:59:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 404D1410EC; Wed, 11 Aug 2021 17:59:41 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id B3CC040C35 for ; Wed, 11 Aug 2021 17:59:39 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="278895794" X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="278895794" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 08:59:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="469444934" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 11 Aug 2021 08:59:38 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 08:59:37 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 08:59:37 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 11 Aug 2021 08:59:37 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 11 Aug 2021 08:59:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IhfXHS4L7kg+36kDGXIMwfvAqokdTVGiTpKad9sxCHnpXKBJZEYY1Ip2IO7BSAxIcD7XGiVS8I9rj5Bh/yoZfeS1i3atb9LDljTROJ9cHxyAllTO7PCoFhsmP9mf5Osa9ajslSQliYtT45+kCexP0iU05gp/JkezUXChGJsErJh1TumTCIYkB77WezjH7kgEpoUSxnBcblAnvtJLGOYTlSSbjRkDGEYscEvT1vh9Ity/9Ninb3vmh3aOMa87i6+gV8M3lWL2G2uMB28pl/6W6q+B+u9URjQKBuZ8pMJyW7X0VXRg6TmSqgPVDGHE5IVTcqGS7W/VrJoCuqNtc106bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tygJWX2stYr3hVI6qFEYoWfZ6YJ7ik/18VALO349lTk=; b=BdVQ387yuOgVOsdEhpuixGaCUrqP2u+g5sPkiYQaYNTXyHhR6sU6bTDktp0G//I5qf3hliZ58G2V4YPm9ZpIrxncRkVGIkGeFV5kyyE5qXiO6+PDZppzrlsbFCFRpqEBLx0zxINQWBZqvk0zndLJxEfxRiIhHrgbokMK5pZnV8AGwFuILNZu0CWdnYAWTX87uvxy/ctt1XkDTxdTJgofDaM9RVJ906qIYumyd8jy5qn5qqFI3wSbR4RmQYCtgmMDLs5/3o+Z9DopoKBcI4sH2poHabxNAVhytcTY2I03fTM04NP+edWARk4/6yMxgb0viYpuW3Rx45xigVx1WU6HWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tygJWX2stYr3hVI6qFEYoWfZ6YJ7ik/18VALO349lTk=; b=j2Sxl5xY/9B/9qoFXqG1paT/mCphhIe/OSLrMPx+ROF6gipJbOJwGVKzBZAxnjQ2zzVCwVaFZtG6v+eDwCxgWE6Hw9Qgw4jqWwzKojChj9uLAIkANxeG0vk1Zj930/B0LdlesxUnvVXgMvJCkc21Ml9b4Tn2UB4cfQlpZ4R48FE= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB4062.namprd11.prod.outlook.com (2603:10b6:208:150::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.19; Wed, 11 Aug 2021 15:59:34 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3%6]) with mapi id 15.20.4415.016; Wed, 11 Aug 2021 15:59:34 +0000 From: "Power, Ciara" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: "Richardson, Bruce" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "skori@marvell.com" , "skoteshwar@marvell.com" Thread-Topic: [v3, 0/3] common/cnxk: enable npa telemetry Thread-Index: AQHXiD5nArMWV+vwKkmy72+Xi67buqtugDew Date: Wed, 11 Aug 2021 15:59:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e310cd7f-2560-484d-1deb-08d95ce1032a x-ms-traffictypediagnostic: MN2PR11MB4062: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uxeiw3bGpp2z0mqyUAtUnbLIF7YhDjQyUuQulkVThCvZzqONUUkKTBqAs1XbUG9LdmnyWpmH/Y14wRKCsB0hhV5YenHxA54gtysIyiMJr0BiBXuDN1kWCRtvHWEaHN06UXM/wBbL+P+TZ0RogE6DpuvZtlf1Qekk8wz3U8QVMJR610vx5ufREAf+tZJrusRmRqZDOnYK02BbAyH9/lukmmkODtDx8OQp3HtbHKAmqDon2oz5Mwf7+xsp4tX7yLnSdUo7KmmvT7KVYENmUX8ThSemeOm2oJ7wZhSI8SHw4ddWN44TYGeptynqsxirlfBnu0L4y/SXmlQDnDZ+mDe8ZPT3Jal1sGygHkkh50HLxjkXLJLASXvClVd1kf3w5ynGNOgaOLAbciNDhdzigDk6kq6I7I1q4Cpaae4VZ8CLtRw3z3MFyht8sBXPYcPMnYbGAxCxCZIbQ3FaGqrYi3knjM0JTSGCSWLwATpxhmBloVsgr+Js3pFJ5+WX0pWT8Tng1T70+9QBjLABxm6IpLOMCtPmrJKp4rgpYPV4azW74ULkR+tPcY3slTEekAg83pc0IoXL+8ENygLTQw805HOShbx+uZFnYoY1kab1H95f3u64GswP+5DQp6l6RLasW8IlAjpF/mjdrHdM9FLMBEvKr4GJ7G3yAPzoEI1GO83ZBLFygzi5fDbaDNfJQGxnjpfUYk8IUgz6fXuMBEowWGU8VQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(38100700002)(110136005)(66446008)(64756008)(316002)(7696005)(26005)(38070700005)(122000001)(66946007)(66556008)(186003)(66476007)(54906003)(4326008)(76116006)(2906002)(5660300002)(83380400001)(9686003)(86362001)(508600001)(8936002)(71200400001)(6506007)(33656002)(8676002)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LNBeyL2yjf+vGefDBK6By93hRFtcgFTyIaOg0jn6luLVdRv/yEUHdgFTzBE2?= =?us-ascii?Q?kq25gKzj4Qc86el4cq0LWkry6EDt8YoTkCFTL5d8fe7CdGlG0vroaZ7NyE3R?= =?us-ascii?Q?mCbc3g3qYPEAFFyaTKUY5KDD3qjM4/30fSPhmtwtqAqFgB36OhYrfI3dnx+g?= =?us-ascii?Q?TRf0y0rR+PwQoFyQjXG3A59B+kF8v5ZN0CBhz2hpdO6oxaIVlmZodKpRII/r?= =?us-ascii?Q?UeC4bJmYOt2/PHjEeFjTVRT5RGWbrydk7kMV+bgMvE4mQ/5qatwH5/uhCv6p?= =?us-ascii?Q?RarKXGikT3s/8li/1dyp+FyWnD8L1zGrLMNgU8zEYUaARiDewIuDFZU3ymjJ?= =?us-ascii?Q?93FSpPVK8LWm2mzR9xo4ETSVZ5Fdt2x7B4pDEojVuvXAMaCMQMca2ZFUy7Yh?= =?us-ascii?Q?iDvoVxnKz5qWlDD1f80v6AF+sytmKzrHeIiy3JGhv5v8eDGvhr/dU+OPU6AU?= =?us-ascii?Q?SzTBA1aKrp2niIS1PflDkp8GiOVDPxreDp4HhF9JfpkyBy9rIKfkSh+v9wgy?= =?us-ascii?Q?9xLriyLZx9UmU3Nd2Q4y6FsevWZJ//MCqozD3VSrO2ycTlIxSKwsjXXUirIy?= =?us-ascii?Q?2m3IvD03QsdCFV//eT0/mreJR0DaBICBJ9ZAILg7B+534IWmwOCy0Pw+/qUw?= =?us-ascii?Q?Lhrph1zEmZXCL19HzKRpNKUV2dzRti5a29XmUwOUzItSqLCcB0dCNlGoCpWl?= =?us-ascii?Q?8WLzKHbB7KHT6hV5wUjGopF+7HrTUpoe4zbp8SFLJc6ET23rv5tTP3p/viPx?= =?us-ascii?Q?g71jOZs974x/vcB/tkYjRpXbIbqLYUw4fYj99GRbLzkTx27b0dP1gzonfca0?= =?us-ascii?Q?8unwv26+HjybBbMRJzywPx6e4/akc0YUTupaJ+jWCq8Dqq+ZC7+WnUajej3f?= =?us-ascii?Q?TV4MPRDulUvICxpJ59INSbeBS57+MuKlYfGfBSoyBwMdg73Rju2qQAgl0o/X?= =?us-ascii?Q?6nmG57X8fM9z4H4p00x6gD+if2ZA3IK0UkVPC/Ubak/0TCpTnTMuYLEHCHfq?= =?us-ascii?Q?yAV/ruhSF3arUfP5Y+B/z6j4f8TmhnrYe/Ma9+dRlke9UajxJGieSfjDjA0E?= =?us-ascii?Q?338VVbnM/QXZXY0Q8p9usg5hcJj9+ttrmpUEOX7p7S2LxoMxBDpt1rdCJG0/?= =?us-ascii?Q?m/kJu4ZCGxTnLMEnsRmDkpX2WkvxipFXF9oYTb3IwtwSyB4NW+apkdrdgE7d?= =?us-ascii?Q?DD/sKIRZ7EMMoXJM6dKcEvWsLjb9bpWRnegq/Jw4E6DRLitx5/pfbFlb0xjl?= =?us-ascii?Q?EPnpqTQECNYwxpS8tm/Lw/icad8+irbUVgc4ErOCouKOkg+VnL8UdZC7s6DO?= =?us-ascii?Q?8x+WnBDQ+CkIqGPPN7t+Meh/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e310cd7f-2560-484d-1deb-08d95ce1032a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 15:59:33.9415 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: amF298Q0GKzSMWT28VlizFV9rysMNxySkwLckesmNPQcq0s9mYAdPifFiUBRCrxN8NvUgm3fRFoG0Z4r+OtJ5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4062 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gowrishankar, >-----Original Message----- >From: Gowrishankar Muthukrishnan >Sent: Tuesday 3 August 2021 09:06 >To: dev@dpdk.org >Cc: Richardson, Bruce ; Power, Ciara >; jerinj@marvell.com; kirankumark@marvell.com; >ndabilpuram@marvell.com; skori@marvell.com; skoteshwar@marvell.com; >Gowrishankar Muthukrishnan >Subject: [v3, 0/3] common/cnxk: enable npa telemetry > >This patch series enables telemetry in NPA LF of cnxk. > >v3: > - fixed format specifier for uintptr_t > >Gowrishankar Muthukrishnan (3): > telemetry: enable storing pointer value > test/telemetry: add unit tests for pointer value > common/cnxk: add telemetry endpoints to npa > > app/test/test_telemetry_data.c | 125 +++++++++++++ > app/test/test_telemetry_json.c | 29 ++- > drivers/common/cnxk/cnxk_telemetry.h | 26 +++ > drivers/common/cnxk/cnxk_telemetry_npa.c | 227 >+++++++++++++++++++++++ > drivers/common/cnxk/meson.build | 4 + > drivers/common/cnxk/roc_platform.h | 8 + > lib/telemetry/rte_telemetry.h | 37 +++- > lib/telemetry/telemetry.c | 21 ++- > lib/telemetry/telemetry_data.c | 40 +++- > lib/telemetry/telemetry_data.h | 2 + > lib/telemetry/telemetry_json.h | 32 ++++ > lib/telemetry/version.map | 2 + > 12 files changed, 539 insertions(+), 14 deletions(-) create mode 100644 >drivers/common/cnxk/cnxk_telemetry.h > create mode 100644 drivers/common/cnxk/cnxk_telemetry_npa.c > >-- >2.25.1 I am still unsure exactly what the use case is here - why are we choosing t= o publish the pointer values through telemetry rather than using a debug lo= g for example? Maybe I am missing something here. Thanks, Ciara