From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40ADAA034F; Wed, 10 Nov 2021 18:01:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01D4841178; Wed, 10 Nov 2021 18:01:08 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A2D7541176 for ; Wed, 10 Nov 2021 18:01:05 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10164"; a="256408543" X-IronPort-AV: E=Sophos;i="5.87,224,1631602800"; d="scan'208";a="256408543" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 09:00:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,224,1631602800"; d="scan'208";a="546185965" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga008.fm.intel.com with ESMTP; 10 Nov 2021 09:00:34 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 09:00:33 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 09:00:33 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 10 Nov 2021 09:00:33 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 10 Nov 2021 09:00:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gu/vJDi8cR7Y3glcL/cAzYw39EfC0XvSG1Mc8igCI46DJpcCRdSP4C18dz92PvBH411uoS8053Wu3zgcRAeVBiHyXn7TZ0GPqYTvqlVuqzOJX27ZNIsrwoSA6giYd29twMxZE6bS5BvsGt18GODVoZiqUu4Bx4LGmOZIMioCdBTiJSZruaZ3jIDrWZjr3x4IObRQzui4W286TlAb0njO56A09QWZCo/UmXm3er5lZrOoyMQOGbgDrHMvPEm7ynk+jSJsw7Y5QelQqUe6IjHZyjTtvm4rmKb9/QjuvU+XNNRTdI3bAr3MyGZrMkEBiYpJlifNGKELXxXV9SwtUyJPMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CogvpYYHUqdTB3nomzNTGgCNuQDPUcO9O1UBAJROwWM=; b=A9F2wSSD8qi1yyHMAq5O5ok0oLaingasGGVCxjnZLazFJXxNw0lAg2AO1vKh9FLNDMhY2HLlmcftBP4tS9envwh46+RoXQp8tdvcPYJOSXTlSWTXzY6xouCgMEl/U5QWqs45UuFVOAoy31i7lzMbS72y/MzV2Oi6G6VNcK3PdDJMtYrtyTmUxrGPaWrwKOjWcg+x30KCz5d6gw6gBi40dqj8fHEMPrZtcrnyBPCe3wPd/IICeShoHkTGlod9Ic8k5ERxVv8+rchxbWMs/aFJjEzENKOFYmkZzW7KxWz8yaMGC6TTjEXaZRzvCRKwo/efRGt+7VLc0OF1OkSEVnVxUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CogvpYYHUqdTB3nomzNTGgCNuQDPUcO9O1UBAJROwWM=; b=SVrKYMO8o19kPj9c5BiwOKAWxRgzpWV5cPPe5kM68c8JJN3f8n9txeRVFvL+zDiE/tMUcXXTf5jc/kBevtH6dfyWixeM3mz9dgQGFiPYim+OBx/MznAQPcZApi1gsk0Uxx7sbmCm5v6YiJ4RFZ3WRaFnYo6zWQMb3XUVtEsS1p8= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3648.namprd11.prod.outlook.com (2603:10b6:208:f0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Wed, 10 Nov 2021 17:00:30 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 17:00:30 +0000 From: "Power, Ciara" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "De Lara Guarch, Pablo" CC: Jerin Jacob , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , Gagandeep Singh , "Ji, Kai" , "dev@dpdk.org" , "adamx.dybkowski@intel.com" , "De Lara Guarch, Pablo" Subject: RE: [PATCH v2] test/crypto: skip plain text compare for null cipher Thread-Topic: [PATCH v2] test/crypto: skip plain text compare for null cipher Thread-Index: AQHX1jOjQJT1ziTmRE+fljMOtza2uKv8/E3g Date: Wed, 10 Nov 2021 17:00:30 +0000 Message-ID: References: <1636384791-157-1-git-send-email-anoobj@marvell.com> <1636549448-643-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1636549448-643-1-git-send-email-anoobj@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28aeabed-78bc-4d21-3ae5-08d9a46b9a4a x-ms-traffictypediagnostic: MN2PR11MB3648: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kfQgr7n7aUSgSzpdmQXj03x5kyMW0TQ89n0L9mKdtNWSqfr1pS8/dggV5noBHZ5NH9kw68HItMAyUJhzBUT0s8Whc28+5BcxRWioFZkTW2S1YwgNrVLq36uAa7NV284s7YBcbwRGzaVaQjN4farLhY4qxXkhVwA/FfQaVk3AkKbd3VqDVQs0Ax+dbtV2j4IXcNOeEidzmXOdIxNENirbRW/wBW5mE+qnmdb4mq8McgAo8jSgeuRJvLJxW3s2UN4zysNlKAhFEP8yFMAnKuORkLcL+xSBa1letcE+26+R4g2aEI+S+ofxwnk2ax7lvpbnzGRyHrH0s9BJ52skW0ZFj9iWhrWWcGRxduYwvlUbGD9AYMQ4C3uhl5ochAfQvs0Q4U9esrQQcw4sDGwku0tN8MCpYaBSwJExByi1lVxvQ78/NvtMkE7zGRcEzLz49XWj5qj4BpnOv8oTqVwkgmlm7XgyKy4dQSshmmtjvIBGw0fWmK8qLjbaR+UrE0yTXsJ/d99+Tc3DPTmkqfEG1gJ5zZqveQuu0ZSQWcvVKv1kOVH3gkO4BqE8u75AFzVMJpnuyHSIk2cXdpMhZW16f/Id0FqdJ5bLChhhWqjjFI4toy7xHyUjiTMp/hhBYcAxajjpz567+ZRVNbh+UeEGYmpc85eNAYxz6FKF5hBbUSKvFqAmQRhRgNVw4VJyBjunRioH3CVT/UGb/CTpxULSBlj9sQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(122000001)(316002)(7696005)(110136005)(38100700002)(186003)(86362001)(5660300002)(54906003)(26005)(71200400001)(107886003)(52536014)(38070700005)(82960400001)(83380400001)(4326008)(64756008)(9686003)(2906002)(8676002)(55016002)(508600001)(66446008)(66476007)(6636002)(6506007)(76116006)(8936002)(66946007)(33656002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ItgpJhjGITalyPyQix1IhBpW1mibTTm8TcKyZ5iP9UWP2bx6GLDuMUma9YJ0?= =?us-ascii?Q?dvKBoBRfG5+IOEDdrxDpgV1v6zzp0Vy6yIchN+WYdg/PK+SZKnAeOixB0aIw?= =?us-ascii?Q?pDGw2VG8wjYj6i37829BaX4XE1jMrBe3Q7pwgvSQG2s4Ui7DuaqggvqiYAEd?= =?us-ascii?Q?VrEsom2zx/e9DhbiyFtlCdqCZnjAegD9HrySYUHp4ja+LZ5qGS/pnjwc2X1Q?= =?us-ascii?Q?3gVMDz/HZZp4e+xvD6xWibOeo7pSg7iZFyNyK72edmssPvDsW83SG/+ccmrO?= =?us-ascii?Q?K9oe8bP0N1d8UYgsTl8efUzdXXr5PUB+ukzChC6T5Lc5MIrhkfe/s2krurGX?= =?us-ascii?Q?HY0vOfnFPT9Ipsx35S7X4/tNcJ8agH8FFD6f+6FVfS04qVNDklhBpzwrlY2z?= =?us-ascii?Q?CvVde39KiGwgnKqZjOLSSk7+RZDsbCFIFrsth9Js7NlIIfZJ5IOsCs/Lmbt8?= =?us-ascii?Q?8Fl6zgpI+GCAEscKZPaJFQUl2btYSonYtf5/0PVe0MQN3yCJE4aYd3U5Isft?= =?us-ascii?Q?q/Iyf/9jW5aP7Cu+WvBXTAZDV/xyHVkygBQsM5xhf4ATwjxjNhZ302KxL7lh?= =?us-ascii?Q?tAhbaQ2F7Nt9i1UnSjvMmQTZl8cr4H+XFDw8jAEUBpt6CsWwSlXYM+x0ucfi?= =?us-ascii?Q?CGH2HKiJBLjRAjv6DuouHj70j8fYPqGMT2Ea+v2XoUbnxlmRPMdrqwD6sCzQ?= =?us-ascii?Q?Tf3twjYlZZd30wMg1r2rJ3viVZwRJfdp+MkCqNG92eJPLJVKXTfMJHWLdgGb?= =?us-ascii?Q?sLE/z39ipGhWR5EPVDx50HQI6+YimJZ3w6zvD6y1z1yY/WES8a3lal38h6GD?= =?us-ascii?Q?FN+0AcOVMGKuODDlVyR8r9qIFNcuy6UHdXhScicqPOfJRMRV8o0GeLOmNv1C?= =?us-ascii?Q?Cn9RZxAyzYBcyKZyWhwNw2cFwtg7lMoyc/GRAtam/TvjqDWlpfqXtA4zRKii?= =?us-ascii?Q?ewNqhQktIGHtaPdQ8/XNwDaA5h31F4fdZTnnKWT1Nr6L4v6dloAVJ943QLJ5?= =?us-ascii?Q?WfkpeiJaTVt3FghOQ6QMU0c6KF2l3hbptR8vu8UgpYJL1eEFxQL7J7R32JEp?= =?us-ascii?Q?ILJm4shl1VwriHYEl8YMeV9+U/gaqWpcYplaCBQteJ7p7ZOZXnjHfp54xelb?= =?us-ascii?Q?uLMRiCQp564nteDBueTQYTfeQZKaNP8AYS+NGDE+YJbYkjd+Ts4XBGbdffbG?= =?us-ascii?Q?zyA+Nc0QSpm7foZPXAZOsjvngUxW679x7H/+C2neqOy0ymLbA0ytnq7Le5qE?= =?us-ascii?Q?VYf2ycld6gJZa3Sq2mkJLXVvD6sE3iE2Wf3WNsKrgiNZJ0fAqmWrCOrhsYhS?= =?us-ascii?Q?k9TU7wdl1xBt09hvHNdWi+6uLGZJK4tC91nYfATaYPDPc6m+B8EYKVRczdSN?= =?us-ascii?Q?bZJU1KnJuPBKZ9a9JHRfBoFZbCRvrvhR4GUw9dBgyoLY7ohvBAeFDE3mEcHf?= =?us-ascii?Q?1dI8ERKvAExIG5EXBK49GpldZc8ClQ5T5iddCAFi55EK4/ZYqttyPDMYI924?= =?us-ascii?Q?9tw6NpS8TinNV0vPq08GDAq8cMT/pXdBzjoIyt8ZzU3ypowgCccD1nToOrlj?= =?us-ascii?Q?g8CaVb9MFmAtwgLB8EeN+134V6kzS0LPt/1AZbWY7XQTUPX+VsGXJj1DMv/I?= =?us-ascii?Q?Plxm1znlYn/CZ2UztOPVmYQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28aeabed-78bc-4d21-3ae5-08d9a46b9a4a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 17:00:30.4608 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Nj4VyyMwMomS8hNLa8fc0W0QVBdiffLVYyoeI/oymygTpa9INWZdecLgOQj7eAi0sJIKSeCn8sw3HL2Scmms2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3648 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, >-----Original Message----- >From: Anoob Joseph >Sent: Wednesday 10 November 2021 13:04 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; De >Lara Guarch, Pablo >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >; Hemant Agrawal ; >Nicolau, Radu ; Power, Ciara >; Gagandeep Singh ; Ji, Kai >; dev@dpdk.org; adamx.dybkowski@intel.com >Subject: [PATCH v2] test/crypto: skip plain text compare for null cipher > >NULL cipher is used for validating auth only cases. With NULL cipher, vali= dating >plain text should not be done as the PMD is only expected to update auth >data. > >Fixes: e847fc512817 ("test/crypto: add encrypted digest case for AES-CTR- >CMAC") >Cc: adamx.dybkowski@intel.com > >Signed-off-by: Anoob Joseph >--- >Changes in v2: >- Made the skip applicable for in place also (comment from Pablo) >- Re-organized code as suggested by Pablo >- Made same change in test_mixed_auth_cipher_sgl (comment from Pablo) > > app/test/test_cryptodev.c | 63 ++++++++++++++++++++++++++-------------- Acked-by: Ciara Power