From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD878A0C53; Fri, 3 Sep 2021 11:38:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BA4F40DF7; Fri, 3 Sep 2021 11:38:46 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id BF1E240DF4 for ; Fri, 3 Sep 2021 11:38:43 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10095"; a="206498069" X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="206498069" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 02:38:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="511408361" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 03 Sep 2021 02:38:42 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 3 Sep 2021 02:38:42 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 3 Sep 2021 02:38:41 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 3 Sep 2021 02:38:41 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 3 Sep 2021 02:38:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fMtrFFmxU9y1v+hXOuNlKMOj30IMFEOjAP5ZgBvG72i8Njd7CLStm23c0N40peRTsnTWbLAHZmroOkN3I8GomB8mrz5DrdDe6D8Y3dyak0MvEA3NSQx8LfAT8LHW2aHlMhqfB0oXH3gBf/+NqBQYpGzQNXy7CjEIBQKusCk7Ulx9QGY4hKfGwjfNet7dM8HY5h0z/qLxfRf8rg+QMndVJStTF4yo6tS63wCwlucJvx+4bRcdTE1KGk+oUQ0Z9/Ikbm/X9mP94vv+5mwdszOqYFp8G82hovqLUmYbYXLMDhAoTpiIDXxBr4wnl8w+P4pVmm/HqaRtv7LVkrxYRigkhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=i15RAj0rzneSvKuAKSIC3RvvveF20MRqN5dBcH44lYM=; b=V89D00o/jGOH6JP5mwpnnQ+zf+Vk6jMrvJRH+HrU6X3NYcKYPSrUznD3Ku4D0GXSk6gfP+vyxGxUeSnH3/di/NLLeQJRgFGYNLYc/Tk7qVq4nqGR8tI4h8z2E8O7N1OGs/XXlF+8jxW5MHycY4wSHGwVY8UMSfZ2q70iwHOEhcjjAL5cfCBZspYrOcWtTdstzXAdyB993d6WI6xxQJM0/DLSwQygyAdYgRvFZnu7+2Ez8+KfHDLyDLBCYGY1lczaS4H+Ph3X81dvq/yY/0KESWiKJyo6sxFriuE38DGcKIW6sF5a9lHKQwJgsYVERdngFEE2jMUq4sq7FvHhk6B5rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i15RAj0rzneSvKuAKSIC3RvvveF20MRqN5dBcH44lYM=; b=b5bNF132wQfDKlaQ5N0+x7w7ny4rD6MSd5mvEn33zhx3qINz6pDYwutS2aTd2pFah0wJUZo9aRaMBNLN3x4K9qlH/Z//iA5Kxdliw5ODWbe0Q6aJYpcnvmeUSIW/RsmYO4mGok9Rb5On+ukYiTW8WdsOMSJ8cYVKNbb2PVkrzxU= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3950.namprd11.prod.outlook.com (2603:10b6:208:137::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Fri, 3 Sep 2021 09:38:40 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3%6]) with mapi id 15.20.4478.019; Fri, 3 Sep 2021 09:38:40 +0000 From: "Power, Ciara" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: Jerin Jacob , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v3 1/5] test/crypto: add lookaside IPsec tests Thread-Index: AQHXoH7SQ2rdACquokWpENFLnU9SUKuSCirg Date: Fri, 3 Sep 2021 09:38:40 +0000 Message-ID: References: <1628675138-17300-1-git-send-email-anoobj@marvell.com> <1630644420-1256-1-git-send-email-anoobj@marvell.com> <1630644420-1256-2-git-send-email-anoobj@marvell.com> In-Reply-To: <1630644420-1256-2-git-send-email-anoobj@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b0b098f5-0e9c-4615-c2be-08d96ebe9ce6 x-ms-traffictypediagnostic: MN2PR11MB3950: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Py2GmfS4oVM+d56uT4K2uW01GISwkOvaM9fttweXyn01dAd+ofSz48/oP2H7UHwfts4wLj2QBod8ykVgs+s5pXt+UlPNpiNXxt4CQJcGADBBzNNN0Fpr45EsEbfKPMKo5OFh4ZQBWBKXpV5FOvvjSRVPNXNnBW+XortlR6blKvU+Y0MzyWIJBvZoH1MQgOooeeUuONbj54e8POMMmleo/64GL3gh6Q70FVFQTJzeDd2caXVjU5YEdhcPmbJuqkO7rINp0/HkIslKwwJUE4CRXO7oL5I4jT60+faGZcUmBA/iynqkmVFFcvo9Nr0slZfpEXBnfNRwxPrx6N/V/Eof5h9raQGKGz4qLMU4C2aJNPA6ibS7aN4wGozcVog7C0ZK34YQjWMpSi2xgAznJnDSHTF7kgcAKxzaQHPs02WbYpAR+APRQy3hEVS/qvakXEQr2DrGz0FhZnawv8oub5YrazWhcGn8XO8JefwAlPXB3i5g0iPBczWYnSwUktA7aFpKp+cuI+iXRK8z5RD/9sWQ4DpO5oi4NaDD33zGYFvso7p4p9fn82KRvsDrF0VONKgvsxMQzpCyRKuo4mqJgM7UP/WdGgY+ZyAh2z7722pXGjRUx8CMll/F3qcm0wvcrpzIDr8B00WX6LZRn4r4VesPEAlFSRJYytBBU/RmcS9wxwkMO9bNEQ7mk8kvUrBlJe0ciaUFafxCGDbMDUHZ/m4RRg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(376002)(136003)(39860400002)(64756008)(26005)(66556008)(66446008)(9686003)(66476007)(33656002)(55016002)(76116006)(66946007)(71200400001)(4326008)(186003)(6506007)(8676002)(52536014)(5660300002)(122000001)(83380400001)(38100700002)(7696005)(8936002)(316002)(6636002)(38070700005)(86362001)(110136005)(2906002)(54906003)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qA3KQtB+XhUHyfPrHt3C12JTfXLv6EHDTyniMOzXNZZs765hr5uxUhDc5TTv?= =?us-ascii?Q?DVKKOhiKu0U0j3GIS5TJ6iXiGHWrXqg/Ng6jAdhcbp5UA1FdeJOYfrSYfvTY?= =?us-ascii?Q?BmI7NMRZH5s1LQ4xgDMV5/ypQsvYrLW7J6nKUDHbad+22MFkDYlvLsNxv2wL?= =?us-ascii?Q?Knk04wPviY4MhQeP48gNIw6Y0zlWQzYubAApnvuzpMeFG6quTUS03bwLcBvU?= =?us-ascii?Q?47rhAANN4zDgyvAwsfpFeS5v3FeBsjpSoIKPsmS6c8UgX/PgE/g9vMlxqfgG?= =?us-ascii?Q?oP/htx6HvSvmkbDmD9X8HYo3RFSlNP5ik6+/e3ajOkYoJkJE9z9IHyJCQr+F?= =?us-ascii?Q?J+TWcSAWnVSWYnOS/oqZ+KJV5kp5lmwDw9zFQ1biWYXNxSaxPWL1kWJmB7Th?= =?us-ascii?Q?avn7Ds3p7pZGcACBL1s79AJ3PtGgt/ElPLe80TN+pIZHqhBvdZKPy3woiJRx?= =?us-ascii?Q?XrOIksDGPF66gfKkxsRWvQuPH7954+ohfadA1xbYkIP6vcNzAUOsglblNH7W?= =?us-ascii?Q?8ewADfOp/K+bEIP+qfg1S7BEJ4mRsOEAv0xabfWfHcRaZVPXdCURVy4TNYlM?= =?us-ascii?Q?hRus7s6ymrkf2C8nKsGx6hKztP7uzYQ+V6xo8cXJn7sn4ZfvihU/0LrShlj6?= =?us-ascii?Q?oF26FEPxNpe3Sepz2JblYKpnIYdfRPAjjGFNHn+lZ50uDSXF6dSqo4NlubyD?= =?us-ascii?Q?7QNHFbzZCr823P+kDvAyOewLp6Ne9G+vKWGJeNAmSRCValdjpUBRqrlfT5jd?= =?us-ascii?Q?SsUfUNfRbbK/oi2d2oGnRA6VujBiHSCBD4+Lrf5y56iFIpqICma+5itEKyny?= =?us-ascii?Q?n/4+z0asWIS0T6zwR9ft1DB683jGD9ptfsnFGj2kCHBJVEb502/yJv8w2IS0?= =?us-ascii?Q?EhFjd8+0NktIZ3SINTOa6lG1WSnTq461EZtOf9qUwP5C27o7k6Nuo56SFwqt?= =?us-ascii?Q?2gNm0lR5h2z/01z8M/KqTMS/ApEW/0pMkF7nvuNfIzAWEG1vfEGwIEarcV2f?= =?us-ascii?Q?Xhmmve73nYbzOsq6k0f7Yy1EtPQk7UGOWZvwNphDUTf0NazxDqCquRjVdkBr?= =?us-ascii?Q?iFKed+y/ky0k+LLastdtB7lRrMWHgcLZYqapflGL6dhdA3JmphIybstAGXcz?= =?us-ascii?Q?6DZmiPWhhtxmUvhLc+gqHPnJnu+ShfGE8xFJz1thjL0lzb7qvq1599rVwAZv?= =?us-ascii?Q?ERyq0AOl5x3Aalw/mlPMDvEWHPmPfD6kLjAX5a2s32rDRs8N2TRzUQsWJY7z?= =?us-ascii?Q?LwWv5BOwjfgofRGF6B0MtkcCA/tlhRxoI40Xp1H9x1QhPTnXlYAbIP/DiFbY?= =?us-ascii?Q?NCA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0b098f5-0e9c-4615-c2be-08d96ebe9ce6 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 09:38:40.3916 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SsIntmZu/wcqrcMfo8tZiWhr+iU9PSFC1xMy2YT9jxihgSiWwB7vXmWyN46Y02dYFCjydaTzPJ6dEud1tZQUIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3950 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/5] test/crypto: add lookaside IPsec tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, Left some comments/questions inline. Thanks, Ciara >-----Original Message----- >From: Anoob Joseph >Sent: Friday 3 September 2021 05:47 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; >Ananyev, Konstantin >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >; Hemant Agrawal ; >Nicolau, Radu ; Power, Ciara >; Gagandeep Singh ; dev@dpdk.org >Subject: [PATCH v3 1/5] test/crypto: add lookaside IPsec tests > >Added test case for lookaside IPsec. Inbound known vector tests are added. > >Cipher list: AES-GCM 128, 192 & 256 > >Signed-off-by: Anoob Joseph >Signed-off-by: Tejasree Kondoj >--- > #ifdef RTE_LIB_SECURITY > static int >+ipsec_proto_testsuite_setup(void) >+{ >+ struct crypto_testsuite_params *ts_params =3D &testsuite_params; >+ struct crypto_unittest_params *ut_params =3D &unittest_params; >+ struct rte_cryptodev_info dev_info; >+ >+ rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); >+ >+ if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_SECURITY)) { >+ RTE_LOG(INFO, USER1, "Feature flag requirements for IPsec >Proto " >+ "testsuite not met\n"); >+ return TEST_SKIPPED; >+ } >+ >+ /* Reconfigure to enable security */ >+ dev_configure_and_start(RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | >+ RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO); >+ Just a question on this - each testcase uses ut_setup_security which in tur= n calls dev_configure_and_start, Is the configuration resulting from this call just being redone when the fi= rst testcase runs? >+ /* Set action type */ >+ ut_params->type =3D >RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL; >+ >+ if (security_proto_supported( >+ RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, >+ RTE_SECURITY_PROTOCOL_IPSEC) < 0) { >+ RTE_LOG(INFO, USER1, "Capability requirements for IPsec Proto >" >+ "test not met\n"); >+ return TEST_SKIPPED; If the test is skipped here, the device is not stopped, which I believe wou= ld cause problems for the next testsuite setup configuring the device. >+ } >+ >+ /* Stop the device */ >+ rte_cryptodev_stop(ts_params->valid_devs[0]); >+ >+ return 0; >+}