From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 957CEA09D3; Thu, 12 Nov 2020 18:09:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A6595928; Thu, 12 Nov 2020 18:09:51 +0100 (CET) Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) by dpdk.org (Postfix) with ESMTP id B3A4856A3 for ; Thu, 12 Nov 2020 18:09:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2943; q=dns/txt; s=iport; t=1605200989; x=1606410589; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+/MQ/uryh46R7lIN/r7kqaXcDs7XqoFQ7bOX3CYMWr4=; b=Xj9eiz9Q9dbN3/Jvf4FXUJKvdxvaTTUANu0IuJpcthIzMgNm+KhD1ae+ Erh/4VUjQTIwDsYqD11NorXzu35OH6c/fzR4sU44Oos9d73FnqMYEDRZ0 dI1Rs6U+IDC7U6UyrZ6w9227PEv99mFrxQsbNOWHMRpDqoLEx9GHwddky s=; X-IPAS-Result: =?us-ascii?q?A0BgBwBEa61ffZhdJa1iHQEBAQEJARIBBQUBQIFPgVIpK?= =?us-ascii?q?HtZLy6IBgONV4hbkCiBQoERA1QLAQEBDQEBHw4CBAEBhEoCghsCJTgTAgMBA?= =?us-ascii?q?QEDAgMBAQEBBQEBAQIBBgQUAQGGPAyFcgEBAQMBEigGAQE3AQsEAgEIEQQBA?= =?us-ascii?q?QEeEDIdCAEBBA4FCBMHgwWCVQMOIAEOpkACgTyIaHSBNIMEAQEFgTMBg18Yg?= =?us-ascii?q?hAJgTiCc4omJhuBQT+BEUOBUX4+hCQcg0iCLKRlgiyRHgqCbYkPkieEQ500L?= =?us-ascii?q?Z4glVMCBAIEBQIOAQEFgWshgVlwFYMkCUcXAg2OH4ElAQmCQoUUhUR0OAIGC?= =?us-ascii?q?gEBAwl8jUwBAQ?= IronPort-PHdr: =?us-ascii?q?9a23=3A/ssZVR9hdrhFEv9uRHGN82YQeigqvan1NQcJ65?= =?us-ascii?q?0hzqhDabmn44+7ZRCN5PNxgVuPVoLeuLpIiOvT5qbnX2FIoZOMq2sLf5EEUR?= =?us-ascii?q?gZwd4XkAotDI/gawX7IffmYjZ8EJFEU1lorHC9LUVRXs35Yg6arni79zVHHB?= =?us-ascii?q?L5OEJ8Lfj0HYiHicOx2qiy9pTfbh8OiiC6ZOZ5LQ69qkPascxFjA=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="5.77,472,1596499200"; d="scan'208";a="609277191" Received: from rcdn-core-1.cisco.com ([173.37.93.152]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 12 Nov 2020 17:09:47 +0000 Received: from XCH-RCD-005.cisco.com (xch-rcd-005.cisco.com [173.37.102.15]) by rcdn-core-1.cisco.com (8.15.2/8.15.2) with ESMTPS id 0ACH9l0S008602 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 12 Nov 2020 17:09:47 GMT Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-RCD-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Nov 2020 11:09:47 -0600 Received: from xhs-aln-002.cisco.com (173.37.135.119) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Nov 2020 12:09:46 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 12 Nov 2020 11:09:46 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LyEd1J4JoKy6gpM8LSE1/bE2si86F6SFHVS3a6mUqIcel9h8Msr3JqgmxQhd40aJo+zPTD2RqtM/RPQo3WlnQ8dWeE9ShWomlciDaWYd3d5fBIvyQDuyeccPfFLya0Mb8aCia/wnwpmxT53uVw6ZJfTd72MkoRgIZzIl6HSFV2taoXjzQEuI0GXX6tpqUbvfkox2vvi+GEmjp2GCIWQbclDPzfE4sEK20/QsRDekGXwGDZqXGVJjGMe4n+UrUSwcHkRie4KbPzPAxYJeGSfGpbREVFXwxqdG+nuz8ufyVblcql3N//aQoauFsZXNVz5vLBaDAWr2LMkRb8z+W/eZ6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gKy5gH64Z2pSXlQnjmZ9EqWegUYvdbcodrbreIVdhxc=; b=VgvTvaGllhsYAb/fVROKTy1gkLHvbk28foN7uAjFGlEorPhTvTP/PQV5X7ieimlMKCCZJDgpARSib4tmy5i2L9EXYDHsU4K+bs0JfJ0vkeoWZH7Cp+M2HIDT7xrMwgBOT26nAcq+Fi8D7XRos3hR2cmKG2qBN9WtovdLb61pUdsEmBusJUWaxgfdkVH5zbH/MRZBYJ0uXVfcxKGcbMWTl1qTRroCGyCU/VTAUxdjTLgm9izvG4GuNK5BL8Y0Zkxa5OEKcQLqI4dhaS5GSW9+cBfFHsVeBByPoUadsq9sWe0bt4wblLokKLXPT6cI3BdeqQuYJicaWzQCP5D+ul81/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gKy5gH64Z2pSXlQnjmZ9EqWegUYvdbcodrbreIVdhxc=; b=r+g90xkyXEj2KrVveRh1Mc5X/LpZMeNLG6Awb/9QfPO39VF06OSgJx0HOx2Dz+qfw+AhBmTW9EMnhIzj7Ywn5mBqyATOeXzS7ZI5W7/MVilC32ZrRLK5j34sM9FPGc1h4t4P2GnbNGlwOeDzzXO3vm6Np0Br5cAEWM3xScWsfK0= Received: from MN2PR11MB3886.namprd11.prod.outlook.com (2603:10b6:208:137::15) by MN2PR11MB3614.namprd11.prod.outlook.com (2603:10b6:208:ea::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Thu, 12 Nov 2020 17:09:45 +0000 Received: from MN2PR11MB3886.namprd11.prod.outlook.com ([fe80::e4ce:8b23:f0cc:ed77]) by MN2PR11MB3886.namprd11.prod.outlook.com ([fe80::e4ce:8b23:f0cc:ed77%7]) with mapi id 15.20.3477.036; Thu, 12 Nov 2020 17:09:45 +0000 From: "David Harton (dharton)" To: Bruce Richardson CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] Eliminate config/rte_config.h? Thread-Index: Ada5CRP8ZTNi3bVXRXOBIao7OHiYyAAAiqcAAAGS7QAAALybQA== Date: Thu, 12 Nov 2020 17:09:45 +0000 Message-ID: References: <20201112154820.GA1322@bricha3-MOBL.ger.corp.intel.com> <20201112163324.GC1322@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201112163324.GC1322@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cisco.com; x-originating-ip: [2600:1700:720:b0d0:b0bd:5e5b:940d:2af2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49499a04-4322-421d-30b6-08d8872dc137 x-ms-traffictypediagnostic: MN2PR11MB3614: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CsexSphIDh0yTT5vOLrTBK46qQwL+G9JJIXh4/J/m/nYzE21C2SbqxpbzhcyknqtgHtIfviKCiOr/x/Zdx87af9fAG0+Kl5bKINrrBr1jtbxm06arVkE9Jfuz7L5CrhSkxtODm7FdkiGbtc6nR7ioOwRBy1TzC43ZLOfI/cjhM2SsWvCTJp1JPCO3Krs/Nal1NoH+djBMQkoL9cXZ/PkkVZV/59scH90VXn/OA0/M4LfR0i8Oy2CJGjwRHN4MMuEhQTro8hf5nThfkW3KOF2W9FxRu3vCszW7yuYNXm820H5ddMiEs5bj3vlf+ZXCVrLFyX8YRwuoqTOkKbUmLsm1+j9Tr9buKpxy76O2QGf/vCJNlEAv3B4RRGXKdx84/xvtlIz3sb3PqQ8prn0uMRPOw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3886.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(346002)(366004)(396003)(136003)(2906002)(316002)(86362001)(478600001)(64756008)(66946007)(33656002)(4326008)(83380400001)(966005)(66556008)(66446008)(66476007)(8676002)(6916009)(6506007)(5660300002)(71200400001)(53546011)(7696005)(55016002)(52536014)(186003)(8936002)(9686003)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: NenkdspYTzb5zvg6WQbTGIikm4+0vNPwdJt7Ja8f5IV5dR0g6C3E+maiUp48p3z/x7DDLt9ccd5BAqRB9Wj64OlxTqXtidyXWG3W5DVpxwuuz3KVN7YDsx49ZXuqvRWQjzEryM6qCRbL/F8fTAt8kvT9v/WXocdDIHEpcWRS+r36xHqzNZgXHEmRFtYgj4knyrQ0U8zz5lB2/gQznEXwprrrQ324bIQA94x/EhwWvKPOBMAXWCnaAWr2H3n3j75N6K8Riq5ozp+woJS95cq13Zw65fpyCmUuaU0tzKGiyTzJPuQG63iGVPW+tvN0ItG5LB5oy4Cwl0DsijYjko9ux0S4S9JjyN2EvlndJcQJxBIa17kuvZcESwkotBjwOI4kq0HEQrF5ZDAx0oMmvHeFZWeXz2ijfH/gbtV6jgSWEKhqct8h655AT/+i9vjfN8zHWcFOMQBrZBG3tVJ5fYgcoDQKjQyCZchs6AEdDBsbCUmM8PHP4gkT2EdbG0lC65+3rsEeCm4HS+33CCs6pPKvQpwaFBpDSsu2gbVyTfJIQYYkS+o3/kXmnZ248qVdem1s0gkj5HiQpnQXyB9PijO93HQBcwCQX8TgYeJ1jSd4+4MAL4YGcNof4F+B6UQMeKGDnZV2/vWos0cGyJJCJQKRuE0dRNPFo8N4Uk87Vu998wtISCpLa1zlnNlEj3seMyMI/WttI/Ehi/G6tEiLPdZpPA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49499a04-4322-421d-30b6-08d8872dc137 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2020 17:09:45.6713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PKpj3RhligaVxpXTgbJhTiFqBWWfTIHKb+kj5gSYIdGuev3qOWrCi0C/LAkRkCpNcBx4JMoVfL9RcYsOuLokUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3614 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.15, xch-rcd-005.cisco.com X-Outbound-Node: rcdn-core-1.cisco.com Subject: Re: [dpdk-dev] Eliminate config/rte_config.h? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, November 12, 2020 11:33 AM > To: David Harton (dharton) > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] Eliminate config/rte_config.h? >=20 > On Thu, Nov 12, 2020 at 03:48:20PM +0000, Bruce Richardson wrote: > > On Thu, Nov 12, 2020 at 03:39:10PM +0000, David Harton (dharton) wrote: > > > Hi folks, > > > > > > > > > > > > Been experimenting with DPDK 20.11 and the loss of the old "config" > > > hierarchy. > > > > > > > > > > > > I wonder if anyone considered eliminating config/rte_config.h in > > > favor of a config/dpdk_conf that can contain the default values at > > > the start of the file but can be overridden with values later in the > > > file similar to how the old config files worked? > > > > > > > > > > > > It just feels awkward to modify a versioned header file per build > > > especially if multiple builds want to share the same repo but with > > > different values specified in config/rte_config.h especially when > > > "rte_build_config.h" is included at the very beginning of > > > config/rte_config.h. > > > > > > > > > > > > Thoughts? > > > > > > Dave > > > > > > > I'd personally be open to replacing it if we have a better solution. > > Are there many values in it that you look to tune, A couple that quickly come to mind are RTE_LOG_DP_LEVEL and RTE_BACKTRACE; = but, doesn't a single tunable value suggest a different mechanism is needed= ? > > because I believe > > the general consensus is that we want to reduce the number of tunables > > we have per DPDK build? Sounds good. But doesn't that imply the config knob (i.e. #define) should = just be removed or minimally moved? IOW, things in rte_config.h should be = tunable values and if they aren't tunable then they should like be in compo= nent specific "private" header files? > > To that end our main concern should be having > > decent defaults, and thereafter we can see about the best mechanism to > > allow easy overriding for edge-cases. > > > > Any early attempt at such a thing was tried [1], but unfortunately it > > had issues so we need a new approach - possibly one as you had > suggested. > > > Just sent another idea of what options might be possible: > http://patches.dpdk.org/patch/84068/ That would be better. What if we had a config/dpdk_conf with all the defaults defined using the o= ld 'config' syntax and then tools just append any overrides as desired. A = simple tool could parse config/dpdk_conf to generate the appropriate rte_co= nfig.h instead of rte_build_config.h? BTW, one of the reasons why I'm asking about a more "config" like approach = to help ease switching between the make and meson build methods for platfor= ms. It may also help folks adopt the meson approach more easily. Dave >=20 > Regards, > /Bruce