From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wang, Zhihong" <zhihong.wang@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/virtio: add DEVICE_NEEDS_RESET status bit
Date: Wed, 5 Aug 2020 10:52:27 +0000 [thread overview]
Message-ID: <MN2PR11MB406335F98D50CAE0209B5A3F9C4B0@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200804072431.86441-2-amorenoz@redhat.com>
Hi Adrian,
> -----Original Message-----
> From: Adrian Moreno <amorenoz@redhat.com>
> Sent: Tuesday, August 4, 2020 3:24 PM
> To: dev@dpdk.org
> Cc: Wang, Zhihong <zhihong.wang@intel.com>; Xia, Chenbo
> <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Adrian Moreno
> <amorenoz@redhat.com>
> Subject: [PATCH v2 1/4] net/virtio: add DEVICE_NEEDS_RESET status bit
>
> For the sake of completeness, add the definition of the missing status
> bit in accordance with the virtio spec
>
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
> ---
> drivers/net/virtio/virtio_pci.h | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_pci.h
> b/drivers/net/virtio/virtio_pci.h
> index 74ed77e33..ab61e911b 100644
> --- a/drivers/net/virtio/virtio_pci.h
> +++ b/drivers/net/virtio/virtio_pci.h
> @@ -57,12 +57,13 @@ struct virtnet_ctl;
> #define VIRTIO_ID_9P 0x09
>
> /* Status byte for guest to report progress. */
> -#define VIRTIO_CONFIG_STATUS_RESET 0x00
> -#define VIRTIO_CONFIG_STATUS_ACK 0x01
> -#define VIRTIO_CONFIG_STATUS_DRIVER 0x02
> -#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04
> -#define VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08
> -#define VIRTIO_CONFIG_STATUS_FAILED 0x80
> +#define VIRTIO_CONFIG_STATUS_RESET 0x00
> +#define VIRTIO_CONFIG_STATUS_ACK 0x01
> +#define VIRTIO_CONFIG_STATUS_DRIVER 0x02
> +#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04
> +#define VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08
> +#define VIRTIO_CONFIG_STATUS_DEV_NEED_RESET 0x40
> +#define VIRTIO_CONFIG_STATUS_FAILED 0x80
>
> /*
> * Each virtqueue indirect descriptor list must be physically contiguous.
Should we also define RESET(0x00) in vhost lib? I don't see the definition
there. Correct me if I'm wrong.
For this patch:
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> --
> 2.26.2
next prev parent reply other threads:[~2020-08-05 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 7:24 [dpdk-dev] [PATCH v2 0/4] Add support for GET/SET_STATUS on virtio-user pmd Adrian Moreno
2020-08-04 7:24 ` [dpdk-dev] [PATCH v2 1/4] net/virtio: add DEVICE_NEEDS_RESET status bit Adrian Moreno
2020-08-05 10:52 ` Xia, Chenbo [this message]
2020-08-05 14:07 ` Adrian Moreno
2020-08-04 7:24 ` [dpdk-dev] [PATCH v2 2/4] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user Adrian Moreno
2020-08-05 10:53 ` Xia, Chenbo
2020-08-04 7:24 ` [dpdk-dev] [PATCH v2 3/4] net/virtio: add GET_STATUS support to virtio-user Adrian Moreno
2020-08-05 10:55 ` Xia, Chenbo
2020-08-05 14:06 ` Adrian Moreno
2020-08-04 7:24 ` [dpdk-dev] [PATCH v2 4/4] net/virtio: enable feature checking on virtio-user Adrian Moreno
2020-08-05 10:57 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB406335F98D50CAE0209B5A3F9C4B0@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=amorenoz@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).