From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] net/vhost: restore pseudo TSO support
Date: Tue, 18 May 2021 08:13:42 +0000 [thread overview]
Message-ID: <MN2PR11MB406352B36D136AD67D1F4D969C2C9@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210518070728.15341-1-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, May 18, 2021 3:07 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>; Maxime
> Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Subject: [PATCH] net/vhost: restore pseudo TSO support
>
> The net/vhost pmd does not comply with the ethdev offload API as it does
> not report rx/tx offload capabilities wrt TSO and checksum offloading.
> On the other hand, the net/vhost pmd lets guest negotiates TSO and
> checksum offloading.
>
> Changing the behavior for rx/tx offload flags handling won't
> improve/fix this situation and will break applications that might have
> been relying on implicit support of TSO in this driver.
>
> Revert this behavior change until we have a complete fix.
>
> Fixes: ca7036b4af3a ("vhost: fix offload flags in Rx path")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> 2.23.0
Applied to next-virtio/main. Thanks.
prev parent reply other threads:[~2021-05-18 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 7:07 David Marchand
2021-05-18 7:16 ` Maxime Coquelin
2021-05-18 8:13 ` Xia, Chenbo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB406352B36D136AD67D1F4D969C2C9@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).