From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix async enqueue accessing uninitialized variables
Date: Wed, 7 Apr 2021 06:14:52 +0000 [thread overview]
Message-ID: <MN2PR11MB40638DEA68067245BF91FE4C9C759@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210407032516.79091-2-yong.liu@intel.com>
> -----Original Message-----
> From: Liu, Yong <yong.liu@intel.com>
> Sent: Wednesday, April 7, 2021 11:25 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Liu, Yong <yong.liu@intel.com>; stable@dpdk.org
> Subject: [PATCH 2/2] vhost: fix async enqueue accessing uninitialized
> variables
>
> This patch fixs coverity issue in async enqueue function by adding
> initialization step before using temporary virtio header.
>
> Coverity issue: 366123
> Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
> Cc: stable@dpdk.org
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> index 48b013a9b4..ff39878609 100644
> --- a/lib/librte_vhost/virtio_net.c
> +++ b/lib/librte_vhost/virtio_net.c
> @@ -986,9 +986,10 @@ async_mbuf_to_desc(struct virtio_net *dev, struct
> vhost_virtqueue *vq,
>
> hdr_mbuf = m;
> hdr_addr = buf_addr;
> - if (unlikely(buf_len < dev->vhost_hlen))
> + if (unlikely(buf_len < dev->vhost_hlen)) {
> + memset(&tmp_hdr, 0, sizeof(struct virtio_net_hdr_mrg_rxbuf));
> hdr = &tmp_hdr;
> - else
> + } else
> hdr = (struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)hdr_addr;
>
> VHOST_LOG_DATA(DEBUG, "(%d) RX: num merge buffers %d\n",
> --
> 2.17.1
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2021-04-07 6:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 3:25 [dpdk-dev] [PATCH 1/2] vhost: fix " Marvin Liu
2021-04-07 3:25 ` [dpdk-dev] [PATCH 2/2] vhost: fix async enqueue " Marvin Liu
2021-04-07 6:14 ` Xia, Chenbo [this message]
2021-04-07 6:53 ` [dpdk-dev] [PATCH 1/2] vhost: fix " Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB40638DEA68067245BF91FE4C9C759@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).