Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost

["Xia, Chenbo" <chenbo.xia@intel.com>]

Hi,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, September 16, 2021 7:34 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Hu, Jiayu <jiayu.hu@intel.com>;
> dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; david.marchand@redhat.com; Jiang,
> Cheng1 <cheng1.jiang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost
> 
> Hi Ferruh,
> 
> On 9/16/21 13:15, Ferruh Yigit wrote:
> > On 8/20/2021 1:44 PM, Jiayu Hu wrote:
> >> Copy threshold is introduced in async vhost data path to select
> >> the appropriate copy engine to do copies for higher efficiency.
> >> However, it may cause packets out-of-order, and it also causes
> >> data path performance unpredictable.
> >>
> >
> > Just checking, if the patch is fixing data performance issue, should it be
> > backported?
> 
> This is experimental code that is not used in real product for now, and
> will likely heavily change given OVS rejected this design.
> 
> So I would personally not bother backporting patches for it.

+1. Based on the experimental state. Let's save the effort of backporting.

Thanks,
Chenbo

> Jiayu, Chenbo, do you think otherwise?
> 
> Regards,
> Maxime
> 
> >> Therefore, this patch removes copy threshold support in async vhost
> >> data path.
> >>
> >> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> >> Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> > <...>
> >
> >