Re: [dpdk-dev] [PATCH] Virtio TX: reverting a small change causing Virtio standard TX broken

["Xia, Chenbo" <chenbo.xia@intel.com>]

Hi Vipul,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Vipul Ashri
> Sent: Friday, August 7, 2020 8:58 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] Virtio TX: reverting a small change causing
> Virtio standard TX broken
> 
> Virtio Standard TX broken : Reverting a small change added few months back
> which has caused breakage in Virtio Standard TX path.
> 
> During basic ping Tx/Rx testing of net_virtio pmd driver using standard Tx
> path, We saw TX is broken since anomaly code added by below patch once
> submitted
> http://git.dpdk.org/dpdk/patch/?id=57f90f89458807bccc63425e4b7279687017797
> 7

First, your commit title and commit message have several problems:
1. Title should be: net/virtio: TITLE_OF_YOUR_COMMIT. As your patch is a
fix patch, your title maybe 'fix XXXX'.
2. Title and description too long, should be less or equal than around 75 chars
per line
3. Seems the link you attached is the bad commit you want to fix. Please use
this way to point it out: add 'Fixes: BAD_COMMIT_ID ("BAD_COMMIT_TITLE")' under
the commit msg.

For all above problems, please see previous git log for reference.

And for the patch content, what is the exact issue you met? I've been told that
the deleted lines were for some CI errors. Besides, better keep the '\' aligned.

Also, please cc to related maintainers in your v2 because otherwise it'll be hard
for them to see your patch.(use get-maintainer.sh to know them)

Thanks!
Chenbo

> ---
>  drivers/net/virtio/virtqueue.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtqueue.h
> b/drivers/net/virtio/virtqueue.h
> index 105a9c00c..81118d9fb 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)
> 
>  /* avoid write operation when necessary, to lessen cache issues */
>  #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
> -	typeof(var) var_ = (var);		\
> -	typeof(val) val_ = (val);		\
> -	if ((var_) != (val_))			\
> -		(var_) = (val_);		\
> +	if ((var) != (val))			\
> +		(var) = (val);		\
>  } while (0)
> 
>  #define virtqueue_clear_net_hdr(hdr) do {		\
> --
> 2.28.0.windows.1