DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
Date: Wed, 8 Sep 2021 05:07:49 +0000	[thread overview]
Message-ID: <MN2PR11MB4063D5C0C727370292CF8E6C9CD49@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210908105915.73420-1-xiao.w.wang@intel.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiao Wang
> Sent: Wednesday, September 8, 2021 6:59 PM
> To: olivier.matz@6wind.com
> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
> 
> rte_net_make_rarp_packet was introduced in version v18.02, there was no
> change in this public API since then, and it's still being used by vhost
> lib and virtio driver, so promote it as stable ABI.
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  lib/net/rte_arp.h   | 4 ----
>  lib/net/version.map | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/lib/net/rte_arp.h b/lib/net/rte_arp.h
> index feb0eb3e49..076c8ab314 100644
> --- a/lib/net/rte_arp.h
> +++ b/lib/net/rte_arp.h
> @@ -50,9 +50,6 @@ struct rte_arp_hdr {
>  } __rte_packed __rte_aligned(2);
> 
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
>   * Make a RARP packet based on MAC addr.
>   *
>   * @param mpool
> @@ -63,7 +60,6 @@ struct rte_arp_hdr {
>   * @return
>   *   - RARP packet pointer on success, or NULL on error
>   */
> -__rte_experimental
>  struct rte_mbuf *
>  rte_net_make_rarp_packet(struct rte_mempool *mpool,
>  		const struct rte_ether_addr *mac);
> diff --git a/lib/net/version.map b/lib/net/version.map
> index 355b7c25b4..7584018d58 100644
> --- a/lib/net/version.map
> +++ b/lib/net/version.map
> @@ -6,6 +6,7 @@ DPDK_22 {
>  	rte_net_crc_calc;
>  	rte_net_crc_set_alg;
>  	rte_net_get_ptype;
> +	rte_net_make_rarp_packet;
> 
>  	local: *;
>  };
> @@ -13,7 +14,6 @@ DPDK_22 {
>  EXPERIMENTAL {
>  	global:
> 
> -	rte_net_make_rarp_packet;
>  	rte_net_skip_ip6_ext;
>  	rte_ether_unformat_addr;
>  };
> --
> 2.15.1

Acked-by: Chenbo Xia <chenbo.xia@intel.com>

  parent reply	other threads:[~2021-09-08  5:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 10:59 Xiao Wang
2021-09-08  4:52 ` Stephen Hemminger
2021-09-08  5:07 ` Xia, Chenbo [this message]
2021-09-16 11:38 ` Olivier Matz
2021-10-02  8:57   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4063D5C0C727370292CF8E6C9CD49@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).