From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"amorenoz@redhat.com" <amorenoz@redhat.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 37/44] net/virtio: make server mode blocking
Date: Fri, 22 Jan 2021 08:19:49 +0000 [thread overview]
Message-ID: <MN2PR11MB4063DB8138784DA5BC0E3D249CA00@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210119212507.1043636-38-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, January 20, 2021 5:25 AM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; olivier.matz@6wind.com;
> amorenoz@redhat.com; david.marchand@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH v2 37/44] net/virtio: make server mode blocking
>
> This patch makes the Vhost-user backend server mode
> blocking at init, waiting for the client connection.
>
> The goal is to make the driver more reliable, as without
> waiting for client connection, the Virtio driver has to
> assume the Vhost-user backend will support all the
> features it has advertized, which could lead to undefined
> behaviour.
>
> For example, without this patch, if the user enables packed
> ring Virtio feature but the backend does not support it,
> the ring initialized by the driver will not be compatible
> with the backend.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> drivers/net/virtio/virtio_user/vhost_user.c | 9 +-
> .../net/virtio/virtio_user/virtio_user_dev.c | 121 +++++++-----------
> drivers/net/virtio/virtio_user_ethdev.c | 5 -
> 3 files changed, 55 insertions(+), 80 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c
> b/drivers/net/virtio/virtio_user/vhost_user.c
> index fb6fcc82c9..a48fadd8c9 100644
> --- a/drivers/net/virtio/virtio_user/vhost_user.c
> +++ b/drivers/net/virtio/virtio_user/vhost_user.c
> @@ -692,6 +692,14 @@ virtio_user_start_server(struct virtio_user_dev *dev,
> struct sockaddr_un *un)
> if (ret < 0)
> return -1;
>
> + PMD_DRV_LOG(NOTICE, "(%s) waiting for client connection...", dev->path);
> + dev->vhostfd = accept(fd, NULL, NULL);
> + if (dev->vhostfd < 0) {
> + PMD_DRV_LOG(ERR, "Failed to accept initial client connection (%s)",
> + strerror(errno));
> + return -1;
> + }
> +
> flag = fcntl(fd, F_GETFL);
> if (fcntl(fd, F_SETFL, flag | O_NONBLOCK) < 0) {
> PMD_DRV_LOG(ERR, "fcntl failed, %s", strerror(errno));
> @@ -736,7 +744,6 @@ vhost_user_setup(struct virtio_user_dev *dev)
> close(fd);
> return -1;
> }
> - dev->vhostfd = -1;
> } else {
> if (connect(fd, (struct sockaddr *)&un, sizeof(un)) < 0) {
> PMD_DRV_LOG(ERR, "connect error, %s", strerror(errno));
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index 95204ea955..c2a41fe3a0 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -144,10 +144,6 @@ virtio_user_dev_set_features(struct virtio_user_dev *dev)
>
> pthread_mutex_lock(&dev->mutex);
>
> - if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER &&
> - dev->vhostfd < 0)
> - goto error;
> -
> /* Step 0: tell vhost to create queues */
> if (virtio_user_queue_setup(dev, virtio_user_create_queue) < 0)
> goto error;
> @@ -190,11 +186,6 @@ virtio_user_start_device(struct virtio_user_dev *dev)
> rte_mcfg_mem_read_lock();
> pthread_mutex_lock(&dev->mutex);
>
> - /* Vhost-user client not connected yet, will start later */
> - if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER &&
> - dev->vhostfd < 0)
> - goto out;
> -
> /* Step 2: share memory regions */
> ret = dev->ops->set_memory_table(dev);
> if (ret < 0)
> @@ -213,7 +204,7 @@ virtio_user_start_device(struct virtio_user_dev *dev)
> goto error;
>
> dev->started = true;
> -out:
> +
> pthread_mutex_unlock(&dev->mutex);
> rte_mcfg_mem_read_unlock();
>
> @@ -422,36 +413,36 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)
> PMD_DRV_LOG(ERR, "Server mode only supports vhost-user!");
> return -1;
> }
> + }
> +
> + if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER) {
> dev->ops = &virtio_ops_user;
> - } else {
> - if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER) {
> - dev->ops = &virtio_ops_user;
> - } else if (dev->backend_type ==
> - VIRTIO_USER_BACKEND_VHOST_KERNEL) {
> - dev->ops = &virtio_ops_kernel;
> -
> - dev->vhostfds = malloc(dev->max_queue_pairs *
> - sizeof(int));
> - dev->tapfds = malloc(dev->max_queue_pairs *
> - sizeof(int));
> - if (!dev->vhostfds || !dev->tapfds) {
> - PMD_INIT_LOG(ERR, "(%s) Failed to allocate FDs", dev-
> >path);
> - return -1;
> - }
> -
> - for (q = 0; q < dev->max_queue_pairs; ++q) {
> - dev->vhostfds[q] = -1;
> - dev->tapfds[q] = -1;
> - }
> - } else if (dev->backend_type ==
> - VIRTIO_USER_BACKEND_VHOST_VDPA) {
> - dev->ops = &virtio_ops_vdpa;
> - } else {
> - PMD_DRV_LOG(ERR, "(%s) Unknown backend type", dev->path);
> + } else if (dev->backend_type ==
> + VIRTIO_USER_BACKEND_VHOST_KERNEL) {
> + dev->ops = &virtio_ops_kernel;
> +
> + dev->vhostfds = malloc(dev->max_queue_pairs *
> + sizeof(int));
> + dev->tapfds = malloc(dev->max_queue_pairs *
> + sizeof(int));
> + if (!dev->vhostfds || !dev->tapfds) {
> + PMD_INIT_LOG(ERR, "(%s) Failed to allocate FDs", dev->path);
> return -1;
> }
> +
> + for (q = 0; q < dev->max_queue_pairs; ++q) {
> + dev->vhostfds[q] = -1;
> + dev->tapfds[q] = -1;
> + }
> + } else if (dev->backend_type ==
> + VIRTIO_USER_BACKEND_VHOST_VDPA) {
> + dev->ops = &virtio_ops_vdpa;
> + } else {
> + PMD_DRV_LOG(ERR, "(%s) Unknown backend type", dev->path);
> + return -1;
> }
>
> +
> if (dev->ops->setup(dev) < 0) {
> PMD_INIT_LOG(ERR, "(%s) Failed to setup backend\n", dev->path);
> return -1;
> @@ -541,54 +532,36 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char
> *path, int queues,
> dev->unsupported_features |=
> (1ULL << VHOST_USER_F_PROTOCOL_FEATURES);
>
> - if (!dev->is_server) {
> - if (dev->ops->set_owner(dev) < 0) {
> - PMD_INIT_LOG(ERR, "(%s) Failed to set backend owner", dev-
> >path);
> - return -1;
> - }
> + if (dev->ops->set_owner(dev) < 0) {
> + PMD_INIT_LOG(ERR, "(%s) Failed to set backend owner", dev->path);
> + return -1;
> + }
> +
> + if (dev->ops->get_features(dev, &dev->device_features) < 0) {
> + PMD_INIT_LOG(ERR, "(%s) Failed to get backend features", dev-
> >path);
> + return -1;
> + }
>
> - if (dev->ops->get_features(dev, &dev->device_features) < 0) {
> - PMD_INIT_LOG(ERR, "(%s) Failed to get backend features",
> dev->path);
> + if ((dev->device_features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)) ||
> + dev->backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA) {
> + if (dev->ops->get_protocol_features(dev, &protocol_features)) {
> + PMD_INIT_LOG(ERR, "(%s) Failed to get backend protocol
> features",
> + dev->path);
> return -1;
> }
>
> + dev->protocol_features &= protocol_features;
>
> - if ((dev->device_features & (1ULL <<
> VHOST_USER_F_PROTOCOL_FEATURES)) ||
> - (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA))
> {
> - if (dev->ops->get_protocol_features(dev, &protocol_features))
> {
> - PMD_INIT_LOG(ERR, "(%s) Failed to get backend protocol
> features",
> - dev->path);
> - return -1;
> - }
> -
> - dev->protocol_features &= protocol_features;
> -
> - if (dev->ops->set_protocol_features(dev, dev-
> >protocol_features)) {
> - PMD_INIT_LOG(ERR, "(%s) Failed to set backend protocol
> features",
> - dev->path);
> - return -1;
> - }
> -
> - if (!(dev->protocol_features & (1ULL <<
> VHOST_USER_PROTOCOL_F_MQ)))
> - dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ);
> + if (dev->ops->set_protocol_features(dev, dev->protocol_features))
> {
> + PMD_INIT_LOG(ERR, "(%s) Failed to set backend protocol
> features",
> + dev->path);
> + return -1;
> }
> - } else {
> - /* We just pretend vhost-user can support all these features.
> - * Note that this could be problematic that if some feature is
> - * negotiated but not supported by the vhost-user which comes
> - * later.
> - */
> - dev->device_features = VIRTIO_USER_SUPPORTED_FEATURES;
>
> - /* We cannot assume VHOST_USER_PROTOCOL_F_STATUS is supported
> - * until it's negotiated
> - */
> - dev->protocol_features &=
> - ~(1ULL << VHOST_USER_PROTOCOL_F_STATUS);
> + if (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_MQ)))
> + dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ);
> }
>
> -
> -
> if (!mrg_rxbuf)
> dev->unsupported_features |= (1ull << VIRTIO_NET_F_MRG_RXBUF);
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> b/drivers/net/virtio/virtio_user_ethdev.c
> index 5e256f4e6d..e822d93690 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -174,11 +174,6 @@ virtio_user_delayed_handler(void *param)
> if (dev->vhostfd >= 0) {
> close(dev->vhostfd);
> dev->vhostfd = -1;
> - /* Until the featuers are negotiated again, don't assume
> - * the backend supports VHOST_USER_PROTOCOL_F_STATUS
> - */
> - dev->protocol_features &=
> - ~(1ULL << VHOST_USER_PROTOCOL_F_STATUS);
> }
> eth_dev->intr_handle->fd = dev->listenfd;
> rte_intr_callback_register(eth_dev->intr_handle,
> --
> 2.29.2
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2021-01-22 8:19 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 21:24 [dpdk-dev] [PATCH v2 00/44] net/virtio: Virtio PMD rework Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 01/44] bus/vdev: add helper to get vdev from eth dev Maxime Coquelin
2021-01-20 0:56 ` Thomas Monjalon
2021-01-25 10:53 ` Maxime Coquelin
2021-01-25 11:04 ` Thomas Monjalon
2021-01-21 8:58 ` Xia, Chenbo
2021-01-25 14:51 ` Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 02/44] bus/vdev: add driver IOVA VA mode requirement Maxime Coquelin
2021-01-20 15:32 ` David Marchand
2021-01-20 17:47 ` Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 03/44] net/virtio: fix getting old status on reconnect Maxime Coquelin
2021-01-21 7:12 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 04/44] net/virtio: introduce Virtio bus type Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 05/44] net/virtio: refactor virtio-user device Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 06/44] net/virtio: introduce PCI device metadata Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 07/44] net/virtio: move PCI device init in dedicated file Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 08/44] net/virtio: move PCI specific dev init to PCI ethdev init Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 09/44] net/virtio: move MSIX detection to PCI ethdev Maxime Coquelin
2021-01-21 7:12 ` Xia, Chenbo
2021-01-25 12:41 ` Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 10/44] net/virtio: force IOVA as VA mode for Virtio-user Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 11/44] net/virtio: store PCI type in Virtio device metadata Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 12/44] net/virtio: add callback for device closing Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 13/44] net/virtio: validate features at bus level Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 14/44] net/virtio: remove bus type enum Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 15/44] net/virtio: move PCI-specific fields to PCI device Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 16/44] net/virtio: pack virtio HW struct Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 17/44] net/virtio: move legacy IO to Virtio PCI Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 18/44] net/virtio: introduce generic virtio header Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 19/44] net/virtio: move features definition to generic header Maxime Coquelin
2021-01-21 6:47 ` Xia, Chenbo
2021-01-25 12:35 ` Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 20/44] net/virtio: move virtqueue defines in " Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 21/44] net/virtio: move config definitions to " Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 22/44] net/virtio: make interrupt handling more generic Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 23/44] net/virtio: move vring alignment to generic header Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 24/44] net/virtio: remove last PCI refs in non-PCI code Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 25/44] net/virtio: make Vhost-user req sender consistent Maxime Coquelin
2021-01-21 8:50 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 26/44] net/virtio: add Virtio-user ops to set owner Maxime Coquelin
2021-01-22 3:27 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 27/44] net/virtio: add Virtio-user features ops Maxime Coquelin
2021-01-22 7:25 ` Xia, Chenbo
2021-01-25 14:53 ` Maxime Coquelin
2021-01-22 8:46 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 28/44] net/virtio: add Virtio-user protocol " Maxime Coquelin
2021-01-22 7:27 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 29/44] net/virtio: add Virtio-user memory tables ops Maxime Coquelin
2021-01-22 7:34 ` Xia, Chenbo
2021-01-25 14:56 ` Maxime Coquelin
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 30/44] net/virtio: add Virtio-user vring setting ops Maxime Coquelin
2021-01-22 7:49 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 31/44] net/virtio: add Virtio-user vring file ops Maxime Coquelin
2021-01-22 8:01 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 32/44] net/virtio: add Virtio-user vring address ops Maxime Coquelin
2021-01-22 8:02 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 33/44] net/virtio: add Virtio-user status ops Maxime Coquelin
2021-01-22 8:02 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 34/44] net/virtio: remove useless request ops Maxime Coquelin
2021-01-22 8:10 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 35/44] net/virtio: improve Virtio-user errors handling Maxime Coquelin
2021-01-22 8:10 ` Xia, Chenbo
2021-01-19 21:24 ` [dpdk-dev] [PATCH v2 36/44] net/virtio: move Vhost-user reqs to Vhost-user backend Maxime Coquelin
2021-01-21 8:56 ` Xia, Chenbo
2021-01-25 14:50 ` Maxime Coquelin
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 37/44] net/virtio: make server mode blocking Maxime Coquelin
2021-01-22 8:19 ` Xia, Chenbo [this message]
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 38/44] net/virtio: move protocol features to Vhost-user Maxime Coquelin
2021-01-22 8:20 ` Xia, Chenbo
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 39/44] net/virtio: introduce backend data Maxime Coquelin
2021-01-22 8:26 ` Xia, Chenbo
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 40/44] net/virtio: move Vhost-user specifics to its backend Maxime Coquelin
2021-01-22 8:49 ` Xia, Chenbo
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 41/44] net/virtio: move Vhost-kernel data " Maxime Coquelin
2021-01-22 8:55 ` Xia, Chenbo
2021-01-25 14:59 ` Maxime Coquelin
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 42/44] net/virtio: move Vhost-vDPA " Maxime Coquelin
2021-01-22 9:06 ` Xia, Chenbo
2021-01-25 15:02 ` Maxime Coquelin
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 43/44] net/virtio: improve Vhost-user error logging Maxime Coquelin
2021-01-22 9:11 ` Xia, Chenbo
2021-01-25 15:04 ` Maxime Coquelin
2021-01-26 6:10 ` Xia, Chenbo
2021-01-19 21:25 ` [dpdk-dev] [PATCH v2 44/44] net/virtio: handle Virtio-user setup failure properly Maxime Coquelin
2021-01-22 9:24 ` Xia, Chenbo
2021-01-25 16:16 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4063DB8138784DA5BC0E3D249CA00@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=amorenoz@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).