From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3883A0527; Mon, 9 Nov 2020 13:07:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 331BF2B9D; Mon, 9 Nov 2020 13:07:30 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 34A9E5B3C; Mon, 9 Nov 2020 13:07:26 +0100 (CET) IronPort-SDR: xL+Jx1KFRqoeHHx1kAGfrGpBSEhbdDhDqis3woEPeBf+2CtXI7itJ3p5VtW5ZBzU6QEzYiG26r 3k5J55LIXbiw== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="187737753" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="187737753" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 04:07:24 -0800 IronPort-SDR: VgDhAVUfgktSTyo0VAsM5HO4/tYdqMkNqtkMniaDpzuWcs8Yxmgaf9IOL/sIylmT/JxSK4ab+1 ncHWTqZL9RLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="365021000" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 09 Nov 2020 04:07:22 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 9 Nov 2020 04:07:21 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 9 Nov 2020 04:07:21 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 9 Nov 2020 04:07:21 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 9 Nov 2020 04:07:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DHMU97Ydr03Zuwxig3hR/5IiDygRNLlsBAZI5U2hXdWwEaPMmDutPOcC6MKhHdfFWbBO5wl7Mg2PdS9t+Amvf9vuzvQOe299CfpybjxUlwEglW6IJnA3yYptO+KnUR5iAzOUbEuVT1cjwR/+/bzjiBx7URXSLD31g3vGWkJqrERq0fEBL+kyE2gLZJKLmopff+BfMc2ZrQduel3J29szgs1OIP2SW1Q2j0UpnWGl+Y+KjwhuVfRkcF435vA7eJV8bbb0/8gl4T85FgHyy103lxnD+EwmR+jTes67lWOiiMhH6RNi/0U/WiiJaypUhApmhFYYgnBC5lgq7Fb9nomlYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOW9rU7RFIphJWp15ifprIOZJRVnxh1PprftW5RYX/E=; b=NgIiSz5cYCAIWnkOTqzLA2YhT4eY5MgDD6i0ZMajzG2DKNPgorRjaft5n0c/Kzll90r6ZqgVmrXHOYCzf68m8rYOAtb9+isJSiZXBpYFhryl4lROR02u7+/RgLsuV87Gf64J/Qdus88j9ncMjBp0JTQVrQ2RsEIsVNzQXtqnJ7T417zZIZqYrFjn8A+o9rsaOShGlmaCmbWS1HWx9FLRTMXrd44L7P+8PmOQ0w+Ubsnv9RxV4VbccA9nH+ccx/VexhtJHM8ZX1L03GrVCL/d9aKSucm02igFR8/a2K/tG9TPQctAu3Pepn/dkhMwhPQyQXrH4YKPx6x1z++w3oURnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOW9rU7RFIphJWp15ifprIOZJRVnxh1PprftW5RYX/E=; b=TL2wDi0zSSHYUWU5WlRXWWStoJl1lBbdslXvjNhh7iyOYDbD2ze5F2hgGDYrbKgUVvxzxar7tWwAHiAPD2QdymLuzKwM/h21R/GHQkT07saImU9mK7ETSaOb/NCYbJqjLDDS2kid2kAWf1K0ayU1UQtzMQNTkmDt2uSooHDeyB4= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB3615.namprd11.prod.outlook.com (2603:10b6:208:ec::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 9 Nov 2020 12:07:20 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::1dc7:9f52:91c1:52da]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::1dc7:9f52:91c1:52da%3]) with mapi id 15.20.3541.025; Mon, 9 Nov 2020 12:07:20 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "Ding, Xuan" , "stephen@networkplumber.org" , "thomas@monjalon.net" , "stable@dpdk.org" Thread-Topic: [PATCH v2 2/3] vhost: fix fd leak in dirty logging setup Thread-Index: AQHWtossaBXBfdnMcEqqZ3i2FnWbF6m/s3mQ Date: Mon, 9 Nov 2020 12:07:20 +0000 Message-ID: References: <20201109112600.250779-1-maxime.coquelin@redhat.com> <20201109112600.250779-3-maxime.coquelin@redhat.com> In-Reply-To: <20201109112600.250779-3-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1eb91cce-894a-4b1a-ba32-08d884a80255 x-ms-traffictypediagnostic: MN2PR11MB3615: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DoMSEzmrs5likPdGSYicSRjLuyuvXSYnWCvYGX2kpyY0VQZDd+kNbnbntZJSSWOvLcdbfoauexi9C6RCxCcCC3FgB+w1zapHFktujzF+8OopRoB+SdE/YafZ2istIpyJ2Ins570+ASSYS2OL0wSyjrhuK+4lgSPsVPbmHxpYdYvUuAuBKWF0H6Vw28N6uG16yUiZU9D16m+REbZuVwRY1cBJCMq8F9tYhm8F6Eu2m1+3Lw17yGjggefW9ZMcCGz4hPt/roice1WZU81Q50WH72/toTiD7zCOHKA3DAdTIRLhf3dcKOAgetYUgcDqtohhIbMouS0pDe5FOlCFWHJpP8Wa3l1LaLYq5oS6ibMn7rxWqLQRBgd6VkD+uOmnuytH x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(7696005)(76116006)(66476007)(66556008)(64756008)(66446008)(2906002)(66946007)(5660300002)(26005)(478600001)(316002)(110136005)(9686003)(33656002)(52536014)(8936002)(55016002)(186003)(83380400001)(8676002)(71200400001)(86362001)(6506007)(53546011)(14143004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Slb+q3M48poLUMw67V4UVF4FZynFf0JxsndFXITjrp77p2SZLbJYctsjA04QV8kqueqZCKgPPh03If/cYTrn00AIr6kzBDzN8V+21aNOoE4vMpA6DH5+N/qzlHc5MQ9t/hFdvM09X9MvUpXjTBpuTysR9U5gqqKZXB87/KYYfBbnRbcqMtcKsAz9XWC5gIggasgEx2XdT6cSo/fC+1IsPT430DovKHa+52yBMhnP/JUDsd3JyVZmt3+/Z+pr96hAz4vJBFPsT5PC9uU0O79nG3hiTwO97DHGCpuHjpy6fhNZVcK/C5gDS6bBERNwJhL/fwC/s0OZxtJVFidBWUD2PkzNKgSmxLAhFtUj1tnfxxQ/wrbvwlsQQQYJifOG3DhNLmrUrmuLbQU5VwsYXwK67oANq+XZl3qwIDLZbmJleJ562taI9oiEYvLm1fDaskEXBwt9t1z6P0VcCuko4YYdQ74VwiqFo56bbQulFmnCGRXRT2HTonKnaOVlGZbtmiYHOHTz9xYbD5+nJFHmTCwd6Mkodl6YqeHLrMI5I5OSEAOiE9HSyf3e6cuMx/Vq1ZxNL4HkZQmiyz1pxVmxsnsSTTWv+J8gNwURuAi/5ODt5dLtNwSPSiUhusNs7lt+Z04FJKtqriolJ+6JT5k/wXNGaw== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4063.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1eb91cce-894a-4b1a-ba32-08d884a80255 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2020 12:07:20.0320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iEmcydQF2MAS0nfjypKJflINz9a/xHeid8pRDIXCfSQIMEoC0RKdr03HV0t+fSSLkRmzRjQNu4QSGnpI9w9E0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3615 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/3] vhost: fix fd leak in dirty logging setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" SGkgTWF4aW1lLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1heGlt ZSBDb3F1ZWxpbiA8bWF4aW1lLmNvcXVlbGluQHJlZGhhdC5jb20+DQo+IFNlbnQ6IE1vbmRheSwg Tm92ZW1iZXIgOSwgMjAyMCA3OjI2IFBNDQo+IFRvOiBkZXZAZHBkay5vcmc7IERpbmcsIFh1YW4g PHh1YW4uZGluZ0BpbnRlbC5jb20+Ow0KPiBzdGVwaGVuQG5ldHdvcmtwbHVtYmVyLm9yZzsgdGhv bWFzQG1vbmphbG9uLm5ldDsgc3RhYmxlQGRwZGsub3JnOyBYaWEsDQo+IENoZW5ibyA8Y2hlbmJv LnhpYUBpbnRlbC5jb20+DQo+IENjOiBNYXhpbWUgQ29xdWVsaW4gPG1heGltZS5jb3F1ZWxpbkBy ZWRoYXQuY29tPg0KPiBTdWJqZWN0OiBbUEFUQ0ggdjIgMi8zXSB2aG9zdDogZml4IGZkIGxlYWsg aW4gZGlydHkgbG9nZ2luZyBzZXR1cA0KPiANCj4gVGhpcyBwYXRjaCBmaXhlcyBhIGZpbGUgZGVz Y3JpcHRvciBsZWFrIHdoaWNoIGhhcHBlbnMNCj4gaW4gdGhlIGVycm9yIHBhdGggb2Ygdmhvc3Rf dXNlcl9zZXRfbG9nX2Jhc2UoKS4NCj4gDQo+IEZpeGVzOiA0Nzk2YWQ2M2JhMWYgKCJleGFtcGxl cy92aG9zdDogaW1wb3J0IHVzZXJzcGFjZSB2aG9zdCBhcHBsaWNhdGlvbiIpDQo+IENjOiBzdGFi bGVAZHBkay5vcmcNCj4gDQo+IFJlcG9ydGVkLWJ5OiBYdWFuIERpbmcgPHh1YW4uZGluZ0BpbnRl bC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBDb3F1ZWxpbiA8bWF4aW1lLmNvcXVlbGlu QHJlZGhhdC5jb20+DQo+IC0tLQ0KPiAgbGliL2xpYnJ0ZV92aG9zdC92aG9zdF91c2VyLmMgfCA4 ICsrKysrKy0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2xpYi9saWJydGVfdmhvc3Qvdmhvc3RfdXNlci5jIGIv bGliL2xpYnJ0ZV92aG9zdC92aG9zdF91c2VyLmMNCj4gaW5kZXggNDczZmQ3NzhjYS4uZTRhZDVm NmJhZiAxMDA2NDQNCj4gLS0tIGEvbGliL2xpYnJ0ZV92aG9zdC92aG9zdF91c2VyLmMNCj4gKysr IGIvbGliL2xpYnJ0ZV92aG9zdC92aG9zdF91c2VyLmMNCj4gQEAgLTIwNzYsNyArMjA3Niw3IEBA IHZob3N0X3VzZXJfc2V0X2xvZ19iYXNlKHN0cnVjdCB2aXJ0aW9fbmV0ICoqcGRldiwNCj4gc3Ry dWN0IFZob3N0VXNlck1zZyAqbXNnLA0KPiANCj4gIAlpZiAoZmQgPCAwKSB7DQo+ICAJCVZIT1NU X0xPR19DT05GSUcoRVJSLCAiaW52YWxpZCBsb2cgZmQ6ICVkXG4iLCBmZCk7DQo+IC0JCXJldHVy biBSVEVfVkhPU1RfTVNHX1JFU1VMVF9FUlI7DQo+ICsJCWdvdG8gY2xvc2VfbXNnX2ZkczsNCg0K SSByZW1lbWJlciB3ZSBoYXZlIGFncmVlZCBvbiBzaW1wbHkgcmV0dXJuIGhlcmU/IEFzIEkgbG9v ayBiYWNrIHRvIHYxLCBJIHRoaW5rDQp5b3UgbWF5IG1vZGlmeSB0aGUgd3JvbmcgcGxhY2UuIEJl Y2F1c2UgSSBzZWUgYW5vdGhlciAnZ290byBjbG9zZV9tc2dfZmRzJyBpcw0KZGVsZXRlZCBjb21w YXJlZCB3aXRoIHYxIPCfmIouDQoNCiAJaWYgKG1zZy0+c2l6ZSAhPSBzaXplb2YoVmhvc3RVc2Vy TG9nKSkgew0KIAkJVkhPU1RfTE9HX0NPTkZJRyhFUlIsDQogCQkJImludmFsaWQgbG9nIGJhc2Ug bXNnIHNpemU6ICUiUFJJZDMyIiAhPSAlZFxuIiwNCiAJCQltc2ctPnNpemUsIChpbnQpc2l6ZW9m KFZob3N0VXNlckxvZykpOw0KLQkJcmV0dXJuIFJURV9WSE9TVF9NU0dfUkVTVUxUX0VSUjsNCisJ CWdvdG8gY2xvc2VfbXNnX2ZkczsNCg0KVGhhbmtzIQ0KQ2hlbmJvDQoNCj4gIAl9DQo+IA0KPiAg CWlmIChtc2ctPnNpemUgIT0gc2l6ZW9mKFZob3N0VXNlckxvZykpIHsNCj4gQEAgLTIwOTQsNyAr MjA5NCw3IEBAIHZob3N0X3VzZXJfc2V0X2xvZ19iYXNlKHN0cnVjdCB2aXJ0aW9fbmV0ICoqcGRl diwNCj4gc3RydWN0IFZob3N0VXNlck1zZyAqbXNnLA0KPiAgCQlWSE9TVF9MT0dfQ09ORklHKEVS UiwNCj4gIAkJCSJsb2cgb2Zmc2V0ICUjIlBSSXg2NCIgYW5kIGxvZyBzaXplICUjIlBSSXg2NCIN Cj4gb3ZlcmZsb3dcbiIsDQo+ICAJCQlvZmYsIHNpemUpOw0KPiAtCQlyZXR1cm4gUlRFX1ZIT1NU X01TR19SRVNVTFRfRVJSOw0KPiArCQlnb3RvIGNsb3NlX21zZ19mZHM7DQo+ICAJfQ0KPiANCj4g IAlWSE9TVF9MT0dfQ09ORklHKElORk8sDQo+IEBAIC0yMTMxLDYgKzIxMzEsMTAgQEAgdmhvc3Rf dXNlcl9zZXRfbG9nX2Jhc2Uoc3RydWN0IHZpcnRpb19uZXQgKipwZGV2LA0KPiBzdHJ1Y3QgVmhv c3RVc2VyTXNnICptc2csDQo+ICAJbXNnLT5mZF9udW0gPSAwOw0KPiANCj4gIAlyZXR1cm4gUlRF X1ZIT1NUX01TR19SRVNVTFRfUkVQTFk7DQo+ICsNCj4gK2Nsb3NlX21zZ19mZHM6DQo+ICsJY2xv c2VfbXNnX2Zkcyhtc2cpOw0KPiArCXJldHVybiBSVEVfVkhPU1RfTVNHX1JFU1VMVF9FUlI7DQo+ ICB9DQo+IA0KPiAgc3RhdGljIGludCB2aG9zdF91c2VyX3NldF9sb2dfZmQoc3RydWN0IHZpcnRp b19uZXQgKipwZGV2IF9fcnRlX3VudXNlZCwNCj4gLS0NCj4gMi4yNi4yDQoNCg==