From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBF79A0032; Thu, 1 Sep 2022 10:08:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 941AB40684; Thu, 1 Sep 2022 10:08:41 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 95F7640143 for ; Thu, 1 Sep 2022 00:42:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661985742; x=1693521742; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=mvTy/OcJxQTs1Rg7/Rl7ydOwfHIlNFAxeRZwD7GlkWw=; b=DTaiV4vqQpjbC6urgV5ZQS9koItIpy38IBay13eHYbttjDgs5dXQbYT5 hAXbLhK4PclfNp0NLN1q9EbqD2kTE4Dk/fWy9GDCWSs0oVyO9ASXftNum D7MTEztTEk0oe34VZvL/YfFS33DbHT++tsRDdhugvHPwR9l2OGsUN716b 0dt9at7SZy3EGk9R/R6uBqA1bZNE1djdsBred+tVWIPScp5eab/+3MElC zowsn5kwWwfm+P686XR3z/f/EWrzDz36Xw/+Acl57iVUPK40L2WhYQc0Y 9I9d4iZOVsENkz2gq6BIDjAu6fKVIdQ9UxFgGxDzZGenbUm+WVlZpO+Iw Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="296841766" X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="296841766" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 15:42:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="673557707" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 31 Aug 2022 15:42:21 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 15:42:21 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 15:42:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 31 Aug 2022 15:42:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 31 Aug 2022 15:42:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EkT9d7iSVvzcMmaCcT4aB3TVqAEgBa82cOACqOTa7jo74QWDAHujUp8DOpLlioKozeHU0Q0g67DWfVOLCy/IZgXElGTLCMXnJv5mMBseR2xZGQ3CSO0Hhj3N/6vuJAyskK6vK9ijeXOrhk1ByhasZsA7dzkN2GN9Hz5wl55F1ja1n6h/imdS1FbFZR8TO6ZHx18MXayQU9GYDbf6g7p+2CcG541OdC0KX+l2ifLEdS3CZNb7qWM4q99lFN1xsU4HsMQXUoX+LBHxqKaUytwlbMy4g5gjguHXfYkcDqQFie4JbwdTVyALwbJytUm4LcxWPqKHhFkIk9cAssI7BakDIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sp7C8b/un+f2sjM+DvuuUQHFYiPBCBZpmImlzegf57E=; b=G/eGhwcVyrHhLCkliizfeuVi32JCQep2S8GTAm0CM8bXsnPLpvRJBTVufefDFO6Ayod2UMkzSybu7Fskg4l5ljyqvRsHBL+I8qIs6RABiUH+jiCgyrmwm5TqEI0mbvSP3VcjU3jH2PTlryFUbeFa7elvbUXzdMHsg8Y6zk6uK314ur2da7p3gJItJtmxmouktMstHY3DZC5nu4Qtt+l/ILStJX3ODx6b+ZJhkIEZK2NyeZPWS2m45htY7gajyPmOm8h3MTvYx8tNDiWjsjbHJdloMgFpjnMM2+Y3FrSvSLDQxLj0D6W7s5kwPNtS7VwiTl4ItQMR4VQHHhkG1PTMSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN2PR11MB4206.namprd11.prod.outlook.com (2603:10b6:208:188::10) by SN6PR11MB3086.namprd11.prod.outlook.com (2603:10b6:805:d6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 31 Aug 2022 22:42:18 +0000 Received: from MN2PR11MB4206.namprd11.prod.outlook.com ([fe80::c804:32f1:ff6c:2504]) by MN2PR11MB4206.namprd11.prod.outlook.com ([fe80::c804:32f1:ff6c:2504%5]) with mapi id 15.20.5588.010; Wed, 31 Aug 2022 22:42:18 +0000 From: "Mah, Yock Gen" To: "Zhang, Qi Z" , IOTG DPDK Ref App , "dev@dpdk.org" Subject: RE: [PATCH] IGC: Remove I225_I_PHY_ID checking Thread-Topic: [PATCH] IGC: Remove I225_I_PHY_ID checking Thread-Index: AQHYu42OWaokG1UUC0ae20RnBouWbq3HS9VQgAJNRCA= Date: Wed, 31 Aug 2022 22:42:18 +0000 Message-ID: References: <20220829081436.29945-1-iotg.dpdk.ref.app@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7caaf16a-34f4-4961-0c29-08da8ba20f41 x-ms-traffictypediagnostic: SN6PR11MB3086:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NqCzLFvUUJUK30ev9xlWt1OcoflrQrML8ue3wnnJcvw9v9Sq0AwZ8ICxvXlZWU0nW1IpC99jjTYwpLCV2nEeCPSO8L6DxhtPG6oCl/M11rmz6FVB7m/IeQlenWeClBVFXn9d8n7EP3cYpA8uO/bo/Aykl2IGtaWQdJVyO3QRld1T1ncPQeUFbOttMXrTpVHFnDIwvwIT8D2NoUUhQPmNW86DxHsQWduVd5apEZvMaqZMsGud9j4fokk9bJkKvosOEQystRs2nRBBM0XidWdWhfcTACLkMlZmFeFr9BTz2f43N2J07z07WpA1MRNsebbNyVgYSDkMY1p5X8aLolmlEbkeq7USrH7LKvwZeJcq2hodXt8QCzSktzXOFHssjkBsz0+lxkJgb4xYScPeDyT6NMcZyYuvxXrBGxhK9/yV3qkw5KzgcNpPjNvjTXvwTTURaw2fbnRtoGHvSB6TrBV5tUx83HOpCWnNmkYKAl1F+mujyYtjbFvVF6eBSm000uipuaAkHpUQh8G28/ayKHzjBAcRXAfpzVQPRJMHAI6AJdAiPjHWpyi5Eu3Dm6WXmo0jz92VCps2GrY7WrbdVMUJgqlilG1D8rpnjr/2RsWqGZNPYFFE4DdvtRIXnF+pcUPRo0yNze7mtqbTTnFz9CEmjC0+d0H2PN1q5kuQbU6n994t+srI5hMRAhfuENFLLG1EI8t+Iti3hQvhP0alIVBDmftfrJy23luop5cM5koiLf7IjH1+PZHaq2Ja9TxHIfo0+WGvzLTEzcXylqjYFGH8HA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4206.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(39860400002)(136003)(396003)(376002)(366004)(6506007)(9686003)(38070700005)(33656002)(7696005)(86362001)(82960400001)(122000001)(26005)(55016003)(478600001)(53546011)(186003)(41300700001)(83380400001)(71200400001)(66946007)(316002)(76116006)(64756008)(5660300002)(66556008)(110136005)(66446008)(8676002)(66476007)(8936002)(52536014)(38100700002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NbFNM7gx/zwuTvimmg/lyt+tyxdec/ZBV0to6d6NFiOO5h1xI0Pj8hq8lPC9?= =?us-ascii?Q?UHj2n/0D8MUXjv2ISJhSrLxueCMWgPClhBmk5Bhwi2HJ59igZvnXvenyemnR?= =?us-ascii?Q?pSvSIhFYX12Hls27caw2XU+GyrlVJuOlzPmZ3FWmqQ4e5AHll9OTHJI36mHV?= =?us-ascii?Q?nb9nCMYE5/KknAMm7BAff9qohrpRtSi5u1xCuyHA94HsXMipqkwJsop4/uLD?= =?us-ascii?Q?VLB95COApdLxMlxA8mNTCGTwEeP6boxcCGGR4BnJkDFCgR4eQ/Vbs6dgv0Cv?= =?us-ascii?Q?q765HmQ/VRZ3+44mfg+0hd8Bsr38Mp/bbfDY32XufV21M5TB7Ud9V1xStVYB?= =?us-ascii?Q?myxHSK5TrBTfsWl26srtLJYp/smvleracwRygLj17SEIL9+ZukIiAyajzGCl?= =?us-ascii?Q?pti7+0tw2wcUSts/69dXqkqSXsvzqjgQ5yAjGWPmfjA2HKOh5hc0mqaeHAt2?= =?us-ascii?Q?6Gp5zvSuPjop2ngNEn4VlMZIXHQaD8tXt33l0yU6xMINAyt73DsRgtII42tz?= =?us-ascii?Q?7f9CqG6ABRGeKB3m0/7CHzSEoCC6DPLXTWkCRFJTslqFjNZm7iBAVSsGjEL+?= =?us-ascii?Q?a5WQ4omUnTdNE0stQt70DnbHZd2uiRCo4tKtjiajTAh3NskWyLS3El6m08p2?= =?us-ascii?Q?4kdYOMAWMrMrlnCdaICn4AQtSywP3gDd6cuOsanfFjE9IGQj0nbmFojqs/4T?= =?us-ascii?Q?A94ZKvTPf1QTVKZBIesheMwGNwjNj9HwIc2dfZoK7mS/eGmQXi7rnPTast5B?= =?us-ascii?Q?pyNSeF2w+dgQZ7yytkqx348UBnf9WfyNjDV7BdWwAbe/EAHjIv8PR7MxMY/D?= =?us-ascii?Q?YMKt//HVKLjmeqwrelAnryk6xgA2trO49y5zbwEKLrohKN3wUzTtPxlMJtjE?= =?us-ascii?Q?ffQ4/Cc5ujAX9Bt2So2EZYBdtpzZRAIjVTEppKl0mSYqYeFrH95jjv3n3ols?= =?us-ascii?Q?4JYr4HZfUz4Stadk/82VUSwM3jU+ah19ZIOv7WryjZ6geKQjH+JXC+Fae7ph?= =?us-ascii?Q?ovaSB3YSaqSIxJlgVKoGWFrEQY68owKmEFyC2BapDjfujhvWII8S3LGVEulZ?= =?us-ascii?Q?dbUl2nmq/qnK6KDX7iKaiHBPgcy7gNoWidr3nlcHppzUMtO7YVWCIj5Y4bNE?= =?us-ascii?Q?cOKXUiImxAD03xxFGAzCqYdPp91owHeEG3jZr3VjYYP4l8McsSCKxWV/5r0l?= =?us-ascii?Q?Pmr7cqSYSzJmkxwQilH/pYPfTWA1f9ae8JjqM0MkUzDA1u27y2b814v9VE2C?= =?us-ascii?Q?4nHbi3nFaSrCSEe2uAtrVY8awU/YPcUR9UYa0VNtpeDtCDaR0uLiRrFPfnr7?= =?us-ascii?Q?1t8HRDOb2c97ihNsR0A60Xok5VtDeyHFjWZ1WuOs059ChaEOqEvrl5KZbqr0?= =?us-ascii?Q?eTUQ3/NeOOOKYzYG0U9EUjnlnO4e2EKpYD1E3Lgg2zAsmfjGIrtFeAPVL0ua?= =?us-ascii?Q?nQFL1WSV15Lj6sVdxzUV+4Btn7DrUxD/yDZ0zr7xXfanp/AyDLBVn6zl21vZ?= =?us-ascii?Q?hha6LS0+kGkb+kgnNGPergxalPh1yc1MMUn1GrHAlc+SyYvkqlr2BcW2szHE?= =?us-ascii?Q?9RvYPxFXV0bmGHU//9GGQl9RCRGrDCRIwx+Wj7fJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4206.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7caaf16a-34f4-4961-0c29-08da8ba20f41 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2022 22:42:18.2605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3aAYEUXxVzQCo19GzQWZFZBLU3ahSZpbMrlU05BlITE2B2STUfzGd6t2vc/LHW4jdAVrZ/A5o5bohVnRuEPKqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3086 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Thu, 01 Sep 2022 10:08:40 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Zhang, Qi Z =20 >Sent: Tuesday, 30 August, 2022 7:17 PM >To: IOTG DPDK Ref App ; dev@dpdk.org >Subject: RE: [PATCH] IGC: Remove I225_I_PHY_ID checking > -----Original Message----- > From: iotg.dpdk.ref.app@intel.com > Sent: Monday, August 29, 2022 4:15 PM > To: dev@dpdk.org > Subject: [PATCH] IGC: Remove I225_I_PHY_ID checking >=20 > From: NSWE SWS DPDK Dev >=20 > i225 devices have only one PHY vendor. There is unnecessary to check=20 > _I_PHY_ID during the link establishment and auto-negotiation process,=20 > the checking also caused devices like i225-IT failed. This patch is to=20 > remove the mentioned unnecessary checking. >=20 > Cc: stable@dpdk.org > Signed-off-by: NSWE SWS DPDK Dev >Is this the expected author name? Yes, this is expected author name, the PDL email contain all developers wor= king on the patch for better support and response.=20 > --- > drivers/net/igc/base/igc_api.c | 1 + > drivers/net/igc/base/igc_hw.h | 1 + > drivers/net/igc/base/igc_i225.c | 15 ++-------------=20 > drivers/net/igc/base/igc_phy.c | 6 ++---- > drivers/net/igc/igc_ethdev.c | 1 + > 5 files changed, 7 insertions(+), 17 deletions(-) >=20 > diff --git a/drivers/net/igc/base/igc_api.c=20 > b/drivers/net/igc/base/igc_api.c index 9b791dc082..c9fc9ed4b0 100644 > --- a/drivers/net/igc/base/igc_api.c > +++ b/drivers/net/igc/base/igc_api.c > @@ -886,6 +886,7 @@ s32 igc_set_mac_type(struct igc_hw *hw) > case IGC_DEV_ID_I225_V: > case IGC_DEV_ID_I225_K: > case IGC_DEV_ID_I225_I: > + case IGC_DEV_ID_I225_IT: > case IGC_DEV_ID_I220_V: > case IGC_DEV_ID_I225_BLANK_NVM: > case IGC_DEV_ID_I226_K: > diff --git a/drivers/net/igc/base/igc_hw.h=20 > b/drivers/net/igc/base/igc_hw.h index 707a1883b4..e919a11c02 100644 > --- a/drivers/net/igc/base/igc_hw.h > +++ b/drivers/net/igc/base/igc_hw.h > @@ -164,6 +164,7 @@ struct igc_hw; > #define IGC_DEV_ID_I225_V 0x15F3 > #define IGC_DEV_ID_I225_K 0x3100 > #define IGC_DEV_ID_I225_I 0x15F8 > +#define IGC_DEV_ID_I225_IT 0x0D9F >The patch's commit log claims to remove something, but in code it also add= some new device ID, could you clarify why we need this or it should be in = a separate patch? The checking issue was firstly discovered because of i225-IT not working on= our lab and escalated to DPDK team for support, as informed by DPDK team a= fter the patch sent, that the i225-IT device ID has been patched in DPDK ne= xt release, we'll send out v2 patch soon with only removing redundance chec= king without i225-IT device ID.