From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 740D7A09D9; Wed, 11 Nov 2020 22:06:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 079375913; Wed, 11 Nov 2020 22:06:00 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 978FA5928 for ; Wed, 11 Nov 2020 22:05:57 +0100 (CET) IronPort-SDR: qNDpJ4Ypx0NaJe9axTXH79zcp8GBf9ACsK8l0YC0SWpVZb9uBvR1ALNZCoDIN2baMF49kDz2+p JewDzKYLfTEw== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="231839545" X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="231839545" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 13:04:57 -0800 IronPort-SDR: AqedbJvIR6mD3DLTu+xF3XyXwTJT7fCdXjmgmfuLNv0eax+Oyy3pNqRKXnaupIFGVacTrfpnrC BbZOdT63wizw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="366375811" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga007.jf.intel.com with ESMTP; 11 Nov 2020 13:04:57 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 11 Nov 2020 13:04:56 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 11 Nov 2020 13:04:56 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 11 Nov 2020 13:04:56 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 11 Nov 2020 13:04:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Boki6yoF9iFb64xWTgrqm/nb6j9CP1lqePsZHmBOlI3gNMcGDBcQQivp9cd1tEb7i+MUCOPg7eSv5h9C9ezNgnrNNKfzL8yNUU/C6c1jSx2PvS75Wl1XiSbmjoZm3c2TW1DDvde0zRpYhJKaxzzBmQP4B1CkEX9p8asK/dMGyaRTXIvzXWuBtff1jpI83h/RF66d/lDBg38ljweAr+VU+kxmSbwM7jnCJAGZAUCBsbvNfgcH+ukwVJc1iz/S6bIOJ9ECeEhd2+W0ZRYBiipgb/OgUlcvtjmpeYQuavtf9Hz8RUHOItNS1PG4TURBbhAwS8ohEDgwm5DXOsudv1v5+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DGIRHCTGI6INxdfdPqUcWxeQrkSbA9JOZJ/IGAw2h2o=; b=Js0F035Y9ujIyVyNEDZhyXu+iQJRxFg3Z5NEuj1syA7vCNNNXYHqbiGWWnV+/i5KtqlXJy+4y4S3s7C726350TGGsFxs9eZ42ap0ZzoF+EpwcpgHLBP8YYmwprPd9YG+Vc9oEdQbQrxNkayHyr+7L7D6zeJq1IG6VKv8VdBnTV/J+VS8PgSgG2ZJ8q5Lfmz6TfDRSZvCL4/KLVgxtUAXEJvpIK9ryJaaTEsijkueiKw9JFm4geW/ULPJPzOOUjfRKsykF35j8+WLvgfYicVpFxisSj5XzKpsgQeuY37Fvcm3xVODvGhc6SNuZpp7ZkUmEOrdI8N48u+hIEmu2hdhjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DGIRHCTGI6INxdfdPqUcWxeQrkSbA9JOZJ/IGAw2h2o=; b=HGOv+lJJjEbqmjHcJmWacX9U5yPigKpjXU/X3Ci6pFAUsfGdEqyzkL5RjIwd9CGekeIDSLKSk7Ttuu2wFsHWVd4AcfQ9QlO2m4g1H2C5n/3joVl7JrEbJoIyKdUzdE373Qape6UWNixfHdpLCbMRpXvlKxtnTD/m/zegDPWn4QI= Received: from MN2PR11MB4431.namprd11.prod.outlook.com (2603:10b6:208:18c::15) by BL0PR11MB3091.namprd11.prod.outlook.com (2603:10b6:208:7f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 21:04:55 +0000 Received: from MN2PR11MB4431.namprd11.prod.outlook.com ([fe80::3496:bd70:9865:8c10]) by MN2PR11MB4431.namprd11.prod.outlook.com ([fe80::3496:bd70:9865:8c10%4]) with mapi id 15.20.3541.022; Wed, 11 Nov 2020 21:04:55 +0000 From: "Chen, Mike Ximing" To: "McDaniel, Timothy" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "jerinj@marvell.com" , "thomas@monjalon.net" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create succeeds Thread-Index: AQHWuGkHbPJkYw7QGUuBTMmtFwJpLKnDaSsw Date: Wed, 11 Nov 2020 21:04:55 +0000 Message-ID: References: <1605126422-522-1-git-send-email-timothy.mcdaniel@intel.com> <1605126422-522-3-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1605126422-522-3-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [69.141.167.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37f4f57d-de0d-427c-39ff-08d8868570ab x-ms-traffictypediagnostic: BL0PR11MB3091: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:404; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ITvLCmSJWm4W1G1BMMqt1ZnpZCF1BjBKMf326sKNROmjd1dMKK73VWP41mhnm1VZsM/b8QAuszHeeSXnZqslovzjmxTAToYfr4JERexPTPzOc/xI4EU1Kqn2ZoltUg1aNX+/3eZ5BqFnmj3KEgODgl82nTkdtODtDRNVAsIIl+BXeQUjeMiYLy3IGN6RevBy+zmXTJ4wT/1z3oX0yLiv9l7hozvobVo5pR86IV+P4v7x/mKD0HgtcrlVmtQK1ADZs5d6nuaJrfFwj7CMpgC9puqnTZZyZHXBrKh7dkjE1vQMP+jvoSSdQepAInN3feQa x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4431.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(83380400001)(33656002)(52536014)(2906002)(7696005)(71200400001)(6506007)(26005)(186003)(478600001)(8936002)(86362001)(6636002)(6862004)(66476007)(66556008)(66946007)(4326008)(64756008)(316002)(54906003)(55016002)(9686003)(66446008)(5660300002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 1IrRGNM0AocU9gPUVvQVCKTg3dCnX/x65DgrasqlDJDIc/F0YGtDPpcC31yL5wIEh8IM88xu3Rvk26UHkzgSCcceTWqAEpk6cAUW9+Y+hxPHjsgo4zDV7Gn7OMgZIskXCJ+XD/p6jAUkX6TiOCRv+rWwJjCcTWWQpTEeC/AZ8QJHCoafP7OrV1yLBaa+BgbqW8xAgNembVv7C5VzJNNNK6RDovVZZVRAMKkvFTyIHWxYQuTlSW2pbmoJpkULq91Ru/B9Q1p1UwoXARqdkg89WlU9iKgRz31b5EGRwDZk3ERAJ6GbwZLrjF9AxtK0a8elgwPXkC1adXPZw3wMVV+qL154nr7ofcDqY8bcOuu3zlaKiVzMcc0YyWtxI8sL1chHVKC1pZ40aWloTfQYFzv4l54y+O5YBcK9Tc02249V/rZDrgK7F/EbdmEy/GE80W3UrhKTy/Ub1uhxTuCCOL1DjGOLLpxs38wrDuqFuTIdBRHno0qr9WrHoR2T8tFMhAz+9g7fheQp5fanL6AgudmhiL1Rvxa/4dMyLFN3GRtR7Hr121PbCV4uOe08tFCuT/lhJW5psvVKdYYem3hk/NSs5xMWojZKKLhqcgmgAPR0Ev8A+T2RlFSFu/uMpbnlNdwMZhi7M6of+Z3HtxdeRfQzkQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4431.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37f4f57d-de0d-427c-39ff-08d8868570ab X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 21:04:55.0687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T3QUHUPiZYuRWOh8ZcVR/dSQMLJaaiMiNwvxmP8Hm3jV7XIL70V9D5gU6ZHda+zOL4FUBEo/OXcAmV0GfXk2XXwcaOx9LU16/w5wSGJLafs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3091 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create succeeds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Timothy McDaniel > Sent: Wednesday, November 11, 2020 3:27 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com; thomas@monjalon.net; david.marchand@redhat.com > Subject: [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create > succeeds >=20 > Add missing returns so that the memzone free is not called if port create= is > successful. >=20 > Signed-off-by: Timothy McDaniel > --- > drivers/event/dlb/pf/dlb_pf.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/event/dlb/pf/dlb_pf.c b/drivers/event/dlb/pf/dlb_pf.= c index > cf88c49..3aeef6f 100644 > --- a/drivers/event/dlb/pf/dlb_pf.c > +++ b/drivers/event/dlb/pf/dlb_pf.c > @@ -342,6 +342,7 @@ dlb_pf_ldb_port_create(struct dlb_hw_dev *handle, > *(struct dlb_cmd_response *)cfg->response =3D response; >=20 > DLB_INFO(dev->dlb_device, "Exiting %s() with ret=3D%d\n", __func__, ret= ); > + return 0; >=20 > create_port_err: >=20 > @@ -419,6 +420,7 @@ dlb_pf_dir_port_create(struct dlb_hw_dev *handle, > *(struct dlb_cmd_response *)cfg->response =3D response; >=20 > DLB_INFO(dev->dlb_device, "Exiting %s() with ret=3D%d\n", __func__, ret= ); > + return 0; >=20 > create_port_err: >=20 > -- > 2.6.4 Reviewed-by: Mike Ximing Chen