Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

["Van Haaren, Harry" <harry.van.haaren@intel.com>]

Hey Folks,

> -----Original Message-----
> From: Aaron Conole <aconole@redhat.com>
> Sent: Monday, November 25, 2019 4:59 PM
> To: Amber, Kumar <kumar.amber@intel.com>
> Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Thakur, Sham Singh
> <sham.singh.thakur@intel.com>; David Marchand <dmarchan@redhat.com>
> Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query
> key id
> 
> "Amber, Kumar" <kumar.amber@intel.com> writes:
> 
> > Hi all ,
> >
> > I want to report random untouched unit test cases failed by Jenkins
> > . pls can you guys check why it is unstable ?
> > Every upload shows random test failed .
> >
> > http://mails.dpdk.org/archives/test-report/2019-November/109120.html
> 
> I think the service core code needs the following patch:
> ---
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 79235c03f8..f2efb8c4a5 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -383,7 +383,7 @@ rte_service_may_be_active(uint32_t id)
>  	int32_t lcore_count = rte_service_lcore_list(ids, RTE_MAX_LCORE);
>  	int i;
> 
> -	if (!service_valid(id))
> +	if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>  		return -EINVAL;
> 
>  	for (i = 0; i < lcore_count; i++) {
> @@ -398,7 +398,7 @@ int32_t
>  rte_service_run_iter_on_app_lcore(uint32_t id, uint32_t
> serialize_mt_unsafe)
>  {
>  	/* run service on calling core, using all-ones as the service mask */
> -	if (!service_valid(id))
> +	if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>  		return -EINVAL;
> 
>  	struct core_state *cs = &lcore_states[rte_lcore_id()];
> ---
> 
> Harry?

Apologies - I've been AFK and hence this made no progress in the last weeks.
Thanks Aaron for the suggested patch, I'll review/test now and report back tomorrow.


<snip unrelated patch code>