DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Aaron Conole <aconole@redhat.com>,
	"Amber, Kumar" <kumar.amber@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Wang, Yipeng1" <yipeng1.wang@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Thakur, Sham Singh" <sham.singh.thakur@intel.com>,
	David Marchand <dmarchan@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id
Date: Mon, 25 Nov 2019 17:16:05 +0000	[thread overview]
Message-ID: <MN2PR11MB4447A1FB631A5DF6C1687BBCD74A0@MN2PR11MB4447.namprd11.prod.outlook.com> (raw)
In-Reply-To: <f7ty2w399kn.fsf@dhcp-25.97.bos.redhat.com>

Hey Folks,

> -----Original Message-----
> From: Aaron Conole <aconole@redhat.com>
> Sent: Monday, November 25, 2019 4:59 PM
> To: Amber, Kumar <kumar.amber@intel.com>
> Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Thakur, Sham Singh
> <sham.singh.thakur@intel.com>; David Marchand <dmarchan@redhat.com>
> Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query
> key id
> 
> "Amber, Kumar" <kumar.amber@intel.com> writes:
> 
> > Hi all ,
> >
> > I want to report random untouched unit test cases failed by Jenkins
> > . pls can you guys check why it is unstable ?
> > Every upload shows random test failed .
> >
> > http://mails.dpdk.org/archives/test-report/2019-November/109120.html
> 
> I think the service core code needs the following patch:
> ---
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 79235c03f8..f2efb8c4a5 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -383,7 +383,7 @@ rte_service_may_be_active(uint32_t id)
>  	int32_t lcore_count = rte_service_lcore_list(ids, RTE_MAX_LCORE);
>  	int i;
> 
> -	if (!service_valid(id))
> +	if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>  		return -EINVAL;
> 
>  	for (i = 0; i < lcore_count; i++) {
> @@ -398,7 +398,7 @@ int32_t
>  rte_service_run_iter_on_app_lcore(uint32_t id, uint32_t
> serialize_mt_unsafe)
>  {
>  	/* run service on calling core, using all-ones as the service mask */
> -	if (!service_valid(id))
> +	if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>  		return -EINVAL;
> 
>  	struct core_state *cs = &lcore_states[rte_lcore_id()];
> ---
> 
> Harry?

Apologies - I've been AFK and hence this made no progress in the last weeks.
Thanks Aaron for the suggested patch, I'll review/test now and report back tomorrow.


<snip unrelated patch code>

  reply	other threads:[~2019-11-25 17:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 14:59 [dpdk-dev] [PATCH v2] " Kumar Amber
2019-11-22 18:21 ` [dpdk-dev] [PATCH v3] " Kumar Amber
2019-11-25 11:08   ` Kumar Amber
2019-11-25 15:50     ` Amber, Kumar
2019-11-25 16:01       ` Aaron Conole
2019-11-25 16:58       ` Aaron Conole
2019-11-25 17:16         ` Van Haaren, Harry [this message]
2019-11-25 17:54           ` Thomas Monjalon
2019-11-25 18:10             ` Aaron Conole
2019-11-25 22:53               ` Aaron Conole
2019-11-26 13:19                 ` Van Haaren, Harry
2019-11-26 13:29                   ` Van Haaren, Harry
2019-11-26 13:57                     ` Aaron Conole
2019-11-27 11:37                       ` Van Haaren, Harry
2019-11-26 15:58                   ` Aaron Conole
2019-11-25 19:41     ` Wang, Yipeng1
2019-11-26  2:39   ` [dpdk-dev] [PATCH v4] " Kumar Amber
2019-11-27  1:59     ` Wang, Yipeng1
2020-01-20  0:16       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4447A1FB631A5DF6C1687BBCD74A0@MN2PR11MB4447.namprd11.prod.outlook.com \
    --to=harry.van.haaren@intel.com \
    --cc=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmarchan@redhat.com \
    --cc=ferruh.yigit@intel.com \
    --cc=kumar.amber@intel.com \
    --cc=sham.singh.thakur@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).