From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D7D0A04C2; Mon, 25 Nov 2019 18:16:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64ACC2BCE; Mon, 25 Nov 2019 18:16:10 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 628F92952 for ; Mon, 25 Nov 2019 18:16:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 09:16:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,242,1571727600"; d="scan'208";a="233467913" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 25 Nov 2019 09:16:07 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 09:16:06 -0800 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.54) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 09:16:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwdFEQcH8cjO0pX4SoQ+pFu9ekkaZEQ+3H8EzMMoLyDtw/I1W1lylpv1XwSMamgrKfZa9s0IphyV/WEVbXIwaG5Z89vTGyDX/PVbvKLlsRuy3YVdFIOyzX4esp2PkM7Z/0xYIHUKgt1kJPIIMG2P4yb5Ln0QULvg6QAflo7/r1Hio2z7yFJuZLGvGqclFJ654Hp0Vnraz0TAcRRaJhpbYw0ukCI8qGRyqZrhjMiR3eR7CsRymNqHULoSjoFBoYRF4JY9b+Tuk4A+SZkERD0HkTGp+KpmzyJC1jbOTCOjGnqe65TtjU5LNStWIJebRlf7rQn1v2vqohz5c+ofkvDgQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bV3FAtcVskQpiE81PunyV8lmpU08BSY23mkMUoFjZms=; b=iUsL6eLxwclxLpnuNQQqd3Ql8RpEqiQCXJC2LZ+4wjjamuLIWe7Ey++C4YK719xn+yo8WTWLN3A5nCjVfxo0M6W6xsDUJcqCBewO/yNCoyfI8+cFqwWFuSjiicJirR64zcYjlSJNelfQfOrgqCkZHLdQUoIU02BVKS22V6t0I2wsMFrigKXc4Lu28x1e0PTgrtktpCNMblBAwI8wSs3yGjYM+nDaRhmpxRNoysxARW4rJ4trfGjqvpcRy5P5GmNADIseahYFi8E0u3i8IXriWzbbZNSD3uSJDPwflSpbOsMpbos0gZd6P5XUyqfTPpCCffpQVbuLULqil7txWcqFUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bV3FAtcVskQpiE81PunyV8lmpU08BSY23mkMUoFjZms=; b=SAUTAGrtI2gujKbYbTArFmyNo6myVY/Md5aPNZiZbOft8KWAitNWss4XBn24aaoqatgBk59ACN1KbF5P/CnWpbadOUCMCm25eQb5ixb3TbNwN27g239/1C+k8ft6DXH5KHOBUsdxkJv8JB3m3q8HP5E7QzeR1eg+hJWcmxPyWH4= Received: from MN2PR11MB4447.namprd11.prod.outlook.com (52.135.39.217) by MN2PR11MB3711.namprd11.prod.outlook.com (20.178.254.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.22; Mon, 25 Nov 2019 17:16:05 +0000 Received: from MN2PR11MB4447.namprd11.prod.outlook.com ([fe80::c4e6:5cec:9c4c:e37]) by MN2PR11MB4447.namprd11.prod.outlook.com ([fe80::c4e6:5cec:9c4c:e37%2]) with mapi id 15.20.2474.023; Mon, 25 Nov 2019 17:16:05 +0000 From: "Van Haaren, Harry" To: Aaron Conole , "Amber, Kumar" CC: "dev@dpdk.org" , "Wang, Yipeng1" , "Yigit, Ferruh" , "thomas@monjalon.net" , "Thakur, Sham Singh" , David Marchand Thread-Topic: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id Thread-Index: AQHVoWHEOsXFPYPhH0ut+Ho/0A5KwqebvnSAgABPAACAABNGUoAAAEMw Date: Mon, 25 Nov 2019 17:16:05 +0000 Message-ID: References: <20191122182100.15631-1-kumar.amber@intel.com> <20191125110805.28187-1-kumar.amber@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjRhN2RhNmYtNzQxZS00MTdjLWE1ZTUtZjZkNTE5Njg1Y2Y0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSXlxNlNBRXR0bExieHE3aHFpYXlyMElpVmlEYkw2VUVmU29LdFlsb2RDSWl4ZTd2eWM3VHdOUnNFYnk5b1ExdCJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=harry.van.haaren@intel.com; x-originating-ip: [192.198.151.163] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6233a203-3155-4788-a2a4-08d771cb27cf x-ms-traffictypediagnostic: MN2PR11MB3711: x-ms-exchange-purlcount: 1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0232B30BBC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(376002)(136003)(39860400002)(346002)(189003)(199004)(13464003)(53754006)(14454004)(66476007)(76116006)(99286004)(66556008)(66946007)(66446008)(64756008)(71200400001)(316002)(7736002)(6436002)(71190400001)(305945005)(86362001)(110136005)(478600001)(6116002)(54906003)(52536014)(6636002)(25786009)(3846002)(229853002)(186003)(7696005)(33656002)(6246003)(11346002)(66066001)(4326008)(446003)(5660300002)(102836004)(8936002)(26005)(76176011)(9686003)(55016002)(6306002)(74316002)(8676002)(81156014)(2906002)(81166006)(966005)(6506007)(53546011)(256004); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB3711; H:MN2PR11MB4447.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vfliC3bkIECLFxpxoDd1P/s++D8HoJvmHqrg5f0X7iK+AYlbPMUNEu11oEIOo778hOuOai30rejcFG580XkO3tGlkp8bCREDNiCk0ZdYHjYMfqUAPuhxRmnvVRWyfaqAykv2C4ftLpk4eUGAIWOidF6HmbyVb2AjgWvlU3WaMJQ1BzlYaKCrpEr5JsFCP+Qa44i7d6b9pkHOQIFHWvUK3pIaj8qZ+8S8WPyhEFOAYdFcYd8y9hpe2g2zR780fRsdxnkpSvNquL8x855hgfnbTzaSJgmDN5VYNZg/SIVnGXdKY3+VovDecHRALSO1Eqv0gEhAi7+WV4uqRFgIFMm+wMzV5f5D3kiXFumubKK1w8iwytwssS+6jYSJfLtkk37N3t+AQzrMj+gQs2fK9M/wzdiUO+yuvGYzFKckDiNQ0DnOdYJ4d/+dflIpXuN3bve7cDICEso1f3F9IqrU+39LO9mruZQ2Q3SPujVOj4AKF4g= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6233a203-3155-4788-a2a4-08d771cb27cf X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2019 17:16:05.4584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AqXtMi1P/kCPd1B70kB7LSs5/hEb44/11bHE7yyBfAdtwS3JBmlcxlmPnW7ZU5Ot8nj7IHWIzN6owBNo7e8S8HEq2MujX/6GWTwhKfZ+7nQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3711 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hey Folks, > -----Original Message----- > From: Aaron Conole > Sent: Monday, November 25, 2019 4:59 PM > To: Amber, Kumar > Cc: dev@dpdk.org; Wang, Yipeng1 ; Yigit, Ferruh > ; thomas@monjalon.net; Van Haaren, Harry > ; Thakur, Sham Singh > ; David Marchand > Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query > key id >=20 > "Amber, Kumar" writes: >=20 > > Hi all , > > > > I want to report random untouched unit test cases failed by Jenkins > > . pls can you guys check why it is unstable ? > > Every upload shows random test failed . > > > > http://mails.dpdk.org/archives/test-report/2019-November/109120.html >=20 > I think the service core code needs the following patch: > --- > diff --git a/lib/librte_eal/common/rte_service.c > b/lib/librte_eal/common/rte_service.c > index 79235c03f8..f2efb8c4a5 100644 > --- a/lib/librte_eal/common/rte_service.c > +++ b/lib/librte_eal/common/rte_service.c > @@ -383,7 +383,7 @@ rte_service_may_be_active(uint32_t id) > int32_t lcore_count =3D rte_service_lcore_list(ids, RTE_MAX_LCORE); > int i; >=20 > - if (!service_valid(id)) > + if (id >=3D RTE_SERVICE_NUM_MAX || !service_valid(id)) > return -EINVAL; >=20 > for (i =3D 0; i < lcore_count; i++) { > @@ -398,7 +398,7 @@ int32_t > rte_service_run_iter_on_app_lcore(uint32_t id, uint32_t > serialize_mt_unsafe) > { > /* run service on calling core, using all-ones as the service mask */ > - if (!service_valid(id)) > + if (id >=3D RTE_SERVICE_NUM_MAX || !service_valid(id)) > return -EINVAL; >=20 > struct core_state *cs =3D &lcore_states[rte_lcore_id()]; > --- >=20 > Harry? Apologies - I've been AFK and hence this made no progress in the last weeks= . Thanks Aaron for the suggested patch, I'll review/test now and report back = tomorrow.