From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5C7BA04DD; Tue, 26 Nov 2019 14:29:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADBFA4C99; Tue, 26 Nov 2019 14:29:42 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 15B204C90 for ; Tue, 26 Nov 2019 14:29:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 05:29:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,245,1571727600"; d="scan'208";a="408661609" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2019 05:29:40 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 26 Nov 2019 05:29:39 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 26 Nov 2019 05:29:39 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 26 Nov 2019 05:29:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXp0Wm/aFw2x1fIWbMWU0UN+KtoTO3FE+GResDdsPYQ1B8xldSvCIBlpRXGf0drFEXDaGCmtGU1lpR8qKSmFlm70FxQ+yG/Q4dQNxG6az39gKsCwfU1+VwvMk9e8l8zie/3OdG0uf8CriGzQYMxAfjlHQBv1soSi2tDpwB4gi5Hfzu9YRabnM1x+RHcjYZs2giR11bIocULtjPE7Aaq9s1hrMD0kgy2q2XYXqqrnPQfDHMrZppkZJswvxLAEqi3aPYQtMVO8mqDjcm2ikiGBdKh2zXPyf39QcxlSxNVr3cLVWpVt0IsymPRgKyWAVD6E6HSn/DyLPS1hMn9bRKdS7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2tNkADmRcPcHyzciriRZfYHzVxK/j+4GTmQcKWWHwY=; b=fvqvlBKCL/saIJvz1TSUtSOZfS6e7UFVyqXkYVFuHDbaAr4kNO4NDwsa7sToSU/dGrBQhdOaaKGVsqCJG00SJdtL7W5T82N61BG5614316CwV6s9v0RmX4EeyP6MhUlTD+QGVwKpdSWpTLpdUqLuKhQVAt63zUH2EbH4kmhxpCx2ekIQ6v4jbSOnhqou9yxQWwDFzHbAQIkRZ2Z11qvLaScue7+FqHnuZdCPk70B32i2C8e1ttxm+iZ4CtPH78QXI/JZeELabkCMSC4gefgho942ynAiCXNVcTBW5VfyHiA5duzoQAGDKXAo7rUwnn2M+GQrHoQkoQRRR4nb+iV/kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2tNkADmRcPcHyzciriRZfYHzVxK/j+4GTmQcKWWHwY=; b=KGGZPnmMBoV5sSIIu0khkBwSVqUM0DC9LBGli3e3nePVaXCbonWlqiMV4v2K7gIyOXta/blkcc/kzAFDsC9OxrqKlw4z2aqGsFFakihOqMpIBNqQ4tKczMyS1AI6e6nBYzpDHrGcqWvkdewIHcZmaRZVRGROg2maT5B1vkBnV6M= Received: from MN2PR11MB4447.namprd11.prod.outlook.com (52.135.39.217) by MN2PR11MB4446.namprd11.prod.outlook.com (52.135.36.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Tue, 26 Nov 2019 13:29:38 +0000 Received: from MN2PR11MB4447.namprd11.prod.outlook.com ([fe80::c4e6:5cec:9c4c:e37]) by MN2PR11MB4447.namprd11.prod.outlook.com ([fe80::c4e6:5cec:9c4c:e37%2]) with mapi id 15.20.2474.023; Tue, 26 Nov 2019 13:29:37 +0000 From: "Van Haaren, Harry" To: Aaron Conole , Thomas Monjalon CC: "Amber, Kumar" , "dev@dpdk.org" , "Wang, Yipeng1" , "Yigit, Ferruh" , "Thakur, Sham Singh" , David Marchand Thread-Topic: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id Thread-Index: AQHVoWHEOsXFPYPhH0ut+Ho/0A5KwqebvnSAgABPAACAABNGUoAAAEMwgAAO4wCAAATYEYAATxO8gADv7OCAAAP2oA== Date: Tue, 26 Nov 2019 13:29:37 +0000 Message-ID: References: <20191122182100.15631-1-kumar.amber@intel.com> <2900799.QLPOietlla@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWQyNTA1NWItZjA4Ny00ZWYwLWExZGMtMzA4MTY4Zjc0Y2VhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieDNvZFFObU04ZjE3MnRSUHlDTEtKTnRHbytcL2praUMxS3picFVmcU5MZ1VVc2RiWGxnckpmdElcL296amxLdFFCIn0= dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=harry.van.haaren@intel.com; x-originating-ip: [192.198.151.163] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37d0a4ca-7205-4780-3ac8-08d77274af5b x-ms-traffictypediagnostic: MN2PR11MB4446: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0233768B38 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(396003)(346002)(39860400002)(136003)(13464003)(189003)(199004)(11346002)(446003)(7696005)(6246003)(6506007)(4326008)(256004)(76176011)(53546011)(110136005)(316002)(66946007)(99286004)(66446008)(64756008)(66556008)(25786009)(9686003)(76116006)(54906003)(66476007)(74316002)(52536014)(6116002)(478600001)(229853002)(3846002)(66066001)(55016002)(305945005)(5660300002)(86362001)(71190400001)(71200400001)(6436002)(14454004)(26005)(102836004)(81156014)(186003)(81166006)(8676002)(33656002)(8936002)(7736002)(2906002)(2940100002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB4446; H:MN2PR11MB4447.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JgxUiSpHA9aQmLdGX404aUS7B/8cZIYk2lAgJpittjedo6AnLftYXWYCAbvw0cQjHfF+5XNs4sn5KeVXxgvZ2B8Be4bozdbF6Mkgod2oTsBibtWVTls7NAckV/FbImB5GJ0dlxGlBghvt5/UqzFLEbruoe4GmNG2ZP0KAF8Agm/r3pWeWhsTSL7l8kRGpHDPPmfsZKTKcauuGdSGeeD0VPtwzPYx+iEPW3EdFlbwN3lPoH7YNZLqGik9SDrSmfV7rRjH9+1kGvHvJqrRnVrCVaTyuNv50RcoAS4da7RRSfg5I6uZKsFyLPJ3Nm9rH04TorrFI0E5saFg+98hoYGvoVrpf3glZPk7Nsrv9ip1vYiz+G1qeDMOpQRZfFghqjBYFYr4w6o+RzTCVfM3DLSavmYhOWv44bBAUaVgL6mz5rdNEX5hPNoXDDrWdpKzxd4S Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 37d0a4ca-7205-4780-3ac8-08d77274af5b X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2019 13:29:37.8699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H/sO46Td31YNOV2pHPLUIlwOXPH1VZPhf7eEDdVcbBRFX17JtKTrntVOgMTCDvqhSvOQcDgEIWgDYt9iuG1hdwmXU9Cird8xwl3vg6VWDRE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4446 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Van Haaren, Harry > Sent: Tuesday, November 26, 2019 1:19 PM > To: Aaron Conole ; Thomas Monjalon > > EAL: Test assert service_lcore_en_dis_able line 487 failed: Ex-service > core > > function call had no effect. > > > > So I'll spend some time in this area, it seems. >=20 >=20 > The below diff makes it 100% reproducible here, failing every time. >=20 > It seems like the main thread is returning, before the service thread has > returned. >=20 > The rte_eal_mp_wait_lcore() call seems to not wait on the service-core, > which allows > the main thread to read the "service_remote_launch_flag" value as 0 (befo= re > the service-thread writes it to 1). >=20 > Adding the delay between the service launch and service write being > performed makes this issue much much more likely to occur - so the above > description I have confidence in. >=20 > What I'm not clear on (yet) is why the eal_mp_wait_lcore() isn't waiting.= .. >=20 > -H >=20 >=20 > diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.= c > index 9fe38f5e0..846ad00d1 100644 > --- a/app/test/test_service_cores.c > +++ b/app/test/test_service_cores.c > @@ -445,6 +445,7 @@ static int > service_remote_launch_func(void *arg) > { > RTE_SET_USED(arg); > + rte_delay_ms(100); > service_remote_launch_flag =3D 1; > return 0; > } Diff below seems to fix the problem here; Aaron would you test the below fi= x in your setup for a while too? I have a loop running here attempting to reproduce - but before 100% failur= es and so far 100% passes with the added wait_lcore() call. diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c index 9fe38f5e0..62ffedb19 100644 --- a/app/test/test_service_cores.c +++ b/app/test/test_service_cores.c @@ -445,6 +445,7 @@ static int service_remote_launch_func(void *arg) { RTE_SET_USED(arg); + rte_delay_ms(100); service_remote_launch_flag =3D 1; return 0; } @@ -483,6 +484,7 @@ service_lcore_en_dis_able(void) int ret =3D rte_eal_remote_launch(service_remote_launch_func, NULL, slcore_id); TEST_ASSERT_EQUAL(0, ret, "Ex-service core remote launch failed."); + rte_eal_wait_lcore(slcore_id); rte_eal_mp_wait_lcore(); TEST_ASSERT_EQUAL(1, service_remote_launch_flag, "Ex-service core function call had no effect.");