From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DF98A034F; Mon, 22 Mar 2021 10:05:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09291140E13; Mon, 22 Mar 2021 10:05:24 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id 2A99F4003D; Mon, 22 Mar 2021 10:05:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZNR6uwE5tz1LhbUnv/e7HAAjtKjN8mpmarzWuXlN/mQwFtR9zCNAAR7wClktO1ozIjUgqYAfy3T9P4IGJnI6O8P8bxWGoRlOpNl+lsrdHYXErSiXA01CZ/UsaXYyqNQFZb1y8jACk+aOuVwflNKTKK/1AghHSqcvGACu7KW9yhcCmEzz+ZS7Y7mPlPPaNRBNKTPv1sAW5UbNfv5E/tjcqompPav2bTpJiZVAlKFln1is4Syo17HmE+dXHuTxKBJ/FJAm1AIRapxOWEfXUHghfBLYySABUu9EKOdNqx3wpxOh1M9KEI76xjPncK2fn6G+tqnrTCaWaZcc6g8gYhpLcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sKjNg/E3WzwcLX0mpup0b++hCTWYEd6hDs7GLw8yj0Q=; b=X53YbhaVS3zfzQZHihHMEQrm505q0xuJitSgXtigM+Xa5Tpq1RIXk0ZkTqNDGhSRiC4amxkGPOgPkU8By9xy4QhaGXFt0h0SVNapHURawdmHfuKi0T8WLFDZVm3MC0sUuXCTxujjpjlF+4ncNutmuzsuhAfqQvXytl1aomgCDxNmccR7cDUs6M6uPeE+rz0uDDcFjE0+/46t+Sd38p18GCICXh8SWBmyWj1wdA+RplXuXVYm5FoWxR2ImdbGadce5Dvbbv1r7rVdnFMSvpZLhA1EtOdz87ZaCtTF2uaB85im2rAkmTOil06FfGV7+o1/cc4Rwh4FdvSd7GMmeJl0ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sKjNg/E3WzwcLX0mpup0b++hCTWYEd6hDs7GLw8yj0Q=; b=Qq9QbmoB7FGh+v9eVMDCv99Q263MBHC6p9g6T6McGGB5BReYbyR/eT80OIf/AcYu0whbw1yan46Va7WnieDqeu2ADf3W63wAvdfIPq11yijqy4DK6VXCwHtkb7VZRk7toKi3WrmaUT9lzj0+KWsmZbYxu0MZtMEKU/2llge0MQZP7xBSD6ks0eZUGPJAEQ9K/cRZiuSbkJo5ky74UIabsBs228dYihWipWmi5ysvF0VOmt8MPtvItayWxj7xqAEeqRFDgOICu40xRbSKNSCDCeUNJVG8kCm1CKeBZghyv7LNSfRMhqWcoltxWRqiEByGknu4ZeUTM8/11hsSm4Rxlw== Received: from MN2PR12MB2909.namprd12.prod.outlook.com (2603:10b6:208:103::13) by MN2PR12MB3423.namprd12.prod.outlook.com (2603:10b6:208:cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 09:05:18 +0000 Received: from MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7cbc:e499:e936:7408]) by MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7cbc:e499:e936:7408%7]) with mapi id 15.20.3955.025; Mon, 22 Mar 2021 09:05:18 +0000 From: Bing Zhao To: Jens Freimann , NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "stable@dpdk.org" , Ajit Khaparde , Bruce Richardson , Andrew Rybchenko , Xiaoyun Li , Ori Kam , Bernard Iremonger , Kevin Traynor , Stephen Hemminger , Maciej Czekaj , Pablo de Lara Thread-Topic: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text Thread-Index: AQHXHqIMaWkHp9CrPUyzlAtkmQFY1aqPrRuAgAAKMPA= Date: Mon, 22 Mar 2021 09:05:18 +0000 Message-ID: References: <20210309233116.1934666-1-thomas@monjalon.net> <20210321223116.1340974-1-thomas@monjalon.net> <20210321223116.1340974-12-thomas@monjalon.net> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [154.18.175.99] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eca9ce09-8b04-485a-eb86-08d8ed119d8b x-ms-traffictypediagnostic: MN2PR12MB3423: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CUL0hyheLwKj9nR/cEk/anUPvKQJdW3BefkSd1DysM8HgWtXBNrrXp146wVT6M6HlgieJg9ZE5iLfcUyMYhql3G8POafnqt++XA3tPn3iyzaWSG30BssCAVzDoyANMvNUZU0sFCAtvail71UzwDc2D+clpnmBez6hJn4zF38+DDeXyEWHqzNyxU+Npcujq2vqWvBgYRALp4B4HhX1omj2xS3KIyfPA6wEXI/wWsEyiFvr3ScBGd0ef6PEz/PEKbM6BpJPqXjMNJW3M6Q5HvYltdIqesxNlMQD00ZV1o1lKjoY/VgKwncZ6R5Xq998qEg9zR3eOHVl7l6bJgHr+wiLVm9zvsDG9vuE0w0otPC3VxXUPUCRxNzh8yEXI0NT0hCl7pii7HZWJjdF980XmRrIsrsnqG8BAKc286kqMs81/C2rOUfMEM4+1W5sJpab0iIqXLPWGt8Nj3rPXiUNbRdO4efMmF/HmI7Qcm3DvaWwSQtph+UQop9hu9JFZ0ErjYu0L8K8b8Nv1KhTHGajHDkuCyiXRYsVJC4jw1WjJTTrMhUrjkiiwkpzVBnAyIiBhDK31J6mH/9Mkb8Ai3gX1gpiYuz9jic0CQUDalsXgauCjqnv+WOVY0vCTw8GanEIqM4Z7y0tjdZZTYR9QtXssKF7c/osKyMS/V529YSOBniKqc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB2909.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(39860400002)(346002)(366004)(136003)(9686003)(54906003)(38100700001)(110136005)(8936002)(5660300002)(83380400001)(55016002)(71200400001)(7416002)(7696005)(186003)(8676002)(316002)(6506007)(66946007)(66476007)(26005)(66446008)(64756008)(66556008)(2906002)(86362001)(53546011)(76116006)(4326008)(478600001)(52536014)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?oTRfR41ncPYuPqT952wmfnyS2dXcocf5HvV2W9LVADaROU3hQOJGgQvnO3/t?= =?us-ascii?Q?+c+pEWvksyVCm3WxnZzHRo//LY3HVSfVbc0eqYdd2WmukOLX1Vg6I4Esl62r?= =?us-ascii?Q?KP1SOUulNowJV2swY0kCzlj7NvDCkKeMYsRXkpQUePf21UPpbk8geGOLHcmz?= =?us-ascii?Q?wLkRe8jgpBFDGWXj4yTFcoyCGyeT+GFMXj73JkR6y45egpMKUXoVed/fUytt?= =?us-ascii?Q?Jm0HwbZEgzfhLwTLQiHYqR2geGMkQ7JhSzdK29Zr9C51VFXOSXvhybvVJuk7?= =?us-ascii?Q?nrWQxmaw6l4JY2Grq0QcyCBStIe6c0/LkD2NH1FEJKFF6vuBpbRVUrUgfzfh?= =?us-ascii?Q?+q6G7dF4hxPsTOjuy5d/uvzfSE0QBm0W7u5n/dH7y2JOSFqZBNqcGC0kvUSl?= =?us-ascii?Q?wOaZQkjRo1YK8PFSrns7brMg9NdCXn55m491U+GjfhR7NYAtHkq1g5NZ6/PC?= =?us-ascii?Q?vHJIHhrw/XiPFvfsuEXrDNd7prBCHDl/dblQSoz8adq+LYN9f1kYIgFX9qI4?= =?us-ascii?Q?oj25SNgI0AG47MTGwJNmYkBrGjUIyX5HzmbQOB/DRMSecn5ARRtq0158R/eA?= =?us-ascii?Q?KRHZf2TpKKtzmkzGtqpb8VWuQ9pvZYvbkuCoMmEyQdtu8CxGtCOEUIeuopF2?= =?us-ascii?Q?x2GzyQlwo8o1ESf51ieWcWhYlCkwvI+7rAdXBumrzvMhXlUGdc54hVs45Q98?= =?us-ascii?Q?wSzKsVFuHU7T3LwwHEVj9WRzapONsi/b0zguvQKkBsMSgLl1Ce1U9lk2XtgA?= =?us-ascii?Q?d4XOkRMCLdXc3+nXJpo6ZczTARwhZB9YY9Dg0JIwcHHGgniL06n0Q0zqLN7u?= =?us-ascii?Q?AgNRo8tDycsJdVsSIKw7fp+e5lC6RXa11HHQyy5VYKQwGZdcnJDl/H7D0Rlv?= =?us-ascii?Q?ud94Q77qzVD/4xR60zYM4betO3jA2uHihK8ZGw9RPHFwfREcKlBCHrTQbdyv?= =?us-ascii?Q?dN5xYmneiKLG9C2PLEsRgMZfvhFAm/blesG+CF0HR+8cVZNs8n/Bj/mjO0q6?= =?us-ascii?Q?HZ54uOvf1CQLQbBBUNYE6luqp8p+49c0CIuZOFcw/rsM2HQCzIeDmz+sQQMF?= =?us-ascii?Q?oeI+AaQ2/h10XA02I1cUQ5JS1+tx4BY9whsMpJSQGOhoTWc57ZXxH3yq/0o7?= =?us-ascii?Q?qq13TeEclmrUd4HBIKU/dx91scY3Px1Hwrrd+lLVsErS8amJvCiaS65w6CJ/?= =?us-ascii?Q?VFJXF1MDQ45sQRz9gGDNTt926tKUuByP7NmUcsVcdxgRDCj3NwqqyS79tTp6?= =?us-ascii?Q?LZJFWmP2PJNhD74CSUvI42Mo6P0xqRxFVRAEqajpKVKn2Rga/1d90PDCSz7X?= =?us-ascii?Q?XItB1/XasTdE62uGTtKTmlrg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2909.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eca9ce09-8b04-485a-eb86-08d8ed119d8b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2021 09:05:18.4705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CesCY3o5rLLrJwcOGfcYB0pzGcHfqPizBGcaHF7m5M5jOgHe7C+qMX9lGtc2VILKb0R2Z9tL7IIrthujieNvGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3423 Subject: Re: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Jens Freimann > Sent: Monday, March 22, 2021 4:27 PM > To: NBU-Contact-Thomas Monjalon > Cc: dev@dpdk.org; david.marchand@redhat.com; stable@dpdk.org; Ajit > Khaparde ; Bruce Richardson > ; Andrew Rybchenko > ; Xiaoyun Li ; > Ori Kam ; Bing Zhao ; Bernard > Iremonger ; Kevin Traynor > ; Stephen Hemminger > ; Maciej Czekaj > ; Pablo de Lara > > Subject: Re: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Sun, Mar 21, 2021 at 11:31:15PM +0100, Thomas Monjalon wrote: > >The options help text was including an incomplete and redundant > summary > >of the options before explaining each. The summary is dropped. > > > >The details of the option --hairpin-mode had an extra space, > breaking > >the alignment with the next line. > > > >There were some mismatches between options in the usage text > > sed -rn 's/.*\(" *--([a-z-]*)[=3D: ].*/\1/p' > >app/test-pmd/parameters.c and the options declared in lgopts array > > sed -rn 's/.*\{.*"(.*)",.*,.*,.*},.*/\1/p' > >app/test-pmd/parameters.c The misses were: > > --no-numa > > --enable-scatter > > --tx-ip > > --tx-udp > > --noisy-lkup-num-reads-writes > >The option --ports was not implemented. > > > >Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup") > >Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding > >mode") > >Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP > >parameters") > >Fixes: 0499793854f5 ("app/testpmd: add scatter enabling option") > >Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default") > >Fixes: af75078fece3 ("first public release") > >Cc: stable@dpdk.org > > > >Signed-off-by: Thomas Monjalon > >Acked-by: Ajit Khaparde > >Acked-by: Bruce Richardson > >Acked-by: Andrew Rybchenko > >--- > > app/test-pmd/parameters.c | 35 ++++++++--------------------------- > > 1 file changed, 8 insertions(+), 27 deletions(-) > > >=20 > Thank you Thomas! >=20 > Reviewed-by: Jens Freimann >=20 > regards, > Jens Reviewed-by: Bing Zhao Thanks a lot for the help.