From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DBC7A0546; Tue, 6 Apr 2021 13:02:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0038140F35; Tue, 6 Apr 2021 13:02:43 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by mails.dpdk.org (Postfix) with ESMTP id D1FD14067C for ; Tue, 6 Apr 2021 13:02:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4Qa9hJYCvv32KWccADZo4CQTeoXfqfdu2XUhdoCFCdSbOc8tMmhRTaGJTDSqcrTnSKEAcc/dq6/BB96y0YHoSJV6J+2DlqfdIpKjNMCEXiwR/lxB8BgB852fvYQFGBN3WTg+ljj10qqnK+Jd//+abkwS+01UloJPyRhl+JtX0KTl0KRMZPCxadUZLmU7WnC4zG+YEWeXOjJsPCq0lEyHIzWbvwFB//eH2iHNO544QYqic0OwxVi1dm/OLhwiok2k8R9KqaKE3XOgc7MQRSXHqeZxJh+1I+qpGcGQGrAyzKLWlGBtDHZgl9zui55R4zQ8fW4fUsg4WzuYSh7e1XNXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M2abieF1nxJH+oUyCxsKZ09XtpRb893ce6D59qU8Zh8=; b=iIbE/7z8x96IExOIu8nsu8P4NYzoiZZHgc6whM1xYEqiwolKATdcZlBi7pSddgsUz2U/BuxVj4aXi13zRvyncXpJ6S3aedZs1rqtvqsPF0q2x5Omyvr4VTXFJEu5aUNwhozkxMfqG3oBvbEDw1326K3aMqY2BrKE0n7zDL42C3p0R0ouJUFz9BfglqOjcfj8r72vcjuTuPwqmJvcK0tvXJBB5sYYidvY5R5a9iiLMOJbMFRRKOQi41rk84yxyD0gaQ8Xkg7asiQicykdZHOy1RotMl8yZqKq3Y5ALzTS9cW7ZiB3RyPe9uPSGr8IKVnb2UKKe/y/AEmylcBYc59KKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M2abieF1nxJH+oUyCxsKZ09XtpRb893ce6D59qU8Zh8=; b=UeoAP7TJnGdwrCPRElOYd/wnBcMeXEK3uM2U1asgFnwSRUaqhmoblBK0+e8tUl0HFSE18OJx0stfVBqTaDj5EfsmHIvDvA6fgQx3GAH90Zph4xi7hh4XZ82tDXUIIbPqc6RqRevE/eE44TH5vbtUbnjM/058ZBE0arGM8ZS6f8XBAqdAB24DkEosEd3WiYdvt1xvbVQtXRkllKsM7j55Fr1c6sb04xC3bvHDAnC4/PDU4YDeY53nqs+yz3tqWXac/b+COIJiHpsk0AoocAcv8QfVFUhZGMTtxdxjd7/R9KZTMJ+N9Sk9DxhUQHe1VnP/tRn2Fw3uGmFIXyveWx2wtQ== Received: from MN2PR12MB2909.namprd12.prod.outlook.com (2603:10b6:208:103::13) by MN2PR12MB3263.namprd12.prod.outlook.com (2603:10b6:208:ab::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 6 Apr 2021 11:02:41 +0000 Received: from MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7cbc:e499:e936:7408]) by MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7cbc:e499:e936:7408%7]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 11:02:40 +0000 From: Bing Zhao To: NBU-Contact-Thomas Monjalon CC: Andrew Rybchenko , Ori Kam , "ferruh.yigit@intel.com" , "dev@dpdk.org" Thread-Topic: [RFC] ethdev: introduce action context APIs Thread-Index: AQHXGweOxhV9biVSf0uN0t84s4bJAqqQIHcAgBcxnFCAAAvIAIAAEfyg Date: Tue, 6 Apr 2021 11:02:40 +0000 Message-ID: References: <1615967952-228321-1-git-send-email-bingz@nvidia.com> <27c5c98f-b29c-d8a6-d3f3-05fcd41d5a8a@oktetlabs.ru> <3094400.VKgfFvgXnU@thomas> In-Reply-To: <3094400.VKgfFvgXnU@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [103.150.130.69] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 74617d69-5b1d-4f18-c08e-08d8f8eb7f14 x-ms-traffictypediagnostic: MN2PR12MB3263: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0ffOM4sqxJuh5P1oF5ti7no1qBpYgm/aB70XNBZqFz8MPisOXEFA9lyunVPz61ng8MITAAxDhyG5pQV83YWtd/QYwsBkU3eHK+Ar8ZfZl0/DjEaiixJOwOS/7mVCeMqNmwS8Qd6+HyVurg01dJKvLBUyn501UmnH7zk6UhZgtiSE/x/A5/VFM5cKPbY6fsAZ/AovmY6sauNTZOgoBnFvvASKlAj4UyyELchtB8dwu0O7+1pmV4QmD9Dt/0Lys7D1z7mNQiz29V53LVhImAUNxgMOpvSXzT3aNH+8P4nKt6Y3KYiIX0kA2/7W5CAht8N+hx5gIKh3ag07nLJ+LoQ/0p7VDBjURs7YeLGEyrhMKa9dVyyb/rm9CBek5P0BxyVbniLIZRb/aWU1uuzi851V0esLcOtLH4LXG0dsuBKdi0Q+t/lVHhg08SD+Klhf5mvSJ4xbs0fenY6Vc5STTCh6e7VlOutN59j6NW83ygSB9lt2KWxRoD7BWg7D/O5odM7vETFjH12mO7lGLsbbk0zSNL9NUrgGW2HetQsjy8J7/8k/OE5X8+rWM/DVIexUM8dbEiJcEVXSAMVOpwY5Uxb3SKMZzJ4A+UCFOUaxRAs74Fs9CPcJbQZUrKhhVUnDOorlSMdcSiXHpdZgwhjBvIensxKl9lXU28AMhBwXxfKDzNKwqTJOm7luJymjxfcPBlRqi2dLqDUjPk6Cl7tyTL4EinkrzPikFapCroxexDBwaxY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB2909.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(66556008)(6916009)(966005)(54906003)(186003)(66476007)(6506007)(66946007)(478600001)(55016002)(5660300002)(71200400001)(66446008)(8676002)(26005)(52536014)(4326008)(64756008)(45080400002)(2906002)(38100700001)(316002)(33656002)(83380400001)(53546011)(7696005)(9686003)(86362001)(76116006)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ITAgo9e5a2mfZhjsR6csY3Rl0AZY/55Nn0mPqrCcv0UQBO+9oiJk+3/OGoUr?= =?us-ascii?Q?Dv6mDQKN3lcG1rEqhDISSgkyg0wAWl/SAscoT32b1PV/bK7nM8A/n6g3jBnw?= =?us-ascii?Q?Rl7zIGsMB470o0H+xFTpTfK4vJsk/RChQIuxuxkInTUypCklXFOkiCXFHC5q?= =?us-ascii?Q?Gi+GRi2h19jtwvJ5u6Eo9WCI/e8vuJA58JMi9OtpWrPTQOGhIck/wKrKwapt?= =?us-ascii?Q?f3nB4ds6kjbTjdDeBnWO1GMS+VFfajjMNL+bZaVL1jsUndA1vA8EuOxTJnEx?= =?us-ascii?Q?vyBD8C7/na4Ornb9kTHRKoKFihW8VrUY/Roxy3yfQ2pj6J6heuccUWiBkTr/?= =?us-ascii?Q?zrqTpFgRckgx9K1nsg0t6PL5rDYPEHw8v+hPmzOzCkj1VLER+N63DCBMEatb?= =?us-ascii?Q?VCHVA7klL+woe7WLEJjjxPN3D76KYTYeJepcEZA7BpV1vnCJJaCLQtaffLlW?= =?us-ascii?Q?8LQUtCnkodcPTAczUUitKiiKnyW+dqu+cLeAZvMBKBRFF+vtVB1Hj3PHnzL9?= =?us-ascii?Q?Gp86deBgzZMFU8DCxM5eyWObNkYM+2deTksOVVXlci/4Ol1PTHRh14exH0wk?= =?us-ascii?Q?xcWKBQUfKPahN06ir/Zptdv25LCxNpN0pViZa3WzzOWMFyMjMH+h1zvc7DgJ?= =?us-ascii?Q?/uwaNOVahxq+TyCa8n5QMKx2B5Ov/aPHV7VrzdVefA638z5rwYAQveY+Ukhl?= =?us-ascii?Q?F+9Mw/23revT6FGLu24xAV0w4ooqtlXT7S0t/RrO8hvgZKU8GpO/ayvr4D6Z?= =?us-ascii?Q?TzNRXzvnh+Kq27jPPa3/5t3SUYyS7lkddQF98xom8Pl/t5KtC9ECVunkhj+D?= =?us-ascii?Q?/Q0z50ReMyzOAGrs3Xea74G5U+4kTjjZ30NRuycb62VjX6yu5Ams2Xag/RpL?= =?us-ascii?Q?RGe+RDs7Bcj3GyfsOHnMe1Nb/d9xd/6QgPefr01UF84IrVk4lY1AaPmxvW8x?= =?us-ascii?Q?7PFkLX0uVAabxmzsHAx1Vw2Bu0A2legkc8Bsi8IqWn9a+OA+/cer8BjTIPB9?= =?us-ascii?Q?Y6nKah+rWtYCtp2dv/it/nzf15xlWHA0zq6qwbkzYJPAlMiShxUpfWP2g9GT?= =?us-ascii?Q?zB7NX9D5uM87UCsYNKL4UVeA9cAeE6VO748jd4sbb9VCaDNRPuS28xjxNIuW?= =?us-ascii?Q?H5DhRO0mb5FProiTvhn1aEH8GX/anFtHl02rSiDRPIjn7ezz3me5s5FoQ9jC?= =?us-ascii?Q?jMF4E9dQ4/YGz9eWfJn5VNCgS1RdnuDkNA4lrhSEAANQpI/A2wnDXxf5KshC?= =?us-ascii?Q?R2vQe8+cgBe4b+UHfRXn+a86pnmiRENY7LBoSDEW2ZvlH9vKY2OSPIZVtwMw?= =?us-ascii?Q?rpnVr68Pkz6i8/AhTGc8uZH1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2909.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74617d69-5b1d-4f18-c08e-08d8f8eb7f14 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 11:02:40.4275 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FJiydzQUk4XZEcgXLD3zt7mJuvw1SwG7VdT4qGC0VzM3ck5aB0G9bVA5e88ZB01t8TIdT5FVoaUh1gGVcIiQDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3263 Subject: Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, April 6, 2021 5:48 PM > To: Bing Zhao > Cc: Andrew Rybchenko ; Ori Kam > ; ferruh.yigit@intel.com; dev@dpdk.org > Subject: Re: [RFC] ethdev: introduce action context APIs >=20 > External email: Use caution opening links or attachments >=20 >=20 > 06/04/2021 11:07, Bing Zhao: > > Hi Thomas and Andrew, > > > > From: Andrew Rybchenko > > > On 3/17/21 11:28 AM, Thomas Monjalon wrote: > > > > 17/03/2021 08:59, Bing Zhao: > > > >> The new functions rte_flow_action_ctx* that were added will > > > replace > > > >> the curret shared functions rte_flow_shared_action_*. > > > >> - rte_flow_shared_action_create > > > >> - rte_flow_shared_action_destroy > > > >> - rte_flow_shared_action_update > > > >> - rte_flow_shared_action_query > > > >> + rte_flow_action_ctx_create > > > >> + rte_flow_action_ctx_destroy > > > >> + rte_flow_action_ctx_update > > > >> + rte_flow_action_ctx_query > > > >> > > > >> When creating a action context, it could be shared among > > > different > > > >> flows or different ports. Or it could also be used by a > single > > > flow. > > > >> The name "shared" is improper in a sense. > > > > > > > > Is it the only reason for the change? > > > > I better understand "shared" even if it is sometimes not > shared. > > > > > > +1 > > > > In another email, I explained the change a bit more. Please check > and give comments, thank you all. >=20 > Any link to this email from inbox.dpdk.org? The link is here. http://inbox.dpdk.org/dev/MN2PR12MB29097FE55676D5D389D86C46D0769@MN2PR12MB2= 909.namprd12.prod.outlook.com/ >=20 > Please explain here the naming reason. >=20 The naming reasons are listed below: 1. The "shared_action*" is incorrect or improper naming of the interface. 2. The "_update" interface needs to be changed to support the partial updat= ing capability. 3. Since we need to modify the update interface, this is a chance to change= the improper *experimental* interfaces naming to make them more proper. BR. Bing