From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F933A0501; Mon, 28 Mar 2022 14:29:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29CA2427EA; Mon, 28 Mar 2022 14:29:16 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2065.outbound.protection.outlook.com [40.107.212.65]) by mails.dpdk.org (Postfix) with ESMTP id 896D341104 for ; Mon, 28 Mar 2022 14:29:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IIv/nLxBhJ2IV/6m3Rr6jDIW+ywqSaqE2a3E/7iHU9/1ke7QuRce7A7/Uq2v9oRq5oVwtr2b3+gbapLE/QArYV5YlLi2W7kk47xKzu1gXBhd6emTraeX4oqjFk/hXz7qTpMfkhRvIJYnUA0wXO3lvvbER0+7UNnrvbhfK4WcdQm9bFkyG7jcy2G6VxTEKWEyLw8wXxJGvdOEa19y5zcwJBB19EnrZt1K5p9y1D4Pnw/so3P9ohKgbY50TqBYuS5eBXqnapPvTxhsGbEH2xpi4U4+g6u/lGWPKhg671dFj17Q27PHxksSRlTziwpL9Wxrg5+56PDx0yLtN31AVOCBOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=938GgzyKXKK+f7/+6mG9a9eSdlmPDRoN+k72hvrl1kQ=; b=hdPy8XTC7Sco0shWBxS4s92vrnXlX8U5CV8ni9OJ0gaAn9UdWNPvGeqnutFooIw+emkOQz/Rl3forktvBDuVfjkgoG5GQOFBBhErfOAvxoKED5Zj9n/73jyQiYgCzMT6p3j3ZyE2DAYiWCjPJl7yg8wPSmTR58SPbA+EPkwfgZNMc4ko1KyTKjPGKvseb3fVPIPRQhzhgfCmNalben0jUISxysshdYT58pzt8SRYbwgY4e5g+7Q0AQldV8kgFHf88f5QCr6VEMQ8gydK9L2+6l914Crogl4r+HcY2H5BLyhVvfXEY46YF5Ai6IQe6MlT7gmBi6u1txqTWY+IBHtPpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=938GgzyKXKK+f7/+6mG9a9eSdlmPDRoN+k72hvrl1kQ=; b=uMSaVsROD+0f3lZeotj1/hRqyWZNiU34kiZ+9k4R8wiB7MhoJixRAyQ1Y7DV7gXYf6KgPhgspCzJBcdCjTXZIsmWmO/Yfmqx4fgtgsujRt8a/DwDmwnaALmG5YoXzSAIwn09tO631b/JablydPuVqF0SMY2x6M1sd80cBbpo9R0= Received: from MN2PR12MB3085.namprd12.prod.outlook.com (2603:10b6:208:c5::29) by CO6PR12MB5412.namprd12.prod.outlook.com (2603:10b6:5:35e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Mon, 28 Mar 2022 12:29:11 +0000 Received: from MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::4920:844e:76e8:1fd3]) by MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::4920:844e:76e8:1fd3%3]) with mapi id 15.20.5102.023; Mon, 28 Mar 2022 12:29:11 +0000 From: "Varghese, Vipin" To: Dmitry Kozlyuk CC: Thomas Monjalon , "david.marchand@redhat.com" , "Tummala, Sivaprasad" , "dev@dpdk.org" Subject: RE: [PATCH] meson: update doc logic for Windows Thread-Topic: [PATCH] meson: update doc logic for Windows Thread-Index: AQHYQL2QO93fBhsTI0SBKbXk6WPI/KzRaemAgAKz22CAAG7WAIAAMAYg Date: Mon, 28 Mar 2022 12:29:11 +0000 Message-ID: References: <20220326025936.487626-1-vipin.varghese@amd.com> <2037084.bB369e8A3T@thomas> <20220328123438.0f8bb44e@sovereign> In-Reply-To: <20220328123438.0f8bb44e@sovereign> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2022-03-28T12:29:07Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=ba29def8-2a6d-40d9-bd1a-eda757cd6e11; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_enabled: true msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_setdate: 2022-03-28T12:29:07Z msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_method: Standard msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_name: AMD Official Use Only-AIP 2.0 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_actionid: 70db1aab-e63a-468a-95d8-1139b342d233 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53751ba5-b44a-468f-4fb8-08da10b69047 x-ms-traffictypediagnostic: CO6PR12MB5412:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W7hqdn023ZuuT4Kiv371c9zLXERt/Fgox88RdQ0dVJSKrCczRn5ssOinbOL6x50XXQWladCqILmQ18Nr5pofZrXuCoAv0hkQ/9jM3A579RSRNWR1gT9uKOrLQCYT/o361qesfpHqBr1xYHPouk+5x3JfZCIRMhQddI8baQO6ldBv9l04/QAmDnGj741DGfeA45IEcM/I71YgiiLwwfQ/J9m0PkpW2tZzfylVnMnvvY8TIzU2HmgeuTpJ6CAAPl0bUEmqYgNAyuZHI07Fld3w2hdMPlUu0NNz8iFIxDy0N7twMvQu+5ydDqhq+kdH0Q+lGMyHzYAZf/Vo+hut7UVa2lgozTTU8mtcI5/XFNFd1JBVD7tqjXoZLrka0Zc5JbxjaKytBbPlisYvBZiwMCS02fLzvqyz5FA5LDYgS7LO7jixX49Xc2Pz7cRmh8l3KrN0S76MUrKvLSbtLQQLvxzOP5rC8w2nFl2OThQ1RAX5CW1hJKd8nr5I0nRnb6uKJHMxR8EuTgYKUccbTOimlNA4TkZ9LJfPpPl3ClbpToQlAx1q4hk/kcl2DI8B1KbSji0cUxmoUQrYv5rRwNWNu3HOiCd2+D2OptnCnk3kTu+X7DWjyMYLNBHimSkax1S8dv1KoQgaiwbYOnvucsiAVcDeDIw2enQotg8lLhPHx6pFTKVIXGpr+xWQbVuyrw13BQyBhacZKKyfqJA/SzjGVDL94w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3085.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(55016003)(66476007)(33656002)(66556008)(71200400001)(9686003)(15650500001)(64756008)(2906002)(316002)(86362001)(186003)(508600001)(52536014)(6916009)(38100700002)(8676002)(26005)(76116006)(122000001)(38070700005)(4326008)(8936002)(83380400001)(5660300002)(66446008)(54906003)(66946007)(7696005)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vl99Hf5tNSfk79+sA+dSrtqnf5GPIvyuXv4Fe+ABvU6Dy3OF8ZSKDvcoRiJJ?= =?us-ascii?Q?NJzSXWPBO4u0bGxSUpMtEb1Z6XkrP4Dxm+FFGBAt97cPkP4wDYnlT1Bh6Bth?= =?us-ascii?Q?R9YjdnmfRwu3iKOZNcL904zMwfg64nQWpJWUACv6yoqLF44zQt1gdR9VT62I?= =?us-ascii?Q?Yhflj5Z3e+Df+KuJyzaCXdsyVxT3F5X2e5WebDrde4+atWePZNRYYWL3qTL1?= =?us-ascii?Q?U9jEdk+3K6p5XhD09uzRz2AXfT2pWiLInwWUPiUDRaxhF7I49fnYu/wuklLE?= =?us-ascii?Q?p9Fj1KdAFJ/aCHMlbgX4W8J+hcJyJGXeWZuWm4eBCX0nFN8w2PjhOAbvf/xv?= =?us-ascii?Q?a7OugPxX7I8tfyA37YeKBSNTk2lLerkmu6HLHcc2tyudOBXQYLayBwfY0SSb?= =?us-ascii?Q?b+qUujelCY6wrFhXVoL13hCsBOd5k9kghhbuwJdM81yOwhStMBH8cG6OGaPu?= =?us-ascii?Q?NpcAXLevMfQYPP0VK+RBcIpFDZs/vkeObOKvgT4o7lPzNzSIhkfX6QzkoIb1?= =?us-ascii?Q?D8feLX31S4ZXGN0AWpTErBnmqaomxxvfQYM3Q9Ei1rL7H7b3GyKrrWVoGgSH?= =?us-ascii?Q?gZzmCEgXdj+obs8jI8a2ogiq3iQY+5HYVq/Uwq/4lgNO/SqtZHfDweZZzDXQ?= =?us-ascii?Q?5aYVq9Sbq2Aj1NWEfFmt42YzacJxoLWCstRgMSiPHTlzCWIiHdGpGxExRJNE?= =?us-ascii?Q?fAD9UBjNead4FHa+zlVk1XVGG3By9KgIYERMYhkPQbj2p6cxmBrdCo7JtH23?= =?us-ascii?Q?4FT+KkOEH00Q/MCmticzlAJuZ3i9+YkfzzCbz4L8M0jSTSnGhnyAldwCbw3V?= =?us-ascii?Q?DEggo39+n8L69IO4OzV2e9Wur/Ka5OGUBzSFkdwjK7hjnzYSGDc1OEtuCSPj?= =?us-ascii?Q?gBhPa5NETknT0rnUdmQn7r8rGHBsLt0HIKEFCNHTX62H393A7fYxTl7zq+76?= =?us-ascii?Q?IYQ3ERmInX3h9vAXlBK82I+89OoqsdxmKEuXf34mOJaPJtKRq4QC94uJpOQ0?= =?us-ascii?Q?6Bl7ohNnsX7v+LHSn4dOsNqUtStRmG4o3YCxzm78LjzSuXP0VDjcim1LnO8E?= =?us-ascii?Q?SFm2Spyd1nKy44NSNE9u6lnbnoDx84+a8qWXZ/mvp5Rb9NT9iu0DN96bb+ST?= =?us-ascii?Q?/+uFwv+hnTlXSEUQUA8ltKrnjEs0GlAha7rHVIKN/8yrqpERKG7fPw/dKw13?= =?us-ascii?Q?FWVwF1dEjgVWibxULuyIo2CWbRjz36j5vuLYBBfqCU1ZOftRO/Yte1b2DhYZ?= =?us-ascii?Q?/aAxfJlprWG3q776dqU+ntsbTEIWocZ4Zr2+gIhYfvs/DA96kAKHdifO45wC?= =?us-ascii?Q?+XgjzgpatVu8ki1j6EhbgnpyZVZ21dx+IF5/WVoMVFTnJG3zWeaaNNuAjbVI?= =?us-ascii?Q?SS1Oox0qSgAAIfFoF8SRTjX38JVJSNx+HjObFS3q1cSF946Ylr+3oIiPcBSr?= =?us-ascii?Q?o42v+dEcsOAl2h1qA78gpEyT/reitQv5Ji5mIJGGGBm3iI6IGoaLoU3Z0lsZ?= =?us-ascii?Q?wLt7jQNJJjnZm1O7RfheTOVimSLcl6hls7Hl/Ck1IiAPIpMBe9WVj3DjkfIV?= =?us-ascii?Q?7QiIGUa699KSHXLxmr1vWffpZ6QmmPpQu9l/8KI741OIlt6iumAwbMDcS+oP?= =?us-ascii?Q?PWpY3vjV/hYdIdmeOcqSvNOl5ogGKxtVP3I7sHj1sf6hF1/B0bxgQ6CYCxAa?= =?us-ascii?Q?totfMJIoeadn3TnM+0tjql36QRKHGL+ZDns8WtEBTDCIlIaR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3085.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53751ba5-b44a-468f-4fb8-08da10b69047 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2022 12:29:11.5937 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /WH37NWvSNQLTVSHV0IwgUSPuBczK8/7HSGJVZw6wh+m3rF15SXLsaEKzn59LLFa1V1PnKyeT9QrmMqKIdMrPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5412 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only] Hi Dmitry, Thanks for inputs, please find my question below 2022-03-28 03:02 (UTC+0000), Varghese, Vipin: > [AMD Official Use Only] > > Hi Thomas, > > > > Thank you for looking at this problem. > > 26/03/2022 03:59, Vipin Varghese: > > Support for shell scripts doxy-html-custom, generate_doxygen and=20 > > generate_examples are absent. The current patch address the same by=20 > > disabling document build notifying the user. > > It should not prevent generating guides with sphinx. > > We did get error from `doc/meson` stating ` echo command not available=20 > on windows` for both cmd and powershell for the line ```=20 > run_target('doc', command: [echo, message, doc_target_names], > depends: doc_targets) > ``` This line never searches for "echo" command, e8c90926bdde ("doc: fix build = on Windows with Meson 0.58") introduced "echo" variable precisely to avoid = this. Can you give the full log? > > Steps to reproduce the error: > > - Install dependencies doxygen & sphinix build on Windwos server 2019. > > - Build DPDK with option enable_docs=3Dtrue for API or User Guide. > > > > This produces error > > ``` > > FAILED: doc/api/examples.dox > > sh -e dpdk/doc/api/generate_examples.sh dpdk/examples=20 > > doc/api/examples.dox ``` > > I suppose we could replace shell scripts with Python equivalent. > > I am trying to minimize the changes as first step: fix the build error by= disabling on windows`. > Next step we can convert to python to make it cross platform independent. If something is explicitly requested but not supported, there should be a f= ailure. By the way, -Denable_docs=3Dtrue works when cross-compiling for Windows, so= disabling docs for this target is not right. I think we should sort out what's causing an issue with "echo" for you (it = shouldn't happen), then fix the scripts to fully enable docs. Are you recommending=20 Windows libraries and binaries should be cross build from linux (where all = dependencies and shell script works)? Or=20 let us enhance the check for windows native build, if yes for option `-Dena= ble_docs=3Dtrue, we can stop the build for docs`. If the latter is suggestion I will share v2 patch to check the same.