From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA92DA00C2; Mon, 28 Mar 2022 16:37:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E38E427F9; Mon, 28 Mar 2022 16:37:50 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2058.outbound.protection.outlook.com [40.107.92.58]) by mails.dpdk.org (Postfix) with ESMTP id 8246541104 for ; Mon, 28 Mar 2022 16:37:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fd60Pvr1YMUAzL5zmA5Cu8mh2V+OgBGXI1VChAsfUeIJ7Fw/RGC4rW8ucJuGD/+CJDEOAoZJ1KNbtjUS72BqBqdSP5Fsc6SnvomXXrPwH19rYiqkYSMg2DIOnsQSviRL+vkwhKU43E+O3NK1zrf6eBojfRpy1HKpaSkPlRZkGkWrs6LcQa3jdhMqzmtSy4Gs/41Hsr9RSRhE/KWudkk5zHMNmFxeU7ETUNJDXW5nNV49NYcezioO++JnSRFULLSeXw4qPAuII2Z4IBsc4xNWL0P6LvZYjCH0WioXbzVnjzOe+iWF1jjcTjYf+6FQktw6ZgpYxdO3+iX9uHJ83pyp/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lXGpcJO2+EXXBxaZaTVgGAVGcdqy+s9IOEF14cr1Pa4=; b=L7GXGB+T+yBo9HG1h8aFxe5XMx2ecSmLn2RXfSAhzEFsefLtUNUjQSjrFGBS+N15CipuB4khgzSyXM0l+vVcsh4jHfHVyH+LVYpxmXCtNtjKCOCZerpF/eTSj6r85Wt7OOIdFvhqKkMoWt3PfHiUe3VqaG1rcCx8CaDcCL2Tw1WvmHZKq+lBSTMcJ3CVVCBkMoaze3vmYIbhIzqm/Epaurc+Jmo/pMgRUq2eO8gRIyW+41ojWOyMWN9ljgbxc+KiUpYI3zBa0SCYhWn1xt0Yps2gxaRdUD+fFj8Hs+ySJEYgZnS9D9ahWyYqbuuNLhPR9s+IXyWqLMol7MoZghC4Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lXGpcJO2+EXXBxaZaTVgGAVGcdqy+s9IOEF14cr1Pa4=; b=mm/dlOpexRFJX4N8uOX2vamOvhwO2Kx9qdKNTeU2cGCRlAINVZgI2MI2IXCOp/jITHvfWUf3ZAYPn/CZk8ysguzEM3QUS/KC1MN3NXWzuhmeNhiUqbX/cZwCAV9dyN3jKM/zBRPaLJriLDluRbKsBkkIoK7NVUsTR3k2TcuHI4A= Received: from MN2PR12MB3085.namprd12.prod.outlook.com (2603:10b6:208:c5::29) by CY4PR1201MB0181.namprd12.prod.outlook.com (2603:10b6:910:1f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.22; Mon, 28 Mar 2022 14:37:47 +0000 Received: from MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::4920:844e:76e8:1fd3]) by MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::4920:844e:76e8:1fd3%3]) with mapi id 15.20.5102.023; Mon, 28 Mar 2022 14:37:47 +0000 From: "Varghese, Vipin" To: "Varghese, Vipin" , Dmitry Kozlyuk CC: Thomas Monjalon , "david.marchand@redhat.com" , "Tummala, Sivaprasad" , "dev@dpdk.org" Subject: RE: [PATCH] meson: update doc logic for Windows Thread-Topic: [PATCH] meson: update doc logic for Windows Thread-Index: AQHYQL2QO93fBhsTI0SBKbXk6WPI/KzRaemAgAKz22CAAG7WAIAAMAYggAAiyFA= Date: Mon, 28 Mar 2022 14:37:47 +0000 Message-ID: References: <20220326025936.487626-1-vipin.varghese@amd.com> <2037084.bB369e8A3T@thomas> <20220328123438.0f8bb44e@sovereign> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2022-03-28T12:29:07Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=ba29def8-2a6d-40d9-bd1a-eda757cd6e11; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_enabled: true msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_setdate: 2022-03-28T14:37:43Z msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_method: Standard msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_name: AMD Official Use Only-AIP 2.0 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_actionid: db63d0f0-9533-4b0d-bdac-cb37bb3be823 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10191a13-728b-44b7-9bfe-08da10c8873e x-ms-traffictypediagnostic: CY4PR1201MB0181:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AMK3r3ufUZqb1SuNiFceMfNPOAsbH2fJK59juDell10fAJrNefpJGLVIjJkz8uIFCpeK78hJOvEFQK++qjqyEljxfA1d9lv7dpW2k3sJF5hkg8S6vEtnEVmMdH6Le3OC0dLcKnNkwIFPBLqEZ+JbQogVs5mJPFB6wtFdVBjQyNV/ur6GGI7E0WT7U6OPWO6kMEKYWUrsNIAxWzIZbH9ULD8RRMGUOW/sf52T2liKVTZi4G1mPhgS3Fg1dwFXcQNfiM3L/wcuKnEuWSmdS/551O19tun+WNFaEUJ16Ij2tLBU3zNGhUePdmRzxTJqOYu0EyqrFIbfg4ik2gTRMcjiHn8rj9n48gkhlIa04OEG8FEBR4Z41uom/LI5S8TSsR2Wl4vNoWi3TZMgNrP/Jaw+JTutFKhTGwjJCPGmlGh/j6OM854QfMmf2ua/oRX82gFctOo5URpwVSaOPn68/SIEia4ndERJQMb23Z4KS+oZpW9pZpbLjsRL4lix9nGFVaILLPaQkWRHQLnlQHEguF84LmucORD06SqX5HdggMhmLmhLQkcrttYLXqeeYOWpFFOrK0dOYpzwLe/LU7DTlEgT3TxEPtsMpCArq2AaPDx25fKgZ/OMZe+YKV6SSyfjm5wxcxRF6fgada2bzE/quxUVxZbES0G5e534+VENuh4Qjlh8ByX0qAiEargWfrJQp++l1u5Ig8YFhBkb19BGcEh2hyJPDanMAMRBqvO+5SCgkH0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3085.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(52536014)(66476007)(110136005)(54906003)(66556008)(316002)(55016003)(4326008)(5660300002)(15650500001)(2906002)(64756008)(76116006)(66946007)(8676002)(66446008)(38100700002)(33656002)(38070700005)(86362001)(122000001)(9686003)(6506007)(7696005)(2940100002)(186003)(26005)(71200400001)(83380400001)(508600001)(460985005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l7wvA7YNPVZ1MX4i7TiENWPdsFaFxH9P8l46bbfCSm+3t3AsaAVMBKnbckTV?= =?us-ascii?Q?gxiECgrf/TWzaCfvFnYbJuxAJJ5p1Pjbw5DiIsSutc/RJReCOL+ydzBtrXEc?= =?us-ascii?Q?0YjdrO5JOulOgoX5DiTxYIaCbi+14vg2sVX7a5qA9J9d7/CyrdSp/TuuiH/s?= =?us-ascii?Q?/AJ3fFpgaxPqXQqhyrJd0jhz0lLRc9B7g4VUD+GFpfs955SccbCk+DRTyCD2?= =?us-ascii?Q?qKHylnVazby4kbm2uaZs61oZAE+jtaLTCv7dpa0Bx3Ou2RlqEs/kTUxC7jT8?= =?us-ascii?Q?p5a/E0LRvSLRYc2sLyjcBPWe5n4lQeP59D9DQPNMt306TmbugmmFo0wMKbUG?= =?us-ascii?Q?VPUw6UeliAniXTXEHBzoPoNojct5vEIzi34s/rGlRPzq4aKCOrAr3O/yP+cq?= =?us-ascii?Q?1pJV1pljVR+9Q+taLiUoew1Hpg+zzKGJUE/SdUsSf/YhSj8cV2mmbofGgw87?= =?us-ascii?Q?3j9iWia0F+3S/L6dfmb8ftV9TD0qN6PazClV1cOOFcXZxqxnwLflKQIc08L6?= =?us-ascii?Q?5ttY6qeSOGSLYo2L67W9pYRPV2FTjeNE3cKmjdWcthU8vWqSh1/ifbsan8D5?= =?us-ascii?Q?2xyaGRrEoaRsg2N5X105Xy6Xq0Ph7JrH031H6mbYSZofb2yBWGkDOERXMdOt?= =?us-ascii?Q?1VVwbP01INscTjp/Dxli11nqcUdOTO9FW5NDn2j2q+oJ8RxC4PQ9CyPKSM8p?= =?us-ascii?Q?Ws6TVYcQoI7ks1tnJjG7udjqkiX1fHWJoX1kJC76rlaivbJPaSge7SHoHqQS?= =?us-ascii?Q?C+ShBVvbG3BCj1lrPyUGp4+uYRH4pCd6roMxDKQyWYySzwc8oLD7juGOdv1O?= =?us-ascii?Q?APWc3/wYTjtUQ0fyojkW8RPqkZt7TykXLmZqnkJSZ63Bsxn2y2l3JTr3te8X?= =?us-ascii?Q?LbGNK/IXoey4MbcUEbHeXg208A7c7rRU/Q6yAKwXuVKuWnhro4OSPLxxO82Z?= =?us-ascii?Q?VzccTnalUfxBI/C6M+7sShI4h+CdOigjKFxWnjB7/r2heu8fOmd5wd7DF1yn?= =?us-ascii?Q?d8mtUK4PS9WDOuxEeJo1MUJClFpDryeJ8ll6NfBDsN+rK4EmjqZPq1+kIZeL?= =?us-ascii?Q?LCAYpDbvrceYUkydW3MZ0tSMs/MuIknU+Filh6Rk/pJwMQwQMKIWxV+fKCDQ?= =?us-ascii?Q?8CjbtSCkNglKuGW9mDcNrRpS+PjJxHTyN6hGTVx3ZTL3WuftWe2tpvwXvCtj?= =?us-ascii?Q?Fd3D131q1vbtp1IQxzYOf4SwTXajM0X7UXAlJlc+06buWjqSm4gxW5w8TSR3?= =?us-ascii?Q?PElr9lqNAyJ5XyOO4TfT2Ya4Hwa9EkSCwhY03aoEMHUvKnuug5dQQYCz6ENx?= =?us-ascii?Q?5tT4/2d+PIOFcuHjWJbhk0eO7OjQL7zxJ0tbJF4DcLpBynULVz/5QMBpgsoT?= =?us-ascii?Q?cBk2EYVjqt10IVBv9VwZfa6wWZXqEc1lYfwj/+8/4t0Jhh8D5EEH8QpyxS4w?= =?us-ascii?Q?f14n6OTWZNQWxtICSu2Nl2h1mbSMC0+Ab4r6N+tddTyJLtC7TcTK1hpXN00u?= =?us-ascii?Q?zYu3ZjCYHQ4+LdzQfO4sfQxekwwhcODkdlsjmlYXj3Npi/LTImRnKpj42mLn?= =?us-ascii?Q?dKjNxTNUUhJp77GG8HB8s7369I4G/NN6Wyl/Q1k4kyTu0COsRCCMVg83auzA?= =?us-ascii?Q?JY1Abx2LMsA9urC0rkg+FOHNYxFXKYs1+iMHgG0uuE18IFqO5FDoXLW3h3P/?= =?us-ascii?Q?LVFOmNoXnsn8lh5vOIsQ0A51YnNsHRrNd57tc7aLXlHlsTZm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3085.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10191a13-728b-44b7-9bfe-08da10c8873e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2022 14:37:47.3939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XKVS4b0n54zmeAYApIjiUAM1+eibidVuYiM1sC7I9q/q2FrYnh2fEA+FlmJN3+hSGNU2klqdeiS3b3AKJ58Sxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0181 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only] > > 26/03/2022 03:59, Vipin Varghese: > > Support for shell scripts doxy-html-custom, generate_doxygen and=20 > > generate_examples are absent. The current patch address the same by=20 > > disabling document build notifying the user. > > It should not prevent generating guides with sphinx. > > We did get error from `doc/meson` stating ` echo command not available=20 > on windows` for both cmd and powershell for the line ```=20 > run_target('doc', command: [echo, message, doc_target_names], > depends: doc_targets) > ``` This line never searches for "echo" command, e8c90926bdde ("doc: fix build = on Windows with Meson 0.58") introduced "echo" variable precisely to avoid = this. Can you give the full log? Hi Dmitry, as requested please find the logs attached below for windows nat= ive build for DPDK Modified `doc/meson.build` to highlight the docs build echo log as ``` if doc_targets.length() =3D=3D 0 message =3D 'No docs targets found' else message =3D 'Building docs:' endif message('=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n\n\n\n\n\n') run_target('doc', command: [echo, message, doc_target_names], depends: doc_targets) message('=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n\n\n\n\n\n') ``` Meson Logs: ``` The Meson build system Version: 0.61.3 Program doxygen found: YES (C:\Program Files\doxygen\bin\doxygen.EXE) Program generate_doxygen.sh found: YES (sh -e C:\Users\Administrator\Deskto= p\dpdk\doc\api\generate_doxygen.sh) Program generate_examples.sh found: YES (sh -e C:\Users\Administrator\Deskt= op\dpdk\doc\api\generate_examples.sh) Program doxy-html-custom.sh found: YES (sh -e C:\Users\Administrator\Deskto= p\dpdk\doc\api\doxy-html-custom.sh) Configuring doxy-api.conf using configuration Program sphinx-build found: YES (C:\Users\Administrator\AppData\Local\Progr= ams\Python\Python310\Scripts\sphinx-build.EXE) ``` Actual log from `meson build` (there is no echo message stating No docs tar= gets found or Building docs:) ``` Message: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Message: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ``` Ninja build error log ``` Found ninja-1.10.2 at "C:\Program Files\Meson\ninja.EXE" Cleaning... 0 files. [1/2] Generating doc/api/examples.dox with a custom command FAILED: doc/api/examples.dox "sh" "-e" "C:/Users/Administrator/Desktop/dpdk/doc/api/generate_examples.sh= " "C:/Users/Administrator/Desktop/dpdk/examples" "doc/api/examples.dox" CreateProcess failed: The system cannot find the file specified. ninja: build stopped: subcommand failed. C:\Users\Administrator\Desktop\dpdk> ``` > I suppose we could replace shell scripts with Python equivalent. > > I am trying to minimize the changes as first step: fix the build error by= disabling on windows`. > Next step we can convert to python to make it cross platform independent. If something is explicitly requested but not supported, there should be a f= ailure. By the way, -Denable_docs=3Dtrue works when cross-compiling for Windows, so= disabling docs for this target is not right. I think we should sort out what's causing an issue with "echo" for you (it = shouldn't happen), then fix the scripts to fully enable docs. Are you recommending Windows libraries and binaries should be cross build from linux (where all = dependencies and shell script works)? Or let us enhance the check for windows native build, if yes for option `-Dena= ble_docs=3Dtrue, we can stop the build for docs`. If the latter is suggestion, I will share v2 patch to check the same.