From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AFD943054; Sun, 13 Aug 2023 18:35:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A381C40F16; Sun, 13 Aug 2023 18:35:36 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2075.outbound.protection.outlook.com [40.107.223.75]) by mails.dpdk.org (Postfix) with ESMTP id 9701B40E0F for ; Sun, 13 Aug 2023 18:35:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8yM6AB2h1WFYMVwkSCR4wNG1aRPWxsKa0c1bX4mRyFnu2iU9717Om3L9F9QArFwEBMECg6a1a1uTsLAEBrmEyyDxlq9A3iI/xKPzI91NzM6Yp21N1gnzfeuvaT4HyVGkfAw4v0vQ8Q8206de7holpoCPTLwDQvaE1Yz4TCCGO700V1eSTzO7DdeISCj8x3wSOBdiW23LTCLSRLAag4MZapHUIW0MDp4VuVpPEde0dw+h9LWa1dKBXuBrV3bgXNLk0D++stofWpys2cRR0L7XcUIjDPAHrz/M0pJLXrZOkONlZH5YUDsX4ZevQh7NTPe649RJZcf4+Tosqwxt13KfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ijZahaMNts6sqZmgEmRVMjA+vdNNRdPqsjSu6yndHt0=; b=H5NvNttSKTMC+DqnP9ezSCaT1XohPViNo1/1pj7SAz/s441QVwA6/qOz7czMEnFrg1uq7paNTgVn8ltGFKtz2ay4qUs2+E4pJ11fiy2l0PRyVqASICRhZtYDPRZZ/OK+Bgv7t7Bo8+H4dPRNyaMK6u0YrNkMG0Fd9SSfIPopsk8NiOAq3T3ABb/G/4xO2M0FoC4cZUXcpLpgx2lofeOVhRBOiNlosgfbf+8SYMfdxFHZ0oCeP3P0bh8hERwo4gh5c/GLWZKROKGKIVA0GvUZza/sgKlJZEwfGb5QN2/oqdFGMfm/ZAPuI7Mu00MTrtKpADxG307j1DnJDEdUSqFJPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ijZahaMNts6sqZmgEmRVMjA+vdNNRdPqsjSu6yndHt0=; b=Acs5hT7vz9rkf2HK5TeHdA479eVHCr9CNORPO9YZPRlogzWK1jpOU1pw37aEfqNL1t9T21B/QA1XusrBdkgf4T3Aq4GhyWHVV4ht0mJuP2+XFa/SDILPhZKThSMxi7vSJiFGFxQTdyGOzIx3qT6oOvXIIwL1XgzX5cLob/2OtNo= Received: from MN2PR12MB3085.namprd12.prod.outlook.com (2603:10b6:208:c5::29) by SA3PR12MB8023.namprd12.prod.outlook.com (2603:10b6:806:320::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.23; Sun, 13 Aug 2023 16:35:31 +0000 Received: from MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::5527:ce19:d57f:4172]) by MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::5527:ce19:d57f:4172%7]) with mapi id 15.20.6678.022; Sun, 13 Aug 2023 16:35:31 +0000 From: "Varghese, Vipin" To: Stephen Hemminger CC: "thomas@monjalon.net" , "dev@dpdk.org" , "Yigit, Ferruh" Subject: RE: [PATCH] usertools: suggest use of hwloc for new cpu Thread-Topic: [PATCH] usertools: suggest use of hwloc for new cpu Thread-Index: AQHZzLgM+SPcnylxlkWW9UguJmnQ/6/mwgKAgAC6V0CAAOZpgIAAC5rw Date: Sun, 13 Aug 2023 16:35:30 +0000 Message-ID: References: <20230812005720.997-1-vipin.varghese@amd.com> <20230812080025.7626a94d@hermes.local> <20230813085201.719e7a73@hermes.local> In-Reply-To: <20230813085201.719e7a73@hermes.local> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b937c640-6422-4cff-92e7-879ce712e910; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-08-13T16:33:32Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3085:EE_|SA3PR12MB8023:EE_ x-ms-office365-filtering-correlation-id: cc4e8445-1fee-4502-24d2-08db9c1b4f22 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZHjFb77Ogt6Vr9qVEQnvFrnxa6g965aD7I1byizos3TgmsnFVCzCQ/e0KZe9Ilg2dnJH1W3cY0RPTeOgVH9NRdphRNdir8n4D7jo6K7BREcvOoLsdj2KeJXW8wZxDtHl2f0qubdpQlQA0xQi7F+pDUtl/roy3DLkdephWrbMeUVJBLKCgBei8840QaAmtTleFyEvpOOa8CZ2Tt3JX4ln2KBBhHLzSeOpxj5CK+pxF538cpCOIJ9nfJcx9H+0svfD40DSMlTNrdSB7lheso9eyYLnyn9K7Cvtf1aPMTvus2F18eK88eIhoxDDIoclm0E8qHr9x98EIZG3AP/8qb3v4zwADPwh5pKXYhpAppK12XH46DsGVpiU41Wbig14+PcdDT8EIq+Fob/rZI+rLvNZ3P6KRoS+T3IbZiiQH06KFOlwmbSCzbKfwDFE+LzL0IBFDhff0GKEfKVreHc5wGw/heUQ10g7AT+8V5z1zUoRqzP8aamN4CEf7ZpH5oIelxYpLB9oaNeRs3fkmfu9SJO8dqcr/vgAU6MIj0ViGp66m3ljbVP0Nt2EWKnGAATf5N9CbA7ekOpy+F3c6Yr9CR70xtou77ZfNAaf5b13kxYRqsR10W+vQHZgc8b/idXGu7ej x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3085.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(136003)(396003)(39860400002)(366004)(186006)(1800799006)(451199021)(66899021)(9686003)(71200400001)(7696005)(33656002)(86362001)(38100700002)(38070700005)(122000001)(83380400001)(53546011)(6506007)(2906002)(55016003)(54906003)(478600001)(26005)(8676002)(66946007)(66476007)(66446008)(41300700001)(66556008)(52536014)(64756008)(5660300002)(8936002)(4326008)(316002)(6916009)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gmpoE8K4R2ljcttq9DV0izSl2EovbUeL3+jWV4G7m2UvTm2lUIOBNLvBNdVS?= =?us-ascii?Q?jZ0ppw0UJq184qWgm48rOT/eEAPmvwFEULBYiGNEm+s/2vfl+JwG4OU5wjI3?= =?us-ascii?Q?S3iVHCWb8nsoiEzTolrFYXL7nPr+3xDQEsW9gc0I0q/nDMhB75C5i3X+e/M/?= =?us-ascii?Q?sc52N5fflsNWqf02ztPAVF/2QVPNKRGtBmGhwiiwkkDisbcSaKMjykrQDXAL?= =?us-ascii?Q?z2fYAB+D8Whq5nCBQf09F/SClVIR+1/6AfHwzmVb36N/v+HnPvoHyLb23x03?= =?us-ascii?Q?Fa3DZoTAhpiW/KzBcI2iJmbl4Jrou1UWhiXqBgWSOOrAQ6diQDdw8IZ7be82?= =?us-ascii?Q?/Du5hsLfBZvHjSG6oZ81+zbkIMsx7a6nNQwJVLDP8QaNrXq7mOjVx4Mi6dBP?= =?us-ascii?Q?4Occd9QrRqIMKvXJ3pCJ8ZyLCC4ps1VSp8aYUZ5FfRa3BJzFqpsB313qzBJd?= =?us-ascii?Q?N2A9GZoQJDirl6UdGmKnEPgGkKlkVkUnIvcJbUdm3vw0+qd/SyfJT969PYuk?= =?us-ascii?Q?u6NjwjbccHY5FTOMgqXkohVecPzy3RsoGlMImSFAyMyN7cvr6Wpn8hINcbzJ?= =?us-ascii?Q?O7GkJcTsZU/1cWFV/bKp/Gdy5z4fwXyavN4xsJqQd/w3yMAZBSOC8sXW5kUy?= =?us-ascii?Q?Mn8iNpxptnBz4SSD/aRZ4n6xVjHKFxw3FfST853H9w6Y+j+8jKAdyUjJKD2U?= =?us-ascii?Q?Yon/RG9wXrYgO3upCQ8w56XNfIHyEhbrBF9ZExbz5BGajEw4LUa5c5NacOp1?= =?us-ascii?Q?Pdeh1v7AZ3V1VgpdqAWfiF51Llxg0G6sn2Bhu3umM6jkxeTQCbSYI2S6pR44?= =?us-ascii?Q?bKZi9cr9Qt70aS5KqQlVS+KPWjsNlv9hdeyjh7u5j0pLz5twd0dNJe2m2NRb?= =?us-ascii?Q?Z03Lu5a93sbvsj2uLgJnyep0G49GCoMij4QhZIblrt4jBF/THLrVO3TNMjVQ?= =?us-ascii?Q?HULBAhPWILzBj1Qbl996o+1scKiSpY5RIJVHAVCWab0xEKdpak7i+TwIYGAo?= =?us-ascii?Q?B5ZENmzqjpSk6INZ4Wy92QedfHNZveMfWjM+mGGs7e1LWaL9e5fsAgUslF4p?= =?us-ascii?Q?DPku9CqEJZ9K0HJ4i2QZxZZ4hVa11s5Q7Oj2282zSasmIKlaIFJfaYqMGu31?= =?us-ascii?Q?yc2PSbzrYGqSol97LY7nMJ8sujC8zPyGD5g7HLuoxnMiOyElFF5aa1WnO9H0?= =?us-ascii?Q?UEmUvm43b96ioj43H8JxARwt7Oxw6OvyebrUCqEtbYNdqGiEuvEAJLomCvKf?= =?us-ascii?Q?6qxj0moHhS0OEoI7kvteI46KiqTo+FX5XMcVaceyNubcT3nq9uBWi96fU5p4?= =?us-ascii?Q?mKMCVYs1YovWuqmeXRKKNdpclqiI2ECXp9hRWeZe9fJeHoPQ9cW52HwDQm1P?= =?us-ascii?Q?9fS2JwlVeESASXgJQvpqXscllyMzauYMXtGcUOUQzkx/YWnoFFaJ1DRLC0jN?= =?us-ascii?Q?xAjqQabOfGST8jkJbSwGJYaf6fTBImIRkDGxjBsw7uPwLzIGZdz6qNrzrG8x?= =?us-ascii?Q?BidlO1r5sHOcjQKBzQxLr2U6YkXA/YAahvRjOGFxcqHhuy2BK+gRJslbczL5?= =?us-ascii?Q?CYGJrE4c9YSxDwjkHJU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3085.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc4e8445-1fee-4502-24d2-08db9c1b4f22 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2023 16:35:30.8256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wptLSuoKHDomOfwKe1cF/cUoW4Da+B3PU5zltiMgiZJyr+0/Fz8NHiXFwfX6mzGisYX4H+isWHAoGcC1Ibd9Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8023 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - General] > -----Original Message----- > From: Stephen Hemminger > Sent: Sunday, August 13, 2023 9:22 PM > To: Varghese, Vipin > Cc: thomas@monjalon.net; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [PATCH] usertools: suggest use of hwloc for new cpu > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > On Sun, 13 Aug 2023 02:12:03 +0000 > "Varghese, Vipin" wrote: > > > > > > > On Sat, 12 Aug 2023 06:27:20 +0530 > > > Vipin Varghese wrote: > > > > > > > Most modern processor now supports numa by partitioning NUMA > based > > > > on CPU-IO & Last Level Cache within the same socket. > > > > As per the discussion in mailing list, suggesting the make use of > > > > hw-loc for such scenarios. > > > > > > > > Signed-off-by: Vipin Varghese > > > > > > NAK, no scripting hwloc, it is ugly and creates a dependency that is > > > not listed in DPDK packaging. > > > > There is no calls to hwloc within in thescript. Hence not clear what do= es ` > NAK, no scripting hwloc it is ugly and creates a dependency that is not l= isted in > DPDK packaging.`. > > > > Requesting to cross check why NAK is shared for `print` as suggestion. = Hence, > I have disagree to this. > > Sorry, I misinterpreted what the print's were doing. > Better off not to list exact flags, the lstopo may change and user may wa= nt > different format anyway. Thanks Stephen, to that I agree `lstopo can change the flags and user might= need in various format.` > > How about something like this? > > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > usertools/cpu_layout.py | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 317875c5054b..25a116900dfb 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -185,3 +185,8 @@ Deprecation Notices > will be deprecated and subsequently removed in DPDK 24.11 release. > Before this, the new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status. > + > +* cpulayout: The CPU layout script is unable to deal with all the > +possible > + complexities of modern CPU topology. Other existing tools offer more > + features and do a better job with keeping up with innovations. > + Therefore it will be deprecated and removed in a future release. > diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index > 891b9238fa19..37a4f9ff24b4 100755 > --- a/usertools/cpu_layout.py > +++ b/usertools/cpu_layout.py > @@ -62,3 +62,8 @@ > else: > output +=3D " " * (max_core_map_len + 1) > print(output) > + > +print("") > +print("This tool is unable to cope with complex NUMA layouts") > +print("and will be removed in a future release.") print("Suggest using > +lstopo or similar tools instead.") I am comfortable with the same as it serves the needs. I am happy to `ack` = the same too. > -- > 2.39.2