From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B2A54368B; Wed, 6 Dec 2023 16:22:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5003A402A7; Wed, 6 Dec 2023 16:22:47 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2081.outbound.protection.outlook.com [40.107.102.81]) by mails.dpdk.org (Postfix) with ESMTP id 9F9424021E for ; Wed, 6 Dec 2023 16:22:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rj0FKb4KbTvdelOp0V9VwY6pI7gXaJbSwDwLh7vo7g57RE7FB4y5HsrCO6tAF1b0rPmKv39J/VNjC9DnM+MAB5rRI1pM6Z+HYoP9mYALcuqTWIyZnFK9DUZUXRyJDqP4yPo8igeOzIyaQVjA8vCF16idttg52ykkwG5e1BTnR+nwoNBucMKPUhQXOY0CHrbdLoLSLF/uDxX60mNUPOYqRA98qhFGhTje2qqavXzrIZ6B3m1obFCQBssYgdimF2mREaHEO1S0RSev2tBpEenK1i4QVpYbwVBKmovHjTCB1oo6vgUY/1VwlbhOm2+WxrCMLodkdy0w2v6BqgCc486AIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d0PFbXiYWqNchvlU1g/7s3svVQZwroRERMacSfoL7qM=; b=MdOHjpXUsKYYAi9+rN0V6iDUiYsyk5MPven6K5pc7e3T8BVFjKzwRdPw4HblnNSnesVCSmRGNVKdhhb1yto4UXkq4zhl6HyM1vq7qg9qR8ctJB9/pI+e1w9ZUPBzv28olLBirDSGwwBrPa1/Y9/yWe9aLbksI4EYQacAR1AyL8Ukf3Ye+O+4hML8lcga6JXdjKEOwXnC4bfueWy4NZgF7WLbH2LPsenO95GmbJLKjLI8xeWMUta2jvPMhd8/lK+UkByauiSm6XZUPxRn4XmdtPUpy3Ecdqj0B3FK4Q/hrSoawnfw8wY7aMwJEc3cOQ8v9EGg9V8ZEufgYFGmsoJlNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d0PFbXiYWqNchvlU1g/7s3svVQZwroRERMacSfoL7qM=; b=P3voBdPPefUdjW56KBvAmOJNOxe+acTPkrQ7+6ePRpJcFxHMz58T8tCQC9qg4l6nQsMCVHj+EMT7z89y5+guYGkbslD4GF285VpwGcSSJXtbkB6YonmgkNxcEjMY/E2zhf7rUwRo6Q9VISiANDPNwx1TllSy51u6oVIepEjTobo= Received: from MN2PR12MB3085.namprd12.prod.outlook.com (2603:10b6:208:c5::29) by MW6PR12MB7087.namprd12.prod.outlook.com (2603:10b6:303:238::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Wed, 6 Dec 2023 15:22:42 +0000 Received: from MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::579d:6ed5:68a6:3cba]) by MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::579d:6ed5:68a6:3cba%3]) with mapi id 15.20.7068.025; Wed, 6 Dec 2023 15:22:42 +0000 From: "Varghese, Vipin" To: "Dumitrescu, Cristian" , "Richardson, Bruce" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Parikh, Neerav" Subject: Re: [PATCH] cfgfile: increase value length Thread-Topic: [PATCH] cfgfile: increase value length Thread-Index: AQHaKDe4yCtpk7vSyU+P/DqWnXg8prCcPeuAgAADiQCAABy+Uw== Date: Wed, 6 Dec 2023 15:22:41 +0000 Message-ID: References: <20231206112952.1588-1-vipin.varghese@amd.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-06T15:22:41.555Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3085:EE_|MW6PR12MB7087:EE_ x-ms-office365-filtering-correlation-id: 685f022d-0e81-4614-a77d-08dbf66f30a0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TAuYnQIyxH0lJajY59yle+Wm6Sru60RTd6qAD5sVs/uIc7NS1Ekc7QUo9Vbo9xBUIoRD9l808F8qj90LA1GJC7AOiGkyXWQFx7hHYuX740oi69MQo2MdO/73+jNgDTruorn6jCRnBU56cfME4G+ic5MzPYqhXZ1fxZP4ujlF04K2y5IF0YLb3xvzS3SLlr9WtAKaTvwQKZZdb0srL3XZZqMLwUm9DFxDNtxP5tvJOjLrum3x+LBAhEaR1PK/64eICu6xvbSE4Orrirnks4ukKT7JZSB4XwI6BkzO5GwcjN/hMktrraWq9HVosogVlxJU1Mwm62VR6lqHyuq3chGyxu1jVRcQJufoGxtqunl4r22db7bP2NNKp6s5cksM4YOVLOYGF0XUGMLpwi8UySAiwgRq7PZI/pL2imwNJDWb5BqWXbnsMH+O47ookeh86oIsguJoNiJOIQ7B+5qKjNxing28yfvzExqdnZcsPLwzFof9/uQG1v8Y1M4kqRDcstmaXaUFRaxhjdJEeQzrtmGs8ixTLqABkwX5tEtY/Q/PHemcuj2yKE+pMmW1iPS31XIkGR2FBewJoqWI5heq6cP9l9HgEETmu0FP5t+Cz9DfnY/cgoW+6D/k6qNTlBt3eImcIRG7U2yVhRMu43oIJbTxng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3085.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(346002)(39860400002)(376002)(396003)(230273577357003)(230922051799003)(230173577357003)(64100799003)(1800799012)(186009)(451199024)(122000001)(2906002)(38070700009)(26005)(83380400001)(55016003)(86362001)(166002)(38100700002)(33656002)(7696005)(5660300002)(6506007)(53546011)(71200400001)(966005)(8936002)(19627405001)(8676002)(52536014)(4326008)(9686003)(41300700001)(66476007)(66556008)(64756008)(66446008)(316002)(110136005)(54906003)(1015004)(91956017)(76116006)(66946007)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?763PSHJtwU91MdmsCBA5AuS0EkhhbMaaNMf/8RUMLUFFQjrR7VM0hlw5/w?= =?iso-8859-1?Q?w6zbG3NM65sE+pDy2YRwkksI5BYLUFIuoMHPYwcnDc/r3VJasee01txPih?= =?iso-8859-1?Q?azvhS+TcRicXtG0c4W6s/uSwptY3sdfMa0qTkG1/5ypstCGPweYYClqIVz?= =?iso-8859-1?Q?1QkN3oR6PLNRJQyScz4sccs2W+vWNlBoAknWoY5+CDAaI0TFjMTU7pldXV?= =?iso-8859-1?Q?+TX+kpnMvlPaf6kcob1QWA6mNOIL03PC7lZqp0CWwUQltImhgN0ViGli5c?= =?iso-8859-1?Q?x8Gz0Xnq4vsI8CySqntNHAwO2zeusz3cZt5+nI/t/l4TnuzpUwr+xXkxUW?= =?iso-8859-1?Q?CRH2RLaYfJxE0lp3MJ1hUx6KoiNYps0ithmIUmQvXuOOqsiBNGx6uomHKJ?= =?iso-8859-1?Q?BV+MFB2L+23wSFWjEx8YEFLdgxVtghUaWDlSpHKYOcKZGqlgm8l4jKMNGh?= =?iso-8859-1?Q?ATySHnJDE85hZW0RlzK+grvY9sJHpedyP+ZP95ALj+3Uy+qw9n139dJIHT?= =?iso-8859-1?Q?56lFZpvIxnIM40yALLWZc5Jt8y/BVLV0PYCN/u9luiLnwv+KdEVSyA8a/R?= =?iso-8859-1?Q?lrG3OuS+fa/8PgciCUvsxKe/drpu7qnUqwLp3fuLNFJaYNoeSVsGhAsiUP?= =?iso-8859-1?Q?InkkuP+kgjYrcGuGG2HhEjcw2L7lgeO6v3hSIkeY04xdM2F3PpILO1NHD4?= =?iso-8859-1?Q?Im7DuhE1hz5/rsn0+uPMRwAgLTApAO36vC4QNGxbeu+I5QWMHGWOdaQ0JR?= =?iso-8859-1?Q?/IkTuxwSsbyNmytU1lvNMlve9CW4xeh0jOjBHwYlD+OFKqmC8euMTOYOmc?= =?iso-8859-1?Q?x5nC3CdISgoWY0QtsrUq0kLYAqU41oHxxiG/2Vo6n0BzkulrcorZCyzhPF?= =?iso-8859-1?Q?sDBaCZ/b6aByxBxevCfaoGuZeld5iczBitdHqbkfMr4OQBZAV24Kl4hWet?= =?iso-8859-1?Q?yEuImgY5bBfGXJGoteKr9g5F7X9Xw0Dr7F+WTAJok+/HvbtvrAlZ7juqgh?= =?iso-8859-1?Q?BgPiSdeBLQOkGujsZk8bZmEuoJ2DSk4VrCuFkpMt7rDtEHQgs7LvqPensi?= =?iso-8859-1?Q?MTH+ZbiIcOO9Cro/14J9O180rpYNT/scPRw9wEhCwxwhsQDa25csVohPfu?= =?iso-8859-1?Q?uPjAOJ6yhgsxj5h+PxKJZW3FbQ8WqH/zHKLgGGoT13S2gcp65yV6L4zXt/?= =?iso-8859-1?Q?W5SWUE+E+iQ+5VtEVpyTcmOCisthPGIWAuF6rpGJod8zImXKPDqstkQ11L?= =?iso-8859-1?Q?0mGuE9gNprtl2H5bb53aXWCfuRzKq1AXk8GQ/UEFH1d1ZYOc3+B0AH08er?= =?iso-8859-1?Q?CyxiRN4dR+np6+BmuQoG0NNXmO+Zzrj9dV92P4kGUz8noMw+3/6Csjo5QO?= =?iso-8859-1?Q?d4a8rbrB19odD9PtPMrTkhYzstnM9j74hNatp7gm/jn8/2tbdUXkhDrIa1?= =?iso-8859-1?Q?md+Ckk14ixBteC+WD5VGXOLui70BV0ZhXIiGBf1GT2REEiOx3KzkYg/Mb0?= =?iso-8859-1?Q?QhriN5yjKJQIb25uQBbqtKqDX8n2h4qp8EbVPkDRwtnr0J/J6t91Vw96Qz?= =?iso-8859-1?Q?yo9h7j6MEuZsNKO/MbHI7NFtrUxcbCPL7CUUCnmQ8QzlkZ5BnEve5N2Ouq?= =?iso-8859-1?Q?/yzrt9irHkPns=3D?= Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3085F25BCFA579B06B0B5AFE8284AMN2PR12MB3085namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3085.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 685f022d-0e81-4614-a77d-08dbf66f30a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2023 15:22:42.0062 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iQ8ox/56ZH5+ncZn/q55qkyHtMPipiSxVslqvWTkwyzuQaw5za6M/I3y3cytWi5tAbDS0Y6c8vxlddtkMyrnIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7087 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_MN2PR12MB3085F25BCFA579B06B0B5AFE8284AMN2PR12MB3085namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks Bruce & Cristian for the comments. An increase seems ok to me, but is an 8x increase really necessary? If lines in the config files are over 1k in size, then it implies that some other mechanism would surely be better for configuration. Can we make do with an increase to 512 only? VV> We encountered this issue https://bugs.dpdk.org/show_bug.cgi?id=3D1333 = trying to use multiple queue with DSA. But I hear you 256 to 2048 is big ju= mp. Happy to compromise with 1K. VV> Sure let me update this is v2. Since there is a ABI breakage, https://patchwork.dpdk.org/project/dpdk/patc= h/20231206112952.1588-1-vipin.varghese@amd.com/ I will re work and share v2= . ________________________________ From: Dumitrescu, Cristian Sent: 06 December 2023 19:04 To: Richardson, Bruce ; Varghese, Vipin Cc: dev@dpdk.org ; Yigit, Ferruh Subject: RE: [PATCH] cfgfile: increase value length Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, December 6, 2023 1:22 PM > To: Vipin Varghese > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Ferruh Yigit > Subject: Re: [PATCH] cfgfile: increase value length > > On Wed, Dec 06, 2023 at 04:59:52PM +0530, Vipin Varghese wrote: > > The default value for CFG_VALUE_LEN is set to 256 characters. > > This limits the parsing for longer strings in configuration file. > > Setting the default to 2048 characters increases the value array > > size in `struct rte_cfgfile_entry`. > > > > Files using cfgfile library are > > 1. drivers/net/mvpp2/ > > 2. app/test-dma-perf/ > > 3. app/test/ > > 4. examples/qos_sched/ > > > > The structure `rte_cfgfile_entry` is not included in DPDK libraries. > > Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` helps to > > parse longer string as shared in > https://bugs.dpdk.org/show_bug.cgi?id=3D1333 > > > > Signed-off-by: Vipin Varghese > > Suggested-by: Ferruh Yigit > > --- > > lib/cfgfile/rte_cfgfile.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h > > index 232c65c77b..401353c44e 100644 > > --- a/lib/cfgfile/rte_cfgfile.h > > +++ b/lib/cfgfile/rte_cfgfile.h > > @@ -24,7 +24,7 @@ extern "C" { > > #endif > > > > #ifndef CFG_VALUE_LEN > > -#define CFG_VALUE_LEN 256 > > +#define CFG_VALUE_LEN 2048 > > #endif > > > An increase seems ok to me, but is an 8x increase really necessary? If > lines in the config files are over 1k in size, then it implies that some > other mechanism would surely be better for configuration. > Can we make do with an increase to 512 only? > > /Bruce Happy to compromise with 1K. Acked-by: Cristian Dumitrescu --_000_MN2PR12MB3085F25BCFA579B06B0B5AFE8284AMN2PR12MB3085namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Thanks Bruce & Cristian for the comments. 

An increase seems ok to me, but is an 8x increas= e really necessary? If
Can we make do with an increase to 512 only?

VV> We encountered this issue https://bugs.dpdk.org/show_bug.cg= i?id=3D1333 trying to use multiple queue with DSA. But I hear you 256 to 2048 is big jump.


Happy to compromise with 1K.
<= /span>VV> Sure let me update this is v2.

Since there is a ABI breakage, https://patchwork.dpdk.org/project/dpdk/patch/20231206112952.1588-1-vipin.v= arghese@amd.com/ I will re work and share v2.

From: Dumitr= escu, Cristian <cristian.dumitrescu@intel.com>
Sent: 06 December 2023 19:04
To: Richardson, Bruce <bruce.richardson@intel.com>; Vargh= ese, Vipin <Vipin.Varghese@amd.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Yigit, Ferruh <Ferruh= .Yigit@amd.com>
Subject: RE: [PATCH] cfgfile: increase value length
 
Caution: This message originated from= an External Source. Use proper caution when opening attachments, clicking = links, or responding.


> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Wednesday, December 6, 2023 1:22 PM
> To: Vipin Varghese <vipin.varghese@amd.com>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.c= om>;
> Ferruh Yigit <ferruh.yigit@amd.com>
> Subject: Re: [PATCH] cfgfile: increase value length
>
> On Wed, Dec 06, 2023 at 04:59:52PM +0530, Vipin Varghese wrote:
> > The default value for CFG_VALUE_LEN is set to 256 characters.
> > This limits the parsing for longer strings in configuration file.=
> > Setting the default to 2048 characters increases the value array<= br> > > size in `struct rte_cfgfile_entry`.
> >
> > Files using cfgfile library are
> > 1. drivers/net/mvpp2/
> > 2. app/test-dma-perf/
> > 3. app/test/
> > 4. examples/qos_sched/
> >
> > The structure `rte_cfgfile_entry` is not included in DPDK librari= es.
> > Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` help= s to
> > parse longer string as shared in
> https://bugs.dpdk.org/show_bug.cgi?id=3D1333
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
> > Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > ---
> >  lib/cfgfile/rte_cfgfile.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.= h
> > index 232c65c77b..401353c44e 100644
> > --- a/lib/cfgfile/rte_cfgfile.h
> > +++ b/lib/cfgfile/rte_cfgfile.h
> > @@ -24,7 +24,7 @@ extern "C" {
> >  #endif
> >
> >  #ifndef CFG_VALUE_LEN
> > -#define CFG_VALUE_LEN 256
> > +#define CFG_VALUE_LEN 2048
> >  #endif
> >
> An increase seems ok to me, but is an 8x increase really necessary? If=
> lines in the config files are over 1k in size, then it implies that so= me
> other mechanism would surely be better for configuration.
> Can we make do with an increase to 512 only?
>
> /Bruce

Happy to compromise with 1K.

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

--_000_MN2PR12MB3085F25BCFA579B06B0B5AFE8284AMN2PR12MB3085namp_--