From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 334C7A0506; Tue, 29 Mar 2022 07:36:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C116942807; Tue, 29 Mar 2022 07:35:59 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2046.outbound.protection.outlook.com [40.107.243.46]) by mails.dpdk.org (Postfix) with ESMTP id 14B3940691 for ; Tue, 29 Mar 2022 07:35:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2/Ynnfb3PleYZj3VruJmF7lH/D9Mhek5pvk3Ujaf3Iwi/2KWKXl5pl17s7azeBsIfSm2bZaUVDkta66wjpvpt53/ZPXH0gRYjaUI/ohWDU4WSS3XZgwO7Dq52BBQlNTWy0jkvpZODBuQvg8YbF+zNxK3uHVNNPvPAI6+o8w0VDQht+tURSReUnbsmM9q4Vo93wJjahm1hCNPmetkkwdfV6CH84+aW49Mw14XnzBgESnezdchJrjd2uNILSQui0K7EImOwW0+yvjFV18Whe1D6lRBwaLRdLxDPfUckWRFWkO5peMiYvb2zVbZL/9KbFdyoQR88uDIKOWG+qqNfq/uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pNW15ikXQjHK9iTcXno2F//7Ott9FLeUJ18eEdbotA=; b=IJ/EXb8BDTEmLO0jPXdfZ6Wy8MdJyDlj8DscN6cHBJ2az/jrzo8f/g47uLhfbWo/Ggzs+e4NsCFBHl4FUCikWOKFsLRjENTdSxNP+fIXP9DA8ogMmOCb915nfSSBZQW77C0sVTBbTv0yemNhZhlgSItKWOo4MzkJV6W8SG5oE2htuw7WGE8V/OYSpEEKeZJpZKqFCTA4fk6b2tNTSqBkv7f111RZitB7Z3zwdZ17A8F1JYCqHTd8t2UnYF/0USgMwujY1OBwM/UGVfRF/9u8z65nsCmMuIAwnUvYJ9B8jRItEFG8kwBdPkWRFD9BHqTdNe6lQMXkYrXLyf8h7Oe9Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pNW15ikXQjHK9iTcXno2F//7Ott9FLeUJ18eEdbotA=; b=bxOu0WLfR44BOCh7TqSmdFsrtJW9CM2P2fMK6t1lEzcVO6VlPq1rJLEouD/7x+poo1kzf6eqXmiwhgGnZPP7L7vol70C4UBf1+g6xaboBXWPX2RgyhioaxtIxP6RNbelGqLrivyUJ1TJ22X5S4vOgQ7TK44voBpUNjgnGHpWinA= Received: from MN2PR12MB3085.namprd12.prod.outlook.com (2603:10b6:208:c5::29) by BN9PR12MB5322.namprd12.prod.outlook.com (2603:10b6:408:103::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.19; Tue, 29 Mar 2022 05:35:56 +0000 Received: from MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::4920:844e:76e8:1fd3]) by MN2PR12MB3085.namprd12.prod.outlook.com ([fe80::4920:844e:76e8:1fd3%3]) with mapi id 15.20.5102.023; Tue, 29 Mar 2022 05:35:55 +0000 From: "Varghese, Vipin" To: Dmitry Kozlyuk CC: Thomas Monjalon , "david.marchand@redhat.com" , "Tummala, Sivaprasad" , "dev@dpdk.org" Subject: RE: [PATCH] meson: update doc logic for Windows Thread-Topic: [PATCH] meson: update doc logic for Windows Thread-Index: AQHYQL2QO93fBhsTI0SBKbXk6WPI/KzRaemAgAKz22CAAG7WAIAAMAYggACujACAAG+F8A== Date: Tue, 29 Mar 2022 05:35:55 +0000 Message-ID: References: <20220326025936.487626-1-vipin.varghese@amd.com> <2037084.bB369e8A3T@thomas> <20220328123438.0f8bb44e@sovereign> <20220329015114.04aedb30@sovereign> In-Reply-To: <20220329015114.04aedb30@sovereign> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2022-03-29T05:35:53Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=025bedfd-35a5-46ab-8fca-0ead7ff12863; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_enabled: true msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_setdate: 2022-03-29T05:35:53Z msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_method: Standard msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_name: AMD Official Use Only-AIP 2.0 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_actionid: f09d6ee5-5dab-4e6c-9fad-568e8dd94ae2 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 75e2bfb4-8c3b-4879-66c6-08da1145ff4a x-ms-traffictypediagnostic: BN9PR12MB5322:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aIVwzfSF6XnoLkKZ068+/s1sSzyfHiC+9nAibIaQeg0tMleoRFbN7qhYmgI99bCIo9up/eZ7OeoXwvR+mslLLMkhTF7E9nmXuoeNgiMR1KZgcK2mRianzSImUMrL+YWxO/u5IxLRpZU6Tx6ahRC+clHs63MHMMcrJ08wE7+Kjphuaq3fTf0WPspYcugY3bF5H/G/36AKQQmBioCpzyodw+mCiRl4VrWy8IbmY2XVh+WfZKkXSo+amZVUkn0Roq4SedvYL1Ohva5GvQl473RfAJUgiwy1/RrGRvRQSaUlf5cyQUMujrSYx89fM5sfc/KxYqyhonn7DuBou8Hy/z3GMAaVCQAD1LH3irdJKDTfEtLGx7ahwsMWBwZSFosk0+13XKXGRGhpSEFmt7SM09Jk3s1V5c7ZttncinYO9r7/cxSnQYMMUaMJvUlKZhffYW7NU32MkAMRvA/IPziaDT1ZXoFKa7sIBZylbNTWk60rjBkwlIZorgVJyJnd3caMv3To80gR68HJoR/dDPbkQTLYbGi1VrHYSThjXsbP7JCqAhU7/VNF4LZSDdLkWwp08tvM8CKsWsQMg+vzc+5yehoBXhSgX7aK4bdnXCBAMnCAPDrELKaz99hrFTlc4IfozE3KcfGIRZea4CVFHNyzxr6BqnEWu/FCdWpl0cMtWdh4CD1l8g8j9VYRPheaQOYjzLPedD3ZTyzXWqE4Gw6pnwNXzw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3085.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(33656002)(2906002)(71200400001)(5660300002)(52536014)(66946007)(8676002)(66446008)(15650500001)(508600001)(64756008)(66556008)(55016003)(4326008)(38100700002)(8936002)(66476007)(54906003)(53546011)(86362001)(76116006)(316002)(7696005)(26005)(6916009)(6506007)(83380400001)(38070700005)(186003)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A3yFpybsUKKTWWKOmxiAIS0LATDPOElB92F5g2uifA+UAjhJAWgYipb5f9Mz?= =?us-ascii?Q?WbY62CukGH9gCAXf9n4vODcOkshjdEDxgRUG4dbnlwSUT6S+jpELkt/Dv9rz?= =?us-ascii?Q?y2vmUk/uR+o7QiG3aZvonoj+31mj9zUW95S76XE9GxUaGqYdY5TY+dvzGCSk?= =?us-ascii?Q?oaD8bipfXKZ4MkIVI9jicly2aW0b+qQl+xMXnL1IHBWsuFIkvC1qMo/2tGTF?= =?us-ascii?Q?6G4yB9Zij5ejvng91xFs3QXgA7yLhsj6uoNxpJNOvAfDivSGB1d8i2CoOJIT?= =?us-ascii?Q?yB08vOO0fvwQDERFdaXcJX+V9RplwtNL7pJ3h8bDbpNt1z2VEsCCNGlRygjf?= =?us-ascii?Q?Lt3jcZcyM8jfPQenc1jZiGggdw+9ueW97/Mn0xuZyHr45CtkxFqGIQflMGfZ?= =?us-ascii?Q?r4HMjtB+TLZKQuTJ/kCuglS1hOD6M+tQUQLn14p/vfyg6Tl+HLYuxveaHUTK?= =?us-ascii?Q?mUhXRBWT01dTkRNXJJCDiLVA3JcE8XxcPeRS9SEAHQO4sMrCRtKQ2zEkrlb7?= =?us-ascii?Q?sfrH4drJQPhF2aMV8StryfP5SKX7403tDaWQreAxglRMRdN6Gteru6UMV5Hs?= =?us-ascii?Q?fXK9vVQMGVsRyabTKEeJme0tgW+0YkUJJ4+mQ9rHgzfhkAMkO91Q6y0Lgc97?= =?us-ascii?Q?rg7YYXaKQRT25qqdMTreHXY7EBihN0595wLwepCQwbipO51iF288f4dhW91y?= =?us-ascii?Q?edL67hYU8ll66bvKl8m5uxlrFETNpRKNCyptmkdHUmwx1HsoSLaIZySSnWvD?= =?us-ascii?Q?J/2uSUQOQvMa7AadZJIuV9o307h6OkRnHl8k05iGy/VhFXJClh2VuxJiGv+R?= =?us-ascii?Q?oHvSQBIxlh8LRP7dTJQV39GEYUgshsHIx/Yu2swFaurJ0v6kLbmuwAohmDwS?= =?us-ascii?Q?hnvXXRFHpReRkBhlmlqknmL45oSUlw7qLrP47SYHe+zOUXzfXEjMy86oycjj?= =?us-ascii?Q?h8YYo1MrboUsO8urggKbSd7BpoAURAYb1PXT86Xc1dVnmp35/2K9wG4rV/Ae?= =?us-ascii?Q?x3HoSwf5UDvc8wjiTA6targKu0t+uHNHdf2q/O+ASRZeufpo5lhiT1L1t7QC?= =?us-ascii?Q?w711VzefRxDnTLfQn8lDnRoYJtEUcqfUp53ipsQ1v4HrlLgrDvwACA3fFsTI?= =?us-ascii?Q?b+f01E909OJtLgDcuv8xa6b3z+zx4XHK5L1z0sL/qMQHythQqWHehIMXBb7U?= =?us-ascii?Q?zDrhtelVzwDZ0rUVYglypUjVzDIzMmLnzJU+FhtHUNRLZgiJllqvCGb6BLRB?= =?us-ascii?Q?RfqG0Kz1qsjmqjx7tr6jaIvmEMTJiesspFQP8ijJrrpHU8UjOO4xNejmbdSo?= =?us-ascii?Q?2oZWRjSvCVqTQjhqh/hfNAGeVTV3m9wawbd57oCrKDeRK1OgU2hdH3/OLEU1?= =?us-ascii?Q?f/QlDIBgR+7VEXuSrYSOC5YUe/GCEY657OpYeTg38QzwnsCMjNzhqhZuFUMQ?= =?us-ascii?Q?znkWXutagoL1DBFlJy4aOawWP3cx7TqoXk8NI92w1TsjjJgUmKrOVg1I30D/?= =?us-ascii?Q?EoHtWDp0I76hLdpWtriQuDxiO63XpNB+6KqFL3dJ8sTY7fjGjiDm565u1ACA?= =?us-ascii?Q?hgKLaBwypFn751fr01yUgy0u0vmJtFk1aTA6TAXLoJ1BwcSRJGwB8llFJ0VD?= =?us-ascii?Q?LUTBBYFV/p9qB7aX2elG1YYM7u8+3A9f4nMoEapR3o605FqGlDwESqmMShLb?= =?us-ascii?Q?kdG3OGxuwq9XvOJ1awAat6u3oaLdtd/8IgQul5/nKJ9LRT+n85Owxnw1+/aT?= =?us-ascii?Q?ExmdPoFscA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3085.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75e2bfb4-8c3b-4879-66c6-08da1145ff4a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2022 05:35:55.8890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W7qf1o9bbv6LOM5gw9TRariAnucLI0n7Zy7c46vlcHml0Nq10bvkraYrcJC7dnsDVYUJ8jAWj+G7ONlZLf29tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5322 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only] > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Tuesday, March 29, 2022 4:21 AM > To: Varghese, Vipin > Cc: Thomas Monjalon ; > david.marchand@redhat.com; Tummala, Sivaprasad > ; dev@dpdk.org > Subject: Re: [PATCH] meson: update doc logic for Windows >=20 > [CAUTION: External Email] >=20 > 2022-03-28 12:29 (UTC+0000), Varghese, Vipin: > [...] > > > We did get error from `doc/meson` stating ` echo command not > > > available on windows` for both cmd and powershell for the line ``` > > > run_target('doc', command: [echo, message, doc_target_names], > > > depends: doc_targets) > > > ``` > > > > This line never searches for "echo" command, e8c90926bdde ("doc: fix > build on Windows with Meson 0.58") introduced "echo" variable precisely t= o > avoid this. > > Can you give the full log? > > > > > > Steps to reproduce the error: > > > > - Install dependencies doxygen & sphinix build on Windwos server > 2019. > > > > - Build DPDK with option enable_docs=3Dtrue for API or User Guide. > > > > > > > > This produces error > > > > ``` > > > > FAILED: doc/api/examples.dox > > > > sh -e dpdk/doc/api/generate_examples.sh dpdk/examples > > > > doc/api/examples.dox ``` >=20 > Thanks for confirming that the "echo" issue did not reappear. >=20 > [...] > > Are you recommending > > > > Windows libraries and binaries should be cross build from linux (where = all > dependencies and shell script works)? > > > > Or > > > > let us enhance the check for windows native build, if yes for option `- > Denable_docs=3Dtrue, we can stop the build for docs`. > > > > If the latter is suggestion I will share v2 patch to check the same. >=20 > I recommend enhancing the Windows native build by enabling full-fledged > docs generation :) I'm reluctant to accept this patch, even corrected, be= cause > it effectively works against better Windows support: > - it makes less meson code reachable on Windows, > allowing it to accumulate incompatible changes; > - it treats Windows as special, > while we want it to be a platform supported on par with the others. > That being said, the latter option is acceptable for sure, because it fix= es a > build failure in certain configuration. As stated in patch with Windows native build using meson `-Denable_docs=3Dt= rue` result in build error ``` FAILED: doc/api/examples.dox sh -e dpdk/doc/api/generate_examples.sh dpdk/examples doc/api/examples.dox = ``` ``` The reason is because shell script is not supported on Windows CMD. The sco= pe of the patch is addressing the issue `by continuing the build processing= with a warning to user`. IMO the current patch can be deprecated or removed from mainline one `once = full fledge docs generation is supported by native Windows build` as sugges= ted by Dmitry.