* [PATCH] net/mlx5: fix thread workspace memory leak
@ 2022-10-13 9:34 Dong Zhou
2022-10-18 11:48 ` Raslan Darawsheh
0 siblings, 1 reply; 2+ messages in thread
From: Dong Zhou @ 2022-10-13 9:34 UTC (permalink / raw)
To: viacheslavo, matan; +Cc: dev, rasland, xuemingl, stable
The thread workspace push/pop should be paired. In the "flow_list_create"
routine, if error happened the workspace pop was missed. This patch shares
the workspace pop for all return paths.
Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation")
Cc: xuemingl@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Dong Zhou <dongzhou@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/mlx5_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index e4744b0..6fb1d53 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -7028,8 +7028,8 @@ struct mlx5_list_entry *
rte_errno = ret; /* Restore rte_errno. */
ret = rte_errno;
rte_errno = ret;
- mlx5_flow_pop_thread_workspace();
error_before_hairpin_split:
+ mlx5_flow_pop_thread_workspace();
rte_free(translated_actions);
return 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] net/mlx5: fix thread workspace memory leak
2022-10-13 9:34 [PATCH] net/mlx5: fix thread workspace memory leak Dong Zhou
@ 2022-10-18 11:48 ` Raslan Darawsheh
0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2022-10-18 11:48 UTC (permalink / raw)
To: Bill Zhou, Slava Ovsiienko, Matan Azrad; +Cc: dev, Xueming(Steven) Li, stable
Hi,
> -----Original Message-----
> From: Bill Zhou <dongzhou@nvidia.com>
> Sent: Thursday, October 13, 2022 12:34 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread workspace memory leak
>
> The thread workspace push/pop should be paired. In the "flow_list_create"
> routine, if error happened the workspace pop was missed. This patch shares
> the workspace pop for all return paths.
>
> Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation")
> Cc: xuemingl@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dong Zhou <dongzhou@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-18 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 9:34 [PATCH] net/mlx5: fix thread workspace memory leak Dong Zhou
2022-10-18 11:48 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).