From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 892A3A04B5; Wed, 30 Sep 2020 16:54:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C34B1DB49; Wed, 30 Sep 2020 16:54:50 +0200 (CEST) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 2933B1DB43 for ; Wed, 30 Sep 2020 16:54:48 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 30 Sep 2020 07:53:55 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 30 Sep 2020 14:54:43 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 30 Sep 2020 14:54:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jbrSzqYH4ixTAOF2pTSAZvnLC/F07ebXShx4AigwOQfBeE4ict3x7/Eu7oFjgKaiVSqOZT0CNicntqtN/7ODGbqmWkR93oUPYArmLf+e2XARkyMUIch9w5b5hHylYUP93J61WVE2vmahXXinJR/Lk02sslxYUnJW1F8X31sYL93hcpM1etANW9KKEU3iZL6nu2vvoipa1tiX8XxEpN881bpGH5kwpZo75U4kyW8N66VpdZUZ5ccmQ7lMug7ruJwpgxFvRVe0HgF7XhFQWNLm1E/8sRZbSTvMTDWN9vRfe10hPLyfHMbWKHeSgEvsw0KXCUZiVg43Mn6ReiNj7/0XGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTUIdFHu28mq2EMKadtY0zuVHxY3xj3/3Ln6PgNodp8=; b=fIpLH5WcA07Xict6qwQ6IVF727H04945X33KOmo2pfMN2IlxKfkBIiREB4Aq/coV9TbVnwS51Rc6v7ALqyQTmvzg5im2h/eTSNXhnciXgcooJB78urruz7rO3FMBGWiXQaMptMnNpiuPA5Qe4/GNhaCmGNyjbhB0Upq4rHol90xjrpoy9ZkiByWI11Tod4ScdJXKIhxkWq640CqzK5QFkigyIKeqVA0h2EopBQ4AW9kgoDcYywZWDObe1E2b+q4GB4vzlNyyPnGYS0vq/At4WrHbcAiDRUS81MOLrTQgDvjd2QfpkOyHR7JXj7EfgBG7S94Cp4UhlsDBD8Lcl008Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4286.namprd12.prod.outlook.com (2603:10b6:208:199::22) by BL0PR12MB4994.namprd12.prod.outlook.com (2603:10b6:208:1ca::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.35; Wed, 30 Sep 2020 14:54:42 +0000 Received: from MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f]) by MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f%8]) with mapi id 15.20.3433.035; Wed, 30 Sep 2020 14:54:42 +0000 From: Ori Kam To: Dekel Peled , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [PATCH 03/10] app/testpmd: support IPv4 fragments Thread-Index: AQHWlzOEV8moELuOYk2RFtSSIybnAqmBRL2g Date: Wed, 30 Sep 2020 14:54:41 +0000 Message-ID: References: <1c0211586b73c14e58fa1da2d97077c3d950f717.1601474841.git.dekelp@nvidia.com> In-Reply-To: <1c0211586b73c14e58fa1da2d97077c3d950f717.1601474841.git.dekelp@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9a40bd0-cb95-4013-e7a8-08d86550c342 x-ms-traffictypediagnostic: BL0PR12MB4994: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bv82V7B9WOcQL5ndlJbkVtli6wIbFwH+D9q1iHdryX/qHvxKLo+YPGSRUT+GX9vTYkkGJ1gBeO8/A7itW5HS7NeYvb+v5hzFmAvM+P0gva7OVdjrlwOrb9Odtd5kwkWGmDNfL5Ap6RszSiM7ImSgljuf0ZT0fjOPX/RtHwfVwbohqP0GnDzGDcBAgvPKWzVos12GahIrKDmrLmpPBl9/1KDlwzO7yG6ZsIbhQcD32fwoD+HILHe+Dil1cEQ+LyG+g+fqdVK/pfqHbX10401hO2t7MRXWxSi/fofYzWy97Q8/IwzLBT8bHDS8gTFqgP1fLPXDYVMFTMrpAoDFf7LD+CuJPXddWyHvUic+igXKOTJDsJqmlrgLQ1S0Kcz7MWYm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4286.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(316002)(86362001)(71200400001)(478600001)(33656002)(110136005)(83380400001)(186003)(4326008)(66556008)(66476007)(8676002)(66446008)(64756008)(2906002)(52536014)(26005)(76116006)(66946007)(8936002)(9686003)(55016002)(7696005)(6506007)(5660300002)(53546011)(6636002)(921003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: uN/fRAdlyu2wU3WcXBk7aW/tx/P0MXIB/UvU3HIxlZPhKp6gN/glgVtVNZge5Ke+gTlOD6rnK58zya0AJNrBG86ANfvT1wFSkubEATIcnTR7IKjowoG6cbJrJhrc2Qeu5MQk69emj/f3a79A088nDFD0XujODdl2nbrXf+ZrbXjnl014mHmgk6/36j7GEG4T3QRp/o9FViq4P8JbvnWs9cNuNnJNRqsoPBk2Z+kczVV3ug5VNUuDSLv/WvUJB+sIgEnEno3ann54K005LxKpkSVqHNSbXkVibdTvtyxxk0JB6j+1/ckHHqJaNnEVv4sMeAAKw3N3WtyHVwqbTxne4mCC9cprJ8liw/3c1lVmGM2pemU82Dk5GVBdb3lYg02MBVJE047XeRThta14NY0Es4Sj0wgf5Gnq0A+laf45NchKsQw01MKWghSFzoEVM7feH0t4nSMonmJKzMXfGPBMyFoxILjaVxIhdOaLMuPWtUZNJE3HsScN/Pp9+xlVERfV8nUVilZ+dZwwtZdFrKZX3V4vJhPS12nznev/1kJ6v07/QIiPfpSjgAGF600VqXD+7cqwoeakJRLMau7VizzOU9y5G8XMPR3bA7DHVas03MVWPg9b8xiJCz6h+MpAD5g5X3DFlALvZ2CiyohdY01I/w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4286.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9a40bd0-cb95-4013-e7a8-08d86550c342 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2020 14:54:41.9212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qtWA4VGeqnDRP4UJjDMuomE/FRBMc7oKSk4+95s95VjHwjj6bNaz12na0lnk0w3VtsJG/meKSeA7LNfRdbjA4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4994 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601477635; bh=qTUIdFHu28mq2EMKadtY0zuVHxY3xj3/3Ln6PgNodp8=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=HxaXkrw+1KTe+Z0IBaMc6LcLP7O/aacQnUkfLg2SDtFsPJTfkYvWjdP8i6gVeoldc zlQUG+cFUmwNZxxCYQPdrq9xXaPFhJdztyswn7wGlaAfs4gJKDYJkdxjAoTLc24qg4 UKvJhyILT5zOtoU8jiARMv/1+75ltNkopuP9ts4euQNn6vd5N3F0OMwV7IB5SEvrHF ZYiXgIAmHF04Y+Wsh5ey6DgMjL8zlfk2mfiPDg5Ztd6v6/5uTCbujQNIEHEvGesC1R vnqPwbTojGhV6YugZpNt+m0IzL3iD5uPpsxMzBilVppwXjUro90owa2ySDa6SnJSzi q7NzHxchsva6g== Subject: Re: [dpdk-dev] [PATCH 03/10] app/testpmd: support IPv4 fragments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, September 30, 2020 5:10 PM > Subject: [PATCH 03/10] app/testpmd: support IPv4 fragments >=20 > This patch updates testpmd CLI to support fragment_offset field of > IPv4 header item. >=20 > To match on non-fragmented IPv4 packets, need to use pattern: > ... ipv4 fragment_offset spec 0 fragment_offset mask 0x3fff ... > To match on fragmented IPv4 packets, need to use pattern: > ... ipv4 fragment_offset spec 1 fragment_offset last 0x3fff > fragment_offset mask 0x3fff ... > (Use the full available range 1 to 0x3fff to include all possible > values.) > To match on any IPv4 packets, fragmented and non-fragmented, > the fragment_offset field should not be specified for match. >=20 > Signed-off-by: Dekel Peled > --- > app/test-pmd/cmdline_flow.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 6263d30..0c964c1 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -129,6 +129,7 @@ enum index { > ITEM_VLAN_INNER_TYPE, > ITEM_IPV4, > ITEM_IPV4_TOS, > + ITEM_IPV4_FRAGMENT_OFFSET, > ITEM_IPV4_TTL, > ITEM_IPV4_PROTO, > ITEM_IPV4_SRC, > @@ -871,6 +872,7 @@ struct parse_action_priv { >=20 > static const enum index item_ipv4[] =3D { > ITEM_IPV4_TOS, > + ITEM_IPV4_FRAGMENT_OFFSET, > ITEM_IPV4_TTL, > ITEM_IPV4_PROTO, > ITEM_IPV4_SRC, > @@ -2093,6 +2095,13 @@ static int comp_set_raw_index(struct context *, > const struct token *, > .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4, > hdr.type_of_service)), > }, > + [ITEM_IPV4_FRAGMENT_OFFSET] =3D { > + .name =3D "fragment_offset", > + .help =3D "fragmentation flags and fragment offset", > + .next =3D NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), > item_param), > + .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4, > + hdr.fragment_offset)), > + }, > [ITEM_IPV4_TTL] =3D { > .name =3D "ttl", > .help =3D "time to live", > -- > 1.8.3.1 Acked-by: Ori Kam Thanks, Ori