From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D660A09E0; Sat, 14 Nov 2020 18:41:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C8F5C88A; Sat, 14 Nov 2020 18:41:16 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 9F720C882 for ; Sat, 14 Nov 2020 18:41:13 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sat, 14 Nov 2020 09:41:15 -0800 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 14 Nov 2020 17:41:11 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sat, 14 Nov 2020 17:41:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRrZV9GB0AJ6mnOuZ65HVjggEVL2FkjKhI25jzkC6OwMFFCHe/Dx8u/4UIgKSY5NL1gCOQIh8xUkBZcBDdo0/zTtx2JispUWCf9LkT+dSZizJ3YFeLMhc/ltlbVSVHniQfrH2gIOgakZHF9Sb5HXLogpflhW7YmbOxJ64moXoG89eUI5LHvN/9vGvY1jyfY3W+3WMEHW/lE2DVKfRNP1kS/DWtszX7Vf6jAr/u/a6kfEvPriyxDLJ1ISI+8DtgePVGlYnIKoSgt4NhJdorGEovDBMNA/uvnhAJgkQr01mZ1uGnAIOXpuhUrdJg81tKL+G6cBW1NI1HkTYDiGyCUsnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=73sdYuVkImrpas+ygM6BAPn78tJHv2zWyzOK3zrUIvI=; b=Jy2GgOvvH+JuvyNmSHBMwv3snpymY9ZtWX4ZcBlVGDHM4dZf9quCILhk5SkQ5ezdk236hCcTqrm9kK9p0VVyYrdrOoXH1ZX+i/VxCdycBLHRw0mmrwvln3H+DkHq4s5GP8U0OhXHTYNkz0teg479Clj2M3G2HHUpzcAdwsHY3SdTdWQIwip5+CWXaNwkzQHcC34/+fcqYETxl3lLImirpY2EpsgJeTJ/UzeKkKl6F+JSi0VUD+u9X/A4ZToFvC2xDqRdX9qB3uhKa/9OGaoH6APuF7+G0dQLOG/yCgf6IS4T1YOAPAAr6s0DAVDwE3JJ5CE5s0lF/G872nLAJlX/Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4639.namprd12.prod.outlook.com (2603:10b6:208:a4::31) by MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Sat, 14 Nov 2020 17:41:09 +0000 Received: from MN2PR12MB4639.namprd12.prod.outlook.com ([fe80::e1c9:53d3:6bee:7ee4]) by MN2PR12MB4639.namprd12.prod.outlook.com ([fe80::e1c9:53d3:6bee:7ee4%6]) with mapi id 15.20.3541.025; Sat, 14 Nov 2020 17:41:09 +0000 From: Gregory Etelson To: NBU-Contact-Thomas Monjalon , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , Raslan Darawsheh , Shahaf Shuler , Asaf Penso Thread-Topic: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors Thread-Index: AQHWucyyqMqK6MOxrUuraGToZ9w0pKnHiZ+AgABa57A= Date: Sat, 14 Nov 2020 17:41:08 +0000 Message-ID: References: <20201113145231.13154-1-getelson@nvidia.com> <20201113145231.13154-6-getelson@nvidia.com> <2696445.BIzKWCxRHJ@thomas> In-Reply-To: <2696445.BIzKWCxRHJ@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [176.230.226.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 851ad55a-1b2f-43bb-8249-08d888c47897 x-ms-traffictypediagnostic: MN2PR12MB4301: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lNDA/Z459hj3p7dvDJu+I3x0V9cMoO4DYyebuVBbsRyCydgIabkegoKeevVhbOg4iX5aQW6aYsHCDZW/xM3GZmOx1tAdxUKIYnhE1CAEyRIXeQ7UUHZ64dkIG13St7h+6hv132ttNPXJBjvwf+ZOciq1C41imj4/KwjK7W+2SatZeT0QUZpHijTo9cx+3JKBi+kYBvyjT7LlFqdVCS/grvTZrWAlmzSVjQwipriQntHzlYGkpQymA5raaWgY3meIkQwFABs5Uqli6Za1ihJQrgWH8e+hAZo8WjB989crVTooYbb8tamAm4MZD2I6pq+j x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4639.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(136003)(39860400002)(346002)(9686003)(8936002)(52536014)(55016002)(86362001)(76116006)(8676002)(5660300002)(64756008)(66446008)(66946007)(71200400001)(4744005)(4326008)(316002)(66556008)(66476007)(7696005)(6506007)(2906002)(54906003)(107886003)(110136005)(6636002)(478600001)(26005)(33656002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: kx4dpFYliCY4o1KRoqTM3glGjbO1PNP/kavryJ1H+FCRcH964dFh0qi9VMAA6Q+TO3ol0mJBY5gO6tJ5/NRHSZ4fSCjYpj3na7WfREGX2JaWTePYwiK8ZRW0yFRacLMhoZEeSOnkLNqCh9MviRiufab6P5pMDejyeGpXQ2xyJqf+x+4aUn+EHlEdgzYolhThrt5UjU+rFyKY/TwyqtYAo0dmnQdU/wDvHx6JDMJDNPvixCsVldBdMgwzvadFSbOWrUom3dJfe14H416uVotOFYUjn2JmfCRH5bmv9isugtSteG+mewZTYaHhykBbk+AqyP/pQLsoDX4us+g7NoaYCZyC7/HEcT+ibz0wjPnQAcj6W3JzPNt1yWu8An24E7gGAiua0Q3L1fFpLJM2Xwl6U5DVbrAoqO7ErQiGAKQIcVu3ls4PYb20SwcYPuWzJjkEVS2Wx2F2PkK8DgjszLv+k5I8NNamQkbn30uDysmG/uB679w08NQ40yAffFHvc070WYVwFE5HhNArbSDUketHG298KNXPR39QNQz4shYPSMORjlBPE5gorbFBkxKtJaPDN2SWqvtg5XcMzARXjiWzjd0UcXVOGAxwp8+fGpMEGqG8GwPVE2k0Z1sB72BaT9gaPsbkVeHwH/LApiTYppY6vQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4639.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 851ad55a-1b2f-43bb-8249-08d888c47897 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2020 17:41:08.9548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fcc+5cCxQSA/8Jf8mBKBVjN0Ew/GaloENsJXSyKpSPhSFOzc2CgRjQZHanFrdl1zIZdwMK2y5ita1ZOlUzwv6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4301 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605375675; bh=73sdYuVkImrpas+ygM6BAPn78tJHv2zWyzOK3zrUIvI=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=jw3yogIK1VqG6zjHagxO3K3F49WsRGvXDivgQmyzK1van+u2Uj0eKqZNVKIbtAIM6 yB40wGnUmSLMb0JcMijAa28dMBRsWcHhSzSIz3GjG4fUwHXRrvrLRuFQl3VEo2OBt5 0YgGFfkFXGqVZ9tctukyT4UN+OwuABijVxL7YZ10BIC+R+3sai043T8FbcwFaxWSPe +pfLNFrvid/x5ypbsoYPDeaCXnqo1wyiqKlebpJOQ6iYrpzPaNMf4EbQQD+WhwfD0G mPA1Roma97SohBtGlNAVRRtBLRS0dx0QGLti7CIa3WuUA/nOv+0U1rczE+2WGhaEvh 9+lvmxZ4/H5Ig== Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 13/11/2020 15:52, Gregory Etelson: > > + ret =3D mlx5_flow_group_to_table(dev, tunnel, jump_data->group, > > + &flow_table, grp_info, error); >=20 > The parameter grp_info is a struct passed as value. > I believe it should be passed as a pointer. struct flow_grp_info is a 64 bit-field: =20 struct flow_grp_info { uint64_t external:1; uint64_t transfer:1; uint64_t fdb_def_rule:1; /* force standard group translation */ uint64_t std_tbl_fix:1; uint64_t skip_scale:1; }; Since mlx5_flow_group_to_table() does not change bits configuration, there is no need to pass this type as a pointer. >=20 > I see some other functions are passing arrays with [] syntax, which does > not make sense in parameters. I should be a simple pointer. >=20 I agree that arrays should not be passed with [] syntax. However, I kept existing rte flow style - see rte_flow_create > Matan, Slava, as maintainers, what are your policies in mlx5 code? >=20