From: Liron Himi <lironh@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
Liron Himi <lironh@marvell.com>
Subject: Re: [dpdk-dev] [EXT] Re: checkpatch failing on map change
Date: Tue, 17 Dec 2019 08:21:56 +0000 [thread overview]
Message-ID: <MN2PR18MB2398C8F28BD9E430713FD2B3C6500@MN2PR18MB2398.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8x3o=42rb0G5YZ_VS31p1gBqUjWJqam7=2K7YaBfVRonQ@mail.gmail.com>
Great. Thanks. Will send it soon
Regards,
Liron
-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Tuesday, 17 December 2019 10:15
To: Liron Himi <lironh@marvell.com>; Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dpdk-dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>; nhorman@tuxdriver.com; stephen@networkplumber.org
Subject: [EXT] Re: [dpdk-dev] checkpatch failing on map change
External Email
----------------------------------------------------------------------
Hello,
On Tue, Dec 17, 2019 at 8:36 AM Liron Himi <lironh@marvell.com> wrote:
> One of our drivers is using the rte_cfgfile and meson is failing on 'rte_cfgfile_section_num_entries_by_index' which is undefined.
>
> After a few debug cycles, I found out that this function is missing from the .map file.
>
> So I added it and created a patch but checkpatch is failing with
> ERROR: symbol rte_cfgfile_section_num_entries_by_index is added in the
> DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL
> section of the version map
>
> Do you know what it means and how to fix it? The function is not
> defined as experimental so I don't understand what is the problem
Liron,
The script can't tell that the symbol that was added in the map file is already part of the stable ABI: so it complains that a new symbol should first be marked experimental.
But in this specific case, we can ignore the check.
You can send your patch to amend the map file.
Cristian,
Can you double check this library symbols to catch other unexported symbols?
A quick grep shows that rte_cfgfile_section_num_entries_by_index() is not called in the current tree, we have no UT on it.
Maybe something to add.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2019-12-17 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 7:36 [dpdk-dev] " Liron Himi
2019-12-17 8:15 ` David Marchand
2019-12-17 8:21 ` Liron Himi [this message]
2019-12-17 16:23 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB2398C8F28BD9E430713FD2B3C6500@MN2PR18MB2398.namprd18.prod.outlook.com \
--to=lironh@marvell.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).