From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91365A2E8D for ; Thu, 5 Sep 2019 18:41:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6558F1BF4E; Thu, 5 Sep 2019 18:41:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 04C141EFAD; Thu, 5 Sep 2019 18:00:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x85Fxowo006404; Thu, 5 Sep 2019 09:00:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=3x8HZFeGv7zAiCqlqdM3PbcBB1wAyxnkdwfhrCbgMQI=; b=iwJQjEpNcXqdv7QvVI55tVq9v6g5k0Xple0+ujnHUsKAKdIdKXymemi5iEKgVRlTEROn h+9NwWP5aHnSp20BxK2A4LSqHOvE0sELg0b57yqItOWcFFHBZ3dFoQoRBARp3ORqvahG 0IrWzgxFQGC8hRaqQZ+Lzm4Il4UxHC/Bi33Q7iP7TE5LZhjC01saLm7j8+AE9YUGLn9h YdS7alALovBml6AZHGWloFD8WJX0+CeWnFoiBJesgGXhfn80Xz0HJkNEHu4zMqL34g4K OU9qkYNxQLJY+BQZjLSurhn+FkUHeGO8WYZANpOjrXlKQoJGFiJSBda5SzqPZHvpnyfG wA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2uqrdmk656-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 05 Sep 2019 09:00:30 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 5 Sep 2019 09:00:27 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 5 Sep 2019 09:00:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bux10wuiOM957Rfyys4PGTm4pXivP8Svh9flhOhxPgEGhIwaFabubfmVcSGUmhBHe0plvlkGyTsRtQRYt0ZTtdybSpcDFT+RvUtBau7w2ImCW1Q0wL3IXeVXJOEQUBbJFqqFIh2UGh60EkJ5qEMY6thkqUIyBb9pT33cyAY5OCuZOSOUxfvrccbRyNyN9O+U4moGfPFLftUvmJzN273MCIMgAtBuy7VmPFeipn+2E1XHRrrQl/ROra8YhwRMc1HYo1o2pEsqNyc0tSoUBgmrWZGwmL+OCDJHmcJgh1GA/k/PdQYpWzNee7F3EfG/yROMehSq9ggcTY7qReZoZKTHHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3x8HZFeGv7zAiCqlqdM3PbcBB1wAyxnkdwfhrCbgMQI=; b=kmOfBWdzUVn89uRtG/OxMIxqZ/PPTWWZlchUBSFjXIsef7t0K0XRkUVTXPSdvoTX7Y/HXWgYNiMQ3tVoEIz6VOddW52DXEfjGVkgX5X+Wsz3w0S3QPr+U4SfgjbJcakv6n4EpMrdrjX5qXJnsY1UwOQDOzR3zLLr8jHyLJ2xzYxNAeFem2tcd56kZHUm8iFL6csrfVjR566ctrfjWyDZAqMLPnpWIu9ixeioISGod02UBopsy5Fw+M1GD0ImGpW/aA5hwNvhTNetl1wtqWUgUdNfIPDggt9uUW6mGJKg0Xs+Dh56AOpTTmJGPoPR44ZsSrPlfE5ljNB2t1hN1RzlQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3x8HZFeGv7zAiCqlqdM3PbcBB1wAyxnkdwfhrCbgMQI=; b=DSQH6tRCYWgPc+J6xateiOkl6nTwClGsdYFnPdJctPF+4rDaThXFLELaOmX5XYaqBW/l8zgG5bm8qvDdIRNuobN3kwU3Wd57Y1Wc8FJJ+qM81NBwvcMivU631Bgw5ctJGzq752LVcAzKBJjDT0e4PKWT9ryZksHJ7JTlzsa0xig= Received: from MN2PR18MB2416.namprd18.prod.outlook.com (20.179.80.89) by MN2PR18MB2670.namprd18.prod.outlook.com (20.179.81.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.16; Thu, 5 Sep 2019 16:00:25 +0000 Received: from MN2PR18MB2416.namprd18.prod.outlook.com ([fe80::2878:45cb:94a4:1a1f]) by MN2PR18MB2416.namprd18.prod.outlook.com ([fe80::2878:45cb:94a4:1a1f%5]) with mapi id 15.20.2241.014; Thu, 5 Sep 2019 16:00:25 +0000 From: Ashish Gupta To: Ferruh Yigit , Fiona Trahe , Pablo de Lara , Shally Verma CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [EXT] [PATCH 07/10] compress/octeontx: fix global variable multiple definitions Thread-Index: AQHVY/mzV0zatZj8j0yW76nVoyN+L6cdOmMQ Date: Thu, 5 Sep 2019 16:00:25 +0000 Message-ID: References: <20190905145315.19395-1-ferruh.yigit@intel.com> <20190905145315.19395-8-ferruh.yigit@intel.com> In-Reply-To: <20190905145315.19395-8-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 52af4fe3-5fff-4b17-1fed-08d7321a2a03 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2670; x-ms-traffictypediagnostic: MN2PR18MB2670: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 015114592F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(346002)(136003)(39850400004)(13464003)(189003)(199004)(71190400001)(7696005)(71200400001)(102836004)(55236004)(14454004)(14444005)(74316002)(186003)(33656002)(256004)(6506007)(99286004)(110136005)(53546011)(66066001)(316002)(54906003)(478600001)(66446008)(66556008)(66476007)(76116006)(64756008)(86362001)(66946007)(26005)(5660300002)(4326008)(25786009)(8676002)(81156014)(6246003)(76176011)(81166006)(52536014)(9686003)(486006)(53936002)(55016002)(6636002)(6116002)(3846002)(446003)(11346002)(476003)(8936002)(229853002)(7736002)(2906002)(6436002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2670; H:MN2PR18MB2416.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 639LkZUZ1xXj6H58MAy8Uld/QG/UAQ96wPapWD5cOfN9gBlYEjeXftuNcmi12zlvrIamTwgB6+MyC9V0y2qZ1JOCxb9xJGexKwYSohUa/vPhGxAxS4O+qavkt2RAkH6ubTh9Rx2xxbh3sqhIhx0i/rWwWblbKqmVTOB3Wh0YykNaaDBQ4lSwyBDEMGZ6ivPatOf+RlHuvKQLtWPslbTbqnK0ihgsasiVVZHgFCB3yE4Njew5Z1X9/4Xg7382H2/JCUYC1ApXN3VwoPaT23RlpgQMrSGJ9MggYF6oGNeA66K4sHEckj2FxLYw/dXxyEMPOZrs/XetCdKhXmTK7yJ0dXZrZ5VyEghnycFIh+2QCpSxV43z9GeWn1aUIdjHVQHrhMbH49Am+8BMGXJV2634duCaR/i31vOeoJcpWH455LY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 52af4fe3-5fff-4b17-1fed-08d7321a2a03 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2019 16:00:25.0481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y8Pj4Aaezoh4PkNFvkd/3BCrvLsxGvbdljPAX7JX73er6wSl0EGEra5kS4Jc6jmIvN7FY4V/uW2ix9dHnfWf2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2670 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-05_05:2019-09-04,2019-09-05 signatures=0 X-Mailman-Approved-At: Thu, 05 Sep 2019 18:41:03 +0200 Subject: Re: [dpdk-dev] [EXT] [PATCH 07/10] compress/octeontx: fix global variable multiple definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, September 5, 2019 8:53 PM > To: Ashish Gupta ; Fiona Trahe > ; Pablo de Lara > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [EXT] [PATCH 07/10] compress/octeontx: fix global variable multi= ple > definitions >=20 > External Email >=20 > ---------------------------------------------------------------------- > 'octtx_zip_logtype_driver' global variable is defined in a header file wh= ich > was causing multiple definitions of the variable, fixed it by moving it t= o the .c > file. >=20 > Issue has been detected by '-fno-common' gcc flag. >=20 > Fixes: 43e610bb8565 ("compress/octeontx: introduce octeontx zip PMD") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/compress/octeontx/otx_zip.h | 2 +- > drivers/compress/octeontx/otx_zip_pmd.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/compress/octeontx/otx_zip.h > b/drivers/compress/octeontx/otx_zip.h > index 3abefd1dc..e43f7f5c3 100644 > --- a/drivers/compress/octeontx/otx_zip.h > +++ b/drivers/compress/octeontx/otx_zip.h > @@ -17,7 +17,7 @@ >=20 > #include >=20 > -int octtx_zip_logtype_driver; > +extern int octtx_zip_logtype_driver; >=20 > /* ZIP VF Control/Status registers (CSRs): */ > /* VF_BAR0: */ > diff --git a/drivers/compress/octeontx/otx_zip_pmd.c > b/drivers/compress/octeontx/otx_zip_pmd.c > index a1651b22e..9e00c8663 100644 > --- a/drivers/compress/octeontx/otx_zip_pmd.c > +++ b/drivers/compress/octeontx/otx_zip_pmd.c > @@ -11,6 +11,8 @@ >=20 > #include "otx_zip.h" >=20 > +int octtx_zip_logtype_driver; > + > static const struct rte_compressdev_capabilities > octtx_zip_pmd_capabilities[] =3D { > { .algo =3D RTE_COMP_ALGO_DEFLATE, > -- > 2.21.0 Acked-by: Ashish Gupta