From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 65A7C5398 for ; Wed, 10 Apr 2019 14:35:10 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3ACUJiv028756; Wed, 10 Apr 2019 05:35:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=LYGF9msuYEMTZiQm9aj8V9V7hf40LWhBQ1bWXk0DlBo=; b=JwNsLKKxqVIbzdNf7VEaosrRIDTOh4txVPvLWnwjq2qmWJ+tfTgmHZc97PuwYENcZ3hw kdl3k1g6XdZpXlUcMaXikDoetNf2+rO3cbxqxv45V5THW2PgJVfO0oJfLAna94G04SUS JtRNF72iDzX9DKxifyW+XxHVbVglysRZ9DrKGGRmQ+NcrQqS3x0krQIcwSWeAQC7GU3J 3WPB1GWRXCUQ7cLMwYUmYWvtpa35D4wEX+oW2UQ85tRkDk0GP4MYeShFQBfOsPn/Ls9W XECiJhhluBgbqIW1+hgKBQFqXF99++eV2IfYY8fXsG3RRI+aZ/qeZ+vyi9ClraEkwoEz 2g== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2rsggqr0xw-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2019 05:35:08 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 10 Apr 2019 05:33:29 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 10 Apr 2019 05:33:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LYGF9msuYEMTZiQm9aj8V9V7hf40LWhBQ1bWXk0DlBo=; b=SeTOX5woxkTR8AEBSwgSE1t+cgRJ1vHHWflzkJ2ILo9pwV+KlS3P8QucFRH2BS+5KqInKP8NuOYrLPZ1TNi5eq32rDAQK/MX4Fd4nNP7IIZa7p/+BknW20QSDGoWUwMV4eNCpV6vIfxFcbVvrXe+lb0qCNiGCplSYWX27xQIirI= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2544.namprd18.prod.outlook.com (20.179.84.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Wed, 10 Apr 2019 12:33:24 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90%6]) with mapi id 15.20.1771.016; Wed, 10 Apr 2019 12:33:24 +0000 From: Ayuj Verma To: Bruce Richardson CC: "akhil.goyal@nxp.com" , "fiona.trahe@intel.com" , "arkadiuszx.kusztal@intel.com" , "pablo.de.lara.guarch@intel.com" , Shally Verma , "Sunila Sahu" , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Thread-Index: AQHU7sgbOe99eNqykkejJ7mQ56SJHKYz6v4AgAFqH9U= Date: Wed, 10 Apr 2019 12:33:23 +0000 Message-ID: References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com>, <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b03839e4-aa25-4984-aba5-08d6bdb0b960 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR18MB2544; x-ms-traffictypediagnostic: MN2PR18MB2544: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-forefront-prvs: 00032065B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(136003)(346002)(396003)(376002)(189003)(199004)(105586002)(1015004)(68736007)(52536014)(606006)(8936002)(7736002)(476003)(966005)(478600001)(106356001)(11346002)(446003)(229853002)(66066001)(6436002)(25786009)(97736004)(14454004)(33656002)(6306002)(54896002)(99946001)(3846002)(76176011)(256004)(9686003)(2906002)(53376002)(5660300002)(7696005)(53936002)(99286004)(6606003)(86362001)(4744005)(486006)(55236004)(6116002)(55016002)(19627405001)(74316002)(81156014)(6246003)(26005)(71190400001)(81166006)(316002)(8676002)(54906003)(186003)(71200400001)(236005)(6506007)(102836004)(21615005)(53546011)(4326008)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2544; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: O9rE3xGkPkHfYCkNkY5mXwZMABbWMAxDjYfx/Yci7/kFiH62Gr6e+gXE9pzKF4NIw/Tn2rUZRuYH1Vckf+aNoxLZFNM5vrOli0BfPAIv8m4WKgDTsxX67lDVu670xZrnB7xVUwDVdkUiIV4znnK+yxN5Yv4byvB1NHJQ6VwvrBaPCgfjgsWhc9hQ0olbzsfyABSUwJYydY3UP0Sg6hnXAaTEE5JaAXOJmUFXL10taCysv8IWJNlhlio09qRt16dsThDvK0GV+yGBZk2awGx9gfTv582ZtSj5VAW6SCjbsdZkoe66oy2bm4rHl68/eISYodoZLNaYBRZYVM9NsGejqYWuhijmTHXkYOsW7LyG2HGNkPiQVhsHKNrC4Kbrcw62p4jSmo9/0Wvo08jPvSV5AHMMuqGqb9FCsP8QXGDPa9A= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b03839e4-aa25-4984-aba5-08d6bdb0b960 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2019 12:33:24.0046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2544 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-10_06:, , signatures=0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 12:35:10 -0000 Hi Bruce, Have you gone through patch-set v1 What's your opinion on them. Thanks and regards Ayuj Verma ________________________________ From: Bruce Richardson Sent: 09 April 2019 20:25:32 To: Ayuj Verma Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; arkadiuszx.kusztal@intel.co= m; pablo.de.lara.guarch@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga = Kotamarthy; Arvind Desai; dev@dpdk.org Subject: [EXT] Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED wit= h -ENOTSUP External Email ---------------------------------------------------------------------- On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote: > Return -ENOTSUP for unsupported tests > I disagree with this, since TEST_SKIPPED is the correct return value for unsupported test conditions IMHO. If part of the current infrastructure doesn't support that return value, I think the infrastructure should be updated. Ref: http://mesonbuild.com/Unit-tests.html#skipped-tests-and-hard-errors /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3E836A0096 for ; Wed, 10 Apr 2019 14:35:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB6F95F34; Wed, 10 Apr 2019 14:35:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 65A7C5398 for ; Wed, 10 Apr 2019 14:35:10 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3ACUJiv028756; Wed, 10 Apr 2019 05:35:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=LYGF9msuYEMTZiQm9aj8V9V7hf40LWhBQ1bWXk0DlBo=; b=JwNsLKKxqVIbzdNf7VEaosrRIDTOh4txVPvLWnwjq2qmWJ+tfTgmHZc97PuwYENcZ3hw kdl3k1g6XdZpXlUcMaXikDoetNf2+rO3cbxqxv45V5THW2PgJVfO0oJfLAna94G04SUS JtRNF72iDzX9DKxifyW+XxHVbVglysRZ9DrKGGRmQ+NcrQqS3x0krQIcwSWeAQC7GU3J 3WPB1GWRXCUQ7cLMwYUmYWvtpa35D4wEX+oW2UQ85tRkDk0GP4MYeShFQBfOsPn/Ls9W XECiJhhluBgbqIW1+hgKBQFqXF99++eV2IfYY8fXsG3RRI+aZ/qeZ+vyi9ClraEkwoEz 2g== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2rsggqr0xw-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2019 05:35:08 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 10 Apr 2019 05:33:29 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 10 Apr 2019 05:33:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LYGF9msuYEMTZiQm9aj8V9V7hf40LWhBQ1bWXk0DlBo=; b=SeTOX5woxkTR8AEBSwgSE1t+cgRJ1vHHWflzkJ2ILo9pwV+KlS3P8QucFRH2BS+5KqInKP8NuOYrLPZ1TNi5eq32rDAQK/MX4Fd4nNP7IIZa7p/+BknW20QSDGoWUwMV4eNCpV6vIfxFcbVvrXe+lb0qCNiGCplSYWX27xQIirI= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2544.namprd18.prod.outlook.com (20.179.84.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Wed, 10 Apr 2019 12:33:24 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90%6]) with mapi id 15.20.1771.016; Wed, 10 Apr 2019 12:33:24 +0000 From: Ayuj Verma To: Bruce Richardson CC: "akhil.goyal@nxp.com" , "fiona.trahe@intel.com" , "arkadiuszx.kusztal@intel.com" , "pablo.de.lara.guarch@intel.com" , Shally Verma , "Sunila Sahu" , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Thread-Index: AQHU7sgbOe99eNqykkejJ7mQ56SJHKYz6v4AgAFqH9U= Date: Wed, 10 Apr 2019 12:33:23 +0000 Message-ID: References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com>, <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b03839e4-aa25-4984-aba5-08d6bdb0b960 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR18MB2544; x-ms-traffictypediagnostic: MN2PR18MB2544: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-forefront-prvs: 00032065B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(136003)(346002)(396003)(376002)(189003)(199004)(105586002)(1015004)(68736007)(52536014)(606006)(8936002)(7736002)(476003)(966005)(478600001)(106356001)(11346002)(446003)(229853002)(66066001)(6436002)(25786009)(97736004)(14454004)(33656002)(6306002)(54896002)(99946001)(3846002)(76176011)(256004)(9686003)(2906002)(53376002)(5660300002)(7696005)(53936002)(99286004)(6606003)(86362001)(4744005)(486006)(55236004)(6116002)(55016002)(19627405001)(74316002)(81156014)(6246003)(26005)(71190400001)(81166006)(316002)(8676002)(54906003)(186003)(71200400001)(236005)(6506007)(102836004)(21615005)(53546011)(4326008)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2544; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: O9rE3xGkPkHfYCkNkY5mXwZMABbWMAxDjYfx/Yci7/kFiH62Gr6e+gXE9pzKF4NIw/Tn2rUZRuYH1Vckf+aNoxLZFNM5vrOli0BfPAIv8m4WKgDTsxX67lDVu670xZrnB7xVUwDVdkUiIV4znnK+yxN5Yv4byvB1NHJQ6VwvrBaPCgfjgsWhc9hQ0olbzsfyABSUwJYydY3UP0Sg6hnXAaTEE5JaAXOJmUFXL10taCysv8IWJNlhlio09qRt16dsThDvK0GV+yGBZk2awGx9gfTv582ZtSj5VAW6SCjbsdZkoe66oy2bm4rHl68/eISYodoZLNaYBRZYVM9NsGejqYWuhijmTHXkYOsW7LyG2HGNkPiQVhsHKNrC4Kbrcw62p4jSmo9/0Wvo08jPvSV5AHMMuqGqb9FCsP8QXGDPa9A= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b03839e4-aa25-4984-aba5-08d6bdb0b960 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2019 12:33:24.0046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2544 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-10_06:, , signatures=0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410123323.4Yj3LQiJgt3iQlQTcefL6Q-A2O8ZrcQfDgNPCwyo7Zw@z> Hi Bruce, Have you gone through patch-set v1 What's your opinion on them. Thanks and regards Ayuj Verma ________________________________ From: Bruce Richardson Sent: 09 April 2019 20:25:32 To: Ayuj Verma Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; arkadiuszx.kusztal@intel.co= m; pablo.de.lara.guarch@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga = Kotamarthy; Arvind Desai; dev@dpdk.org Subject: [EXT] Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED wit= h -ENOTSUP External Email ---------------------------------------------------------------------- On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote: > Return -ENOTSUP for unsupported tests > I disagree with this, since TEST_SKIPPED is the correct return value for unsupported test conditions IMHO. If part of the current infrastructure doesn't support that return value, I think the infrastructure should be updated. Ref: http://mesonbuild.com/Unit-tests.html#skipped-tests-and-hard-errors /Bruce