From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D1B7A0540; Tue, 14 Jul 2020 09:52:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4847B1D586; Tue, 14 Jul 2020 09:52:57 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 1B29E1D583 for ; Tue, 14 Jul 2020 09:52:55 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06E7nrju005875; Tue, 14 Jul 2020 00:52:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=BpvNXFx5jYycIo2Zh3hMoBTuujgrEPJVI0UQcUh5u08=; b=iU0Asl8dNHNKpAP+gVoEywv0+lCZp9BiRt9fjMDbgLxqJqpeTNRn2qe9ug3TM1L86WGT xnhU5tyQiZs9NAiGTpRxLVCqs31LYzMm8CbNO+FFZIVd/e2L/Y/WA5jBVYNpivZILik3 nSV4df37xdMaAaOpUR7Mn7uQxgWCWjMYrnLMtTWHOs7EV6yOWZX3YMRkzEbQ/nZFGn/o 44oMlthf+ty2NJwMIGqwcghiOiQOnueaADrjU/B3QzOgrDO+Q8MFU4zJ5jSZO/FcNk4p V0HBCzENGx29O/QSxWIiLC3mRAIk0Lzor2WgI+Nx0MQgpehSuNegClGyuQYk9clT4I7a 8w== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 328mmhmhq8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 14 Jul 2020 00:52:54 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Jul 2020 00:52:53 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 14 Jul 2020 00:52:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXvdXPwIsx9xmcfKLviUwX/QozbKwHX74kFF0d/E9bFDftKdPkb6OiS9B2chAhL+KhRLgvsP4veGDotjh7oY3/YRtbqQM/up2xt5K3MBXpYCXpe7BtuFoScM4cVdPprYWa8+eT8Wqp5/ISIJTca1VVXRVhTcxM9WbGO3hbxzFfczELXPcYc5/bhPAPkBE74Prd9FZHf5swlB9X84tqEoLx1ImnKgkbrVeiLHNYC44g+rM9zrnnPoba3osBgXtAg1iER1aIGIOgD/L7RTDZw+YUQYiNDmaZb+OlRshdnta83U0BY5X4FLQiao0qTAB+MqxcBHx14jjt8aYmGkvVSn4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BpvNXFx5jYycIo2Zh3hMoBTuujgrEPJVI0UQcUh5u08=; b=DpiFc9GqRRvFOg96jpva/mkJpDFOMYINrU7qWtJtB53tE90AyiJ+mwjb58YWtS+dYhqNTGdTKQfhAvQ1lLc7DyVuxAetww23EcLqFVDHAyhpswzz6zhKk0ZtzLhRmRthrG4n0fk6q8BJO9x9/YetxMdcWA6tLIIpl8YKZETBnKdQHYOH1t1lSfrvYDBtucb3LIqS/IaYce6bWOi+of4y3cr7hOE5yw2R7wUYQeqv5Ta9ZFx8tFWgleOuSvKtWOb/5khdBT96Pgn77vk189jvNpnylzGWmA/H/8B9Zr2oDr3lvaJuLcQKC/ZW6P2t5aesU3cF7BnoQI5u3pzbRYjTRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BpvNXFx5jYycIo2Zh3hMoBTuujgrEPJVI0UQcUh5u08=; b=f8GcQk2KdFNBKZEc+ON9Pw8bpNh1755A9Fs0HBW8ZvIJsvjFJjW8ziv5JLCbNqB1Qdc/lTwC42cGWUr8c4n8feiMbGzJ6BoE1vH00Hsv+7QBKKJ+0pe/SEB8pFhV8p3ZG5dyW+WG/AmjzaXo55R12Jb+0MUu7j3P5d9Szx3DHpA= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB2880.namprd18.prod.outlook.com (2603:10b6:208:a1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Tue, 14 Jul 2020 07:52:49 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::a975:5b17:ebb4:722a]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::a975:5b17:ebb4:722a%4]) with mapi id 15.20.3174.025; Tue, 14 Jul 2020 07:52:49 +0000 From: Anoob Joseph To: Akhil Goyal CC: "declan.doherty@intel.com" , Hemant Agrawal , Vakul Garg , "dev@dpdk.org" , Ankur Dwivedi Thread-Topic: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector Thread-Index: AQHWWbPFsIxAvgnddUm7hqq89jY3SA== Date: Tue, 14 Jul 2020 07:52:49 +0000 Message-ID: References: <1591345833-19159-1-git-send-email-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [157.46.209.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0702ca75-9b78-45e1-9a13-08d827cae7a5 x-ms-traffictypediagnostic: MN2PR18MB2880: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4AJ4tb2J4ocWD8UDw+M/gHtqaLzY4ydY8IWv5FSDAUqyw751XJPHpoNsKzI3gGkl77D5FRWuzGAoLnGLWtJkB1lBh5XiZ1ALaH0u55lmmpv796o8nkVVGsdVK0V0abNZPZ23Uz8hQSpsHy3VavkaGMbZ+bA6ar+0LN+LS7fKPf3T3N+qLTpStbxBZlY3FWAoz1Ad6cBg3IBCOYhSV++nb0e5DxWrnl8tZBOOMeKceKV4iC1uyyzmZ8oHkOROB/iKCK04LilsYFo8/EptKR5eHFl+Icts4IHhyItKrnyBK9pIsuds1Xxz5EOCF0NhGEcdkIylRApBhFXHe6JrSXuFPA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(66446008)(55016002)(4326008)(9686003)(8936002)(33656002)(6916009)(5660300002)(53546011)(6506007)(186003)(86362001)(7696005)(52536014)(107886003)(26005)(71200400001)(478600001)(316002)(54906003)(76116006)(66476007)(64756008)(66556008)(66946007)(2906002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: GSRecKBZFENB/r9bfUkYc6TCbPNiGIQyLT5sGFHVRE0KfVp4sNUs1NXWfmuWY54sT/FUfxmgVAIB234ma0JMBEWLu21pxxePaO8WTVG9yQQhvhprJvsPwVe93OUUe4aH5YPjB+QOEnh8v5n3XVZN3gC6ML917Ha8pJZBivJiYvkHupDl3coDKdB+d/5p9vOgyQ7vHEHGdX9BdH60qxi4Opu5FgM7ovXqATVOJPRaJPv7ww3JQJEdTH688wLjbjvMVvaKY3OLCATILaNgdrbJA43KJ2UDj7okv4YXl4oMo8f1bxSRwF9XFxeekNwwGeyj7BkYAlfKfs3lj3OoxhCsGETNFFnUzxClYBbiCHoo9yVzV4TQ1//CNyJaEsY4+aR63yQy7yuW4RbbTmA2EZKm+c/eM3Gy2xfFRtLbCL3fVHKJuj6YXctlUpdbaRrBpBWcWmg5iyW96JBAgOFFQa62EEyrjaaAt0aebKfqPP86qzk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR18MB2877.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0702ca75-9b78-45e1-9a13-08d827cae7a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 07:52:49.5272 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: svj8iwU29Z5OG4yXQ225K4FRxIXDSdw4julR1Hp8LZ8ewxcKbA9cs2kvfp1sx08I4uH4/z6PqIPNdhAwPAGVHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2880 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-14_01:2020-07-13, 2020-07-14 signatures=0 Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Did you get a chance to look at my comments? Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Wednesday, July 8, 2020 3:21 PM > To: Akhil Goyal ; Ankur Dwivedi > ; dev@dpdk.org > Cc: declan.doherty@intel.com; Hemant Agrawal > ; Vakul Garg > Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn > vector >=20 > Hi Akhil, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Wednesday, July 8, 2020 12:51 AM > > To: Ankur Dwivedi ; dev@dpdk.org > > Cc: declan.doherty@intel.com; Hemant Agrawal > ; > > Vakul Garg ; Anoob Joseph > > Subject: [EXT] RE: [PATCH] test/crypto: change cipher offset for esn > > vector > > > > External Email > > > > ---------------------------------------------------------------------- > > > > > >> >Why do we need this change? > > > >> >The existing test case is to demonstrate a generic case where we > > > >> >can have an auth only trailer as well. It is similar to a case > > > >> >of IPSEC ESN but not exactly IPSec. Cipher offset can be > > > >> >anything as per the app > > > >requirement. > > > >> >I don't think there is anything wrong in the vector. It should > > > >> >pass in every hardware without any issue. > > > >> [Ankur] It's a limitation in OCTEON TX PMDs that the (encr offset > > > >> - auth offset) should be 8 bytes aligned. > > > >> In the IPSEC ESN scenario generally the offsets will be such. > > > >> But in the above IPSEC ESN test vector, this requirement is not > > > >> met and hence the associated test cases fails on the PMD. > > > > > > > >In that case, I think it is better to have a separate test vector > > > >and both should be executed. With the previous one as not supported > > > >in your case and this one will be supported. > > > [Ankur] The offsets values are present per crypto operation. So to > > > make these tests as unsupported the pmd datapath needs to be > changed. > > > Is there an alternative to make these tests unsupported? > > > > I believe this is a data path error and a limitation in your PMD. > > You can not stop the application writer from using unaligned cipher > > offsets(non-8 byte aligned) >=20 > [Anoob] Yes. But the typical case with IPsec is what is supported in the = PMD. >=20 > > > > This is just a test application, which may hide your PMD limitation by > > accepting this patch But in actual the scenario will fail when some > > user configures a 12B cipher offset. >=20 > [Anoob] Agreed. But autotest having a failure is not an ideal situation t= o be it. > Especially when it's not the typical usage. Can I propose to add a field = like > "Know Issues:" in the summary field? We can add a check for OCTEONTX > PMDs in the test case and mark it as a known case. I do understand that t= he > vision was to remove all driver specific tests and have generic tests for= all > PMDs, but here we are left with no other option. Chances are, other PMDs > also could have similar limitations when moving to generic framework. >=20 > If you have suggestions to skip this test in any other way, that would al= so > work for us. >=20 > > IMO, you should add a new test vector instead of replacing this one > > and it should Be OK to have the existing one fail in your case. > >