[dpdk-dev] [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt

[dpdk-dev] [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt

[Archana Muniganti]

In AEAD decrypt(verify mode), test data should point to
cipher text instead of plain text

Fixes: 5b2b0a740fba ("app/crypto-perf: overwrite mbuf when verifying")

Signed-off-by: Archana Muniganti <marchana@marvell.com>
---
 app/test-crypto-perf/cperf_test_verify.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c
index bbdf37d..833bc9a 100644
--- a/app/test-crypto-perf/cperf_test_verify.c
+++ b/app/test-crypto-perf/cperf_test_verify.c
@@ -203,11 +203,19 @@ struct cperf_op_result {
 {
 	uint32_t segment_sz = options->segment_sz;
 	uint8_t *mbuf_data;
-	uint8_t *test_data =
-			(options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) ?
+	uint8_t *test_data;
+	uint32_t remaining_bytes = options->max_buffer_size;
+
+	if (options->op_type == CPERF_AEAD) {
+		test_data = (options->aead_op == RTE_CRYPTO_AEAD_OP_ENCRYPT) ?
 					test_vector->plaintext.data :
 					test_vector->ciphertext.data;
-	uint32_t remaining_bytes = options->max_buffer_size;
+	} else {
+		test_data =
+			(options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) ?
+				test_vector->plaintext.data :
+				test_vector->ciphertext.data;
+	}
 
 	while (remaining_bytes) {
 		mbuf_data = rte_pktmbuf_mtod(mbuf, uint8_t *);
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt

[Anoob Joseph]

> -----Original Message-----
> From: Archana Muniganti <marchana@marvell.com>
> Sent: Thursday, November 21, 2019 4:44 PM
> To: akhil.goyal@nxp.com; pablo.de.lara.guarch@intel.com
> Cc: Archana Muniganti <marchana@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt
> 
> In AEAD decrypt(verify mode), test data should point to cipher text instead of
> plain text
> 
> Fixes: 5b2b0a740fba ("app/crypto-perf: overwrite mbuf when verifying")
> 
> Signed-off-by: Archana Muniganti <marchana@marvell.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix incorrect input data for AEAD decrypt

[Akhil Goyal]

> >
> > In AEAD decrypt(verify mode), test data should point to cipher text instead of
> > plain text
> >
> > Fixes: 5b2b0a740fba ("app/crypto-perf: overwrite mbuf when verifying")
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto

Thanks.