DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dependency on core 0
@ 2020-03-30 14:55 Lukasz Bartosik
  2020-04-01 10:39 ` Anoob Joseph
  0 siblings, 1 reply; 4+ messages in thread
From: Lukasz Bartosik @ 2020-03-30 14:55 UTC (permalink / raw)
  To: akhil.goyal, radu.nicolau; +Cc: konstantin.ananyev, anoobj, pathreya, dev

If core 0 is not included in coremask in event mode then
ipsec-secgw seg faults. This fix uses first core from
coremask in rx queue configuration instead of core 0
which was always previously used.

Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
---
 examples/ipsec-secgw/ipsec-secgw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index ce36e6d..5fde4f7 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -2643,7 +2643,7 @@ check_event_mode_params(struct eh_conf *eh_conf)
 		params = &lcore_params[nb_lcore_params++];
 		params->port_id = portid;
 		params->queue_id = 0;
-		params->lcore_id = 0;
+		params->lcore_id = rte_get_next_lcore(0, 0, 1);
 	}
 
 	return 0;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dependency on core 0
  2020-03-30 14:55 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dependency on core 0 Lukasz Bartosik
@ 2020-04-01 10:39 ` Anoob Joseph
  2020-04-05 16:43   ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Anoob Joseph @ 2020-04-01 10:39 UTC (permalink / raw)
  To: Lukas Bartosik [C], akhil.goyal, radu.nicolau
  Cc: konstantin.ananyev, Narayana Prasad Raju Athreya, dev


> 
> If core 0 is not included in coremask in event mode then ipsec-secgw seg faults.
> This fix uses first core from coremask in rx queue configuration instead of core 0
> which was always previously used.
> 
> Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
> ---
>  examples/ipsec-secgw/ipsec-secgw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Anoob Joseph <anoobj@marvell.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dependency on core 0
  2020-04-01 10:39 ` Anoob Joseph
@ 2020-04-05 16:43   ` Akhil Goyal
  2020-04-05 16:47     ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2020-04-05 16:43 UTC (permalink / raw)
  To: Anoob Joseph, Lukas Bartosik [C], radu.nicolau
  Cc: konstantin.ananyev, Narayana Prasad Raju Athreya, dev


> >
> > If core 0 is not included in coremask in event mode then ipsec-secgw seg faults.
> > This fix uses first core from coremask in rx queue configuration instead of core
> 0
> > which was always previously used.
> >
> > Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
> > ---
> >  examples/ipsec-secgw/ipsec-secgw.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dependency on core 0
  2020-04-05 16:43   ` Akhil Goyal
@ 2020-04-05 16:47     ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2020-04-05 16:47 UTC (permalink / raw)
  To: Anoob Joseph, Lukas Bartosik [C], radu.nicolau
  Cc: konstantin.ananyev, Narayana Prasad Raju Athreya, dev

> >
> > Acked-by: Anoob Joseph <anoobj@marvell.com>
> 
> Applied to dpdk-next-crypto
> 
> Thanks.

Squashed to the original patch which introduced the issue as it is not submitted to master branch yet.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-05 16:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 14:55 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dependency on core 0 Lukasz Bartosik
2020-04-01 10:39 ` Anoob Joseph
2020-04-05 16:43   ` Akhil Goyal
2020-04-05 16:47     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git