From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFFCFA052F; Wed, 29 Jan 2020 19:10:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E94C1BFE1; Wed, 29 Jan 2020 19:10:16 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 8F65D1BFE0 for ; Wed, 29 Jan 2020 19:10:14 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00TI6NGt010708; Wed, 29 Jan 2020 10:10:13 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=e5xHkcGGlCLDpPBEqeBJH+F4KfJw6+DLZ4Cn8GaEc88=; b=ou6LMLFnV1k91VLZdPXYRP7HNVuv5S4osbUNFaJXvHbsyUnrFq8F0dsiUU4UkZCjxFrF +pQ/6h6sJQkYUvN8VwwEVpIvDnXtizUSXLSAk0/b7QSg8wJL5ByPDX427GXixh7k2l8d pbJiVal8h2p1weaWe+Dgtwal+6r0jvhomAs69yLXD/yWt5p+sFw2OBB+p+DSCSI6BAsl aNtAxNNrNQMSmqdbA3dyBeONUAuVbTgPeqkRz35e3pegsm3fasWk6MTGch1tNwkQur/i CtxKE/NkDaNPaKU55VFcHbkQZLtz1aluYGL4nE4u1vcFmfg9ihDNQglOl65oe9e5K0ia qA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2xt6bt1qcy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 29 Jan 2020 10:10:13 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Jan 2020 10:10:12 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 29 Jan 2020 10:10:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TPvrQ77ALI4kwI82rlWK3xLF77JPBXZZoFSdDkYY45P8B7+JCrqudM7w39H2bnXm/lIwcHOfEpP0B3x8+ywKjRMCNo3HWoc2PKZS9CEyHNYxtv/TcHOZIXLmnX3mpfVwh629ZyqlqsWJH7aenxsSGkqKhlAKZvNQt/vbCJowTtV7mOgu/4bWPs23Z2yOmopEa84dWDF1s8exGghQtu9z7433+jDGWRhnLxu8qgIE+E/ceFEMKewz03kiHpOlN7saBjeqC0sWregG7ytWIzrPbK2jWtU3Lo9szEX8B2uPH3M17Lm3wfhkoJ3yLJBAO10PdjTXDVSPFDHVntTgvdEF+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e5xHkcGGlCLDpPBEqeBJH+F4KfJw6+DLZ4Cn8GaEc88=; b=PhyN/9kia/U34VwvalKoReIWUzJsa7IPOeH0+uBhZKi6oZxBgGqMyo7eA/TV6a+3VvPgHjAmSF9/PuMdL6cM0/x7RmErPkGiPB+fe9MkhpEvC2jRFPrWj1RsM3zIK7r6VDYomIBuFs4d5+e7G4gC3fWLU/CCO0iv6NyZuldOgtk/VBeb1wCKGn8HOmP5r/ut4GiEcbHEcqMG6SYQ7Gha5V6BcioFbnB9Kl+KTLM+FWr/XsY6TDEcddqLlP4GWSV0lpxwvRslyzSDxQropneku0mYNE/7aEPk+9814pxnWzXrlPwGGFi3uTY5N+wh0CDV3P53kAtnmj6dzXnEsq4uQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e5xHkcGGlCLDpPBEqeBJH+F4KfJw6+DLZ4Cn8GaEc88=; b=jRvxUBUg0NQ6yJFYzWWxRKIWISkPm8my5cPn29raZvBx7Opnf01IWgS6IgsqEaLbmScpY4BPNjLYQ4P3uv5Y/WQOrRUvKsTD+KepUopxw+CBbxso5L4dQmrUvBYmfaS8oI31T88yqlkjQvS173J+YUqLgKadqP09mFWa6Jd12mY= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB3102.namprd18.prod.outlook.com (10.255.86.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.23; Wed, 29 Jan 2020 18:10:10 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572%7]) with mapi id 15.20.2665.027; Wed, 29 Jan 2020 18:10:10 +0000 From: Anoob Joseph To: Thomas Monjalon , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" , David Marchand , "bruce.richardson@intel.com" , "nhorman@tuxdriver.com" , John McNamara Thread-Topic: [dpdk-dev] [PATCH v2 4/4] add ABI checks Thread-Index: AQHV1suSb70PYc0vsUm5IbxHuQtV1qgB71vw Date: Wed, 29 Jan 2020 18:10:10 +0000 Message-ID: References: <20191220152058.10739-1-david.marchand@redhat.com> <20200129172621.28565-1-david.marchand@redhat.com> <20200129172621.28565-5-david.marchand@redhat.com> <1827847.CQOukoFCf9@xps> In-Reply-To: <1827847.CQOukoFCf9@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.250.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c388683-e580-430e-4ede-08d7a4e67a90 x-ms-traffictypediagnostic: MN2PR18MB3102: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 02973C87BC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39850400004)(136003)(346002)(376002)(366004)(199004)(189003)(316002)(54906003)(53546011)(110136005)(6506007)(9686003)(5660300002)(186003)(52536014)(8936002)(66446008)(64756008)(66556008)(66476007)(66946007)(81156014)(8676002)(81166006)(76116006)(55016002)(26005)(7696005)(33656002)(4326008)(2906002)(86362001)(478600001)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3102; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dR63pPOKCrXiX6A36uHR8IN6bSJY4nIOmVm2FSaCbtqzkSpD7G5yUMEW9eIj1EEzMZnNB8cZHtYsJVLhSMTMLe74vtMSZVv/5FB9XUuPfgtjdV+P74iSYaiqqmCPFS4Py9NOFZmy/XZSklsF5f2e/xem/fGegVUvHbDM5QN5xaiRIF5Hf6X/g0P5IV3VAjZZXawgcepSvrRLhL9lf6wruWnNhhpjgNfTziHfmP52vmEbwwcmlAYzgOaIGDEVqHXfsuXUTEaiUFzTCZHhu/6ZV/cWrjTwOKhcKKBN9JDslKYZWilq2sNn8Bud90WqLEGExESTlfeIvy3mPLaPEfW6igIchFw2kVi7ADjrm03Qv4hab/SZy4uGitxUdO2b3CRyZ3+rNJfbAwzV4nzhalEF+qTVg2HniFxLafg7EV0sf9nShFPw/osKeqGpXejfHYlj x-ms-exchange-antispam-messagedata: ITinYuY5puFrt3QkboczFZsNmLXYDDlrVskPt4JGy+gUyclsLw7Ek63mJzTRoOty4y/alk8LO/mLh6cZXG2ZyrUQg0gzbXOC0Fljx9f8yqs/tnXBvKbv3T7VMoLTbTVqsa8d5Gh+5l6tADfhPt92fQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7c388683-e580-430e-4ede-08d7a4e67a90 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2020 18:10:10.1046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: osB/0jrOAwlm4q8Dgo8gryVeF/KuD/sUDkD5gtFzwjXZZUyaC/Yi1kUO1k2M7D8RucFdtLMW2uUXiwDIE1f19A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3102 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-29_05:2020-01-28, 2020-01-29 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, The asymmetric crypto library is experimental. Changes to experimental code= paths is allowed, right? Also, I was wondering why changing the LIST_END would cause breakage. Befor= e we introduced the ABI checks and ABI freeze policy, it was always allowed= to add enums to the end. I'm just trying to understand the real impact of = this case. If we don't allow the LIST_END to be modified, then it means no feature can= be implemented in between. And the best way to overcome that would be to j= ust remove the LIST_END or set LIST_END to a very high value. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, January 29, 2020 11:13 PM > To: akhil.goyal@nxp.com; Anoob Joseph > Cc: dev@dpdk.org; David Marchand ; > bruce.richardson@intel.com; nhorman@tuxdriver.com; John McNamara > > Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks >=20 > Anoob, Akhil, >=20 > Please we need to revert or fix the ABI breakages in cryptodev very soon. > The FIXME section below must be empty. >=20 > Thanks >=20 > 29/01/2020 18:26, David Marchand: > > We currently have issues reported for librte_crypto recent changes for > > which suppression rules have been added too. > [..] > > --- /dev/null > > +++ b/devtools/dpdk.abignore > > +; FIXME > > +[suppress_type] > > + type_kind =3D enum > > + name =3D rte_crypto_aead_algorithm > > + changed_enumerators =3D RTE_CRYPTO_AEAD_LIST_END > > +[suppress_type] > > + type_kind =3D enum > > + name =3D rte_crypto_asym_xform_type > > + changed_enumerators =3D RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > > +[suppress_variable] > > + name =3D rte_crypto_aead_algorithm_strings >=20 >=20 >=20