From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D8B8A0562; Fri, 3 Apr 2020 12:28:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A22481C0D6; Fri, 3 Apr 2020 12:28:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 886DA1C0D4 for ; Fri, 3 Apr 2020 12:28:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 033AQaHd018218; Fri, 3 Apr 2020 03:28:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=SzChFj2NLub4erUvhQhWWDCzr6Dv8RHJvqBqLY8sabI=; b=rn5CuMihhY+iWrp5E3pKbrNjxbcnFWne6siA6nnIAWYrQgzpsoonKlON3+vK5H0bgQEq yh1LSt1kjwI/mtbvW+JXAAEooDAahnxgaGw9/+gWKobDryfEy/ihFf6t2F9e9ZQn5Rsx cAhEHNbJM8nwwavdT0bvpIr7qF6OR7ShAveMhnqxyazEcLpQLy8z/g6CGix/v3vGt2Q0 ClCkacd1xFuqlqqRlDKrDzDN+viZr22xuJCVUABTFTslKHO/vEiuxq4gOqOOWrvp7VzI a9Sa5Rog2e6/zl1qQVDQzguU/99VaMMjfidTeQBBN6wrf3jGJjd8qyyvcQT2DLKwRG8X UQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 304855x6ny-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 03 Apr 2020 03:28:29 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 3 Apr 2020 03:28:28 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 3 Apr 2020 03:28:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JmiRZHd4j2J9KYDKYFTJerjN/PrdVnf784ecqrvs27AdP+fheSeirHlcy+4EiG470WAQGfEnmPbq+8gd7x1in8smkNnc/ka+cMat10jnWQIxqqnoJbE1su9qFgnrmdODfdk1aZ4gKkCJb66IQaqWEyacKZej+QTHXanCyzdLKvbqRgJ8EfO2NBxJZZvHaWEE3BaZBS/ZfTXzpBqCKVTgRL/TyclA6YkpDElRrxZXE1fW0jrCh8zVouQH4jNBGMDBT/yLEcyNxMhSKH/BEg4uJc/3JMs3W+oztx6SGKGb9PsWWGYO6t2RVaU9NNEdYMdIzEsA7yI+7gp061jUTy6XUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzChFj2NLub4erUvhQhWWDCzr6Dv8RHJvqBqLY8sabI=; b=SH2VKkFXPYi6BwdV+oPv7dD58EiGPXmC871huvS1AkLXLJYsrJ1/jTGrtIUBicm98E/M/nR43VPhsqVGHB4VwLwmxWcNxG+urohLXxaCOMA4nlZwgEpcMH/hekz+v5EDA/kKcswHlhLEloSKz7yc0Aw1zLBOKiMFwmP+ohfZPw424AYKAKAL4CCHkSlB0kvL8DoNRDDso8oLvj8IfyLfR/hmrxP83wodm0hIG3l7BqP1XTPtyO0YGO7yRSbyE3UzXwqJFuyhVpVlGDXYlxGs2CFEMxgBl7LY8nMrqPWR28j86hyxm+ULtzfuPUzSBiJC0c6FoAfGUuyRrvkA6qARzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzChFj2NLub4erUvhQhWWDCzr6Dv8RHJvqBqLY8sabI=; b=LVqJ6vJwYNLEi0xd++CHxhXh8IVd7hypZY0IS8ll6VGc7pkizp5f4GjvRWroPaJK6/ShnuEKCWphCANBwUrOzbLBSZQCa/xn5HfFm65jFEYW3jNHdKIg1Np6VZNl2I2hZ/IO/xYrUh7EqyQfGhTxHT+qYLvrQ6txmj9u/OQuans= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB2528.namprd18.prod.outlook.com (2603:10b6:208:a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.19; Fri, 3 Apr 2020 10:28:26 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2878.016; Fri, 3 Apr 2020 10:28:26 +0000 From: Anoob Joseph To: "Shetty, Praveen" , Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" CC: "Iremonger, Bernard" , "Ananyev, Konstantin" Thread-Topic: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature Thread-Index: AQHWB1yomOe+1JBZ9km8ZL+21y33gqhlzcFQgABTswCAALv1gIAAC+SAgABLPwCAAAD48A== Date: Fri, 3 Apr 2020 10:28:26 +0000 Message-ID: References: <20200319162145.28906-1-praveen.shetty@intel.com> <20200331130211.24761-1-praveen.shetty@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.244.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7d672cd-753b-4a1e-e7ae-08d7d7b9bebd x-ms-traffictypediagnostic: MN2PR18MB2528: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0362BF9FDB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(346002)(376002)(366004)(39850400004)(136003)(396003)(52536014)(33656002)(5660300002)(55016002)(86362001)(66946007)(66476007)(66446008)(66556008)(64756008)(76116006)(81156014)(8676002)(8936002)(81166006)(2906002)(71200400001)(316002)(6506007)(53546011)(186003)(9686003)(4326008)(54906003)(478600001)(7696005)(110136005)(26005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fL8zqGBBgf4wVHPaYZ1kbk/h5ze3SoErgQDp3+LUvWf/T0iI5sLN8BsxxL7nYQKXpGvqDsSsyF9YIpYqRLt6FPdf7ykUzR9qFUcGvb/Z2mm9lcKfRvioHAaMh9i9ELGiy0xkdEjAWhiNtOLdqSmDNUeHhKMmx51icyQ657yDgZJtL8JJPMCDS551IEyGN4sXNUClVZRTqZMOalkgONMhsb0kcZwpQr174naOfvuSrj4vAYaTcu7P41Ms7PLFB4FcEWFDCi4ssDd8NA9LFXMlKsAEys3vjphu7dX7MjdEIQkEjM2Y8rnqwEd5uF6I/QcBEOV48DP/wYfmHqzhDaKR9j2yUx5gX6CJR49VF/rBL1tuGISAsEEr5bzLSsFoxkG3b74oYHgG82qUpU0Scczg8bYEOdDe0PCnLmHi5n2xLSzT0SYyuqjmIXX9v/39iS5f x-ms-exchange-antispam-messagedata: LrQhlmQystsvILfqKTzkrsHFS1Ei0wFgL5t32YDnujSOyYFmd1FFpYMB8gbdH03jsg3YOaSkrRKRpCaD5agqkulZsaiI6axktUo/4cThmIfD9Im2grATLIYJqEvPmy3BkvuaFYIl9d7BplPhph+MXg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a7d672cd-753b-4a1e-e7ae-08d7d7b9bebd X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2020 10:28:26.4233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EHcGF3ZtIB23GDkTHTFv95K1HZFNFzzMfSii4/X+H6Xn/tQT1wnvgv4D5E/9suwitw5LM5DsTo1Nv1uAx/3bmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2528 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-03_07:2020-04-02, 2020-04-03 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Praveen, Please see inline. Thanks, Anoob > -----Original Message----- > From: Shetty, Praveen > Sent: Friday, April 3, 2020 3:51 PM > To: Akhil Goyal ; Anoob Joseph ; > dev@dpdk.org; Doherty, Declan > Cc: Iremonger, Bernard ; Ananyev, Konstantin > > Subject: RE: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director > feature >=20 >=20 >=20 > -----Original Message----- > From: Akhil Goyal > Sent: Friday, April 3, 2020 11:22 AM > To: Anoob Joseph ; Shetty, Praveen > ; dev@dpdk.org; Doherty, Declan > > Cc: Iremonger, Bernard ; Ananyev, Konstantin > > Subject: RE: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director > feature >=20 > > > > diff --git a/examples/ipsec-secgw/ipsec.c > > > > b/examples/ipsec-secgw/ipsec.c index d40657102..76ee9dbcf 100644 > > > > --- a/examples/ipsec-secgw/ipsec.c > > > > +++ b/examples/ipsec-secgw/ipsec.c > > > > @@ -418,6 +418,73 @@ create_inline_session(struct socket_ctx > > > > *skt_ctx, struct ipsec_sa *sa, > > > > return 0; > > > > } > > > > > > > > +int > > > > +create_ipsec_esp_flow(struct ipsec_sa *sa) { > > > > + int ret =3D 0; > > > > + struct rte_flow_error err; > > > > + if (sa->direction =3D=3D RTE_SECURITY_IPSEC_SA_DIR_EGRESS) > > > > + return 0; /* No Flow director rules for Egress traffic */ > > > > > > [Anoob] Any reason why this is not relevant for Egress. > > > > > > [Praveen] we don't see an use case for load distribution across > > > ingress queues for outbound IPsec traffic therefore we have limited > > > this configuration to inbound IPsec processing, as this is the only u= se case we > can verify. > > > > [Anoob] Why do you say load distribution for ingress queues is not > > required but is required for egress? I would say the use case is the sa= me in > either direction. > > > > Said that, adding just egress should be fine. I leave this to Akhil's j= udgement. > > >=20 > I believe it does not matter for EGRESS in most hardwares, INGRESS flows > should have distribution. I think your comments are just reverse but The = code is > inline with my understanding. >=20 > [Praveen] > Current implementation is only for ingress traffic load distribution ther= efore it is > applicable only for inbound IPsec traffic. >=20 [Anoob] Yes. I got it reverse. Meant egress instead of ingress and the othe= r way round as well. I was asking for the rationale behind limiting the scope. Anyway, that can = be taken up separately.