From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB5C3A0597; Wed, 8 Apr 2020 15:03:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA5871C19E; Wed, 8 Apr 2020 15:03:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 1AB151C190; Wed, 8 Apr 2020 15:03:04 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 038CuHB9022654; Wed, 8 Apr 2020 06:03:04 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-0016f401.pphosted.com with ESMTP id 3091me37gs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Apr 2020 06:03:04 -0700 Received: from m0045851.ppops.net (m0045851.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 038D1bwj027105; Wed, 8 Apr 2020 06:03:03 -0700 Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 3091me37gp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 08 Apr 2020 06:03:03 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Apr 2020 06:03:02 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Apr 2020 06:03:01 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 8 Apr 2020 06:03:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KyVBnSX8lzGEqXWSFkzn+pNUbn8phXMBDv+OTjVi/N5HZu6VmSLwjf9TddTHwopO02BVHR+5v1JcZ0sCpPwEIeWAbXBBlJ97zSK+rSEjtEmafeprZtU8ikZNpt/lAvDxQ0hjs2sCx1X7/lMPTAkShcPBCSp95Ik38y1lFSIyw5Ba/9o5KrxFYXOief/C42NtdV6PYhj2oh7lWq2FtCPDDlWVvCKWytvjf8nOp/11ln9EH6MygGJhbRVqrDLuVq5IeiXVdJcGIPOvswl5X6NkZVYw1R/Io64L6blsgMJZgukEKsLvRA8ufDQDAfrj2cqLCvSawn/2Cu+P4+xWs9cWJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=igWR6HtCCYfiMekUbTZQo8E/1WrOUXW6VkzWSbmwWm8=; b=J97f4ZySZy4Pgd8T0AwKtWd29i6MqC4zRgFBPaYucyOuLTF+pHr16f91O3/4E+VWkX+EaPMbSSCXuFCJjREQZEOjjfHLtazFo1ZbevqMbDdwiyvMDhZ7r4y6ADl7oP/FwTlQP0/Uromnj/ptNXcmmKIhESKabGtl4vkOm8/zB6u5rlD0A6KdPFZ+Dd6iv+6qOYoy07PQpUZl4IJt1P2li+Bt0+tBMUdRx4LfGbF00OQXTNu6Zgs8KDK/QubtWFe1gDpsqgaHjFdk7ckuWLYajcZ+JrIStfe8JKEXWz7P3gSpS81e7Q2egeGcLwMYEsgedlVTAY/4b3tIq9q2/jvrHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=igWR6HtCCYfiMekUbTZQo8E/1WrOUXW6VkzWSbmwWm8=; b=rwzcsdnICGyvsHAL9VuDAyDGiDSvIFvSd5g8fC2Uw1flNYXxIKIG6nEKFbEp/X9xK7ib8uq9Q6yI0jDnFjrgmOgCDqIhILUtuH7gF4/fnywo7MmZoerzL9cAA3BPr1BAKXQdptGa1g2jW8qAKMmG9KXrbw9F965izc1RuQw4zpk= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3438.namprd18.prod.outlook.com (2603:10b6:208:16d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.21; Wed, 8 Apr 2020 13:02:59 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2878.022; Wed, 8 Apr 2020 13:02:59 +0000 From: Anoob Joseph <anoobj@marvell.com> To: Thomas Monjalon <thomas@monjalon.net>, Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> CC: Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty <declan.doherty@intel.com>, Aviad Yehezkel <aviadye@mellanox.com>, "Boris Pismenny" <borisp@mellanox.com>, Radu Nicolau <radu.nicolau@intel.com>, Anoob Joseph <anoob.joseph@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters Thread-Index: AQHWDaTw2tw3hrhr+kWe6txt4zUk/ahvMGCg Date: Wed, 8 Apr 2020 13:02:59 +0000 Message-ID: <MN2PR18MB28771B123F21BDFF4CFA6331DFC00@MN2PR18MB2877.namprd18.prod.outlook.com> References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <CGME20200408031447eucas1p1376332353faa0d217e7be8c32271405f@eucas1p1.samsung.com> <20200408031351.4288-2-l.wojciechow@partner.samsung.com> <1875710.PYKUYFuaPT@thomas> In-Reply-To: <1875710.PYKUYFuaPT@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.244.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2dfa519a-42e8-4414-6ebb-08d7dbbd29e5 x-ms-traffictypediagnostic: MN2PR18MB3438: x-microsoft-antispam-prvs: <MN2PR18MB34380E6AE3BFC95420F33A4ADFC00@MN2PR18MB3438.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0367A50BB1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(66946007)(66446008)(66556008)(4326008)(66476007)(7696005)(9686003)(64756008)(316002)(110136005)(81166007)(7416002)(4744005)(26005)(2906002)(966005)(478600001)(76116006)(15650500001)(5660300002)(6506007)(33656002)(55016002)(8936002)(71200400001)(186003)(52536014)(54906003)(81156014)(86362001); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BDwv6L6L417GOngkliOEI9L3AJXBLx2og6tdPiCxLg1An3HSmiBZNtPlkooByug5eE05BwYUxirdh56y07K3p+fLPVDUKQHNqhgNsQtS9j0o3MPtzqEOVsiutkVc3OHT9dh+TthCCxOaLkm3wQ3zm90jF8pYpX+knLO0i3U3b4DPRnnMbG1hyJ/Ag17um+PuHre/73dhHCTrr12bcDAT0UwJrhFAFvdaQUAJAOjSbV5ZZlZkoXTRBxyBzymHHV5W0AvPYv+TNzkQhozn85dotDoQu6wttZmwooMxU+Tj/uwVIx0UsLjkTcGY3hcqr6j7sQXQ5l+aWIbKH7nYxb8pJF+NFJ+WymqHj4VwTAS/sWbZYyWEOVTnLd6yizsho99rXhK/yMYPC/xLp5dtgTj3KduEtHYUcOysbuMzPDmvkcx209eCGX2khh4bDVLuSlIhGzt0GJWZA0HMf80bv/bpYe2KhFuJX95ii1js3902JOpxnN715UFW3mTupjTGqdrNW5cjpyRhciKka4d61lWYng== x-ms-exchange-antispam-messagedata: tG0FPVHnAH2Jfymu1LDltB0t4JbAmhDRDBrv44kqxRy5bXO0EVNH+dICX8yKmD9q2AzPCMYUdqIdmmQuU5yt7qAw4+bXd8z4CdQN9AxtUofp0q3zjDazqsRMLKDyKA4QNelaBkHv7O36H1GndmVYhQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2dfa519a-42e8-4414-6ebb-08d7dbbd29e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2020 13:02:59.3348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yWNoc9gnysUdOsxSO67YE0o6OEkFqBhwt9Zg/v/lZIe4UKLmbg4yahJ1ZecFS4/eutGOWV2oOyytGoaZEwpKvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3438 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-07_10:2020-04-07, 2020-04-07 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Thomas, > 08/04/2020 05:13, Lukasz Wojciechowski: > > This patch adds verification of the parameters to the ret_security API > > functions. All required parameters are checked if they are not NULL. > [...] > > --- a/config/common_base > > +++ b/config/common_base > > CONFIG_RTE_LIBRTE_SECURITY=3Dy > > +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=3Dn >=20 > Is it a leftover? >=20 [Anoob] It is similar to 'RTE_LIBRTE_ETHDEV_DEBUG' for usage in datapath. = Like in, http://code.dpdk.org/dpdk/latest/source/lib/librte_ethdev/rte_ethd= ev.h#L4378 Thanks, Anoob