From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7623B1B452 for ; Tue, 23 Apr 2019 07:42:33 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3N5fNsk024911; Mon, 22 Apr 2019 22:42:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=lT6GeddtiZ6M9ornCMseM6srBWoheklnXV2/j7J1Owo=; b=P9Y89OQcClPqEZSXb0ajHQcxDGPYZILg73jbIiSutrEZyDnhBpGGEewmz3tvQFtvp3ET lm4uT5o8Wd6p40ahhy5+tuCecK/BdjTyfbTnE/hEaOyOhXIl4alZNUf2EI1Oh3oeSX0y lRbmipXSnjjIL/wrIArasgNMHHkMCud+C2iT8au3wYUM0LzrvpW/8b5BfDMSeBhlC3RN uap55UrPCEyZpXRqBFfB9Br/bj8Cn8pNrknvGvIC6Kv0RFgubiQbk5EDk11KNzdN/IJ6 RIucndjClGnycxRoN2ARuoWlZeKqg91GAufMRdJglJ8dpE6jK1cHMElR4x17VzSVvwN4 qQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2s0tjrdkv6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Apr 2019 22:42:32 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Apr 2019 22:42:30 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.52) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Apr 2019 22:42:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lT6GeddtiZ6M9ornCMseM6srBWoheklnXV2/j7J1Owo=; b=TQy0BgnHCfOzuaY2AUgc7wJyAozgeU5wPqAjRD7OuRKe4EeGt3o3vk3QsFcQ5AnfFr42+UrryWenm8bH1U4I5bZPHMrFDROJYClcNaiklObejeadNXXKXgTpLVxy7Xft6UMVOhGZQhAK4yJrVvBIVbc+8QoHwOJ4LEP77DtdtZ0= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2751.namprd18.prod.outlook.com (20.179.20.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Tue, 23 Apr 2019 05:42:26 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::8c8d:3cce:d106:bf62]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::8c8d:3cce:d106:bf62%7]) with mapi id 15.20.1813.017; Tue, 23 Apr 2019 05:42:26 +0000 From: Anoob Joseph To: Shally Verma , Ayuj Verma , "akhil.goyal@nxp.com" , "arkadiuszx.kusztal@intel.com" , "fiona.trahe@intel.com" CC: Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" , Ayuj Verma Thread-Topic: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers Thread-Index: AQHU8P3sxVaO2mfXd0OTyGsB6JauoaZBTeZwgAbkowCAAQ86oA== Date: Tue, 23 Apr 2019 05:42:25 +0000 Message-ID: References: <1555052602-19155-1-git-send-email-ayverma@marvell.com> <1555052602-19155-2-git-send-email-ayverma@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55fca49f-0f85-4233-21e6-08d6c7ae7761 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR18MB2751; x-ms-traffictypediagnostic: MN2PR18MB2751: x-microsoft-antispam-prvs: x-forefront-prvs: 0016DEFF96 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(39860400002)(346002)(376002)(189003)(199004)(13464003)(25786009)(8936002)(68736007)(4326008)(81166006)(81156014)(6246003)(2201001)(53936002)(14444005)(256004)(9686003)(71200400001)(71190400001)(66556008)(64756008)(66446008)(66476007)(52536014)(86362001)(5660300002)(55016002)(486006)(107886003)(186003)(6116002)(66946007)(3846002)(76116006)(446003)(73956011)(11346002)(476003)(26005)(93886005)(76176011)(110136005)(33656002)(7696005)(316002)(54906003)(2906002)(66066001)(97736004)(55236004)(478600001)(14454004)(102836004)(6506007)(99286004)(53546011)(6436002)(74316002)(7736002)(2501003)(229853002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2751; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jLmqO6BqQis2UwJQFram7/UwGwhyFtjncMq0xkjQfrF4fTExELV+HOyhQkQ7Sdsk3Ht/ROIaVgH+vAj1fqjJH/2CeMxa3AbvSeokim1nQsQ1xbU1YrZeSdMX2CROS7srlRhSVSHlLiJHSfeMdokWcDH7LtxupPQ40GKuTYjruCYcqsWCv53nik/3sseMCFgbKDcfLbtDIPkNONTrQK27ID7a0Cr7MPl0/FZ8Efyj5FqNcOCcnRKnl7PsWZAQSpUYdTuYeot5SeUrv0l2j97jXM0uIp/a1Dn9b5vml12JdbM5MQo/8x5K56Rnw6wLbWWKwrsIHuqMkqUr7wEQwNbRW7uEVnT9K2nMcRm84dK9BK/a8nM1eMXiKzf9r4YcetxbdqZPB/c4oNwSpKLHRCu4wuaAQRJEW2o0lrvGz1iq4n4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 55fca49f-0f85-4233-21e6-08d6c7ae7761 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 05:42:25.9204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2751 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-22_01:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 05:42:33 -0000 Hi Shally, Please see inline. Thanks, Anoob > -----Original Message----- > From: Shally Verma > Sent: Monday, April 22, 2019 6:23 PM > To: Anoob Joseph ; Ayuj Verma > ; akhil.goyal@nxp.com; > arkadiuszx.kusztal@intel.com; fiona.trahe@intel.com > Cc: Sunila Sahu ; Kanaka Durga Kotamarthy > ; Arvind Desai ; > dev@dpdk.org; Ayuj Verma > Subject: RE: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering = of > headers >=20 > Hi Anoob >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Thursday, April 18, 2019 9:28 AM > > To: Ayuj Verma ; akhil.goyal@nxp.com; > > arkadiuszx.kusztal@intel.com; fiona.trahe@intel.com > > Cc: Shally Verma ; Sunila Sahu > > ; Kanaka Durga Kotamarthy > > ; Arvind Desai ; > > dev@dpdk.org; Ayuj Verma > > Subject: RE: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical > > ordering of headers > > > > Hi Ayuj, Akhil, Fiona, Shally, > > > > I think there are couple of issues with this patch. The real issue > > here is the dependency of rte_crypto_asym.h on rte_crypto_sym.h. If > > rte_crypto_asym.h doesn't include all the headers it uses, every file > > which includes rte_crypto_asym.h will have to include > > rte_crypto_asym.h's dependencies, which is not the right practice. > > Keeping it alphabetical etc comes later. >=20 > [Shally] We can change title something to "include dependencies into asym > header files" , but then should I assume that You agree to this patch? [Anoob] Yes. The title and description has to be changed to better reflect = what we are trying to solve. I'm in agreement with what the patch is trying= to achieve. >=20 > > > > So the patch has to be rephrased to better reflect the purpose. > > > > Also please see inline. > > > > Thanks, > > Anoob > > > > > -----Original Message----- > > > From: dev On Behalf Of Ayuj Verma > > > Sent: Friday, April 12, 2019 12:33 PM > > > To: akhil.goyal@nxp.com; arkadiuszx.kusztal@intel.com; > > > fiona.trahe@intel.com > > > Cc: Shally Verma ; Sunila Sahu > > > ; Kanaka Durga Kotamarthy > > > ; Arvind Desai ; > > > dev@dpdk.org; Ayuj Verma > > > Subject: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering > > > of headers > > > > > > include rte_crypto_sym.h in rte_crypto_asym.h in place of including > > > it in rte_crypto.h. > > > > > > Signed-off-by: Ayuj Verma > > > Signed-off-by: Shally Verma > > > > > > --- > > > lib/librte_cryptodev/rte_crypto.h | 1 - > > > lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ > > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/librte_cryptodev/rte_crypto.h > > > b/lib/librte_cryptodev/rte_crypto.h > > > index fd5ef3a..17dccdf 100644 > > > --- a/lib/librte_cryptodev/rte_crypto.h > > > +++ b/lib/librte_cryptodev/rte_crypto.h > > > @@ -22,7 +22,6 @@ > > > #include > > > #include > > > > > > -#include "rte_crypto_sym.h" > > > #include "rte_crypto_asym.h" > > > > [Anoob] If rte_crypto.h uses anything defined in rte_crypto_sym.h, > > then you cannot remove the include. >=20 > [Shally] so you mean we should do #include of sym.h in both, this and > rte_crypto_asym.h file? [Anoob] If this file uses anything from rte_crypto_sym.h, then ' #include "= rte_crypto_sym.h" ' has to be retained. Here the patch is removing the incl= ude. Instead may be the includes can be rearranged to make it follow alphabetica= l order. Again, that need not be part of this patch. If Akhil is okay with = having includes violating the alphabetical sequence, this change can be def= erred. >=20 > >You can make it alphabetical, but the include has to be retained. > [Shally] Sorry didn't get what you exactly mean by this? >=20 > Thanks > Shally >=20 > > >=20 > > > > > > /** Crypto operation types */ [Anoob] IMO, only the following change is needed.=20 > > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > > b/lib/librte_cryptodev/rte_crypto_asym.h > > > index 5e43620..a55923a 100644 > > > --- a/lib/librte_cryptodev/rte_crypto_asym.h > > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > > > @@ -25,6 +25,8 @@ > > > #include > > > #include > > > > > > +#include "rte_crypto_sym.h" > > > + > > > typedef struct rte_crypto_param_t { > > > uint8_t *data; > > > /**< pointer to buffer holding data */ > > > -- > > > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1AB15A05D3 for ; Tue, 23 Apr 2019 07:42:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 386861B453; Tue, 23 Apr 2019 07:42:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7623B1B452 for ; Tue, 23 Apr 2019 07:42:33 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3N5fNsk024911; Mon, 22 Apr 2019 22:42:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=lT6GeddtiZ6M9ornCMseM6srBWoheklnXV2/j7J1Owo=; b=P9Y89OQcClPqEZSXb0ajHQcxDGPYZILg73jbIiSutrEZyDnhBpGGEewmz3tvQFtvp3ET lm4uT5o8Wd6p40ahhy5+tuCecK/BdjTyfbTnE/hEaOyOhXIl4alZNUf2EI1Oh3oeSX0y lRbmipXSnjjIL/wrIArasgNMHHkMCud+C2iT8au3wYUM0LzrvpW/8b5BfDMSeBhlC3RN uap55UrPCEyZpXRqBFfB9Br/bj8Cn8pNrknvGvIC6Kv0RFgubiQbk5EDk11KNzdN/IJ6 RIucndjClGnycxRoN2ARuoWlZeKqg91GAufMRdJglJ8dpE6jK1cHMElR4x17VzSVvwN4 qQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2s0tjrdkv6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Apr 2019 22:42:32 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Apr 2019 22:42:30 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.52) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Apr 2019 22:42:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lT6GeddtiZ6M9ornCMseM6srBWoheklnXV2/j7J1Owo=; b=TQy0BgnHCfOzuaY2AUgc7wJyAozgeU5wPqAjRD7OuRKe4EeGt3o3vk3QsFcQ5AnfFr42+UrryWenm8bH1U4I5bZPHMrFDROJYClcNaiklObejeadNXXKXgTpLVxy7Xft6UMVOhGZQhAK4yJrVvBIVbc+8QoHwOJ4LEP77DtdtZ0= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2751.namprd18.prod.outlook.com (20.179.20.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Tue, 23 Apr 2019 05:42:26 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::8c8d:3cce:d106:bf62]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::8c8d:3cce:d106:bf62%7]) with mapi id 15.20.1813.017; Tue, 23 Apr 2019 05:42:26 +0000 From: Anoob Joseph To: Shally Verma , Ayuj Verma , "akhil.goyal@nxp.com" , "arkadiuszx.kusztal@intel.com" , "fiona.trahe@intel.com" CC: Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" , Ayuj Verma Thread-Topic: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers Thread-Index: AQHU8P3sxVaO2mfXd0OTyGsB6JauoaZBTeZwgAbkowCAAQ86oA== Date: Tue, 23 Apr 2019 05:42:25 +0000 Message-ID: References: <1555052602-19155-1-git-send-email-ayverma@marvell.com> <1555052602-19155-2-git-send-email-ayverma@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55fca49f-0f85-4233-21e6-08d6c7ae7761 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR18MB2751; x-ms-traffictypediagnostic: MN2PR18MB2751: x-microsoft-antispam-prvs: x-forefront-prvs: 0016DEFF96 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(39860400002)(346002)(376002)(189003)(199004)(13464003)(25786009)(8936002)(68736007)(4326008)(81166006)(81156014)(6246003)(2201001)(53936002)(14444005)(256004)(9686003)(71200400001)(71190400001)(66556008)(64756008)(66446008)(66476007)(52536014)(86362001)(5660300002)(55016002)(486006)(107886003)(186003)(6116002)(66946007)(3846002)(76116006)(446003)(73956011)(11346002)(476003)(26005)(93886005)(76176011)(110136005)(33656002)(7696005)(316002)(54906003)(2906002)(66066001)(97736004)(55236004)(478600001)(14454004)(102836004)(6506007)(99286004)(53546011)(6436002)(74316002)(7736002)(2501003)(229853002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2751; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jLmqO6BqQis2UwJQFram7/UwGwhyFtjncMq0xkjQfrF4fTExELV+HOyhQkQ7Sdsk3Ht/ROIaVgH+vAj1fqjJH/2CeMxa3AbvSeokim1nQsQ1xbU1YrZeSdMX2CROS7srlRhSVSHlLiJHSfeMdokWcDH7LtxupPQ40GKuTYjruCYcqsWCv53nik/3sseMCFgbKDcfLbtDIPkNONTrQK27ID7a0Cr7MPl0/FZ8Efyj5FqNcOCcnRKnl7PsWZAQSpUYdTuYeot5SeUrv0l2j97jXM0uIp/a1Dn9b5vml12JdbM5MQo/8x5K56Rnw6wLbWWKwrsIHuqMkqUr7wEQwNbRW7uEVnT9K2nMcRm84dK9BK/a8nM1eMXiKzf9r4YcetxbdqZPB/c4oNwSpKLHRCu4wuaAQRJEW2o0lrvGz1iq4n4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 55fca49f-0f85-4233-21e6-08d6c7ae7761 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 05:42:25.9204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2751 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-22_01:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423054225.OG6F0x9es3iC_1QjLEqLzidcofNWnR74H68FviCx-So@z> Hi Shally, Please see inline. Thanks, Anoob > -----Original Message----- > From: Shally Verma > Sent: Monday, April 22, 2019 6:23 PM > To: Anoob Joseph ; Ayuj Verma > ; akhil.goyal@nxp.com; > arkadiuszx.kusztal@intel.com; fiona.trahe@intel.com > Cc: Sunila Sahu ; Kanaka Durga Kotamarthy > ; Arvind Desai ; > dev@dpdk.org; Ayuj Verma > Subject: RE: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering = of > headers >=20 > Hi Anoob >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Thursday, April 18, 2019 9:28 AM > > To: Ayuj Verma ; akhil.goyal@nxp.com; > > arkadiuszx.kusztal@intel.com; fiona.trahe@intel.com > > Cc: Shally Verma ; Sunila Sahu > > ; Kanaka Durga Kotamarthy > > ; Arvind Desai ; > > dev@dpdk.org; Ayuj Verma > > Subject: RE: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical > > ordering of headers > > > > Hi Ayuj, Akhil, Fiona, Shally, > > > > I think there are couple of issues with this patch. The real issue > > here is the dependency of rte_crypto_asym.h on rte_crypto_sym.h. If > > rte_crypto_asym.h doesn't include all the headers it uses, every file > > which includes rte_crypto_asym.h will have to include > > rte_crypto_asym.h's dependencies, which is not the right practice. > > Keeping it alphabetical etc comes later. >=20 > [Shally] We can change title something to "include dependencies into asym > header files" , but then should I assume that You agree to this patch? [Anoob] Yes. The title and description has to be changed to better reflect = what we are trying to solve. I'm in agreement with what the patch is trying= to achieve. >=20 > > > > So the patch has to be rephrased to better reflect the purpose. > > > > Also please see inline. > > > > Thanks, > > Anoob > > > > > -----Original Message----- > > > From: dev On Behalf Of Ayuj Verma > > > Sent: Friday, April 12, 2019 12:33 PM > > > To: akhil.goyal@nxp.com; arkadiuszx.kusztal@intel.com; > > > fiona.trahe@intel.com > > > Cc: Shally Verma ; Sunila Sahu > > > ; Kanaka Durga Kotamarthy > > > ; Arvind Desai ; > > > dev@dpdk.org; Ayuj Verma > > > Subject: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering > > > of headers > > > > > > include rte_crypto_sym.h in rte_crypto_asym.h in place of including > > > it in rte_crypto.h. > > > > > > Signed-off-by: Ayuj Verma > > > Signed-off-by: Shally Verma > > > > > > --- > > > lib/librte_cryptodev/rte_crypto.h | 1 - > > > lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ > > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/librte_cryptodev/rte_crypto.h > > > b/lib/librte_cryptodev/rte_crypto.h > > > index fd5ef3a..17dccdf 100644 > > > --- a/lib/librte_cryptodev/rte_crypto.h > > > +++ b/lib/librte_cryptodev/rte_crypto.h > > > @@ -22,7 +22,6 @@ > > > #include > > > #include > > > > > > -#include "rte_crypto_sym.h" > > > #include "rte_crypto_asym.h" > > > > [Anoob] If rte_crypto.h uses anything defined in rte_crypto_sym.h, > > then you cannot remove the include. >=20 > [Shally] so you mean we should do #include of sym.h in both, this and > rte_crypto_asym.h file? [Anoob] If this file uses anything from rte_crypto_sym.h, then ' #include "= rte_crypto_sym.h" ' has to be retained. Here the patch is removing the incl= ude. Instead may be the includes can be rearranged to make it follow alphabetica= l order. Again, that need not be part of this patch. If Akhil is okay with = having includes violating the alphabetical sequence, this change can be def= erred. >=20 > >You can make it alphabetical, but the include has to be retained. > [Shally] Sorry didn't get what you exactly mean by this? >=20 > Thanks > Shally >=20 > > >=20 > > > > > > /** Crypto operation types */ [Anoob] IMO, only the following change is needed.=20 > > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > > b/lib/librte_cryptodev/rte_crypto_asym.h > > > index 5e43620..a55923a 100644 > > > --- a/lib/librte_cryptodev/rte_crypto_asym.h > > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > > > @@ -25,6 +25,8 @@ > > > #include > > > #include > > > > > > +#include "rte_crypto_sym.h" > > > + > > > typedef struct rte_crypto_param_t { > > > uint8_t *data; > > > /**< pointer to buffer holding data */ > > > -- > > > 1.8.3.1