From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 876FBA034E;
Thu, 23 Apr 2020 18:08:19 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 3066E1C21B;
Thu, 23 Apr 2020 18:08:18 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id E15641C206;
Thu, 23 Apr 2020 18:08:15 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
03NG5g1g023213; Thu, 23 Apr 2020 09:08:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : references : in-reply-to : content-type :
content-transfer-encoding : mime-version; s=pfpt0818;
bh=GR8H0bRdg4iweaCk07YVPz35oo0CVWAjotqGtMJciWI=;
b=Q6j24ip476Cjy0OEJQ9/DeN+0JOmOtgYHG6MxMwMYsbmXR7+vIBtF73NSfi/TVzZcNhv
6m7Un16Hx4viCB0hZVStOKmc8zxCUr1OmHkWMBv1gP9fRVYmW3bn35keUIZY0FK0Stfu
e1tPNEPzLdDlvaPY2y8CnUSQX57qgxYScrkxvmRXKEvOoLpYgEjm2JWHJcFBtzU1kcOg
eKqb1Mmy7TLhIcQCzbGK7yw3MhZXQGldazYsLjOpRFxFQpBIVjL6jFcM+txwIswhxQ+y
KOXuaNqYPkJPmu8erSOW84pYSW997E7VBS8uX09ZL+jOLLgbqeXUESER4WeLeH1WzTVV Ng==
Received: from sc-exch03.marvell.com ([199.233.58.183])
by mx0b-0016f401.pphosted.com with ESMTP id 30jd0189fj-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Thu, 23 Apr 2020 09:08:14 -0700
Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com
(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Thu, 23 Apr 2020 09:08:12 -0700
Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com
(10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Thu, 23 Apr 2020 09:08:12 -0700
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100)
by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id
15.0.1497.2 via Frontend Transport; Thu, 23 Apr 2020 09:08:11 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Sth11GAaZXNCHh609V9534iE0+eNNhkO4Hqf+2bcCTxOF96CU6/p9RzUj13nibErMCccyMbCIFaMTJOZXU0lS1GuJC46IeHBWMo1gI0amdzmA+wIhexJooArczO1OvVvsL3mLQfh7bgxQUCZ3/3jCECd7OtZa36p0bq5uOajiTC8r6ywaK/8vJKN9rBMyM9R3W469teNi18CZONaiozetT/WquMOVwZiZdgcPi/FOFSvbQmdOnV2Ca/4FGNrySH83XoEp4v7MqY04FZ4fRUXBcBU8Idzi7f92w0VyzmqYSQIfSCdVURC7EQqgvZxWoxgYZr0Su14eYcM3+vOiO7uAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=GR8H0bRdg4iweaCk07YVPz35oo0CVWAjotqGtMJciWI=;
b=XmI7UseY8iw+ROizoMWqoxiUGuH39HoyK4TZHGDpr+0jU3IYFh3t3jrUyg0D/tOBwDkcA8WtzEd/9Xzirzvai3GMw7xbxZNkHa+PNWhHbrDM3V5aW6/vJmqKxikcLFoIzIG9uY+KaiUo4jlIkG1lT/+Jdbs+iQvRyR3XpOAl/xkF+5n4OocUPYWVHMOgKirkkG0qJxpWRKMmBtiNRMcHoniDoyqos0PqlBcBw0jXQEPLPgYTOntIw0Vr8rq+UbrnX6RiETUgbdZrVWYgSRA5MU+x7aNgtv5FfnZxMdKJtZ4udz8DS9Qz2th6x5Y47uXyNWHRVCAmyS5RPQ329FncuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=GR8H0bRdg4iweaCk07YVPz35oo0CVWAjotqGtMJciWI=;
b=QomVXci/2DN0fVYYldfbeqBUQYblszsrbZYYkjPIcYMOJear5lki7zqksztbixwA5ucKp33eJiGeGjq9Ee2c6ceYbCJnQx5G47mgGdlwG8nOhe+bh3WTBF9ys5moXSYvxgQx4QoYQJPYvE/WP09/PlCNjw31nSIbkdoeR5SQfhg=
Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26)
by MN2PR18MB2493.namprd18.prod.outlook.com (2603:10b6:208:ae::15)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Thu, 23 Apr
2020 16:08:11 +0000
Received: from MN2PR18MB2877.namprd18.prod.outlook.com
([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com
([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2921.030; Thu, 23 Apr 2020
16:08:11 +0000
From: Anoob Joseph <anoobj@marvell.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, Konstantin Ananyev
<konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "declan.doherty@intel.com" <declan.doherty@intel.com>, "stable@dpdk.org"
<stable@dpdk.org>
Thread-Topic: [PATCH v2] security: fix crash at accessing non-implemented ops
Thread-Index: AQHWGYcdAz4PUkgON0eHEwGVHg+goKiG3coA
Date: Thu, 23 Apr 2020 16:08:10 +0000
Message-ID: <MN2PR18MB28773439B71C687D4D966EB2DFD30@MN2PR18MB2877.namprd18.prod.outlook.com>
References: <20200422235158.24497-1-konstantin.ananyev@intel.com>
<20200423151042.4650-1-konstantin.ananyev@intel.com>
<VI1PR04MB31682AE581995C9CF8FDA80CE6D30@VI1PR04MB3168.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB31682AE581995C9CF8FDA80CE6D30@VI1PR04MB3168.eurprd04.prod.outlook.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [27.34.246.85]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 298cc686-5c4d-4ef5-471b-08d7e7a0851e
x-ms-traffictypediagnostic: MN2PR18MB2493:
x-microsoft-antispam-prvs: <MN2PR18MB2493123F68064D12B60E6CE4DFD30@MN2PR18MB2493.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 03827AF76E
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(10009020)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(4326008)(76116006)(110136005)(64756008)(66946007)(66556008)(6506007)(53546011)(7696005)(316002)(86362001)(54906003)(26005)(71200400001)(66446008)(66476007)(186003)(2906002)(478600001)(52536014)(55016002)(5660300002)(8936002)(33656002)(8676002)(81156014)(15650500001)(9686003);
DIR:OUT; SFP:1101;
received-spf: None (protection.outlook.com: marvell.com does not designate
permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 24VRwRp2+EHIsDYFiBjrlBz+uzr8W3lpHFtwTCgQtkOve+kSS6Kay8bqQFq2hsgRGxMjike/z26B8TEWppCGhyXqsh8Hawhq6p2X19sQlZxlTSXearEdnCcjhxx0XtFH0e1rekMhmHJ1oxaMcTnJEaxNs9xOhWmNwApSfMQuA3D7/WyJwl8hTqfG/E4BeY7WEYpQxtc4GLBDqDPAKtZWOwBYhvviARWQ43OU7wO8JKvaT99Sn37WiRFqDOze96axGDbcNY2oRtwbv3hroLgmrLDyP+7+9cy8u1LjICFSew2RypgtiUU8rN9bASSlPCs4JsYOAJP0DQOH2Tql6TWsSrwGbhfLYEaeIrcwUmG8iGLyYsc/W0W7uAW1q6bGjgW9Z/76qaNGQR0GCWLI/2brTFxD+QKc6+L67ppgFLPcIVy8aTuevuPZ6LTb6mfRf3CO
x-ms-exchange-antispam-messagedata: JQevaei3UkzKIGY4sxiiiGbbrMNWeO3EujtG1dz9lhMX+Pl0HIyfrTM7F0djE0yFHVnwVkKsWJD7b+SzDE9miVJn2FWg99ebgQXD6XH9fnv9MO953mdd8ZxBU/hKaMpbmdj/q02+ZQplTO7VjXUhGw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 298cc686-5c4d-4ef5-471b-08d7e7a0851e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 16:08:10.8413 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: itcIqslOGqVt3fgkse6dQGbKsJgJgPPo4yWLqcEqw5lmpjIuHJHJwuH3D1SSXnKqDZ86+2n6Gl2tyg4UT5e5xQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2493
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676
definitions=2020-04-23_12:2020-04-23,
2020-04-23 signatures=0
Subject: Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing
non-implemented ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi Akhil,
I have my concerns over unwanted checks in the datapath. Something that cry=
pto enqueue/dequeue APIs are not doing is being enforced on other APIs. As =
Konstantin had suggested, PMDs (IXGBE here) could define a function which r=
eturns -ENOTSUP and it would have been win-win for everyone.
Anyway, I don't have any objections to this.
Thanks,
Anoob
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Thursday, April 23, 2020 9:22 PM
> To: Konstantin Ananyev <konstantin.ananyev@intel.com>; dev@dpdk.org;
> Anoob Joseph <anoobj@marvell.com>
> Cc: declan.doherty@intel.com; stable@dpdk.org
> Subject: [EXT] RE: [PATCH v2] security: fix crash at accessing non-implem=
ented
> ops
>=20
> External Email
>=20
> ----------------------------------------------------------------------
>=20
> > Valid checks for optional function pointers inside dev-ops were
> > disabled by undefined macro.
> >
> > Fixes: b6ee98547847 ("security: fix verification of parameters")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > ---
>=20
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>=20
> Anoob,
>=20
> Do you have any concerns over this patch?
>=20
> Regards,
> Akhil