Re: [dpdk-dev] [EXT] [PATCH v2 0/9] test/crypto: code cleanup

[Anoob Joseph <anoobj@marvell.com>]

Hi Akhil,

Thanks for the cleanup effort. OCTEON TX crypto PMDs would be moved to standard test framework in the next release cycle. Hope that is fine. The patches are looking good.

Series Acked-by: Anoob Joseph <anoobj@marvell.com>

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Sunday, May 10, 2020 4:42 AM
> To: dev@dpdk.org
> Cc: Ruifeng.Wang@arm.com; declan.doherty@intel.com; asomalap@amd.com;
> Anoob Joseph <anoobj@marvell.com>; roy.fan.zhang@intel.com;
> fiona.trahe@intel.com; Nagadheeraj Rottela <rnagadheeraj@marvell.com>;
> Ankur Dwivedi <adwivedi@marvell.com>; G.Singh@nxp.com;
> hemant.agrawal@nxp.com; jianjay.zhou@huawei.com;
> pablo.de.lara.guarch@intel.com; adamx.dybkowski@intel.com;
> apeksha.gupta@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [EXT] [PATCH v2 0/9] test/crypto: code cleanup
> 
> External Email
> 
> ----------------------------------------------------------------------
> Certain cases were put in PMD specific checks which should be avoided.
> Appropriate capability/supported feature flag should be checked before
> executing the test case.
> Added 1 missing feature flag for non-byte aligned data Enabled it for
> SNOW/ZUC/KASUMI PMDs.
> All the PMD owners are requested to verify these changes and let me know in
> case there are some issues.
> 
> Also removed PMD specific testsuite for dpaa_sec and dpaa2_sec.
> It is requested to all PMD owners to remove their PMD specific suites and move
> to generic testsuite.
> 
> changes in v2:
> patch "[8/9] test/crypto: remove QAT specific check" modified The execution of
> test_queue_pair_descriptor_setup and
> test_device_configure_invalid_queue_pair_ids need to be altered as some
> configuration in the device gets altered in the test which cause test_stats to fail.
> After shuffling the test passed on openssl which was failing earlier. Exact root
> cause cannot be found.
> But it is something specific to application and not driver.
> 
> Akhil Goyal (9):
>   cryptodev: add feature flag for non-byte aligned data
>   test/crypto: skip unsupported non-byte aligned cases
>   test/crypto: skip unsupported SG cases
>   test/crypto: skip unsupported sessionless cases
>   test/crypto: skip unsupported session
>   test/crypto: run PDCP cases if supported
>   test/crypto: remove dpaaX_sec specific testsuites
>   test/crypto: remove QAT specific check
>   test/crypto: remove unused variable
> 
>  app/test/test_cryptodev.c                  | 893 +++++----------------
>  doc/guides/cryptodevs/features/default.ini |   1 +
>  doc/guides/cryptodevs/features/kasumi.ini  |   1 +
>  doc/guides/cryptodevs/features/snow3g.ini  |   1 +
>  doc/guides/cryptodevs/features/zuc.ini     |   1 +
>  drivers/crypto/kasumi/rte_kasumi_pmd.c     |   1 +
>  drivers/crypto/snow3g/rte_snow3g_pmd.c     |   1 +
>  drivers/crypto/zuc/rte_zuc_pmd.c           |   1 +
>  lib/librte_cryptodev/rte_cryptodev.c       |   2 +
>  lib/librte_cryptodev/rte_cryptodev.h       |   2 +
>  10 files changed, 218 insertions(+), 686 deletions(-)
> 
> --
> 2.17.1