From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 010AAA04FA; Wed, 5 Feb 2020 13:59:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39DE81C1AF; Wed, 5 Feb 2020 13:59:26 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C98EB1C0D1; Wed, 5 Feb 2020 13:59:24 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 015CtEhb003360; Wed, 5 Feb 2020 04:59:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=5FVYytTlgeQFBXO/IBlqoBAx+7GZoOLfC2+XuT5xXbA=; b=Q/xEQ0So0flfKfozKv88IQYdkcoFxVzX6l3UT6gbS1AkU6+ZX8Cj0jFBNHArx0gfVMVs 80lhf2F8JAK59Noo+QQNz5YgjxnAXbWd19gPCvzN0zl66EuK28p5Prkwh0icUvTO7H0O a/mFN+7e1Ragp9Fr9RJL90XlfQvQFugcV6BDw1MYdwWaFazUxEUeV7srHj/actUA4Sm1 85Jf4k16iA3yACdu5mFjQbSGRgvRAkaVKdIIg+JSTmg6gryFPkWIlDg7L/q/EuC3tcJi gNhnSXGgjc/hbEtkBmlrY2PdmKu3bSDtw686UHYGM4Chd8TVs6iuzHoIJmEXQwg6MLDW QQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2xyhmtasmq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 05 Feb 2020 04:59:23 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Feb 2020 04:59:22 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 5 Feb 2020 04:59:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V69q+d9ibxREKgVafm4m0lzaiV84dgUnwDN2RH69tnUm/y7GGFcUnAu6VGMKkZtjlffyfKinwcO2aTp699Js/8fa/COJnPOTmtzKanh+2wQAUze9uwt0hl7z5lnAhQXOv8vwzT1vEJr6eQJOqJVVSSKFlsZta9qFYpwhc4cD5AFPAlgtccUqMixzg+cKGgg70UGUflCx4eScJk3Jym4LjZU9tjzqvwT+YP/+uRkb9bErT3W5fGVDjs+jZx24NrqSDvtyg33SdrAxiO2ycOCPCVbP0jCs3HDsMC6QzMkJLnLYZiYA+RyAjLKCoIocD42J0ytCw7ZjqvBkzt31DagZxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5FVYytTlgeQFBXO/IBlqoBAx+7GZoOLfC2+XuT5xXbA=; b=cSrJ2D7QQq4iSC+g7zwZzoWbZfkwq3uIQucVU0LprPMkvsXd5iL1Rq4vKJGeqWKh1fzEZXjvktuVo/iOlo3PiWM3gOjYFSVdrGQ8IV0RpI1zNne9xefJV8nM1zS5ZeFY4T+jnWMykSTvPJVrBdVFRoaCfWsxd8XHwKISjyeqwAQ30rQTj8zIaGBfdkHsVa0QUN0ZVCFdT9UlEWjSQkNu25lfR3VjoqfOD/pqlQu0VIrA4FAn5lDrQVYtFRBkqnZkfdn8IqctiRZ3lKuLUA63oxV6vjdXL8cab2VjSGntA12n/iQ1Gnag1vHFoZakSGG01XaY3ij7MuuvU4BkDY00ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5FVYytTlgeQFBXO/IBlqoBAx+7GZoOLfC2+XuT5xXbA=; b=VAX7qdzJ9JV6Ra8NnW5H/huNr6XgGS/QtitlThlNJCcU7yfgAd2EAur6dfqKYKUziHGWBxRS8c4zpU0ZNNs3y+D/ll0zjWJt0o7RzmVJPiiiKQOPIQzokIOfee6gzVFRmej4U7qEKoBpHRQyDqqSEgA2uHvMRNHxlBCzVIgEhbQ= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2544.namprd18.prod.outlook.com (20.179.84.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.26; Wed, 5 Feb 2020 12:59:21 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572%7]) with mapi id 15.20.2686.035; Wed, 5 Feb 2020 12:59:21 +0000 From: Anoob Joseph To: Timothy Redaelli , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [EXT] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10 Thread-Index: AQHV3CLvqR6//AlIzUadRxiuLFm9P6gMj3JQ Date: Wed, 5 Feb 2020 12:59:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [111.125.192.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cfbc0852-f403-4c5c-b38f-08d7aa3b37c3 x-ms-traffictypediagnostic: MN2PR18MB2544: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0304E36CA3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(39860400002)(346002)(136003)(396003)(189003)(199004)(4326008)(33656002)(316002)(55016002)(76116006)(66946007)(478600001)(9686003)(26005)(186003)(86362001)(55236004)(110136005)(2906002)(7696005)(64756008)(66446008)(66556008)(8676002)(66476007)(81156014)(81166006)(5660300002)(71200400001)(8936002)(6506007)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2544; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KB6rDWWr3coIjWc/SYo1cuUMftO6QeYDY5fbDaiQwX2PlkIzvdnIXnctbCwx5QKX9wseOkp/r+Xm4LxTODyMIuRzh+jxnz+RrVE+hxHPTaOsOJMajF/iy0NQCwJkq+YVAUqUKGV0uuDFvEAQEQG+ZdY7o3DM00WYKgercOGrOYBkzji6r4VwowIKIbo7Pdcudq0gRFcQ03B8YL+zmy00hkQr4OzQE2UD5HXbhINkEfBsKPKjrYnSsl2hTLd6ct6/E8gR8ZNvfNkpatL5HYa+zmQYzwWtilCCuGmy5a4C7IR1b6yMZQwYlSs5lOErSquqsSiHhfL4+kxWtIw8Z9EpeCbZv+Phz3xvSIaiUNlAHVMjuj1kV+BO8naFa9Qv7zEaTxfhUjo5oOBL+CMTLJtdIsRi35Zc2G6nyByPpUgGj0kFi7sTf8W29pU/TefvsmFW x-ms-exchange-antispam-messagedata: FEMBET6rJOaf9spDuB5RlceX/ysGpa8PW4T6BC0Kzi7v+n7o/X2wdqwyenCI2y8gF5cunI4oOETGDeBTNLH0WHBu9awdPyEp43XB+tljbUKzbqEMXSOVngJr2AUgo9sKT3LkNQk83xYYMI5RdMn1Kw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cfbc0852-f403-4c5c-b38f-08d7aa3b37c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2020 12:59:21.0899 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bi/PTB5sgVtA05c2fBR3Ahkh9q3JIycY0rplHqMt4OcaqrqMPg2TkzsThFGNlupVlkGL2Zpe+kCLo/NNXgcQUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2544 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-05_03:2020-02-04, 2020-02-05 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > ---------------------------------------------------------------------- > GCC 10 defaults to -fno-common, this means a linker error will now be rep= orted > if the same global variable is defined in more than one compilation unit. >=20 > Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton") > Cc: anoobj@marvell.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli > --- > drivers/crypto/octeontx2/otx2_cryptodev.c | 2 ++ > drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +- > drivers/crypto/octeontx2/otx2_cryptodev_ops.h | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c > b/drivers/crypto/octeontx2/otx2_cryptodev.c > index 7fd216bb3..957bcd720 100644 > --- a/drivers/crypto/octeontx2/otx2_cryptodev.c > +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c > @@ -24,6 +24,8 @@ >=20 > int otx2_cpt_logtype; >=20 > +uint8_t otx2_cryptodev_driver_id; > + > static struct rte_pci_id pci_id_cpt_table[] =3D { > { > RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h > b/drivers/crypto/octeontx2/otx2_cryptodev.h > index 8e0ebc292..c0aa661b3 100644 > --- a/drivers/crypto/octeontx2/otx2_cryptodev.h > +++ b/drivers/crypto/octeontx2/otx2_cryptodev.h > @@ -38,6 +38,6 @@ extern int otx2_cpt_logtype; > /* > * Crypto device driver ID > */ > -uint8_t otx2_cryptodev_driver_id; > +extern uint8_t otx2_cryptodev_driver_id; >=20 > #endif /* _OTX2_CRYPTODEV_H_ */ > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h > b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h > index a2724f722..f83e36b48 100644 > --- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h > +++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h > @@ -16,6 +16,6 @@ enum otx2_cpt_egrp { > OTX2_CPT_EGRP_AE =3D 2 > }; >=20 > -struct rte_cryptodev_ops otx2_cpt_ops; > +extern struct rte_cryptodev_ops otx2_cpt_ops; >=20 > #endif /* _OTX2_CRYPTODEV_OPS_H_ */ > -- > 2.24.1 Acked-by: Anoob Joseph