From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12C68A0524; Sat, 1 Feb 2020 10:35:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E8231C0D9; Sat, 1 Feb 2020 10:35:38 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id CC0891C0D7 for ; Sat, 1 Feb 2020 10:35:36 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0119RIHh002065; Sat, 1 Feb 2020 01:35:35 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=VB9QxD1t/mQNKegmAXC0+K4zL/jrVnkYNE0+Rlum8Zk=; b=KZwOoVdfTwTp6O5xspoE60tOFsBkTztoTtbnm8LTUT4xmzTHJvVZ//cbcDZJ57Uie2gT aqubITIQklDjPc2wwcodo/x5TWFnjCI/s8j7z/BwuCm7A+SUWnJcZg72rLnLtrMNL8kf LssBy6x25zOXLwiM71WCO/XfH24oj3fYqG+hbkPXdCzjc9EyEq6jskcGDTJaC9BC79bs Vxb7DIFPJVd/vIshRLxhhxzYcfPw00o3W82CiQsMykPUxPPc6OQ5rvwxIa/3qNvjectz y35nfXnOG2/U6TyjQZVaUUyZtzdYNk2foCqEEsISVgXJ+1OACotdbAc9XbAOhMFO+DtP jg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2xvpasbq9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 01 Feb 2020 01:35:35 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 1 Feb 2020 01:35:33 -0800 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.53) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sat, 1 Feb 2020 01:35:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKOPPHzesw/kCLvykXeltG2fTtkRhXEMFv2kmN8lGgFrc3GEr4TnGEjg/5QNt1SMuIFLLeilFNYXfjGpd8djgz00usAwG1Jnz2+Yv0TTRHHa1sQ81kh8EXkbZ+zZ/a1iK1ybW+ZnQnlMqMyTWB6AX4wzT356+GGiOhyhykMhJ36HtkluPw5oyieeu3Y2hsd31zi5VmlN5SWC9J+Vay88wG7jYOVHTbWAvZKk47RGylRyJyAe78K5DT96vPEm1QB8mdCt/HU5+FEl04SvW8yHxS4sBMNmumnUqq/nvGTJ0RQV2dXGVhl9xj/FWR3vfPczuJ2TSesH02twUOAplrYVmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VB9QxD1t/mQNKegmAXC0+K4zL/jrVnkYNE0+Rlum8Zk=; b=NtdcCjgBrjErB2xjGdzcXAUgUe5+1UXTVfDKq9QikjCNE0upET9milmIhRey/JLvl5IXD/K7q+MKkxZikE9ik6oqTa3nd8yziq0NjpganDjqC4ga6YxxU7kgs/DanEHWur4as5hOXB3mLvImddoLlOSdXAg8Uj5adw1crMLco97hyM5raZfCy2EWKenxG5xV+cxU6UJORaPWHSjr1Usnf1fnMOCY+0l1bdY8wkOASRjcQrb4dZLqFCV1rQM8mWhhzqM6NtpEc2tL7ChpstjmkgdxvVxXenl+e8cLZz29i/51ISzAZ8E4fHK7RUw9IsT2HVLIPz7FWZwDurH5VC2V/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VB9QxD1t/mQNKegmAXC0+K4zL/jrVnkYNE0+Rlum8Zk=; b=rFfNupkNoS5qnDttrPkm04NmRLv4ZvIjDAv92Dwh0oYGza5EGoUiiY4tJpuYItgGd4mPqodORNQjyxydoIhI7ashfuHDKPFPH70xbsw5Z3ivdhrGySgpnIzQ3BRu741DVLYAO9df7LqhtCx2+GqrWFn3bqkzaDAPXIgZMIRcVCQ= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2799.namprd18.prod.outlook.com (20.179.22.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.27; Sat, 1 Feb 2020 09:35:32 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572%7]) with mapi id 15.20.2686.031; Sat, 1 Feb 2020 09:35:32 +0000 From: Anoob Joseph To: Anoob Joseph , Akhil Goyal , Declan Doherty , Thomas Monjalon CC: Ankur Dwivedi , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Pavan Nikhilesh Bhagavatula , Archana Muniganti , Tejasree Kondoj , Vamsi Krishna Attunuru , Lukas Bartosik , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx path changes Thread-Index: AQHV2OLyb5UTFDsHkEOdW/qDcVNdSg== Date: Sat, 1 Feb 2020 09:35:32 +0000 Message-ID: References: <1579344553-11428-1-git-send-email-anoobj@marvell.com> <1580465035-30455-1-git-send-email-anoobj@marvell.com> <1580465035-30455-15-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.250.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7589f115-a547-4328-08c2-08d7a6fa152e x-ms-traffictypediagnostic: MN2PR18MB2799: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03008837BD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(39850400004)(376002)(366004)(136003)(189003)(199004)(81156014)(478600001)(53546011)(6506007)(33656002)(4326008)(54906003)(81166006)(7696005)(110136005)(8936002)(186003)(71200400001)(26005)(86362001)(55016002)(2906002)(64756008)(66946007)(66446008)(76116006)(5660300002)(9686003)(316002)(66556008)(66476007)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2799; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yVI4R7qrRGyZMj1vzdhrrJHIWD5wB27ca2IFMCh2B829vqlwESZLcw1Z2HNnXhpnLUGB7Xn2+sfcLoMfgOH7Rnd9mGWPn1BtG+NbypwC1uzVgH8oERhX8Pi/1FwxuGvyV3e/chL3+FADiPF2wWzzPqE1p7VjenINDoDqC8L3X1py2U1DqhTuvtHFVB6IkOO1NniCFTCw+U/Bc177oj65dt2vqDPzgisarBKpYS226pfQpo/tWG5/SnomBqAC4k6B7BitMAnTXVERXxRSGalIQMyHTE+3o415WVY22Hfn1HTc/ixOpZ6UP0632OAyACMQi7Td5txp2WJGPSz6Uf7boJLToIoSAgNmLRAWUvBOHlFFR75d8HCGvbs4Ak9CF+PqU/I7avNhJTDq1TqGbYhauNu83w+aGHJ9OWyISBZir0kQZn82Mz82PseSvrb+6wZM x-ms-exchange-antispam-messagedata: HokYmDLBAHdnEHBVB2ZjtyvFvDJ7UnPXapTe+UcfKDsSHyEneCWUuy1o6bgN3SVwWfARIKX5+rv7LH+t/3qb5OPe0YqCHpRZDffiO8JZi1j2I08yQSlbyk6+rkklmcOFmZqltWOY1bno3STT/v162g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7589f115-a547-4328-08c2-08d7a6fa152e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2020 09:35:32.1518 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0qd0lIyd0S5qWP8l32IyVPClP4IUQeCRKoEwgH34RJt66i3f+7x7yM5rmw/1x1Lny9DXkCNrdvFUvp6NLsDxxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2799 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-01_01:2020-01-31, 2020-02-01 signatures=0 Subject: Re: [dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx path changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Friday, January 31, 2020 9:04 PM > To: Akhil Goyal ; Declan Doherty > ; Thomas Monjalon > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Pavan Nikhilesh Bhagavatula > ; Archana Muniganti ; > Tejasree Kondoj ; Vamsi Krishna Attunuru > ; Lukas Bartosik ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx pat= h > changes >=20 > Hi Akhil, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Friday, January 31, 2020 7:06 PM > > To: Anoob Joseph ; Declan Doherty > > ; Thomas Monjalon > > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > > ; Narayana Prasad Raju Athreya > > ; Kiran Kumar Kokkilagadda > > ; Nithin Kumar Dabilpuram > > ; Pavan Nikhilesh Bhagavatula > > ; Archana Muniganti > ; > > Tejasree Kondoj ; Vamsi Krishna Attunuru > > ; Lukas Bartosik ; > > dev@dpdk.org > > Subject: [EXT] RE: [PATCH v3 14/15] net/octeontx2: add inline Tx path > > changes > > > > External Email > > > > ---------------------------------------------------------------------- > > Hi Anoob, > > > > > > > > From: Ankur Dwivedi > > > > > > Adding pre-processing required for inline IPsec outbound packets. > > > > > > Signed-off-by: Ankur Dwivedi > > > Signed-off-by: Anoob Joseph > > > Signed-off-by: Archana Muniganti > > > Signed-off-by: Tejasree Kondoj > > > Signed-off-by: Vamsi Attunuru > > > --- > > > drivers/event/octeontx2/meson.build | 3 +- > > > drivers/event/octeontx2/otx2_worker.h | 6 + > > > drivers/net/octeontx2/otx2_ethdev_sec.c | 82 +++++++++++++ > > > drivers/net/octeontx2/otx2_ethdev_sec.h | 19 +++ > > > drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 181 > > > +++++++++++++++++++++++++++++ > > > 5 files changed, 290 insertions(+), 1 deletion(-) create mode > > > 100644 drivers/net/octeontx2/otx2_ethdev_sec_tx.h > > > > > > diff --git a/drivers/event/octeontx2/meson.build > > > b/drivers/event/octeontx2/meson.build > > > index 56febb8..be4b47a 100644 > > > --- a/drivers/event/octeontx2/meson.build > > > +++ b/drivers/event/octeontx2/meson.build > > > @@ -31,6 +31,7 @@ foreach flag: extra_flags > > > endif > > > endforeach > > > > > > -deps +=3D ['bus_pci', 'common_octeontx2', 'mempool_octeontx2', > > > 'pmd_octeontx2'] > > > +deps +=3D ['bus_pci', 'common_octeontx2', 'cryptodev', > > > +'mempool_octeontx2', > > > 'pmd_octeontx2', > > > + 'security'] > > > > > > includes +=3D include_directories('../../crypto/octeontx2') > > > > > > Why would you need cryptodev in event driver meson.build? > > If you really need it, then why only in meson.build, Makefile should > > also have some change. >=20 > [Anoob] On our platform, it's the eventdev which does packet I/O during i= nline > processing. So the Tx and Rx paths are embedded into event_dequeue_burst(= ) > and tx_adapter_enqueue(). Hence the need for such dependency. >=20 > I'll have the meson and Makefiles synced. Can send the updated series onc= e you > are done with the rest of the reviews. The dependency was added in > meson.build file when some build failure was observed. [Anoob] You are right. The above change is not necessary. I've confirmed th= at the build is not failing even without the above. Do you want me to send = a new version with this fix?=20 =20 >=20 > > > > Please make sure that all individual patches compile for both meson > > and Makefile. > > I have not run the test yet. Will run it on Monday. >=20 > [Anoob] Sure. From our end, we have all the patches passing the build sta= ges. In > case if there is any failure, I'll have it addressed with the next versio= n. >=20 > > > > Regards, > > Akhil