* [dpdk-dev] [PATCH] crypto/octeontx2: fix structure alignment
@ 2020-07-21 4:16 Tejasree Kondoj
2020-07-21 7:09 ` Anoob Joseph
0 siblings, 1 reply; 3+ messages in thread
From: Tejasree Kondoj @ 2020-07-21 4:16 UTC (permalink / raw)
To: Akhil Goyal, Ferruh Yigit, Radu Nicolau
Cc: Tejasree Kondoj, Narayana Prasad, Anoob Joseph, Vamsi Attunuru, dev
The structure cpt_request_info needs only 8 byte alignment.
This patch replaces __rte_cache_aligned of cpt_request_info
with __rte_aligned(8) and removes __rte_aligned(8) in
cpt_meta_info structure.
Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path")
Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
---
drivers/common/cpt/cpt_common.h | 2 +-
drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/cpt/cpt_common.h b/drivers/common/cpt/cpt_common.h
index 56bfea4953..0141b2aed5 100644
--- a/drivers/common/cpt/cpt_common.h
+++ b/drivers/common/cpt/cpt_common.h
@@ -76,6 +76,6 @@ struct cpt_request_info {
/** Control path fields */
uint64_t time_out;
uint8_t extra_time;
-} __rte_cache_aligned;
+} __rte_aligned(8);
#endif /* _CPT_COMMON_H_ */
diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h b/drivers/crypto/octeontx2/otx2_cryptodev.h
index f329741b38..a00f3d696e 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev.h
+++ b/drivers/crypto/octeontx2/otx2_cryptodev.h
@@ -38,7 +38,7 @@ struct cpt_meta_info {
uint64_t deq_op_info[4];
uint64_t comp_code_sz;
union cpt_res_s cpt_res __rte_aligned(16);
- struct cpt_request_info cpt_req __rte_aligned(8);
+ struct cpt_request_info cpt_req;
};
#define CPT_LOGTYPE otx2_cpt_logtype
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix structure alignment
2020-07-21 4:16 [dpdk-dev] [PATCH] crypto/octeontx2: fix structure alignment Tejasree Kondoj
@ 2020-07-21 7:09 ` Anoob Joseph
2020-07-26 19:09 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2020-07-21 7:09 UTC (permalink / raw)
To: Tejasree Kondoj, Akhil Goyal, Ferruh Yigit, Radu Nicolau
Cc: Tejasree Kondoj, Narayana Prasad Raju Athreya,
Vamsi Krishna Attunuru, dev
>
> The structure cpt_request_info needs only 8 byte alignment.
> This patch replaces __rte_cache_aligned of cpt_request_info with
> __rte_aligned(8) and removes __rte_aligned(8) in cpt_meta_info structure.
>
> Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path")
>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Thanks Ferruh for pointing this out.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix structure alignment
2020-07-21 7:09 ` Anoob Joseph
@ 2020-07-26 19:09 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2020-07-26 19:09 UTC (permalink / raw)
To: Anoob Joseph, Tejasree Kondoj, Ferruh Yigit, Radu Nicolau
Cc: Tejasree Kondoj, Narayana Prasad Raju Athreya,
Vamsi Krishna Attunuru, dev
> >
> > The structure cpt_request_info needs only 8 byte alignment.
> > This patch replaces __rte_cache_aligned of cpt_request_info with
> > __rte_aligned(8) and removes __rte_aligned(8) in cpt_meta_info structure.
> >
> > Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path")
> >
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
>
> Thanks Ferruh for pointing this out.
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-26 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 4:16 [dpdk-dev] [PATCH] crypto/octeontx2: fix structure alignment Tejasree Kondoj
2020-07-21 7:09 ` Anoob Joseph
2020-07-26 19:09 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).