From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82204A04F5; Thu, 12 Dec 2019 06:19:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE250374C; Thu, 12 Dec 2019 06:19:02 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id F26DE2BD3 for ; Thu, 12 Dec 2019 06:19:01 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBC5EkDX022583; Wed, 11 Dec 2019 21:19:01 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=SeUmAkLHaHKW4vWNOdoMcllPg8Nq7FLPs6RtmDHFI5A=; b=Cr3oSLAasTOhhaHiVaMn+9jUyR0O2zULveR6Q+bjAZk+0dYQTBQEGE8PEI+GUCd+vB4n IX1AIqsysiDbKAFo9WamNP762QLX4hj3cIy5yX4b0SImTqoAlFlCFcHBhe0MqnCymAiJ 4fsmO/4FUPzCUh6UylLlX+GOcNEjq5bLcZ1ERfNpe3W1W9J2IL5/JQ/6I/rwv9DPFvkY sKh16FgxdlKgRH/7SYTZYAUvxYbdvbU0OXj4X/lSky5O9g1727U3rAuQgSlpwDg5JoPj xw2AeEh4qc+CYLvSSeyA4jYU39vT7L75yTdt6byGJBpXJlCKIWGeGzZb+dcr3CBNcAtV Cw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2wue9mr5y8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 11 Dec 2019 21:19:01 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 11 Dec 2019 21:18:59 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.56) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 11 Dec 2019 21:18:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ITXVA/Tb9TkgqnRrvJRsCa64B9GNew9C3AM8hAqkdvFNgeonokQR9dadtJJ+5u5EtYARY9Ym3OttpPutrPyuUP9K3iR8zpQ9hVtlDjUui0ZmLRXno50HfKWsN9ylADMraO+0zqhKB/IUpUAmdbpkN6b1gI2IxhFELh6J9BiwiF7+mJYhZ3WvJgAPt2aS9+bXqYnWTcxlF/8r3lWAFi7ad45KMYbTsqQ0sgtEjCjhPXQfGjzRbckmUEVhJb61nntGZChe+AF/u9R9otosxdHaHQtj58/Pgz3FMGo6fmD91IbtBNmvT/XnpaN5xdBFV/79aZqYBHN3U/K94z2iQ83TUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SeUmAkLHaHKW4vWNOdoMcllPg8Nq7FLPs6RtmDHFI5A=; b=PDdlgT1iq237Bssc5Xz9Lx6wJLo2/C/zINc7wY0UWXhuiXvHxUfMxcV3VRQ8jG+oXxkG4RHur/iA6wNgoASxfQI/gpUSTpEZtokaeSCNbINt2To2ZqsunIL9wRjFTzCbR7a+TfUyKUOqqpyx2+sCajy/XjXD8GqYHLVKemkOZHQJKA1IqS/NwpfQRnR0iklZros+wQNZ3PrBwKALG6Dl4jnPTvahlmxozCXIu17MmbFlwbF+SmXtmLohwcmZgJozYSWy1cJsK4zTm0CAEcl8MBpKwa41ExctmIfO3jJL51jdztemPcJ8Z/EXu65ILxLNGybef6KHU1Pzx0qPKrmoiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SeUmAkLHaHKW4vWNOdoMcllPg8Nq7FLPs6RtmDHFI5A=; b=AW671Xz7U7qbdTQSVPsFMHwof4hA2p2gnHbSzPu8P0gbWe4Z2wWjACzv5FHPje4P0kqYTeDu/SES+w028HB2shyPv+77ekj/7gnaQt0FR3tyYdKM6uXNwWuuK/Rplu5YUeJ815TzdRbZ8GEsDupcFF3u1gYIGD5Pbz1txL+ev88= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2767.namprd18.prod.outlook.com (20.179.20.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.16; Thu, 12 Dec 2019 05:18:57 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::358a:10f1:5e8e:f6f]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::358a:10f1:5e8e:f6f%7]) with mapi id 15.20.2538.016; Thu, 12 Dec 2019 05:18:57 +0000 From: Anoob Joseph To: Akhil Goyal , Radu Nicolau , Thomas Monjalon CC: Jerin Jacob Kollanukkaran , "Narayana Prasad Raju Athreya" , Ankur Dwivedi , "Archana Muniganti" , Tejasree Kondoj , Vamsi Krishna Attunuru , Lukas Bartosik , Konstantin Ananyev , "dev@dpdk.org" Thread-Topic: [PATCH 04/14] examples/ipsec-secgw: add Rx adapter support Thread-Index: AQHVrcNvvkQaPkX8SU+43RsVeIOeI6e00iIAgAEnesA= Date: Thu, 12 Dec 2019 05:18:56 +0000 Message-ID: References: <1575808249-31135-1-git-send-email-anoobj@marvell.com> <1575808249-31135-5-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 934b0937-36dd-430e-e262-08d77ec2ca24 x-ms-traffictypediagnostic: MN2PR18MB2767: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0249EFCB0B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(199004)(189003)(13464003)(5660300002)(66946007)(86362001)(54906003)(186003)(64756008)(66446008)(110136005)(66556008)(66476007)(71200400001)(33656002)(26005)(316002)(9686003)(55016002)(76116006)(81166006)(81156014)(7696005)(6506007)(4326008)(53546011)(478600001)(8676002)(52536014)(8936002)(2906002)(55236004); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2767; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O8/4Znl5sRaysaB6Ho9l6QJ1IrDlWwg9081wxfbZmdVqzbZJIZrM1lOUvrktcD+Cgwhx/v/xKcgo6qJFSshosKnvNbOxkHJtJum2zSjfoc3+Q0eXsbLk5GeRh8vtm9VHFUs0gtmF2sNinz7mbM/U1gMI/buSGTHiej4aM/fQYRHfu1zk7Xd7n0a8vatF1bY9VPl/hT4+scis1nxw3V00Wyz8frRsPGENho/uGW1RnAGwd+XMbHdXZGkK4noNcb0WFyCzeAKFO98OAZArVWY6t+fiIIAzzErzfWeLpkLa1EdD+QGsoKHwR1ID9GFs5H55nMyebSUmWtLqVIGl6HOm1em0rr9RGDRNrF42kaa4lAFFgng6Zt7rdtsOlzgJG/qrguq6GMV/atWXgw8T0dbQXoDrnI4WSVfSxi2euf2WDrVwBfRTU3bl+57EcI6/KMdfHIn0oMmTkFbib/NMFdxAtH8EinIfgkFufl1AXhXX3O46prSbQwGQtncofGybN6ME Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 934b0937-36dd-430e-e262-08d77ec2ca24 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 05:18:57.0138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jucrbzXvWwIbrAYtWrJcIZAG+4EgwvYQ8xXZ/ONICUMMnKXaI/hMhCERFuLMrqTI/EloWIZdhPgvOnf1Pc9VwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2767 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-12_01:2019-12-12,2019-12-11 signatures=0 Subject: Re: [dpdk-dev] [PATCH 04/14] examples/ipsec-secgw: add Rx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, December 11, 2019 5:04 PM > To: Anoob Joseph ; Radu Nicolau > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Ankur Dwivedi ; > Archana Muniganti ; Tejasree Kondoj > ; Vamsi Krishna Attunuru ; > Lukas Bartosik ; Konstantin Ananyev > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH 04/14] examples/ipsec-secgw: add Rx adapter > support >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > I have just started looking into this patchset. Will be doing a detailed = review > soon. > But an initial comment. > Why do you need 1-1 mapping between event queue and ethdev queue. >=20 > All eth and crypto queues will be attached to eventdev. And there may be = single > event queue Or multiple but not necessarily equal to eth queues. [Anoob] You are right. We could have one single event queue which could han= dle all traffic. But the idea of more event queues is to better isolate ind= ependent traffic flows. If all traffic is forwarded to single event queue, = it could lead to artificial dependency between otherwise independent flows = and underutilization of resources. But having a single event queue is also a valid case, and we shouldn't have= that case failing. So I'll have an else case for the below check and would= adjust the code to work with single event queue. =20 > > + > > + /* Make sure there is enough event queues for 1:1 mapping */ > > + if (nb_eth_dev > eventdev_config->nb_eventqueue) { > > + EH_LOG_ERR("Not enough event queues for 1:1 mapping " > > + "[eth devs: %d, event queues: %d]\n", > > + nb_eth_dev, eventdev_config->nb_eventqueue); > > + return -EINVAL; > > + } > > +