From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07D2FA2EDB for ; Wed, 2 Oct 2019 12:48:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE51A1BEAA; Wed, 2 Oct 2019 12:48:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 88ED41BEA7 for ; Wed, 2 Oct 2019 12:48:10 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x92Akvk5024174; Wed, 2 Oct 2019 03:48:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=SY1XRMdLJJxytuMTgNBOvh/gsi7DZriIpbGCbttiXLQ=; b=J9y5ClBS4O2Sr3b23/7VxNjzX1pS4s4NuWXzQMJKghx8eTtZaTszHKWFu5fdwXWDQhdh bYffp5fQVXMbze4B7FnvK9QYp+om92iG+MgVUESkZw0UD9ECumMh0Is7RDZ0F8dwQDTp 893JwfrhijSOMZ+l9mkRLb8PCwK7q/Te6Cz8Dy2+fOz83WTrQTFqsoB6x/PK36g2pI9S Jl9M5fUtK5nAT1EoRhgfy1JWtu7qZVo1ar70nJ+BPaNo3FWPigQWzKXeV9ra96MKzlUQ 6P7ahiQfoqacpYUcBa5PMuZdo/0Nu4uh1mmyzPEkcL2UjmR9wm8JK8LhQMy5ZC4pq9Sc zw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2va71mpqp5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 02 Oct 2019 03:48:09 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 2 Oct 2019 03:48:08 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 2 Oct 2019 03:48:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AVbTDW5W/mFz8v2AHviO6i/D7eRjjiJPrvp1SlAoadXoysQF9vTm+s76/y93Hod6e5gV0Nahvh63ZOUCDSGiG88oDrNsEVhjaaHaH5lXQHnE2g8TaWywaOpjuXF34rNhbtPqj879ob832nk2lkWCj7JoZxs3IhgKBh+48pQa979IyS2JtPRKq6k3K5/WgqXhKk+jikVen+gStTTeif0gGfWfQJgMLlLiGd7HQkyBuJR7/dXtV8U0cQIN0S36egoFZ+8IDlFNWKpwUUb+qANqEk2/USwr/xJQ8E52B3ZThyINHvjEnpq9/dqlWZBaq+OLaW6y5UmKmX4U6vyGUubLjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SY1XRMdLJJxytuMTgNBOvh/gsi7DZriIpbGCbttiXLQ=; b=S2CEKN4GTvfFMoHJRTJhfK8TXNqFBl3ltp7wkOeRdF4Cg78zfUatLfGtUL1jQxITYtPrn0irz/RScKts1Fja87mbBVJyGrsyNMVZjDscnMIgQKoaXI2jPwLDJYZhPTSI6kCygtGZWTrFq2cQwKbaCg+Uvy6cB1B/bIcJWdk3IzSN65uU4CqF0Vteln6VY5UYcHgmfpU4Cxv78ukIegQpIyEZ+vzBZEm5/9z4lZmAuSu5cw5oCS+x1ph/UgP6ekAV1azsMuAE+c8GceGwzJNtW0mvSkrf3LuwDuYoPWEskIniFtPg9tRZR6e88lAS1LfarGePbNLzId/WEZ1Cih/8iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SY1XRMdLJJxytuMTgNBOvh/gsi7DZriIpbGCbttiXLQ=; b=rVfzklvGsqEfwsVJe7nI9m9ucX1u1yxSzNyJTk3dygMiBbsdx7Ejx6V/EgL0fXPsqXbS0y6gpiUbjLeb2vNnWr9iOmzQOX7yT498YykgkwfNb23VsMpDRlcqcqGJwKvqUbYa4fDLTUZ+nKtyVpAXnk5somOHqMycJ+ZVmNoIsQo= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB3359.namprd18.prod.outlook.com (10.255.239.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Wed, 2 Oct 2019 10:48:06 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::6d15:3367:4c9:5385]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::6d15:3367:4c9:5385%7]) with mapi id 15.20.2305.023; Wed, 2 Oct 2019 10:48:06 +0000 From: Anoob Joseph To: Akhil Goyal , Pablo de Lara CC: Kanaka Durga Kotamarthy , "Jerin Jacob Kollanukkaran" , Narayana Prasad Raju Athreya , Fiona Trahe , Shally Verma , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 2/8] crypto/octeontx: add RSA and modexp asym capabilities Thread-Index: AQHVZxKP6iG0B3bWUUaNsj9jqQwFl6dF3AiAgAFxrzA= Date: Wed, 2 Oct 2019 10:48:05 +0000 Message-ID: References: <1568035687-25492-1-git-send-email-anoobj@marvell.com> <1568035687-25492-3-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.175.98.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0fb2f503-773e-4e6b-d0d0-08d7472601ef x-ms-traffictypediagnostic: MN2PR18MB3359: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0178184651 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(376002)(136003)(396003)(366004)(189003)(199004)(13464003)(476003)(71190400001)(8676002)(8936002)(74316002)(33656002)(81156014)(81166006)(7736002)(305945005)(54906003)(110136005)(52536014)(2906002)(66446008)(66476007)(64756008)(66556008)(66946007)(76116006)(256004)(5660300002)(316002)(3846002)(6116002)(66066001)(71200400001)(86362001)(99286004)(14454004)(186003)(26005)(76176011)(25786009)(7696005)(478600001)(486006)(102836004)(53546011)(6506007)(6246003)(9686003)(6436002)(55016002)(229853002)(4326008)(11346002)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3359; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c643oDPlKpD57itFi2gp9NF/oJU7uze6mNBLUM2zNXM6bng3SKGhve9RS5tR9uB7HH2uMlVqV3qrhcq4Ywy3s7PQOIVfMzXel+hutuskYO/+UQgVMlXmQXroIgEuDFZ7NoW6D2KCaixmNIbulSbubcPGKT9XGTXijh9Wf7xUBguptcqggz5l7sq2yLL+G+sRlG7NdUWmOLwJbaBJZL12nRBC/1BNIxJVSY+sXQgwgeli3v+t6EbeHOpTOVe5K8JDZPiUZhNrvtMO8HELzYZf2+ydNqktIbh7lJ7A6CDpIaNy9o2yDy+BV8jpNhA3RZPx4gg5Z3NGtRBAdWDrSGzDO47e0dQR0CMuk/t9tG4INriaWMwFniwf/AvEqN+1lafp2FHIYMVHiMAFinGEEmjxdsx4xwqAshJvHCHMm5tEXHU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb2f503-773e-4e6b-d0d0-08d7472601ef X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2019 10:48:06.1618 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7Cl8ooCv0ITY7HcMEvJXaNX4u4XXlwg0jAuoefylJiFUEJcs+jRg9VyLoOP0ZiJ5HWiB7M065wb6bJKINFn8wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3359 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-02_06:2019-10-01,2019-10-02 signatures=0 Subject: Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx: add RSA and modexp asym capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, October 1, 2019 6:08 PM > To: Anoob Joseph ; Pablo de Lara > > Cc: Kanaka Durga Kotamarthy ; Jerin Jacob > Kollanukkaran ; Narayana Prasad Raju Athreya > ; Fiona Trahe ; Shally Verma > ; Sunila Sahu ; dev@dpdk.org > Subject: RE: [PATCH 2/8] crypto/octeontx: add RSA and modexp asym > capabilities >=20 > Hi Anoob, >=20 > > const struct rte_cryptodev_capabilities * > > -otx_get_capabilities(void) > > +otx_get_capabilities(uint64_t flags) > > { > > - return otx_capabilities; > > + if (flags & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO) > > + return otx_asym_capabilities; > > + else > > + return otx_sym_capabilities; > > + > > } >=20 > I believe this will give Asym capabilities always. As the feature flag > RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO will always be set, as the flags are > set in init. >=20 > It will never go in else. [Anoob] The flags is set based on the type of underlying device. The crypto= module on OCTEONTX exposes two kinds of VFs. One which does only symmetric= and one which does only asymmetric. Both are never supported together for = a VF, and hence the if...else. >From the first patch, crypto/octeontx: add device type mailbox routine switch (cptvf->vftype) { case OTX_CPT_VF_TYPE_AE: /* Set asymmetric cpt feature flags */ c_dev->feature_flags =3D RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | RTE_CRYPTODEV_FF_HW_ACCELERATED; break; case OTX_CPT_VF_TYPE_SE: /* Set symmetric cpt feature flags */ c_dev->feature_flags =3D RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | RTE_CRYPTODEV_FF_HW_ACCELERATED | RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | RTE_CRYPTODEV_FF_IN_PLACE_SGL | RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT; break; Hope this clarifies.=20 >=20 > > diff --git a/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > > b/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > > index fc62821..439b50e 100644 > > --- a/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > > +++ b/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > > @@ -8,10 +8,9 @@ > > #include > > > > /* > > - * Get capabilities list for the device > > - * > > + * Get capabilities list for the device, based on device type > > */ > > const struct rte_cryptodev_capabilities * > > -otx_get_capabilities(void); > > +otx_get_capabilities(uint64_t flags); > > > > #endif /* _OTX_CRYPTODEV_CAPABILITIES_H_ */ diff --git > > a/drivers/crypto/octeontx/otx_cryptodev_ops.c > > b/drivers/crypto/octeontx/otx_cryptodev_ops.c > > index 88efed3..b59a001 100644 > > --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c > > +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c > > @@ -105,7 +105,7 @@ otx_cpt_dev_info_get(struct rte_cryptodev *dev, > > struct rte_cryptodev_info *info) > > if (info !=3D NULL) { > > info->max_nb_queue_pairs =3D CPT_NUM_QS_PER_VF; > > info->feature_flags =3D dev->feature_flags; > > - info->capabilities =3D otx_get_capabilities(); > > + info->capabilities =3D otx_get_capabilities(info->feature_flags); > > info->sym.max_nb_sessions =3D 0; > > info->driver_id =3D otx_cryptodev_driver_id; > > info->min_mbuf_headroom_req =3D > > OTX_CPT_MIN_HEADROOM_REQ; > > @@ -635,7 +635,8 @@ otx_cpt_dev_create(struct rte_cryptodev *c_dev) > > case OTX_CPT_VF_TYPE_AE: > > /* Set asymmetric cpt feature flags */ > > c_dev->feature_flags =3D > > RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | > > - RTE_CRYPTODEV_FF_HW_ACCELERATED; > > + RTE_CRYPTODEV_FF_HW_ACCELERATED | > > + RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT; > > break; > > case OTX_CPT_VF_TYPE_SE: > > /* Set symmetric cpt feature flags */ > > -- > > 2.7.4