From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6A1BA2EEB for ; Thu, 12 Sep 2019 18:37:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 986591ECC5; Thu, 12 Sep 2019 18:37:30 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id BC90C1EAF9; Thu, 12 Sep 2019 18:37:27 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8CGYt9o013479; Thu, 12 Sep 2019 09:37:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=HSg0mGYZECHvZNALqNabLHq+SuYk2/VebAR5l0x04Z8=; b=iFTODhxXFIXP7PB+nquQIEKZ/JkWPlQaDV5sGpSiRC16sTf67qh7fZsV0DcsBUruqY7W R3mF8IiJ9salhkuFSSgKUEx25l0cEeuIOawuf05SGFAdkCUnzOs0mLA7NsIdWYHygYhI XN7ow45Df9xzZVr7gf0C7Hkh2y1ygVrt386BSIVvwF41plL1VI5FjG7rnsc/fMWqpoM5 idnUXlMxMLIEA16F74+WPmKdWX9d74KaTYkC72VSMWsshnR29JkpgGxQCVXhBxgowtxM XxmGSx9NyHvJdp9SGnDxpD76T81L6thJCvU1t/+uM07mGkzj4AuQWeHYY/RqaNdQkvc+ qg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2uvc2jygf7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 12 Sep 2019 09:37:26 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 12 Sep 2019 09:37:24 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.55) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 12 Sep 2019 09:37:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oF+f16KUQ3/15GTz9hJdfV8bnEvq/0KN60mRrR63Xp5W4gaIxDS+9TTsZd+o8MEF3hICBO3LRVCGvTYZNSnyaqmysOWFAqMfDASSGz3BMZ9u1L7WCawp1KSy6bHvMq3Rw+0zcp+nrXbVKQERFMhu5TStrDXOErW4soBBJvmCGeUxOPgVVaszlBlr90ALvFHzx7Xk/VGiAxskUCWZMwunfPLbtLMwAzE2JFx69pwVUYsP35Ujqy0M0v3aaC7RvQqQ+5Mc/CEyMgltKDnFEq6kuP4ptgoLbFqBVv/jK6L/UcSG194hqJuf+fBsoPvJNJsrXWPKtI0Tj7xitWhMmvDbog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSg0mGYZECHvZNALqNabLHq+SuYk2/VebAR5l0x04Z8=; b=aQ0jFkswPY07Y3SC84RE8U9/toRt21b6K8JTX8fg+Yg8GdjkkpdAC2iNwb1rC+ubfttWVY7GEDSaTdIeeK6xgntDcP6RwM0fHVUGfI9v2B9neapu4AgeNyFYkO4aOeJbiZYfpGVcu5WFpASbg6DuHqynyuE7klXyygGEOKCJLMv1+p6Nj346c1y5rPV5lJeYRrMgpKmnSGbaCTxIwKM7m5i3d8aGjobbtRADoZYVkUihHB5F8Zb6oQpdObvi3huIe166gBtUDzw24xIuGotan7VRi+AmJuyaezE+sWRtKQK6cfJzYc7a+n6NibcOy3nc/aHuSBxofvVc0Yjb9QaUCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSg0mGYZECHvZNALqNabLHq+SuYk2/VebAR5l0x04Z8=; b=GIqc4akTB4BRV3592iHgnhgakhqtcXIpcUR0RqMNz7myLgNfcORVFs/7z+NzDchHiHt798ttQPUjvxmRlMsBWkB1fCU2xwhSnwAMztql5t310Jkd/o2u/aA2l8dxTqIef3ftSw0TQGpVYheyHAXHSzOAcrIO2N1Xkrmx3//dfkQ= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2528.namprd18.prod.outlook.com (20.179.80.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Thu, 12 Sep 2019 16:37:23 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa%7]) with mapi id 15.20.2241.018; Thu, 12 Sep 2019 16:37:23 +0000 From: Anoob Joseph To: Thierry Herbelot , "dev@dpdk.org" CC: Thomas Monjalon , "stable@dpdk.org" Thread-Topic: [EXT] [PATCH] drivers/crypto/octeontx: enable unbinding for the OcteonTx crypto engines Thread-Index: AQHVaLsJf350etiRB0eKIhPqtxgs7qcoPi2A Date: Thu, 12 Sep 2019 16:37:22 +0000 Message-ID: References: <22e44c87c26193219900e738dcda9b1390efcb9c.1568217224.git.thierry.herbelot@6wind.com> In-Reply-To: <22e44c87c26193219900e738dcda9b1390efcb9c.1568217224.git.thierry.herbelot@6wind.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2405:204:d304:6415:d021:38ca:3217:b107] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bcd6cae0-25e9-408e-9c3f-08d7379f7d19 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2528; x-ms-traffictypediagnostic: MN2PR18MB2528: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 01583E185C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(366004)(346002)(136003)(396003)(199004)(189003)(13464003)(486006)(86362001)(316002)(446003)(52536014)(74316002)(7736002)(81166006)(305945005)(4326008)(476003)(11346002)(81156014)(8676002)(8936002)(6246003)(53936002)(186003)(102836004)(6506007)(53546011)(76176011)(229853002)(55016002)(9686003)(46003)(99286004)(110136005)(7696005)(54906003)(66556008)(66446008)(64756008)(33656002)(66476007)(6436002)(2906002)(76116006)(2501003)(66946007)(6116002)(71190400001)(14454004)(256004)(478600001)(71200400001)(5660300002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2528; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7ZDgG1cOZwTK9yf6kMzB7NNRO/yr64gBRgMXPkPn/DTHChGx+/xP4MFGtortko0bFugqTkBkDr+0cLCvYcu19BFw1zmkkZJpslFVFcENbfbcyevNPYuHKPNYzIKGQiKDBIjMyx3FM5mWe0DxoY3PU38EAGXkvnp1OcW8gNLdHYUN+lP0La1EXfIAhcNqvqsKPB+3QGc1WOVQ6DxzK0s+DFDS7aE6l/vpP9OOLPHvjj4SjJ9aJnJIYwmmh3TmeSRJhkOmJ9hlWbRiqPeUBMPcgC5tjEu/GBaKHNF9IFS6tpaxqBnqAxx9KBwHYQLXw8Xh/q/86VGjdgCIy7JDamXSAbCFvVMl+uPXWyIfDcQXPrVKOsBuuAubt5uNEoaTZuI0Je1GrWEIMu0q3XBu0F6CheW9WL1W+Iyf2nSNg7lFuI4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bcd6cae0-25e9-408e-9c3f-08d7379f7d19 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2019 16:37:23.0574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cfdf//5MpSLc9RHjSc7FM3Dou+JQObJ8orOC/A0ibCCakWKqYfKecYwbV4ZtXYc+CydETbVutCaRaJBDnsrZcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2528 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-12_08:2019-09-11,2019-09-12 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH] drivers/crypto/octeontx: enable unbinding for the OcteonTx crypto engines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thierry, Thanks for looking into this. Please see inline. Thanks, Anoob > -----Original Message----- > From: Thierry Herbelot > Sent: Wednesday, September 11, 2019 9:37 PM > To: dev@dpdk.org > Cc: Thomas Monjalon ; stable@dpdk.org; Anoob > Joseph > Subject: [EXT] [PATCH] drivers/crypto/octeontx: enable unbinding for the [Anoob] The subject has to start with "crypto/octeontx: ...". Please correc= t this. Also, please use OCTEON TX instead of OcteonTx here and in the description = below. =20 > OcteonTx crypto engines >=20 > External Email >=20 > ---------------------------------------------------------------------- > Like for Ethernet ports, the OcteonTx crypto engines must first be unboun= d from > their kernel module, then rebound to vfio-pci, before being usable in DPD= K. >=20 > As this capability is detected at runtime by dpdk-pmdinfo, add the info i= n the > PMD registering directives. >=20 > Then an external script can be used for bind and unbind. >=20 > Fixes: bfe2ae495ee268 ('crypto/octeontx: add PMD skeleton') > Cc: stable@dpdk.org > Cc: anoobj@marvell.com >=20 > Signed-off-by: Thierry Herbelot > --- > drivers/crypto/octeontx/otx_cryptodev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/crypto/octeontx/otx_cryptodev.c > b/drivers/crypto/octeontx/otx_cryptodev.c > index fc64a5f3041f..16f1909966d0 100644 > --- a/drivers/crypto/octeontx/otx_cryptodev.c > +++ b/drivers/crypto/octeontx/otx_cryptodev.c > @@ -118,6 +118,7 @@ static struct cryptodev_driver otx_cryptodev_drv; >=20 > RTE_PMD_REGISTER_PCI(CRYPTODEV_NAME_OCTEONTX_PMD, > otx_cryptodev_pmd); > RTE_PMD_REGISTER_PCI_TABLE(CRYPTODEV_NAME_OCTEONTX_PMD, > pci_id_cpt_table); > +RTE_PMD_REGISTER_KMOD_DEP(CRYPTODEV_NAME_OCTEONTX_PMD, "* > igb_uio | > +uio_pci_generic | vfio-pci"); > RTE_PMD_REGISTER_CRYPTO_DRIVER(otx_cryptodev_drv, > otx_cryptodev_pmd.driver, > otx_cryptodev_driver_id); [Anoob] Only the following change is required. Can you send a revised patch= with this change? RTE_PMD_REGISTER_PCI_TABLE(CRYPTODEV_NAME_OCTEONTX_PMD, pci_id_cpt_table); +RTE_PMD_REGISTER_KMOD_DEP(CRYPTODEV_NAME_OCTEONTX_PMD, "vfio-pci"); RTE_PMD_REGISTER_CRYPTO_DRIVER(otx_cryptodev_drv, otx_cryptodev_pmd.driver= , >=20 > -- > 2.20.1