From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43157A0524; Fri, 31 Jan 2020 16:33:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 172101C0CD; Fri, 31 Jan 2020 16:33:36 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 1D4E21C0CC for ; Fri, 31 Jan 2020 16:33:33 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00VFU8W4015775; Fri, 31 Jan 2020 07:33:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=PUPbxgab9RSi/5KS+uBQPlkn+R1RdxIVl+3HWGm0TdM=; b=YffzfgCLrC3DgYQo3T/8z8+nVqQT/DyuRnIi6VorMP+v1Dvq01yASPbjSkT65ZPXJwtO 55694M+7vgdI9VsX7f4vWgKXpKFyVdNQotfci7qbb0tpBVtsjQhtvPGR2Ylo6PlrQPFg zPhfFweCv2Lf4jrduL4xbMxu4nfxVX2e4d3ZEbdfC0Qnu1/sHjBjqcgSVi30CkoUjv7y fUByCFK19m6uuiczPM3jpNdz/ro7ti8ujCg+uGkjM94S01FiahA7DfX1hDgAC1AvS9SD 7/V47RuFAjyWBIOGKxhAW/6mJaO9dU3PA9HTubQQ9wv2+qdodbc7eEdHn0XKJ33RjjmA Tw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2xvpas8573-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 31 Jan 2020 07:33:33 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 31 Jan 2020 07:33:31 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 31 Jan 2020 07:33:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HzW5gpvSuwqBFpzzcz2Sq/s3KWQdFqg8AP7Rj2c6o7jQPN9bzlqMg0ijoUjyJATrSgHDVz+C24huJIp6bs9UfSGZTyP3CCN/KC47wIi20fs5k8uGnDXJsrKl10qRntmroqksMHxTUsm5Af9UJVA8sQgLBRoiwDAY+X35Pw6dWTrHU4m94MCYcwwqxOeYmTo7uRGiUauX4njZf3AqY6/ulkiBAlSVQml2lOOMq+qzhMW3TsEcFKuZBfvu59agJPtgEmeMqtNO8gsarg9XMWhdqjA7zwVw3PzIUukHUo6FHfAGuSNVQHYuffgx5kW6Qg0q8HM81lzY12HryXt9TJQm0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUPbxgab9RSi/5KS+uBQPlkn+R1RdxIVl+3HWGm0TdM=; b=RBWKpg1eAbl5g5toHpAbRf/bnW8caiR37IDyvpfan1f/7hop1gV2xyzomPog9hWsC+lDc8qJ1eqK6ITNn3WWdjZ4nORzE5hTUhPLSuiN1kbCve0Xskts3uGJES/Sa8oS1qIq+/dTFmQyIdt8L3D0kEL3ScpMXX0PJ9Ci5BQqkTTlES2DJwX9gnUg9WjQK38ZQf/LAZXDGaXefXh3R8NpVljrZwQmeVbAWfNCQZAq9tHrBR7XgZiGQMO5i1oi+Rjx7tUQDOGD3gcI4100gIyxRwKXuM1IABWX1FBzmcLMpQP+Vq0OXB7iRVrac4Q8DluPtwdW0r41gntP6pGIFiAVCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUPbxgab9RSi/5KS+uBQPlkn+R1RdxIVl+3HWGm0TdM=; b=Ju8z4k4wmBtWDIrUR3LYGQIQk77OIqi8EeQo7fOzUYSZtZoSpnVQmSKBtpvLxITqjChewdZMjYsxhGtA79BaCs9lP+o8RN/b6z+zbUlt6kUH5OodqPXTVI9vVdDxDHPq1lf3JiljqwjoAUuRsQB1Edy4FjFoNMxFL5SsFufsTpM= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2896.namprd18.prod.outlook.com (20.179.22.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.20; Fri, 31 Jan 2020 15:33:30 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572%7]) with mapi id 15.20.2686.028; Fri, 31 Jan 2020 15:33:30 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Thomas Monjalon CC: Ankur Dwivedi , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Pavan Nikhilesh Bhagavatula , Archana Muniganti , Tejasree Kondoj , Vamsi Krishna Attunuru , Lukas Bartosik , "dev@dpdk.org" Thread-Topic: [PATCH v3 14/15] net/octeontx2: add inline Tx path changes Thread-Index: AQHV2B4LKct+Zf6JVUywgmLVc/H7yqgExpWAgAAeJJA= Date: Fri, 31 Jan 2020 15:33:30 +0000 Message-ID: References: <1579344553-11428-1-git-send-email-anoobj@marvell.com> <1580465035-30455-1-git-send-email-anoobj@marvell.com> <1580465035-30455-15-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.250.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e4ed68d1-e867-4653-2253-08d7a662ec93 x-ms-traffictypediagnostic: MN2PR18MB2896: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 029976C540 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(189003)(199004)(33656002)(71200400001)(478600001)(8936002)(81166006)(316002)(52536014)(110136005)(81156014)(5660300002)(66946007)(76116006)(54906003)(66476007)(8676002)(66556008)(64756008)(66446008)(86362001)(2906002)(55016002)(4326008)(26005)(7696005)(186003)(9686003)(53546011)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2896; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PJIDIPLbuK970vzbRM4SKrNZd24DsooJd1Osui6S46sNJIYSQV+EAENoFhYaRi719r0KYkG0rQI75cHQmpX8LY15dMswcQkSVn30hImqO6YYCDjx8WVksqNd2UtKyOOpNmbPnZwpBJSzv8ojlx1wDrkF3u0B0Q/pGzNAakIj8wWGHlo3QSMcAhbd7aO95ZQSTyb+3r19Df9PytvrE2MHWQ7Tps/Ms7OT68oughPYuf2LNcHcySDoQuLdx9tnZAbhpO/rOa5G80TmYDsj/v1V2HpSsNpx8fO14BZlTDDD+5Uwa5rYSiXVGNEp/9etwS94Uo8nwkRSl++hMwqStPwEaQlPZ0qGli2cCPti+StGyQ4+sMv/pQ1fHT/Eb6gNWhknSkB6AE/eZDfnyZbqxGV4duyfOuHXZ3FFMkq20cGgn6WFJdZA7/19cNR28WeKKjnb x-ms-exchange-antispam-messagedata: HkXCJH4q8RDQo+6nxumrzsINNRz4aMKXtnmwWPvhz4/CaiJ4YW1AkzcfvWOvwsmhBXtZcPVXWRV02fAAz2ikOldK0Ea+r8FbUK/8OzMv5zaKTKvyzW+snVWRSDMEbKvmNLu1jdQj3uS+9ktXVIO43Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e4ed68d1-e867-4653-2253-08d7a662ec93 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2020 15:33:30.0796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h/y3q++dtaZ6ctRn5jQNza/ffi0yTKjrlaDsbqlXjDZfJv3aSKiAvyywExkBvD9EkwzYJzmIpZiNr9zzteD+Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2896 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-31_03:2020-01-31, 2020-01-31 signatures=0 Subject: Re: [dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx path changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Friday, January 31, 2020 7:06 PM > To: Anoob Joseph ; Declan Doherty > ; Thomas Monjalon > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Pavan Nikhilesh Bhagavatula > ; Archana Muniganti ; > Tejasree Kondoj ; Vamsi Krishna Attunuru > ; Lukas Bartosik ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH v3 14/15] net/octeontx2: add inline Tx path cha= nges >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > > > > From: Ankur Dwivedi > > > > Adding pre-processing required for inline IPsec outbound packets. > > > > Signed-off-by: Ankur Dwivedi > > Signed-off-by: Anoob Joseph > > Signed-off-by: Archana Muniganti > > Signed-off-by: Tejasree Kondoj > > Signed-off-by: Vamsi Attunuru > > --- > > drivers/event/octeontx2/meson.build | 3 +- > > drivers/event/octeontx2/otx2_worker.h | 6 + > > drivers/net/octeontx2/otx2_ethdev_sec.c | 82 +++++++++++++ > > drivers/net/octeontx2/otx2_ethdev_sec.h | 19 +++ > > drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 181 > > +++++++++++++++++++++++++++++ > > 5 files changed, 290 insertions(+), 1 deletion(-) create mode 100644 > > drivers/net/octeontx2/otx2_ethdev_sec_tx.h > > > > diff --git a/drivers/event/octeontx2/meson.build > > b/drivers/event/octeontx2/meson.build > > index 56febb8..be4b47a 100644 > > --- a/drivers/event/octeontx2/meson.build > > +++ b/drivers/event/octeontx2/meson.build > > @@ -31,6 +31,7 @@ foreach flag: extra_flags > > endif > > endforeach > > > > -deps +=3D ['bus_pci', 'common_octeontx2', 'mempool_octeontx2', > > 'pmd_octeontx2'] > > +deps +=3D ['bus_pci', 'common_octeontx2', 'cryptodev', > > +'mempool_octeontx2', > > 'pmd_octeontx2', > > + 'security'] > > > > includes +=3D include_directories('../../crypto/octeontx2') >=20 >=20 > Why would you need cryptodev in event driver meson.build? > If you really need it, then why only in meson.build, Makefile should also= have > some change. [Anoob] On our platform, it's the eventdev which does packet I/O during inl= ine processing. So the Tx and Rx paths are embedded into event_dequeue_burs= t() and tx_adapter_enqueue(). Hence the need for such dependency. I'll have the meson and Makefiles synced. Can send the updated series once = you are done with the rest of the reviews. The dependency was added in meso= n.build file when some build failure was observed. >=20 > Please make sure that all individual patches compile for both meson and > Makefile. > I have not run the test yet. Will run it on Monday. [Anoob] Sure. From our end, we have all the patches passing the build stage= s. In case if there is any failure, I'll have it addressed with the next ve= rsion. =20 >=20 > Regards, > Akhil