From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2182BA046B for ; Mon, 24 Jun 2019 05:40:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F64B1BF12; Mon, 24 Jun 2019 05:40:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 67EEE1BF11 for ; Mon, 24 Jun 2019 05:40:20 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5O3eJsm018114; Sun, 23 Jun 2019 20:40:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=6+PNXzk3UDh4/93IdEADMgr3tcyTgV8QslscB5SI7ug=; b=GMWYOO5EZ5+4aH9CxL5eWgrjtOduFJsJmBPr+QgyBjJIP+PiLAkeVku0z6G6/HEdVCtV O6xMRFrnN8NpK1mLDkan4PPqP97tKfFHBVTHAbzNR7d6PHZ6z2s+DW+unlq+SIsqeIrA kIrGkhfFxiTYP+eC8hefEQcIwydbd05PonGTVng1RHngVkLlHlt8dykUw8gu8QnIO4Cy GRUMds25V9S1bGPW2GOQLdRb7cFaJH5FOUgFPf69jm4JxYAM7JLDpjMRqVTm6AjWxlIg uAJyd4U6I58kpMt7Hpy9Cf0d7+CluAWz1/fYo4b0sNY5lFurh59XV/Bx15oRLjievCXB Lg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2t9hpnwt3x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 23 Jun 2019 20:40:19 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 23 Jun 2019 20:40:17 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sun, 23 Jun 2019 20:40:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+PNXzk3UDh4/93IdEADMgr3tcyTgV8QslscB5SI7ug=; b=lDr5qqg3VDjdwWg7gezFx+PhH2IBjBSlIiv5TlGEt0e0Zy9z6MO403Ye8IRg068w98ZW5c3NlmVQ90enTT+Z2Ud1+6F9pS6ekfbLp29IK2Ec+X8ox+f3lXudKszdxuESQOCl2+TM6tRgkfUd/vSG956pv1O7GJgsYG+/TZj7iQE= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2590.namprd18.prod.outlook.com (20.179.81.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Mon, 24 Jun 2019 03:40:13 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::595e:3b6c:3d12:7285]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::595e:3b6c:3d12:7285%7]) with mapi id 15.20.2008.014; Mon, 24 Jun 2019 03:40:13 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Fiona Trahe , "Pablo de Lara" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , "Narayana Prasad Raju Athreya" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH] cryptodev: add ff_disable field in cryptodev config Thread-Index: AQHVKDK1OPbvNsutc06BsyG8LvuSD6aqLIMQ Date: Mon, 24 Jun 2019 03:40:13 +0000 Message-ID: References: <1559575528-5363-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd48bb50-b476-4db8-c80c-08d6f855aa84 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2590; x-ms-traffictypediagnostic: MN2PR18MB2590: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 007814487B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(136003)(366004)(396003)(346002)(376002)(13464003)(189003)(199004)(446003)(102836004)(8936002)(33656002)(305945005)(66946007)(229853002)(55236004)(478600001)(74316002)(53936002)(81166006)(81156014)(64756008)(66446008)(86362001)(9686003)(26005)(316002)(73956011)(14454004)(76116006)(4326008)(486006)(7736002)(66556008)(256004)(76176011)(6116002)(11346002)(6436002)(54906003)(476003)(110136005)(53546011)(6506007)(2501003)(68736007)(3846002)(66476007)(66066001)(107886003)(6246003)(55016002)(71200400001)(7696005)(71190400001)(5660300002)(2906002)(186003)(25786009)(99286004)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2590; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Es7IIL8cLqNmTSPAvN4WP1u2HgPnIrvdjTPMwSwc+6C+Mh/rMB+lzjm9VENEB4HxfRIS63QxCSsNjvNwmws3Dlir5TFjZuwU+YP6OhJtOTv6WaOSJpf8t44pXZLwHUOduzhHAPpZHbiUPHriHNRideRDT95DNUV9GYIvOKEfz+G6arPzxg1mblHjxkWONNMM2stqv2LK0dlIbNwHlzWTQjOfvSTWUXt2XlDIJZqTjpD+FvBvP61Q4nam8+hBOWdE60cKfIs+z27Ryaq3mn8NEqBzE7kSTaoiOE86hHsU98khibskYb7wz7HQHKVKvdYD5ukvMBZ+CJJGCsS3KW4KZTGdlq2WbhVfHXGig5iEvDHomQSbAgbyW0P+oVX1U/aV69gBOyUqN515MYgdeIYNJ/vPd/M8+hW+imeiV0lapMU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fd48bb50-b476-4db8-c80c-08d6f855aa84 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2019 03:40:13.5741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2590 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-24_03:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] cryptodev: add ff_disable field in cryptodev config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, I'll fix the issues and send a revised patch. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Akhil Goyal > Sent: Friday, June 21, 2019 6:40 PM > To: Anoob Joseph ; Declan Doherty > ; Fiona Trahe ; Pablo > de Lara ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya > Subject: [EXT] Re: [dpdk-dev] [PATCH] cryptodev: add ff_disable field in > cryptodev config >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > > > > Adding a new field, ff_disable, to allow applications to control the > > features enabled on the crypto device. This would allow for efficient > > usage of HW/SW offloads by disabling the features not required by the > > application. > > > > Signed-off-by: Anoob Joseph >=20 > I see a compilation issue with this change. > /home/akhil/up/dpdk-next- > crypto/examples/fips_validation/fips_dev_self_test.c: In function > 'fips_dev_auto_test_init': > /home/akhil/up/dpdk-next- > crypto/examples/fips_validation/fips_dev_self_test.c:1560:9: error: missi= ng > initializer for field 'ff_disable' of 'struct rte_cryptodev_config' [- > Werror=3Dmissing-field-initializers] > struct rte_cryptodev_config conf =3D {rte_cryptodev_socket_id(dev_id), = 1}; > ^~~~~~~~~~~~~~~~~~~~ > In file included from /home/akhil/up/dpdk-next- > crypto/examples/fips_validation/fips_dev_self_test.c:5:0: > /home/akhil/up/dpdk-next-crypto/arm64-dpaa-linuxapp- > gcc/include/rte_cryptodev.h:615:11: note: 'ff_disable' declared here > uint64_t ff_disable; > ^~~~~~~~~~ >=20 > Please add a patch for all applications which use struct rte_cryptodev_co= nfig > and set the default values of its parameters. >=20 > > --- > > doc/guides/rel_notes/deprecation.rst | 14 -------------- > > doc/guides/rel_notes/release_19_08.rst | 11 ++++++++++- > > lib/librte_cryptodev/Makefile | 2 +- > > lib/librte_cryptodev/meson.build | 2 +- > > lib/librte_cryptodev/rte_cryptodev.h | 7 +++++++ > > 5 files changed, 19 insertions(+), 17 deletions(-) > >