Re: [dpdk-dev] [PATCH 01/11] crypto/octeontx2: add PMD skeleton

[Anoob Joseph <anoobj@marvell.com>]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Friday, October 4, 2019 4:52 PM
> To: Anoob Joseph <anoobj@marvell.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>; Thomas Monjalon <thomas@monjalon.net>
> Cc: Ankur Dwivedi <adwivedi@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
> <pathreya@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>;
> dev@dpdk.org
> Subject: RE: [PATCH 01/11] crypto/octeontx2: add PMD skeleton
> 
> Hi Anoob,
> 
> > diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
> > index 83e7886..3c88f3c 100644
> > --- a/drivers/crypto/meson.build
> > +++ b/drivers/crypto/meson.build
> > @@ -2,8 +2,8 @@
> >  # Copyright(c) 2017 Intel Corporation
> >
> >  drivers = ['aesni_gcm', 'aesni_mb', 'caam_jr', 'ccp', 'dpaa_sec', 'dpaa2_sec',
> > -	'kasumi', 'mvsam', 'null', 'octeontx', 'openssl', 'qat', 'scheduler',
> > -	'snow3g', 'virtio', 'zuc']
> > +	'kasumi', 'mvsam', 'null', 'octeontx', 'octeontx2', 'openssl', 'qat',
> > +	'scheduler', 'snow3g', 'virtio', 'zuc']
> >
> 
> Could you please rearrange this list as every pmd in a separate line as it is there
> in net/meson.build.
> 
> Every time a new PMD is added people need to realign this list.
> 
> >  std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
> > config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
> 
> Regards,
> Akhil

Will make the suggested change.

Thanks,
Anoob