From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC17AA0531; Tue, 4 Feb 2020 05:11:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0628D1C01E; Tue, 4 Feb 2020 05:11:22 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 82B3D1BF02 for ; Tue, 4 Feb 2020 05:11:20 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0144Aef7028575; Mon, 3 Feb 2020 20:11:19 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=HG/wMxAVggMDtF4MobtUYt31tmlLdjPCsAXntNiyaKg=; b=v8LdxEhYkgWYajrHe6VGW2jLEckwiY6uvLhx94RcfnQ7HdmM0p2TeR0k3dr9eW4J343s H/y/Fcc4v6BhSmRCh1MXAUfdexYTwlFZLfjvIYLtNk2hpp8b8fglZr2uobIut2FdPXgF tS3e5hEodMjTDC6ZCL6NO2Kw+kYFBPXsfrXrESEYXqnnPBDZ+RZDloSzlbvtdhPf5u4I c/vuIz+t+JFxg8v1rQ8ASAQxZdY/gS3O0ragXm+KkS7++RUTT9aLw3ZewcoyOtefWyl4 yHxfF3zL0GV4Fnltpk+l21e7ozBWJ4O+XRhVyAL5bW3tJfRvlqffz6o+S2mFZLZYs32s MA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2xw7jvjpf0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 03 Feb 2020 20:11:19 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Feb 2020 20:11:18 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 3 Feb 2020 20:11:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APS7rHYS9X82ewx3F7DG7cUWX1GOOGZ09Gny4OwmCuLHc7O/ZdftpaK2qkYdkfh4BV3uUf9Tmz4nYBCGXhhK+PfyeUWcZFPaAiT9sJ9uFHJZ+4z3SMIbw4Mduz4fHSjXFPbCBda2ne5ETEdFKPdzixLw2S/2IxZskgoMSR6JtIwSCX+1kAZMYzDgNQ5gB7KwSbf4itZaDZLjCLR29VwB2iXI0Yb088h+ekX+ubBcpPSy36Qmq+ULloGFaDWIt5aIhowQtthW0bOPz+iKv1ADQpohXpZz08EgC4bCClu8bZrBiLMzS8Igm4eYMaPz/jQUNoQPF1CYAD0apgKW03UiUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HG/wMxAVggMDtF4MobtUYt31tmlLdjPCsAXntNiyaKg=; b=jn/YXCuWXCxt9PwXU9rnAnWkbwfLxxVOP3aIP0LltMjkdx0jp7TvF7vmdluYu5NhoFMLWLngrFwan9dxCWtpSjDV+vSCjxbUE+CZWbV5IyQhA/7ntRVizvlolBC0RhI2NBCsByPr/WUs91sL83OCJoANXk/0xAMSwQ695R/o/BccjJDgwlmaL+mueYjwoz3zFW3IRauuQK0TOu4bKsbYcz519L0W8fnO989iDtkkMWajPFKe6wOcGoVubv5QpVed5VoBVy5gskqYLNQQwS8rHcfXzul4XukIFWhx5O/ikSMJtaCA90oCjT4qL5438wzGWDFsABhjd2wdqsCdO9gY9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HG/wMxAVggMDtF4MobtUYt31tmlLdjPCsAXntNiyaKg=; b=ACBkplw2muaWMObChEYgAc98qy7jsBBcCzCnwBXILMDjs67C4XrxLjJY7Z2aRsrhsjpxNUO/HJrnufKgX45SAOKoFeudaUIOMwUf61NV10BgKln2rS2b03AS8E0SjWcMhASRMxcF/HyZv5igJ39FKgLbhkMIkRK0JV/EwFqL5pE= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2960.namprd18.prod.outlook.com (20.179.22.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Tue, 4 Feb 2020 04:11:16 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572%7]) with mapi id 15.20.2686.031; Tue, 4 Feb 2020 04:11:14 +0000 From: Anoob Joseph To: Akhil Goyal , Vladimir Medvedkin CC: "konstantin.ananyev@intel.com" , "dev@dpdk.org" Thread-Topic: [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw Thread-Index: AQHV2DVo6nkG9YBo8k6LJ9V06sYaIKgKcR2g Date: Tue, 4 Feb 2020 04:11:14 +0000 Message-ID: References: <1579012036-326214-1-git-send-email-vladimir.medvedkin@intel.com> <1580306768-110555-1-git-send-email-vladimir.medvedkin@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 676f061b-b988-4e1c-aefb-08d7a92846bf x-ms-traffictypediagnostic: MN2PR18MB2960: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:935; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(110136005)(55236004)(86362001)(54906003)(7696005)(6506007)(478600001)(9686003)(33656002)(2906002)(186003)(55016002)(316002)(71200400001)(26005)(52536014)(76116006)(66446008)(64756008)(66556008)(66476007)(66946007)(8676002)(81156014)(4326008)(5660300002)(81166006)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2960; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o6+VAoO4qa8fyKySE1tvb0GiFKozHtSov84NYCt8LNt5omdmfId8Brsy6ekWIyZ0SAf6z4/tUx4Jff8ku0D4F22KeEQcfi5YDEqrLBPzJzjdPncmPrMTp5WE71NLtftU76OO0DU4OASdz6sqpYS4VRtElfVUHEB+PRJhxbauTReep16IqxjsZruOvgiPHnifcAvwIq7l4L/fgS7qOhv/FZJRKjjQqJx3EaZGVN258TjPyyhd/HjzcC63v9D65toHxFRdHftWAYXJuG/v1TaEXzapx1J2q0dgbBWjXZdIawtCPvyTZtzXNTVWie64G6HG5NN7FJdPrSW53D0HDvT8zSDubL/9VgBYEfBUxvJV8wwBeYnLHgluYOP66+zVisEbJvlqXU/oX7Y922Y/k/5Xx++q+svSQ5MmuB/YaLW8gHatktLAaAWvku4lVn0Nkp5x x-ms-exchange-antispam-messagedata: ZXtU/AXPCURRaTbhDib6tX9ZLnbgQF7juJElkE5+0UF+p5zkQEWd2iw5E+fUtfWsrzLlAWIq42psCYnG3IuVU5AMIbRRAVAQ5BZI5KDSl8kSEL1XbbidYrj1HJyZP5dLvsIMi7adrIwR2uYmLICoPw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 676f061b-b988-4e1c-aefb-08d7a92846bf X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 04:11:14.5218 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MMHsTrNLRuIQlR9WUV9aHhnfZtj6CmvvmxNEK2SPrKVei/2u2m3yRMKXBtNYFg2u6RwnuGDtJUDZ3LueN38MbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2960 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-04_01:2020-02-04, 2020-02-03 signatures=0 Subject: Re: [dpdk-dev] [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > > > > This series integrates SA database (SAD) capabilities from ipsec librar= y. > > The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. > > Also patch series removes hardcoded limitation for maximum number of > > SA's and SP's. > > According to our measurements, after this series of patches, > > ipsec-secgw performance drops by about 0-2%. > > > > v5: > > - introduce SAD cache to solve performance degradation > > - ipsec_sad_add() returns an error if the key is present > > > > v4: > > - put tunnel SA's into SAD with SPI_ONLY type for performance reason > > > > v3: > > - parse SA and SP into sorted array instead of linked list > > > > v2: > > - get rid of maximum sp limitation > > > > Vladimir Medvedkin (6): > > ipsec: move ipsec sad name length into .h > > examples/ipsec-secgw: implement inbound SAD > > examples/ipsec-secgw: integrate inbound SAD > > examples/ipsec-secgw: get rid of maximum sa limitation > > examples/ipsec-secgw: get rid of maximum sp limitation > > examples/ipsec-secgw: add SAD cache > > > > examples/ipsec-secgw/Makefile | 1 + > > examples/ipsec-secgw/ipsec-secgw.c | 34 +++++- > > examples/ipsec-secgw/ipsec.h | 12 +- > > examples/ipsec-secgw/meson.build | 2 +- > > examples/ipsec-secgw/parser.c | 4 + > > examples/ipsec-secgw/parser.h | 9 ++ > > examples/ipsec-secgw/sa.c | 238 +++++++++++++++++++++--------= --- > ----- > > examples/ipsec-secgw/sad.c | 149 +++++++++++++++++++++++ > > examples/ipsec-secgw/sad.h | 168 ++++++++++++++++++++++++++ > > examples/ipsec-secgw/sp4.c | 114 +++++++++++++----- > > examples/ipsec-secgw/sp6.c | 112 ++++++++++++----- > > lib/librte_ipsec/ipsec_sad.c | 20 ++-- > > lib/librte_ipsec/rte_ipsec_sad.h | 2 + > > 13 files changed, 686 insertions(+), 179 deletions(-) create mode > > 100644 examples/ipsec-secgw/sad.c create mode 100644 > > examples/ipsec-secgw/sad.h > > >=20 > Series > Acked-by: Akhil Goyal >=20 > Hi Anoob, >=20 > Do you have any comments on this set. I do not see degradation on this > patchset now. [Anoob] The perf degradation is negligible on our platform as well. I don't= have any issue with the patch set. Series=20 Acked-by: Anoob Joseph